The following document contains the results of FindBugs
FindBugs Version is 3.0.0
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.opentrafficsim.core.car.LaneBasedIndividualCar defines non-transient non-serializable instance field animation | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.opentrafficsim.core.car.LaneBasedTemplateCar defines non-transient non-serializable instance field animation | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Field only ever set to null: org.opentrafficsim.core.car.LaneBasedTemplateCar$LaneBasedTemplateCarBuilder.gtuFollowingModel | CORRECTNESS | UWF_NULL_FIELD | Not available | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.opentrafficsim.core.dsol.OTSSimTimeDouble defines compareTo(OTSSimTimeDouble) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 54 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.opentrafficsim.core.gtu.TemplateGTUType defines non-transient non-serializable instance field lengthDist | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class org.opentrafficsim.core.gtu.TemplateGTUType defines non-transient non-serializable instance field maximumSpeedDist | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class org.opentrafficsim.core.gtu.TemplateGTUType defines non-transient non-serializable instance field widthDist | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to car in org.opentrafficsim.core.gtu.generator.AbstractGTUGenerator.generate() | STYLE | DLS_DEAD_LOCAL_STORE | 158 | Medium |
Dead store of String.class in org.opentrafficsim.core.gtu.generator.AbstractGTUGenerator.generate() | CORRECTNESS | DLS_DEAD_STORE_OF_CLASS_LITERAL | 115 | Medium |
org.opentrafficsim.core.gtu.generator.AbstractGTUGenerator.generate() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 135 | Medium |
org.opentrafficsim.core.gtu.generator.AbstractGTUGenerator.generate() invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 139 | Medium |
org.opentrafficsim.core.gtu.generator.AbstractGTUGenerator.generate() invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 131 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Test for floating point equality in org.opentrafficsim.core.gtu.lane.AbstractLaneBasedGTU.getLocation() | STYLE | FE_FLOATING_POINT_EQUALITY | 1183 | High |
Redundant nullcheck of longitudinalPosition, which is known to be non-null in org.opentrafficsim.core.gtu.lane.AbstractLaneBasedGTU.position(Lane, RelativePosition, DoubleScalar$Abs) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 621 | Medium |
Private method org.opentrafficsim.core.gtu.lane.AbstractLaneBasedGTU.headwayRecursiveBackwardSI(Lane, double, LaneBasedGTU, double, double, DoubleScalar$Abs) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 942-975 | Medium |
new org.opentrafficsim.core.gtu.lane.AbstractLaneBasedGTU(Object, GTUType, GTUFollowingModel, LaneChangeModel, Map, DoubleScalar$Abs, OTSDEVSSimulatorInterface) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 135 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
There is an apparent infinite recursive loop in org.opentrafficsim.core.gtu.lane.AbstractLaneBasedTemplateGTU.getGTUType() | CORRECTNESS | IL_INFINITE_RECURSIVE_LOOP | 58 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Impossible downcast of toArray() result to org.opentrafficsim.core.network.Link[] in org.opentrafficsim.core.network.ExpansionNetwork.collapseLinks(Node, Node) | CORRECTNESS | BC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY | 276 | High |
Impossible downcast of toArray() result to org.opentrafficsim.core.network.Link[] in org.opentrafficsim.core.network.ExpansionNetwork.collapseToNode(HashSet) | CORRECTNESS | BC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY | 229 | High |
Impossible downcast of toArray() result to org.opentrafficsim.core.network.Link[] in org.opentrafficsim.core.network.ExpansionNetwork.findLinkHierarchyBelow(int) | CORRECTNESS | BC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY | 342 | High |
Dead store to n in org.opentrafficsim.core.network.ExpansionNetwork.getSubNetworkConsistNode(Node) | STYLE | DLS_DEAD_LOCAL_STORE | 181 | Medium |
Dead store to n in org.opentrafficsim.core.network.ExpansionNetwork.isInNetwork(Node, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 152 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to width in org.opentrafficsim.core.network.factory.LaneFactory.makeMultiLane(String, NodeGeotools$STR, NodeGeotools$STR, Coordinate[], int, int, int, LaneType, OTSDEVSSimulatorInterface) | STYLE | DLS_DEAD_LOCAL_STORE | 161 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to n in org.opentrafficsim.core.network.factory.NetworkLaneParser.main(String[]) | STYLE | DLS_DEAD_LOCAL_STORE | 744 | Medium |
org.opentrafficsim.core.network.factory.NetworkLaneParser.makeId(Class, String) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 368 | Medium |
Doomed test for equality to NaN in org.opentrafficsim.core.network.factory.NetworkLaneParser.parseLink(String) | CORRECTNESS | FE_TEST_IF_EQUAL_TO_NOT_A_NUMBER | 346 | High |
Return value of String.replace(char, char) ignored in org.opentrafficsim.core.network.factory.NetworkLaneParser.parseLink(String) | CORRECTNESS | RV_RETURN_VALUE_IGNORED | 286 | High |
Return value of String.replace(char, char) ignored in org.opentrafficsim.core.network.factory.NetworkLaneParser.parseNode(String) | CORRECTNESS | RV_RETURN_VALUE_IGNORED | 221 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to n in org.opentrafficsim.core.network.factory.TestXMLModel.constructModel(SimulatorInterface) | STYLE | DLS_DEAD_LOCAL_STORE | 57 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to roadMarkers in org.opentrafficsim.core.network.factory.XmlNetworkLaneParser.parseElements(String, CrossSectionLink, XmlNetworkLaneParser$LinkTag, XmlNetworkLaneParser$GlobalTag) | STYLE | DLS_DEAD_LOCAL_STORE | 1177 | High |
Dead store to n in org.opentrafficsim.core.network.factory.XmlNetworkLaneParser.main(String[]) | STYLE | DLS_DEAD_LOCAL_STORE | 2001 | Medium |
org.opentrafficsim.core.network.factory.XmlNetworkLaneParser.makeId(Class, String) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 792 | Medium |
Unwritten field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser.network | CORRECTNESS | UWF_UNWRITTEN_FIELD | 285 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$ArcTag be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 1862-1871 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$FillTag be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 1968-1983 | Medium |
Unread public/protected field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$FillTag.distanceDist | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 1977 | Medium |
Unread public/protected field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$FillTag.gtuTag | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 1974 | Medium |
Unread public/protected field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$FillTag.initialSpeedDist | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 1980 | Medium |
Unread public/protected field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$FillTag.maxGTUs | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 1983 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$GTUTag be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 1916-1937 | Medium |
Unread public/protected field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$GTUTag.followingModel | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 1931 | Medium |
Unread public/protected field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$GTUTag.gtuType | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 1922 | Medium |
Unread public/protected field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$GTUTag.laneChangeModel | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 1934 | Medium |
Unread public/protected field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$GTUTag.lengthDist | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 1925 | Medium |
Unread public/protected field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$GTUTag.maxSpeedDist | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 1937 | Medium |
Unread public/protected field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$GTUTag.widthDist | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 1928 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$GeneratorTag be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 1942-1963 | Medium |
Unread public/protected field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$GeneratorTag.endTime | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 1963 | Medium |
Unread public/protected field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$GeneratorTag.gtuTag | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 1948 | Medium |
Unread public/protected field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$GeneratorTag.iatDist | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 1951 | Medium |
Unread public/protected field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$GeneratorTag.initialSpeedDist | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 1954 | Medium |
Unread public/protected field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$GeneratorTag.maxGTUs | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 1957 | Medium |
Unread public/protected field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$GeneratorTag.startTime | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 1960 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$GlobalTag be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 1788-1794 | Medium |
Unread public/protected field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$GlobalTag.speed | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 1791 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$LaneTag be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 1839-1857 | Medium |
Unread public/protected field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$LaneTag.cse | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 1857 | Medium |
Unread public/protected field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$LaneTag.speed | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 1845 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$LinkTag be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 1799-1834 | Medium |
Unread public/protected field: org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$LinkTag.speed | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 1805 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$NodeTag be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 1890-1902 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$SAXHandler.endElement(String, String, String) | STYLE | REC_CATCH_EXCEPTION | 461 | Medium |
Exception is caught when Exception is not thrown in org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$SAXHandler.startElement(String, String, String, Attributes) | STYLE | REC_CATCH_EXCEPTION | 381 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.opentrafficsim.core.network.factory.XmlNetworkLaneParser$StraightTag be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 1882-1885 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Static initializer for org.opentrafficsim.core.unit.AccelerationUnit creates instance before all static final fields assigned | BAD_PRACTICE | SI_INSTANCE_BEFORE_FINALS_ASSIGNED | 64 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Static initializer for org.opentrafficsim.core.unit.AreaUnit creates instance before all static final fields assigned | BAD_PRACTICE | SI_INSTANCE_BEFORE_FINALS_ASSIGNED | 64 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Static initializer for org.opentrafficsim.core.unit.DensityUnit creates instance before all static final fields assigned | BAD_PRACTICE | SI_INSTANCE_BEFORE_FINALS_ASSIGNED | 38 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Static initializer for org.opentrafficsim.core.unit.ElectricalChargeUnit creates instance before all static final fields assigned | BAD_PRACTICE | SI_INSTANCE_BEFORE_FINALS_ASSIGNED | 63 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Static initializer for org.opentrafficsim.core.unit.ElectricalPotentialUnit creates instance before all static final fields assigned | BAD_PRACTICE | SI_INSTANCE_BEFORE_FINALS_ASSIGNED | 61 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Static initializer for org.opentrafficsim.core.unit.ElectricalResistanceUnit creates instance before all static final fields assigned | BAD_PRACTICE | SI_INSTANCE_BEFORE_FINALS_ASSIGNED | 50 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Static initializer for org.opentrafficsim.core.unit.EnergyUnit creates instance before all static final fields assigned | BAD_PRACTICE | SI_INSTANCE_BEFORE_FINALS_ASSIGNED | 112 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Static initializer for org.opentrafficsim.core.unit.FlowMassUnit creates instance before all static final fields assigned | BAD_PRACTICE | SI_INSTANCE_BEFORE_FINALS_ASSIGNED | 39 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Static initializer for org.opentrafficsim.core.unit.FlowVolumeUnit creates instance before all static final fields assigned | BAD_PRACTICE | SI_INSTANCE_BEFORE_FINALS_ASSIGNED | 83 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Static initializer for org.opentrafficsim.core.unit.ForceUnit creates instance before all static final fields assigned | BAD_PRACTICE | SI_INSTANCE_BEFORE_FINALS_ASSIGNED | 60 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Static initializer for org.opentrafficsim.core.unit.FrequencyUnit creates instance before all static final fields assigned | BAD_PRACTICE | SI_INSTANCE_BEFORE_FINALS_ASSIGNED | 61 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Static initializer for org.opentrafficsim.core.unit.LinearDensityUnit creates instance before all static final fields assigned | BAD_PRACTICE | SI_INSTANCE_BEFORE_FINALS_ASSIGNED | 39 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Static initializer for org.opentrafficsim.core.unit.PowerUnit creates instance before all static final fields assigned | BAD_PRACTICE | SI_INSTANCE_BEFORE_FINALS_ASSIGNED | 69 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Static initializer for org.opentrafficsim.core.unit.PressureUnit creates instance before all static final fields assigned | BAD_PRACTICE | SI_INSTANCE_BEFORE_FINALS_ASSIGNED | 90 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.opentrafficsim.core.unit.SICoefficients.divide(SICoefficients, SICoefficients) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 281 | Medium |
org.opentrafficsim.core.unit.SICoefficients.enumMapToString(EnumMap) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 45 | Medium |
org.opentrafficsim.core.unit.SICoefficients.multiply(SICoefficients, SICoefficients) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 246 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Static initializer for org.opentrafficsim.core.unit.SpeedUnit creates instance before all static final fields assigned | BAD_PRACTICE | SI_INSTANCE_BEFORE_FINALS_ASSIGNED | 49 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Static initializer for org.opentrafficsim.core.unit.TemperatureUnit creates instance before all static final fields assigned | BAD_PRACTICE | SI_INSTANCE_BEFORE_FINALS_ASSIGNED | 44 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Static initializer for org.opentrafficsim.core.unit.TorqueUnit creates instance before all static final fields assigned | BAD_PRACTICE | SI_INSTANCE_BEFORE_FINALS_ASSIGNED | 49 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Static initializer for org.opentrafficsim.core.unit.VolumeUnit creates instance before all static final fields assigned | BAD_PRACTICE | SI_INSTANCE_BEFORE_FINALS_ASSIGNED | 83 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.opentrafficsim.graphs.ContourPlot.STANDARDDISTANCEGRANULARITIES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 87 | Medium |
org.opentrafficsim.graphs.ContourPlot.STANDARDTIMEGRANULARITIES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 81 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Comparison of String objects using == or != in org.opentrafficsim.graphs.FundamentalDiagram.actionPerformed(ActionEvent) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 540 | Medium |
Class org.opentrafficsim.graphs.FundamentalDiagram defines non-transient non-serializable instance field densityAxis | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class org.opentrafficsim.graphs.FundamentalDiagram defines non-transient non-serializable instance field flowAxis | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class org.opentrafficsim.graphs.FundamentalDiagram defines non-transient non-serializable instance field samples | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class org.opentrafficsim.graphs.FundamentalDiagram defines non-transient non-serializable instance field speedAxis | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class org.opentrafficsim.graphs.FundamentalDiagram defines non-transient non-serializable instance field xAxis | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class org.opentrafficsim.graphs.FundamentalDiagram defines non-transient non-serializable instance field yAxis | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.opentrafficsim.graphs.TrajectoryPlot defines non-transient non-serializable instance field path | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class org.opentrafficsim.graphs.TrajectoryPlot defines non-transient non-serializable instance field trajectories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class org.opentrafficsim.graphs.TrajectoryPlot defines non-transient non-serializable instance field trajectoryIndices | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Possible null pointer dereference of ReadOSMFile.reader in new org.opentrafficsim.importexport.osm.input.ReadOSMFile(String, List, List) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 118 | Medium |
new org.opentrafficsim.importexport.osm.input.ReadOSMFile(String, List, List) invokes Thread.start() | MT_CORRECTNESS | SC_START_IN_CTOR | 121 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to structurewithOffset in org.opentrafficsim.importexport.osm.output.Convert.makeStructure(Link) | STYLE | DLS_DEAD_LOCAL_STORE | 230 | Medium |
Redundant nullcheck of intermediateCoordinates, which is known to be non-null in org.opentrafficsim.importexport.osm.output.Convert.convertLink(Link) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 134 | Medium |
org.opentrafficsim.importexport.osm.output.Convert.makeLaneType(List) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 609 | Medium |
org.opentrafficsim.importexport.osm.output.Convert.makeLanes(Link, OTSDEVSSimulatorInterface) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 545 | Medium |