The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to exception in ccol.CCOL.step() | STYLE | DLS_DEAD_LOCAL_STORE | 179 | Medium |
| Found reliance on default encoding in ccol.CCOL.setClientSocket(Socket): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 139 | High |
| Found reliance on default encoding in ccol.CCOL.setClientSocket(Socket): new java.io.PrintWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 140 | High |
| new ccol.CCOL(String, String, Set, Set, DEVSSimulator) invokes Thread.start() | MT_CORRECTNESS | SC_START_IN_CTOR | 113 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Integer is incompatible with expected argument type Short in org.opentrafficsim.trafficcontrol.trafcod.Diagram.routePoint(int, Diagram$RouteStep[]) | CORRECTNESS | GC_UNRELATED_TYPES | 688 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.opentrafficsim.trafficcontrol.trafcod.Diagram.checkBoxPanel from instance method org.opentrafficsim.trafficcontrol.trafcod.Diagram$2.run() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 812 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.opentrafficsim.trafficcontrol.trafcod.Diagram$RouteStep be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 416-519 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.opentrafficsim.core.dsol.OTSSimulatorInterface to nl.tudelft.simulation.dsol.simulators.DEVSSimulator in org.opentrafficsim.trafficcontrol.trafcod.TrafCOD.clone(OTSSimulatorInterface, Network) | STYLE | BC_UNCONFIRMED_CAST | 1907 | Medium |
| Found reliance on default encoding in org.opentrafficsim.trafficcontrol.trafcod.TrafCOD.makeDisplay(URL, Set): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 518 | High |
| Found reliance on default encoding in org.opentrafficsim.trafficcontrol.trafcod.TrafCOD.parseTrafCODRules(URL, Set, Set): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 251 | High |
| org.opentrafficsim.trafficcontrol.trafcod.TrafCOD.evalRule(Object[]) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 875 | Medium |
| org.opentrafficsim.trafficcontrol.trafcod.TrafCOD.parse(String, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 1513 | Medium |
| Dereference of the result of readLine() without nullcheck in org.opentrafficsim.trafficcontrol.trafcod.TrafCOD.parseTrafCODRules(URL, Set, Set) | STYLE | NP_DEREFERENCE_OF_READLINE_VALUE | 335 | Medium |
| v could be null and is guaranteed to be dereferenced in org.opentrafficsim.trafficcontrol.trafcod.TrafCOD.notify(EventInterface) | CORRECTNESS | NP_GUARANTEED_DEREF | 1837 | High |
| org.opentrafficsim.trafficcontrol.trafcod.TrafCOD.makeDisplay(URL, Set) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 518 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in org.opentrafficsim.trafficcontrol.trafcod.Variable.cloneState(Variable, Network) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 2386 | Medium |
| A known null value is checked to see if it is an instance of org.opentrafficsim.road.network.lane.object.trafficlight.TrafficLight in org.opentrafficsim.trafficcontrol.trafcod.Variable.cloneState(Variable, Network) | CORRECTNESS | NP_NULL_INSTANCEOF | 2386 | Medium |