FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
41 11 0 0

Files

Class Bugs
org.opentrafficsim.road.network.factory.xml.FillTag 3
org.opentrafficsim.road.network.factory.xml.LinkTag 1
org.opentrafficsim.road.network.factory.xml.Links 2
org.opentrafficsim.road.network.factory.xml.ListGeneratorTag 1
org.opentrafficsim.road.network.factory.xml.XmlNetworkLaneParser 3
org.opentrafficsim.road.network.factory.xml.demand.XmlOdParser 1

org.opentrafficsim.road.network.factory.xml.FillTag

Bug Category Details Line Priority
Dead store to rg in org.opentrafficsim.road.network.factory.xml.FillTag.makeFill(FillTag, XmlNetworkLaneParser, LinkTag, DEVSSimulatorInterface$TimeDoubleUnit) STYLE DLS_DEAD_LOCAL_STORE 222 High
Dead store to lane in org.opentrafficsim.road.network.factory.xml.FillTag.makeFill(FillTag, XmlNetworkLaneParser, LinkTag, DEVSSimulatorInterface$TimeDoubleUnit) STYLE DLS_DEAD_LOCAL_STORE 215 Medium
Dead store of org.opentrafficsim.road.gtu.lane.LaneBasedIndividualGTU.class in org.opentrafficsim.road.network.factory.xml.FillTag.makeFill(FillTag, XmlNetworkLaneParser, LinkTag, DEVSSimulatorInterface$TimeDoubleUnit) CORRECTNESS DLS_DEAD_STORE_OF_CLASS_LITERAL 216 Medium

org.opentrafficsim.road.network.factory.xml.LinkTag

Bug Category Details Line Priority
Class org.opentrafficsim.road.network.factory.xml.LinkTag defines non-transient non-serializable instance field bezierTag BAD_PRACTICE SE_BAD_FIELD Not available High

org.opentrafficsim.road.network.factory.xml.Links

Bug Category Details Line Priority
Useless object stored in variable cseList of method org.opentrafficsim.road.network.factory.xml.Links.applyRoadTypeToLink(LinkTag, XmlNetworkLaneParser, DEVSSimulatorInterface$TimeDoubleUnit) STYLE UC_USELESS_OBJECT 525 Medium
Useless object stored in variable lanes of method org.opentrafficsim.road.network.factory.xml.Links.applyRoadTypeToLink(LinkTag, XmlNetworkLaneParser, DEVSSimulatorInterface$TimeDoubleUnit) STYLE UC_USELESS_OBJECT 526 Medium

org.opentrafficsim.road.network.factory.xml.ListGeneratorTag

Bug Category Details Line Priority
Unwritten field: org.opentrafficsim.road.network.factory.xml.ListGeneratorTag.gtuColorer CORRECTNESS UWF_UNWRITTEN_FIELD 143 Medium

org.opentrafficsim.road.network.factory.xml.XmlNetworkLaneParser

Bug Category Details Line Priority
Write to static field org.opentrafficsim.road.network.factory.xml.GTUColorerTag.defaultColorer from instance method new org.opentrafficsim.road.network.factory.xml.XmlNetworkLaneParser(DEVSSimulatorInterface$TimeDoubleUnit, GTUColorer) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 172 High
org.opentrafficsim.road.network.factory.xml.XmlNetworkLaneParser.build(InputStream, OTSNetwork, boolean) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 368 Medium
org.opentrafficsim.road.network.factory.xml.XmlNetworkLaneParser.fixOD(OTSNetwork) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 577 Medium

org.opentrafficsim.road.network.factory.xml.demand.XmlOdParser

Bug Category Details Line Priority
Class org.opentrafficsim.road.network.factory.xml.demand.XmlOdParser defines non-transient non-serializable instance field demand BAD_PRACTICE SE_BAD_FIELD Not available High