The following document contains the results of SpotBugs
SpotBugs Version is 4.1.4
Threshold is medium
Effort is default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 43 | 13 | 0 | 0 |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.opentrafficsim.road.network.factory.xml.demand.XmlOdParser defines non-transient non-serializable instance field demand | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of networkGtuType, which is known to be non-null in org.opentrafficsim.road.network.factory.xml.parser.DefinitionsParser.parseGtuTypes(DEFINITIONS, OTSRoadNetwork, boolean) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 88 | Medium |
| Redundant nullcheck of networkLaneType, which is known to be non-null in org.opentrafficsim.road.network.factory.xml.parser.DefinitionsParser.parseLaneTypes(DEFINITIONS, OTSRoadNetwork, boolean) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 183 | Medium |
| Redundant nullcheck of networkLinkType, which is known to be non-null in org.opentrafficsim.road.network.factory.xml.parser.DefinitionsParser.parseLinkTypes(DEFINITIONS, OTSRoadNetwork, boolean, Map) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 132 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of nodeTo, which is known to be non-null in org.opentrafficsim.road.network.factory.xml.parser.GeneratorSinkParser.parseShortestRoutes(OTSRoadNetwork, NETWORKDEMAND) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 133 | High |
| Exception is caught when Exception is not thrown in org.opentrafficsim.road.network.factory.xml.parser.GeneratorSinkParser.parseGenerators(OTSRoadNetwork, NETWORKDEMAND, Map, Map, Map, Map) | STYLE | REC_CATCH_EXCEPTION | 363 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of endNode in org.opentrafficsim.road.network.factory.xml.parser.NetworkParser.parseLinks(OTSRoadNetwork, NETWORK, Map, OTSSimulatorInterface) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 175 | High |
| Possible null pointer dereference of startNode in org.opentrafficsim.road.network.factory.xml.parser.NetworkParser.parseLinks(OTSRoadNetwork, NETWORK, Map, OTSSimulatorInterface) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 175 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Useless object stored in variable categoryFactors of method org.opentrafficsim.road.network.factory.xml.parser.ODParser.parseDemand(OTSRoadNetwork, List, Map, Map, Map, Map) | STYLE | UC_USELESS_OBJECT | 172 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to animation in org.opentrafficsim.road.network.factory.xml.parser.XmlNetworkLaneParser.build(OTS, OTSRoadNetwork, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 379 | Medium |
| Dead store to modelParameters in org.opentrafficsim.road.network.factory.xml.parser.XmlNetworkLaneParser.build(OTS, OTSRoadNetwork, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 377 | Medium |
| Dead store to scenario in org.opentrafficsim.road.network.factory.xml.parser.XmlNetworkLaneParser.build(OTS, OTSRoadNetwork, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 378 | Medium |
| Hard coded reference to an absolute pathname in org.opentrafficsim.road.network.factory.xml.parser.XmlNetworkLaneParser.main(String[]) | STYLE | DMI_HARDCODED_ABSOLUTE_FILENAME | 393 | Medium |