The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.opentrafficsim.core.dsol.OTSSimTimeDouble defines compareTo(OTSSimTimeDouble) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 55 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.opentrafficsim.core.geometry.OTSLine3D.getPoints() may expose internal representation by returning OTSLine3D.points | MALICIOUS_CODE | EI_EXPOSE_REP | 174 | Medium |
| new org.opentrafficsim.core.geometry.OTSLine3D(OTSPoint3D[]) may expose internal representation by storing an externally mutable object into OTSLine3D.points | MALICIOUS_CODE | EI_EXPOSE_REP2 | 59 | Medium |
| Inconsistent synchronization of org.opentrafficsim.core.geometry.OTSLine3D.length; locked 62% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 456 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.opentrafficsim.core.gtu.TemplateGTUType defines non-transient non-serializable instance field lengthDist | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
| Class org.opentrafficsim.core.gtu.TemplateGTUType defines non-transient non-serializable instance field maximumSpeedDist | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
| Class org.opentrafficsim.core.gtu.TemplateGTUType defines non-transient non-serializable instance field widthDist | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.opentrafficsim.core.network.factory.xml.units.AngleUnits.ANGLE_UNITS is a mutable collection which should be package protected | MALICIOUS_CODE | MS_MUTABLE_COLLECTION_PKGPROTECT | 22 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.opentrafficsim.core.network.factory.xml.units.LengthUnits.LENGTH_UNITS is a mutable collection which should be package protected | MALICIOUS_CODE | MS_MUTABLE_COLLECTION_PKGPROTECT | 24 | Medium |
| org.opentrafficsim.core.network.factory.xml.units.LengthUnits.PER_LENGTH_UNITS is a mutable collection which should be package protected | MALICIOUS_CODE | MS_MUTABLE_COLLECTION_PKGPROTECT | 27 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.opentrafficsim.core.network.factory.xml.units.SpeedUnits.SPEED_UNITS is a mutable collection which should be package protected | MALICIOUS_CODE | MS_MUTABLE_COLLECTION_PKGPROTECT | 22 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.opentrafficsim.core.network.factory.xml.units.TimeUnits.PER_TIME_UNITS is a mutable collection which should be package protected | MALICIOUS_CODE | MS_MUTABLE_COLLECTION_PKGPROTECT | 26 | Medium |
| org.opentrafficsim.core.network.factory.xml.units.TimeUnits.TIME_UNITS is a mutable collection which should be package protected | MALICIOUS_CODE | MS_MUTABLE_COLLECTION_PKGPROTECT | 23 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.opentrafficsim.core.network.route.FixedRouteGenerator defines compareTo(FixedRouteGenerator) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 83 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Hard coded reference to an absolute pathname in new org.opentrafficsim.gui.OTSControlPanel(OTSDEVSSimulatorInterface, WrappableAnimation) | STYLE | DMI_HARDCODED_ABSOLUTE_FILENAME | 123 | Medium |
| Hard coded reference to an absolute pathname in new org.opentrafficsim.gui.OTSControlPanel(OTSDEVSSimulatorInterface, WrappableAnimation) | STYLE | DMI_HARDCODED_ABSOLUTE_FILENAME | 124 | Medium |
| Hard coded reference to an absolute pathname in new org.opentrafficsim.gui.OTSControlPanel(OTSDEVSSimulatorInterface, WrappableAnimation) | STYLE | DMI_HARDCODED_ABSOLUTE_FILENAME | 127 | Medium |
| Hard coded reference to an absolute pathname in new org.opentrafficsim.gui.OTSControlPanel(OTSDEVSSimulatorInterface, WrappableAnimation) | STYLE | DMI_HARDCODED_ABSOLUTE_FILENAME | 126 | Medium |
| Hard coded reference to an absolute pathname in new org.opentrafficsim.gui.OTSControlPanel(OTSDEVSSimulatorInterface, WrappableAnimation) | STYLE | DMI_HARDCODED_ABSOLUTE_FILENAME | 130 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.opentrafficsim.gui.OTSControlPanel$DisposeOnCloseThread be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 212-244 | Medium |
