FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
51 75 0 0

Files

Class Bugs
org.opentrafficsim.demo.carFollowing.FundamentalDiagrams$FundamentalDiagramPlotsModel 6
org.opentrafficsim.demo.carFollowing.FundamentalDiagramsLane$FundamentalDiagramLanePlotsModel 6
org.opentrafficsim.demo.carFollowing.LaneSimulationModel 7
org.opentrafficsim.demo.carFollowing.OSMModel 5
org.opentrafficsim.demo.carFollowing.RoadSimulationModel 8
org.opentrafficsim.demo.carFollowing.SequentialModel 7
org.opentrafficsim.demo.carFollowing.StraightModel 6
org.opentrafficsim.demo.carFollowing.TrajectoriesModel 10
org.opentrafficsim.demo.carFollowing.XMLNetworkModel 10
org.opentrafficsim.demo.carFollowing.XMLNetworks 1
org.opentrafficsim.demo.geometry.shape.ShapeFileReader 5
org.opentrafficsim.demo.geometry.shape.ShapeModel 2
org.opentrafficsim.demo.lanechange.LaneChangeGraph 2

org.opentrafficsim.demo.carFollowing.FundamentalDiagrams$FundamentalDiagramPlotsModel

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.following.IDM stored into non-transient field FundamentalDiagrams$FundamentalDiagramPlotsModel.carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD_STORE 312 Medium
org.opentrafficsim.road.gtu.following.IDMPlus stored into non-transient field FundamentalDiagrams$FundamentalDiagramPlotsModel.carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD_STORE 321 Medium
org.opentrafficsim.road.gtu.following.IDM stored into non-transient field FundamentalDiagrams$FundamentalDiagramPlotsModel.carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD_STORE 315 Medium
org.opentrafficsim.road.gtu.following.IDMPlus stored into non-transient field FundamentalDiagrams$FundamentalDiagramPlotsModel.carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD_STORE 324 Medium
org.opentrafficsim.road.gtu.lane.changing.Egoistic stored into non-transient field FundamentalDiagrams$FundamentalDiagramPlotsModel.laneChangeModel BAD_PRACTICE SE_BAD_FIELD_STORE 230 Medium
Should org.opentrafficsim.demo.carFollowing.FundamentalDiagrams$FundamentalDiagramPlotsModel be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 215-498 Medium

org.opentrafficsim.demo.carFollowing.FundamentalDiagramsLane$FundamentalDiagramLanePlotsModel

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.following.IDM stored into non-transient field FundamentalDiagramsLane$FundamentalDiagramLanePlotsModel.carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD_STORE 324 Medium
org.opentrafficsim.road.gtu.following.IDMPlus stored into non-transient field FundamentalDiagramsLane$FundamentalDiagramLanePlotsModel.carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD_STORE 333 Medium
org.opentrafficsim.road.gtu.following.IDM stored into non-transient field FundamentalDiagramsLane$FundamentalDiagramLanePlotsModel.carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD_STORE 327 Medium
org.opentrafficsim.road.gtu.following.IDMPlus stored into non-transient field FundamentalDiagramsLane$FundamentalDiagramLanePlotsModel.carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD_STORE 336 Medium
org.opentrafficsim.road.gtu.lane.changing.Egoistic stored into non-transient field FundamentalDiagramsLane$FundamentalDiagramLanePlotsModel.laneChangeModel BAD_PRACTICE SE_BAD_FIELD_STORE 233 Medium
Should org.opentrafficsim.demo.carFollowing.FundamentalDiagramsLane$FundamentalDiagramLanePlotsModel be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 218-495 Medium

org.opentrafficsim.demo.carFollowing.LaneSimulationModel

Bug Category Details Line Priority
Integral division result cast to double or float in org.opentrafficsim.demo.carFollowing.LaneSimulationModel.constructModel(SimulatorInterface) STYLE ICAST_IDIV_CAST_TO_DOUBLE 418 Medium
Class org.opentrafficsim.demo.carFollowing.LaneSimulationModel defines non-transient non-serializable instance field carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.LaneSimulationModel defines non-transient non-serializable instance field carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.LaneSimulationModel defines non-transient non-serializable instance field gtuColorer BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.LaneSimulationModel defines non-transient non-serializable instance field laneChangeModel BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.LaneSimulationModel defines non-transient non-serializable instance field properties BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.opentrafficsim.road.gtu.lane.changing.Egoistic stored into non-transient field LaneSimulationModel.laneChangeModel BAD_PRACTICE SE_BAD_FIELD_STORE 314 Medium

org.opentrafficsim.demo.carFollowing.OSMModel

Bug Category Details Line Priority
Class org.opentrafficsim.demo.carFollowing.OSMModel defines non-transient non-serializable instance field converter BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.OSMModel defines non-transient non-serializable instance field osmNetwork BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.OSMModel defines non-transient non-serializable instance field progressListener BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.OSMModel defines non-transient non-serializable instance field warningListener BAD_PRACTICE SE_BAD_FIELD Not available Medium
Unwritten field: org.opentrafficsim.demo.carFollowing.OSMModel.simulator CORRECTNESS UWF_UNWRITTEN_FIELD 373 Medium

org.opentrafficsim.demo.carFollowing.RoadSimulationModel

Bug Category Details Line Priority
Integral division result cast to double or float in org.opentrafficsim.demo.carFollowing.RoadSimulationModel.constructModel(SimulatorInterface) STYLE ICAST_IDIV_CAST_TO_DOUBLE 453 Medium
Class org.opentrafficsim.demo.carFollowing.RoadSimulationModel defines non-transient non-serializable instance field carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.RoadSimulationModel defines non-transient non-serializable instance field carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.RoadSimulationModel defines non-transient non-serializable instance field gtuColorer BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.RoadSimulationModel defines non-transient non-serializable instance field laneChangeModel BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.RoadSimulationModel defines non-transient non-serializable instance field properties BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.opentrafficsim.road.gtu.lane.changing.Altruistic stored into non-transient field RoadSimulationModel.laneChangeModel BAD_PRACTICE SE_BAD_FIELD_STORE 432 Medium
org.opentrafficsim.road.gtu.lane.changing.Egoistic stored into non-transient field RoadSimulationModel.laneChangeModel BAD_PRACTICE SE_BAD_FIELD_STORE 428 Medium

org.opentrafficsim.demo.carFollowing.SequentialModel

Bug Category Details Line Priority
Class org.opentrafficsim.demo.carFollowing.SequentialModel defines non-transient non-serializable instance field carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.SequentialModel defines non-transient non-serializable instance field carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.SequentialModel defines non-transient non-serializable instance field gtuColorer BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.SequentialModel defines non-transient non-serializable instance field laneChangeModel BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.SequentialModel defines non-transient non-serializable instance field properties BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.opentrafficsim.road.gtu.lane.changing.Egoistic stored into non-transient field SequentialModel.laneChangeModel BAD_PRACTICE SE_BAD_FIELD_STORE 337 Medium
Useless object stored in variable links of method org.opentrafficsim.demo.carFollowing.SequentialModel.constructModel(SimulatorInterface) STYLE UC_USELESS_OBJECT 410 Medium

org.opentrafficsim.demo.carFollowing.StraightModel

Bug Category Details Line Priority
Class org.opentrafficsim.demo.carFollowing.StraightModel defines non-transient non-serializable instance field carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.StraightModel defines non-transient non-serializable instance field carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.StraightModel defines non-transient non-serializable instance field gtuColorer BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.StraightModel defines non-transient non-serializable instance field laneChangeModel BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.StraightModel defines non-transient non-serializable instance field properties BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.opentrafficsim.road.gtu.lane.changing.Egoistic stored into non-transient field StraightModel.laneChangeModel BAD_PRACTICE SE_BAD_FIELD_STORE 355 Medium

org.opentrafficsim.demo.carFollowing.TrajectoriesModel

Bug Category Details Line Priority
Class org.opentrafficsim.demo.carFollowing.TrajectoriesModel defines non-transient non-serializable instance field carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.TrajectoriesModel defines non-transient non-serializable instance field carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.TrajectoriesModel defines non-transient non-serializable instance field gtuColorer BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.TrajectoriesModel defines non-transient non-serializable instance field laneChangeModel BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.TrajectoriesModel defines non-transient non-serializable instance field properties BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.opentrafficsim.road.gtu.following.IDM stored into non-transient field TrajectoriesModel.carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD_STORE 299 Medium
org.opentrafficsim.road.gtu.following.IDMPlus stored into non-transient field TrajectoriesModel.carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD_STORE 308 Medium
org.opentrafficsim.road.gtu.following.IDM stored into non-transient field TrajectoriesModel.carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD_STORE 302 Medium
org.opentrafficsim.road.gtu.following.IDMPlus stored into non-transient field TrajectoriesModel.carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD_STORE 311 Medium
org.opentrafficsim.road.gtu.lane.changing.Egoistic stored into non-transient field TrajectoriesModel.laneChangeModel BAD_PRACTICE SE_BAD_FIELD_STORE 221 Medium

org.opentrafficsim.demo.carFollowing.XMLNetworkModel

Bug Category Details Line Priority
Primitive value is boxed and then immediately unboxed in org.opentrafficsim.demo.carFollowing.XMLNetworkModel.constructModel(SimulatorInterface) PERFORMANCE BX_BOXING_IMMEDIATELY_UNBOXED 414 Medium
Class org.opentrafficsim.demo.carFollowing.XMLNetworkModel defines non-transient non-serializable instance field carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.XMLNetworkModel defines non-transient non-serializable instance field carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.XMLNetworkModel defines non-transient non-serializable instance field gtuColorer BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.XMLNetworkModel defines non-transient non-serializable instance field laneChangeModel BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.XMLNetworkModel defines non-transient non-serializable instance field properties BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.XMLNetworkModel defines non-transient non-serializable instance field routeGenerator BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.opentrafficsim.road.gtu.lane.changing.Egoistic stored into non-transient field XMLNetworkModel.laneChangeModel BAD_PRACTICE SE_BAD_FIELD_STORE 217 Medium
org.opentrafficsim.road.network.route.FixedLaneBasedRouteGenerator stored into non-transient field XMLNetworkModel.routeGenerator BAD_PRACTICE SE_BAD_FIELD_STORE 404 Medium
org.opentrafficsim.road.network.route.ProbabilisticLaneBasedRouteGenerator stored into non-transient field XMLNetworkModel.routeGenerator BAD_PRACTICE SE_BAD_FIELD_STORE 419 Medium

org.opentrafficsim.demo.carFollowing.XMLNetworks

Bug Category Details Line Priority
Integer remainder modulo 1 computed in org.opentrafficsim.demo.carFollowing.XMLNetworks.makeCharts() STYLE INT_BAD_REM_BY_1 141 High

org.opentrafficsim.demo.geometry.shape.ShapeFileReader

Bug Category Details Line Priority
Dead store to capacity in org.opentrafficsim.demo.geometry.shape.ShapeFileReader.readLinks(String, Map, Map, OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 235 Medium
Dead store to length in org.opentrafficsim.demo.geometry.shape.ShapeFileReader.readLinks(String, Map, Map, OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 223 Medium
Dead store to speed in org.opentrafficsim.demo.geometry.shape.ShapeFileReader.readLinks(String, Map, Map, OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 233 Medium
Redundant nullcheck of nr, which is known to be non-null in org.opentrafficsim.demo.geometry.shape.ShapeFileReader.readNodes(String, String, boolean, boolean) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 121 Medium
Exception is caught when Exception is not thrown in org.opentrafficsim.demo.geometry.shape.ShapeFileReader.readLinks(String, Map, Map, OTSSimulatorInterface) STYLE REC_CATCH_EXCEPTION 276 Medium

org.opentrafficsim.demo.geometry.shape.ShapeModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.geometry.shape.ShapeModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 55 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.geometry.shape.ShapeModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 53 Medium

org.opentrafficsim.demo.lanechange.LaneChangeGraph

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.following.IDM stored into non-transient field LaneChangeGraph.carFollowingModel BAD_PRACTICE SE_BAD_FIELD_STORE 280 Medium
org.opentrafficsim.road.gtu.following.IDMPlus stored into non-transient field LaneChangeGraph.carFollowingModel BAD_PRACTICE SE_BAD_FIELD_STORE 277 Medium