FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
62 83 0 0

Files

Class Bugs
org.opentrafficsim.demo.carFollowing.FundamentalDiagrams$FundamentalDiagramPlotsModel 6
org.opentrafficsim.demo.carFollowing.FundamentalDiagramsLane$FundamentalDiagramLanePlotsModel 6
org.opentrafficsim.demo.carFollowing.LaneSimulationModel 7
org.opentrafficsim.demo.carFollowing.OSMModel 5
org.opentrafficsim.demo.carFollowing.RoadSimulationModel 8
org.opentrafficsim.demo.carFollowing.SequentialModel 7
org.opentrafficsim.demo.carFollowing.StraightModel 6
org.opentrafficsim.demo.carFollowing.StraightPerceptionModel 6
org.opentrafficsim.demo.carFollowing.StraightPerceptionModel$LaneBasedPerceivingCar 1
org.opentrafficsim.demo.carFollowing.TrajectoriesModel 10
org.opentrafficsim.demo.carFollowing.XMLNetworkModel 10
org.opentrafficsim.demo.carFollowing.XMLNetworkModel$DirectionGTUColorer 1
org.opentrafficsim.demo.carFollowing.XMLNetworks 1
org.opentrafficsim.demo.geometry.shape.ShapeFileReader 5
org.opentrafficsim.demo.geometry.shape.ShapeModel 2
org.opentrafficsim.demo.lanechange.LaneChangeGraph 2

org.opentrafficsim.demo.carFollowing.FundamentalDiagrams$FundamentalDiagramPlotsModel

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.tactical.following.IDMOld stored into non-transient field FundamentalDiagrams$FundamentalDiagramPlotsModel.carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD_STORE 329 Medium
org.opentrafficsim.road.gtu.lane.tactical.following.IDMPlusOld stored into non-transient field FundamentalDiagrams$FundamentalDiagramPlotsModel.carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD_STORE 338 Medium
org.opentrafficsim.road.gtu.lane.tactical.following.IDMOld stored into non-transient field FundamentalDiagrams$FundamentalDiagramPlotsModel.carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD_STORE 332 Medium
org.opentrafficsim.road.gtu.lane.tactical.following.IDMPlusOld stored into non-transient field FundamentalDiagrams$FundamentalDiagramPlotsModel.carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD_STORE 341 Medium
org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.Egoistic stored into non-transient field FundamentalDiagrams$FundamentalDiagramPlotsModel.laneChangeModel BAD_PRACTICE SE_BAD_FIELD_STORE 244 Medium
Should org.opentrafficsim.demo.carFollowing.FundamentalDiagrams$FundamentalDiagramPlotsModel be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 223-526 Medium

org.opentrafficsim.demo.carFollowing.FundamentalDiagramsLane$FundamentalDiagramLanePlotsModel

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.tactical.following.IDMOld stored into non-transient field FundamentalDiagramsLane$FundamentalDiagramLanePlotsModel.carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD_STORE 340 Medium
org.opentrafficsim.road.gtu.lane.tactical.following.IDMPlusOld stored into non-transient field FundamentalDiagramsLane$FundamentalDiagramLanePlotsModel.carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD_STORE 349 Medium
org.opentrafficsim.road.gtu.lane.tactical.following.IDMOld stored into non-transient field FundamentalDiagramsLane$FundamentalDiagramLanePlotsModel.carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD_STORE 343 Medium
org.opentrafficsim.road.gtu.lane.tactical.following.IDMPlusOld stored into non-transient field FundamentalDiagramsLane$FundamentalDiagramLanePlotsModel.carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD_STORE 352 Medium
org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.Egoistic stored into non-transient field FundamentalDiagramsLane$FundamentalDiagramLanePlotsModel.laneChangeModel BAD_PRACTICE SE_BAD_FIELD_STORE 247 Medium
Should org.opentrafficsim.demo.carFollowing.FundamentalDiagramsLane$FundamentalDiagramLanePlotsModel be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 223-521 Medium

org.opentrafficsim.demo.carFollowing.LaneSimulationModel

Bug Category Details Line Priority
Integral division result cast to double or float in org.opentrafficsim.demo.carFollowing.LaneSimulationModel.constructModel(SimulatorInterface) STYLE ICAST_IDIV_CAST_TO_DOUBLE 425 Medium
Class org.opentrafficsim.demo.carFollowing.LaneSimulationModel defines non-transient non-serializable instance field carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.LaneSimulationModel defines non-transient non-serializable instance field carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.LaneSimulationModel defines non-transient non-serializable instance field gtuColorer BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.LaneSimulationModel defines non-transient non-serializable instance field laneChangeModel BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.LaneSimulationModel defines non-transient non-serializable instance field properties BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.Egoistic stored into non-transient field LaneSimulationModel.laneChangeModel BAD_PRACTICE SE_BAD_FIELD_STORE 329 Medium

org.opentrafficsim.demo.carFollowing.OSMModel

Bug Category Details Line Priority
Class org.opentrafficsim.demo.carFollowing.OSMModel defines non-transient non-serializable instance field converter BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.OSMModel defines non-transient non-serializable instance field osmNetwork BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.OSMModel defines non-transient non-serializable instance field progressListener BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.OSMModel defines non-transient non-serializable instance field warningListener BAD_PRACTICE SE_BAD_FIELD Not available Medium
Unwritten field: org.opentrafficsim.demo.carFollowing.OSMModel.simulator CORRECTNESS UWF_UNWRITTEN_FIELD 393 Medium

org.opentrafficsim.demo.carFollowing.RoadSimulationModel

Bug Category Details Line Priority
Integral division result cast to double or float in org.opentrafficsim.demo.carFollowing.RoadSimulationModel.constructModel(SimulatorInterface) STYLE ICAST_IDIV_CAST_TO_DOUBLE 491 Medium
Class org.opentrafficsim.demo.carFollowing.RoadSimulationModel defines non-transient non-serializable instance field carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.RoadSimulationModel defines non-transient non-serializable instance field carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.RoadSimulationModel defines non-transient non-serializable instance field gtuColorer BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.RoadSimulationModel defines non-transient non-serializable instance field laneChangeModel BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.RoadSimulationModel defines non-transient non-serializable instance field properties BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.Altruistic stored into non-transient field RoadSimulationModel.laneChangeModel BAD_PRACTICE SE_BAD_FIELD_STORE 450 Medium
org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.Egoistic stored into non-transient field RoadSimulationModel.laneChangeModel BAD_PRACTICE SE_BAD_FIELD_STORE 446 Medium

org.opentrafficsim.demo.carFollowing.SequentialModel

Bug Category Details Line Priority
Class org.opentrafficsim.demo.carFollowing.SequentialModel defines non-transient non-serializable instance field carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.SequentialModel defines non-transient non-serializable instance field carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.SequentialModel defines non-transient non-serializable instance field gtuColorer BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.SequentialModel defines non-transient non-serializable instance field laneChangeModel BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.SequentialModel defines non-transient non-serializable instance field properties BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.Egoistic stored into non-transient field SequentialModel.laneChangeModel BAD_PRACTICE SE_BAD_FIELD_STORE 355 Medium
Useless object stored in variable links of method org.opentrafficsim.demo.carFollowing.SequentialModel.constructModel(SimulatorInterface) STYLE UC_USELESS_OBJECT 438 Medium

org.opentrafficsim.demo.carFollowing.StraightModel

Bug Category Details Line Priority
Class org.opentrafficsim.demo.carFollowing.StraightModel defines non-transient non-serializable instance field carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.StraightModel defines non-transient non-serializable instance field carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.StraightModel defines non-transient non-serializable instance field gtuColorer BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.StraightModel defines non-transient non-serializable instance field laneChangeModel BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.StraightModel defines non-transient non-serializable instance field properties BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.Egoistic stored into non-transient field StraightModel.laneChangeModel BAD_PRACTICE SE_BAD_FIELD_STORE 369 Medium

org.opentrafficsim.demo.carFollowing.StraightPerceptionModel

Bug Category Details Line Priority
Class org.opentrafficsim.demo.carFollowing.StraightPerceptionModel defines non-transient non-serializable instance field carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.StraightPerceptionModel defines non-transient non-serializable instance field carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.StraightPerceptionModel defines non-transient non-serializable instance field gtuColorer BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.StraightPerceptionModel defines non-transient non-serializable instance field laneChangeModel BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.StraightPerceptionModel defines non-transient non-serializable instance field properties BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.Egoistic stored into non-transient field StraightPerceptionModel.laneChangeModel BAD_PRACTICE SE_BAD_FIELD_STORE 385 Medium

org.opentrafficsim.demo.carFollowing.StraightPerceptionModel$LaneBasedPerceivingCar

Bug Category Details Line Priority
Should org.opentrafficsim.demo.carFollowing.StraightPerceptionModel$LaneBasedPerceivingCar be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 727-816 Medium

org.opentrafficsim.demo.carFollowing.TrajectoriesModel

Bug Category Details Line Priority
Class org.opentrafficsim.demo.carFollowing.TrajectoriesModel defines non-transient non-serializable instance field carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.TrajectoriesModel defines non-transient non-serializable instance field carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.TrajectoriesModel defines non-transient non-serializable instance field gtuColorer BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.TrajectoriesModel defines non-transient non-serializable instance field laneChangeModel BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.TrajectoriesModel defines non-transient non-serializable instance field properties BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.opentrafficsim.road.gtu.lane.tactical.following.IDMOld stored into non-transient field TrajectoriesModel.carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD_STORE 319 Medium
org.opentrafficsim.road.gtu.lane.tactical.following.IDMPlusOld stored into non-transient field TrajectoriesModel.carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD_STORE 329 Medium
org.opentrafficsim.road.gtu.lane.tactical.following.IDMOld stored into non-transient field TrajectoriesModel.carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD_STORE 322 Medium
org.opentrafficsim.road.gtu.lane.tactical.following.IDMPlusOld stored into non-transient field TrajectoriesModel.carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD_STORE 332 Medium
org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.Egoistic stored into non-transient field TrajectoriesModel.laneChangeModel BAD_PRACTICE SE_BAD_FIELD_STORE 236 Medium

org.opentrafficsim.demo.carFollowing.XMLNetworkModel

Bug Category Details Line Priority
Class org.opentrafficsim.demo.carFollowing.XMLNetworkModel defines non-transient non-serializable instance field carFollowingModelCars BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.XMLNetworkModel defines non-transient non-serializable instance field carFollowingModelTrucks BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.XMLNetworkModel defines non-transient non-serializable instance field gtuColorer BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.XMLNetworkModel defines non-transient non-serializable instance field idGenerator BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.XMLNetworkModel defines non-transient non-serializable instance field laneChangeModel BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.XMLNetworkModel defines non-transient non-serializable instance field properties BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.demo.carFollowing.XMLNetworkModel defines non-transient non-serializable instance field routeGenerator BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.Egoistic stored into non-transient field XMLNetworkModel.laneChangeModel BAD_PRACTICE SE_BAD_FIELD_STORE 252 Medium
org.opentrafficsim.core.network.route.FixedRouteGenerator stored into non-transient field XMLNetworkModel.routeGenerator BAD_PRACTICE SE_BAD_FIELD_STORE 489 Medium
org.opentrafficsim.core.network.route.ProbabilisticRouteGenerator stored into non-transient field XMLNetworkModel.routeGenerator BAD_PRACTICE SE_BAD_FIELD_STORE 519 Medium

org.opentrafficsim.demo.carFollowing.XMLNetworkModel$DirectionGTUColorer

Bug Category Details Line Priority
Should org.opentrafficsim.demo.carFollowing.XMLNetworkModel$DirectionGTUColorer be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 901-936 Medium

org.opentrafficsim.demo.carFollowing.XMLNetworks

Bug Category Details Line Priority
Integer remainder modulo 1 computed in org.opentrafficsim.demo.carFollowing.XMLNetworks.makeCharts() STYLE INT_BAD_REM_BY_1 173 High

org.opentrafficsim.demo.geometry.shape.ShapeFileReader

Bug Category Details Line Priority
Dead store to capacity in org.opentrafficsim.demo.geometry.shape.ShapeFileReader.readLinks(String, Map, Map, OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 238 Medium
Dead store to length in org.opentrafficsim.demo.geometry.shape.ShapeFileReader.readLinks(String, Map, Map, OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 226 Medium
Dead store to speed in org.opentrafficsim.demo.geometry.shape.ShapeFileReader.readLinks(String, Map, Map, OTSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 236 Medium
Redundant nullcheck of nr, which is known to be non-null in org.opentrafficsim.demo.geometry.shape.ShapeFileReader.readNodes(String, String, boolean, boolean) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 124 Medium
Exception is caught when Exception is not thrown in org.opentrafficsim.demo.geometry.shape.ShapeFileReader.readLinks(String, Map, Map, OTSSimulatorInterface) STYLE REC_CATCH_EXCEPTION 281 Medium

org.opentrafficsim.demo.geometry.shape.ShapeModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.geometry.shape.ShapeModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 56 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.demo.geometry.shape.ShapeModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 54 Medium

org.opentrafficsim.demo.lanechange.LaneChangeGraph

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.tactical.following.IDMOld stored into non-transient field LaneChangeGraph.carFollowingModel BAD_PRACTICE SE_BAD_FIELD_STORE 298 Medium
org.opentrafficsim.road.gtu.lane.tactical.following.IDMPlusOld stored into non-transient field LaneChangeGraph.carFollowingModel BAD_PRACTICE SE_BAD_FIELD_STORE 295 Medium