PMD Results

The following document contains the results of PMD 5.1.2.

Files

org/opentrafficsim/core/gtu/generator/AbstractGTUGenerator.java

Violation Line
Avoid unused private fields such as 'lane'. 63
Avoid unused local variables such as 'car'. 158

org/opentrafficsim/core/gtu/lane/AbstractLaneBasedGTU.java

Violation Line
Useless parentheses. 207
Avoid empty if statements 424–435
Avoid unused private methods such as 'headwayRecursiveForwardSI(Lane,double,double,double,DoubleScalar.Abs)'. 688–689
Avoid unused private methods such as 'headwayRecursiveBackwardSI(Lane,double,double,double,DoubleScalar.Abs)'. 751–752
Avoid unused private methods such as 'headwayRecursiveBackwardSI(Lane,double,LaneBasedGTU,double,double,DoubleScalar.Abs)'. 938–939
Avoid empty catch blocks 1227–1230

org/opentrafficsim/core/network/ExpansionNetwork.java

Violation Line
Avoid unused local variables such as 'n'. 152
Avoid unused local variables such as 'n'. 181
Avoid empty if statements 319–323
Avoid empty if statements 325–329
Avoid unused local variables such as 'link'. 345

org/opentrafficsim/core/network/Junction.java

Violation Line
Avoid unused private fields such as 'id'. 45
Avoid unused private fields such as 'nodeSet'. 50

org/opentrafficsim/core/network/factory/LaneFactory.java

Violation Line
Avoid unused private methods such as 'makeLane(CrossSectionLink,LaneType,DoubleScalar.Rel,Rel,DoubleScalar.Rel,OTSDEVSSimulatorInterface)'. 99–101

org/opentrafficsim/core/network/factory/NetworkLaneParser.java

Violation Line
Avoid unused private fields such as 'linkIdClass'. 69
An operation on an Immutable object (String, BigDecimal or BigInteger) wont change the object itself 221
Avoid unused local variables such as 'speed'. 262
An operation on an Immutable object (String, BigDecimal or BigInteger) wont change the object itself 286
An operation on an Immutable object (String, BigDecimal or BigInteger) wont change the object itself 293
Avoid unused private methods such as 'eatSpeedRel(StringBuilder,String)'. 572
Avoid unused private methods such as 'eatLengthAbs(StringBuilder,String)'. 618
Avoid unused method parameters such as 'elements'. 712
Avoid unused local variables such as 'n'. 744

org/opentrafficsim/core/network/factory/TestXMLModel.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.core.dsol.OTSAnimatorInterface' 13
Avoid unused local variables such as 'n'. 57

org/opentrafficsim/core/network/factory/TestXMLParser.java

Violation Line
Avoid unused imports such as 'nl.tudelft.simulation.dsol.ModelInterface' 7

org/opentrafficsim/core/network/factory/XmlNetworkLaneParser.java

Violation Line
Useless parentheses. 652
Useless parentheses. 1101
Avoid unused local variables such as 'roadMarkers'. 1177
Useless parentheses. 1232
Useless parentheses. 1238
Avoid unused local variables such as 'n'. 2001

org/opentrafficsim/core/network/lane/SourceLane.java

Violation Line
Avoid unused private fields such as 'generators'. 26

org/opentrafficsim/core/unit/ElectricalChargeUnit.java

Violation Line
Too many static imports may lead to messy code 1–155

org/opentrafficsim/core/unit/EnergyUnit.java

Violation Line
Too many static imports may lead to messy code 1–249

org/opentrafficsim/core/unit/ForceUnit.java

Violation Line
Too many static imports may lead to messy code 1–177

org/opentrafficsim/core/unit/MassUnit.java

Violation Line
Too many static imports may lead to messy code 1–114

org/opentrafficsim/core/unit/PowerUnit.java

Violation Line
Too many static imports may lead to messy code 1–186

org/opentrafficsim/core/unit/PressureUnit.java

Violation Line
Too many static imports may lead to messy code 1–223

org/opentrafficsim/core/unit/SICoefficients.java

Violation Line
Avoid using a branching statement as the last in a loop. 209

org/opentrafficsim/core/value/vdouble/matrix/MutableDoubleMatrix.java

Violation Line
Avoid unused private methods such as 'incrementValueByValue(DoubleMatrix)'. 1024
Avoid unused private methods such as 'decrementValueByValue(DoubleMatrix)'. 1044

org/opentrafficsim/core/value/vdouble/vector/MutableDoubleVector.java

Violation Line
Avoid unused private methods such as 'incrementValueByValue(DoubleVector)'. 1018
Avoid unused private methods such as 'decrementValueByValue(DoubleVector)'. 1035

org/opentrafficsim/core/value/vfloat/matrix/MutableFloatMatrix.java

Violation Line
Avoid unused private methods such as 'incrementValueByValue(FloatMatrix)'. 1022
Avoid unused private methods such as 'decrementValueByValue(FloatMatrix)'. 1042

org/opentrafficsim/core/value/vfloat/vector/MutableFloatVector.java

Violation Line
Avoid unused private methods such as 'incrementValueByValue(FloatVector)'. 1018
Avoid unused private methods such as 'decrementValueByValue(FloatVector)'. 1035

org/opentrafficsim/graphs/FundamentalDiagram.java

Violation Line
Avoid unused private methods such as 'configureAxis(ValueAxis,Axis)'. 298

org/opentrafficsim/importexport/osm/output/Convert.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.importexport.osm.Link' 39
Unnecessary use of fully qualified name 'org.opentrafficsim.importexport.osm.Link' due to existing import 'org.opentrafficsim.importexport.osm.Link' 99
Unnecessary use of fully qualified name 'org.opentrafficsim.importexport.osm.Link' due to existing import 'org.opentrafficsim.importexport.osm.Link' 227
Avoid unused private methods such as 'calculateOffsets(SortedMap,org.opentrafficsim.importexport.osm.Link,Integer,Integer)'. 438–439
Unnecessary use of fully qualified name 'org.opentrafficsim.importexport.osm.Link' due to existing import 'org.opentrafficsim.importexport.osm.Link' 439
Unnecessary use of fully qualified name 'org.opentrafficsim.importexport.osm.Link' due to existing import 'org.opentrafficsim.importexport.osm.Link' 529
Unnecessary use of fully qualified name 'org.opentrafficsim.importexport.osm.Link' due to existing import 'org.opentrafficsim.importexport.osm.Link' 637
Unnecessary use of fully qualified name 'org.opentrafficsim.importexport.osm.Link' due to existing import 'org.opentrafficsim.importexport.osm.Link' 639
Unnecessary use of fully qualified name 'org.opentrafficsim.importexport.osm.Link' due to existing import 'org.opentrafficsim.importexport.osm.Link' 643
Unnecessary use of fully qualified name 'org.opentrafficsim.importexport.osm.Link' due to existing import 'org.opentrafficsim.importexport.osm.Link' 644
Unnecessary use of fully qualified name 'org.opentrafficsim.importexport.osm.Link' due to existing import 'org.opentrafficsim.importexport.osm.Link' 648
Unnecessary use of fully qualified name 'org.opentrafficsim.importexport.osm.Link' due to existing import 'org.opentrafficsim.importexport.osm.Link' 664
Unnecessary use of fully qualified name 'org.opentrafficsim.importexport.osm.Link' due to existing import 'org.opentrafficsim.importexport.osm.Link' 698
Unnecessary use of fully qualified name 'org.opentrafficsim.importexport.osm.Link' due to existing import 'org.opentrafficsim.importexport.osm.Link' 699

org/opentrafficsim/simulationengine/ControlPanel.java

Violation Line
These nested if statements could be combined 178–181