Checkstyle Results

The following document contains the results of Checkstyle 6.2 with development/dsol-checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
9 4 133 0

Files

File  I  W  E
org/opentrafficsim/imb/kpi/GtuData.java 0 11 0
org/opentrafficsim/imb/kpi/GtuTypeData.java 0 9 0
org/opentrafficsim/imb/kpi/IMBSampler.java 4 32 0
org/opentrafficsim/imb/kpi/ImbKpiTransceiver.java 0 14 0
org/opentrafficsim/imb/kpi/LaneData.java 0 17 0
org/opentrafficsim/imb/kpi/LinkData.java 0 20 0
org/opentrafficsim/imb/kpi/NodeData.java 0 11 0
org/opentrafficsim/imb/kpi/RouteData.java 0 19 0

Rules

Category Rule Violations Severity
blocks NeedBraces 48  Warning
design DesignForExtension 23  Warning
VisibilityModifier 10  Warning
javadoc JavadocMethod 15  Warning
JavadocVariable 8  Warning
misc FinalParameters 29  Warning
sizes LineLength
  • max: "128"
 4  Info

Details

org/opentrafficsim/imb/kpi/GtuData.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 77
 Warning design DesignForExtension Method 'equals' is not designed for extension - needs to be abstract, final or empty. 88
 Warning misc FinalParameters Parameter obj should be final. 89
 Warning blocks NeedBraces 'if' construct must use '{}'s. 91
 Warning blocks NeedBraces 'if' construct must use '{}'s. 93
 Warning blocks NeedBraces 'if' construct must use '{}'s. 95
 Warning blocks NeedBraces 'if' construct must use '{}'s. 100
 Warning blocks NeedBraces 'if' construct must use '{}'s. 103
 Warning blocks NeedBraces 'if' construct must use '{}'s. 107
 Warning blocks NeedBraces 'if' construct must use '{}'s. 110
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 116

org/opentrafficsim/imb/kpi/GtuTypeData.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 37
 Warning design DesignForExtension Method 'equals' is not designed for extension - needs to be abstract, final or empty. 47
 Warning misc FinalParameters Parameter obj should be final. 48
 Warning blocks NeedBraces 'if' construct must use '{}'s. 50
 Warning blocks NeedBraces 'if' construct must use '{}'s. 52
 Warning blocks NeedBraces 'if' construct must use '{}'s. 54
 Warning blocks NeedBraces 'if' construct must use '{}'s. 59
 Warning blocks NeedBraces 'if' construct must use '{}'s. 62
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 68

org/opentrafficsim/imb/kpi/IMBSampler.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'nodes' must be private and have accessor methods. 65
 Warning design VisibilityModifier Variable 'links' must be private and have accessor methods. 68
 Warning design VisibilityModifier Variable 'lanes' must be private and have accessor methods. 71
 Warning design VisibilityModifier Variable 'gtus' must be private and have accessor methods. 74
 Warning design VisibilityModifier Variable 'lastLanes' must be private and have accessor methods. 77
 Warning design VisibilityModifier Variable 'defaultGtuType' must be private and have accessor methods. 80
 Warning design VisibilityModifier Variable 'defaultRoute' must be private and have accessor methods. 83
 Info sizes LineLength Line is longer than 128 characters (found 130). 166
 Info sizes LineLength Line is longer than 128 characters (found 129). 168
 Info sizes LineLength Line is longer than 128 characters (found 130). 178
 Info sizes LineLength Line is longer than 128 characters (found 147). 187
 Warning design DesignForExtension Method 'sample' is not designed for extension - needs to be abstract, final or empty. 257
 Warning misc FinalParameters Parameter timeStamp should be final. 257
 Warning javadoc JavadocMethod Expected @param tag for 'timeStamp'. 257
 Warning misc FinalParameters Parameter gtuId should be final. 257
 Warning javadoc JavadocMethod Expected @param tag for 'gtuId'. 257
 Warning misc FinalParameters Parameter laneId should be final. 257
 Warning javadoc JavadocMethod Expected @param tag for 'laneId'. 257
 Warning misc FinalParameters Parameter forward should be final. 257
 Warning javadoc JavadocMethod Expected @param tag for 'forward'. 257
 Warning misc FinalParameters Parameter longitudinalPosition should be final. 257
 Warning javadoc JavadocMethod Expected @param tag for 'longitudinalPosition'. 257
 Warning misc FinalParameters Parameter speed should be final. 258
 Warning javadoc JavadocMethod Expected @param tag for 'speed'. 258
 Warning misc FinalParameters Parameter acceleration should be final. 258
 Warning javadoc JavadocMethod Expected @param tag for 'acceleration'. 258
 Warning design DesignForExtension Method 'updateClock' is not designed for extension - needs to be abstract, final or empty. 297
 Warning misc FinalParameters Parameter timeStamp should be final. 297
 Warning misc FinalParameters Parameter imbEventName should be final. 358
 Warning misc FinalParameters Parameter imbPayload should be final. 358
 Warning misc FinalParameters Parameter imbEventName should be final. 463
 Warning misc FinalParameters Parameter imbPayload should be final. 463
 Warning misc FinalParameters Parameter imbEventName should be final. 538
 Warning misc FinalParameters Parameter imbPayload should be final. 538
 Warning misc FinalParameters Parameter imbEventName should be final. 628
 Warning misc FinalParameters Parameter imbPayload should be final. 628

org/opentrafficsim/imb/kpi/ImbKpiTransceiver.java

Severity Category Rule Message Line
 Warning javadoc JavadocVariable Missing a Javadoc comment. 280
 Warning javadoc JavadocVariable Missing a Javadoc comment. 282
 Warning javadoc JavadocVariable Missing a Javadoc comment. 284
 Warning javadoc JavadocVariable Missing a Javadoc comment. 286
 Warning javadoc JavadocVariable Missing a Javadoc comment. 288
 Warning javadoc JavadocVariable Missing a Javadoc comment. 290
 Warning javadoc JavadocVariable Missing a Javadoc comment. 292
 Warning javadoc JavadocVariable Missing a Javadoc comment. 294
 Warning misc FinalParameters Parameter time should be final. 307
 Warning misc FinalParameters Parameter networkId should be final. 307
 Warning design DesignForExtension Method 'notifyTime' is not designed for extension - needs to be abstract, final or empty. 334
 Warning misc FinalParameters Parameter time should be final. 334
 Warning javadoc JavadocMethod Expected @param tag for 'time'. 334
 Warning design DesignForExtension Method 'sendStatisticsUpdate' is not designed for extension - needs to be abstract, final or empty. 352

org/opentrafficsim/imb/kpi/LaneData.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'length' must be private and have accessor methods. 26
 Warning javadoc JavadocMethod Expected @param tag for 'linkData'. 33
 Warning javadoc JavadocMethod Expected @param tag for 'laneName'. 33
 Warning misc FinalParameters Parameter linkData should be final. 66
 Warning design DesignForExtension Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 72
 Warning design DesignForExtension Method 'equals' is not designed for extension - needs to be abstract, final or empty. 84
 Warning misc FinalParameters Parameter obj should be final. 85
 Warning blocks NeedBraces 'if' construct must use '{}'s. 87
 Warning blocks NeedBraces 'if' construct must use '{}'s. 89
 Warning blocks NeedBraces 'if' construct must use '{}'s. 91
 Warning blocks NeedBraces 'if' construct must use '{}'s. 96
 Warning blocks NeedBraces 'if' construct must use '{}'s. 99
 Warning blocks NeedBraces 'if' construct must use '{}'s. 103
 Warning blocks NeedBraces 'if' construct must use '{}'s. 106
 Warning blocks NeedBraces 'if' construct must use '{}'s. 110
 Warning blocks NeedBraces 'if' construct must use '{}'s. 113
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 119

org/opentrafficsim/imb/kpi/LinkData.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'startNode' must be private and have accessor methods. 27
 Warning design VisibilityModifier Variable 'endNode' must be private and have accessor methods. 30
 Warning javadoc JavadocMethod Expected @param tag for 'startNode'. 44
 Warning javadoc JavadocMethod Expected @param tag for 'endNode'. 44
 Warning design DesignForExtension Method 'addLaneData' is not designed for extension - needs to be abstract, final or empty. 56
 Warning design DesignForExtension Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 100
 Warning design DesignForExtension Method 'equals' is not designed for extension - needs to be abstract, final or empty. 113
 Warning misc FinalParameters Parameter obj should be final. 114
 Warning blocks NeedBraces 'if' construct must use '{}'s. 116
 Warning blocks NeedBraces 'if' construct must use '{}'s. 118
 Warning blocks NeedBraces 'if' construct must use '{}'s. 120
 Warning blocks NeedBraces 'if' construct must use '{}'s. 125
 Warning blocks NeedBraces 'if' construct must use '{}'s. 128
 Warning blocks NeedBraces 'if' construct must use '{}'s. 132
 Warning blocks NeedBraces 'if' construct must use '{}'s. 135
 Warning blocks NeedBraces 'if' construct must use '{}'s. 139
 Warning blocks NeedBraces 'if' construct must use '{}'s. 142
 Warning blocks NeedBraces 'if' construct must use '{}'s. 146
 Warning blocks NeedBraces 'if' construct must use '{}'s. 149
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 155

org/opentrafficsim/imb/kpi/NodeData.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 53
 Warning design DesignForExtension Method 'equals' is not designed for extension - needs to be abstract, final or empty. 64
 Warning misc FinalParameters Parameter obj should be final. 65
 Warning blocks NeedBraces 'if' construct must use '{}'s. 67
 Warning blocks NeedBraces 'if' construct must use '{}'s. 69
 Warning blocks NeedBraces 'if' construct must use '{}'s. 71
 Warning blocks NeedBraces 'if' construct must use '{}'s. 76
 Warning blocks NeedBraces 'if' construct must use '{}'s. 79
 Warning blocks NeedBraces 'if' construct must use '{}'s. 83
 Warning blocks NeedBraces 'if' construct must use '{}'s. 86
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 92

org/opentrafficsim/imb/kpi/RouteData.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter routeName should be final. 31
 Warning javadoc JavadocMethod Expected @param tag for 'routeName'. 31
 Warning misc FinalParameters Parameter startNode should be final. 31
 Warning javadoc JavadocMethod Expected @param tag for 'startNode'. 31
 Warning misc FinalParameters Parameter endNode should be final. 31
 Warning javadoc JavadocMethod Expected @param tag for 'endNode'. 31
 Warning design DesignForExtension Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 64
 Warning design DesignForExtension Method 'equals' is not designed for extension - needs to be abstract, final or empty. 76
 Warning misc FinalParameters Parameter obj should be final. 77
 Warning blocks NeedBraces 'if' construct must use '{}'s. 79
 Warning blocks NeedBraces 'if' construct must use '{}'s. 81
 Warning blocks NeedBraces 'if' construct must use '{}'s. 83
 Warning blocks NeedBraces 'if' construct must use '{}'s. 88
 Warning blocks NeedBraces 'if' construct must use '{}'s. 91
 Warning blocks NeedBraces 'if' construct must use '{}'s. 95
 Warning blocks NeedBraces 'if' construct must use '{}'s. 98
 Warning blocks NeedBraces 'if' construct must use '{}'s. 102
 Warning blocks NeedBraces 'if' construct must use '{}'s. 105
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 111