The following document contains the results of Checkstyle 6.2 with development/dsol-checks.xml ruleset. 
| Category | Rule | Violations | Severity |
|---|---|---|---|
| blocks | EmptyBlock | 1 |  Warning |
| NeedBraces | 11 | Warning | |
| design | DesignForExtension | 28 | Warning |
| HideUtilityClassConstructor | 2 | Warning | |
| VisibilityModifier | 12 | Warning | |
| imports | UnusedImports | 1 | Warning |
| javadoc | JavadocMethod | 18 | Warning |
JavadocStyle
|
4 | Warning | |
| JavadocVariable | 17 | Warning | |
| misc | FinalParameters | 43 | Warning |
| TodoComment | 3 | Warning | |
| modifier | ModifierOrder | 4 | Warning |
| naming | MethodName | 4 | Warning |
| StaticVariableName | 1 | Warning | |
| sizes | LineLength
|
2 |  Info |
| MethodLength | 4 | Info | |
| ParameterNumber | 1 | Info |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
naming | StaticVariableName | Name 'PROPERTY_KEY' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 26 |
| Warning |
design | VisibilityModifier | Variable 'PROPERTY_KEY' must be private and have accessor methods. | 26 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'imbConnector' must be private and have accessor methods. | 186 |
| Warning |
design | VisibilityModifier | Variable 'dx' must be private and have accessor methods. | 293 |
| Warning |
design | VisibilityModifier | Variable 'dy' must be private and have accessor methods. | 296 |
| Warning |
misc | FinalParameters | Parameter x should be final. | 310 |
| Warning |
misc | FinalParameters | Parameter y should be final. | 310 |
| Warning |
misc | FinalParameters | Parameter x should be final. | 318 |
| Warning |
misc | FinalParameters | Parameter y should be final. | 318 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | FinalParameters | Parameter simulator should be final. | 250 |
| Warning |
design | VisibilityModifier | Variable 'imbConnector' must be private and have accessor methods. | 434 |
| Info |
sizes | MethodLength | Method length is 272 lines (max allowed is 150). | 467 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 27 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 43 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
| Warning |
javadoc | JavadocMethod | Missing a Javadoc comment. | 47 |
| Warning |
javadoc | JavadocMethod | Missing a Javadoc comment. | 85 |
| Warning |
javadoc | JavadocMethod | Missing a Javadoc comment. | 100 |
| Warning |
javadoc | JavadocMethod | Missing a Javadoc comment. | 117 |
| Warning |
javadoc | JavadocMethod | Missing a Javadoc comment. | 150 |
| Warning |
javadoc | JavadocMethod | Missing a Javadoc comment. | 166 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 8). | 166 |
| Warning |
javadoc | JavadocMethod | Missing a Javadoc comment. | 258 |
| Warning |
javadoc | JavadocMethod | Expected @throws tag for 'URISyntaxException'. | 291 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 315 |
| Warning |
design | VisibilityModifier | Variable 'x' must be private and have accessor methods. | 315 |
| Warning |
design | VisibilityModifier | Variable 'y' must be private and have accessor methods. | 315 |
| Warning |
misc | FinalParameters | Parameter x should be final. | 321 |
| Warning |
javadoc | JavadocMethod | Expected @param tag for 'x'. | 321 |
| Warning |
misc | FinalParameters | Parameter y should be final. | 321 |
| Warning |
javadoc | JavadocMethod | Expected @param tag for 'y'. | 321 |
| Warning |
misc | FinalParameters | Parameter obj should be final. | 344 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 346 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 348 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 350 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 353 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 355 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'btnConnect' must be private and have accessor methods. | 56 |
| Warning |
modifier | ModifierOrder | 'public' modifier out of order with the JLS suggestions. | 69 |
| Warning |
misc | FinalParameters | Parameter comTime should be final. | 69 |
| Warning |
modifier | ModifierOrder | 'public' modifier out of order with the JLS suggestions. | 79 |
| Warning |
misc | FinalParameters | Parameter comTime should be final. | 79 |
| Warning |
modifier | ModifierOrder | 'public' modifier out of order with the JLS suggestions. | 97 |
| Warning |
misc | FinalParameters | Parameter javaDate should be final. | 97 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 106 |
| Warning |
modifier | ModifierOrder | 'public' modifier out of order with the JLS suggestions. | 111 |
| Warning |
misc | FinalParameters | Parameter milliseconds should be final. | 111 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 123 |
| Warning |
design | DesignForExtension | Method 'AddMessage' is not designed for extension - needs to be abstract, final or empty. | 129 |
| Warning |
naming | MethodName | Name 'AddMessage' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 129 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 149 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 151 |
| Warning |
design | DesignForExtension | Method 'Connect' is not designed for extension - needs to be abstract, final or empty. | 158 |
| Warning |
naming | MethodName | Name 'Connect' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 158 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 163 |
| Warning |
misc | FinalParameters | Parameter aEvent should be final. | 183 |
| Warning |
misc | FinalParameters | Parameter aPayload should be final. | 183 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 196 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 197 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 199 |
| Warning |
design | DesignForExtension | Method 'Disconnect' is not designed for extension - needs to be abstract, final or empty. | 208 |
| Warning |
naming | MethodName | Name 'Disconnect' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 208 |
| Warning |
design | DesignForExtension | Method 'Send' is not designed for extension - needs to be abstract, final or empty. | 220 |
| Warning |
naming | MethodName | Name 'Send' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 220 |
| Warning |
misc | FinalParameters | Parameter args should be final. | 253 |
| Warning |
misc | FinalParameters | Parameter windowEvent should be final. | 289 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 322 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 324 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 326 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 342 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 351 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 357 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 369 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'descriptionPanel' must be private and have accessor methods. | 95 |
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 104 |
| Info |
sizes | LineLength | Line is longer than 128 characters (found 135). | 237 |
| Info |
sizes | MethodLength | Method length is 251 lines (max allowed is 150). | 353 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 558 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 571 |
| Warning |
misc | FinalParameters | Parameter e should be final. | 584 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | FinalParameters | Parameter args should be final. | 127 |
| Warning |
javadoc | JavadocMethod | Expected @param tag for 'args'. | 127 |
| Warning |
misc | FinalParameters | Parameter providedModelName should be final. | 127 |
| Warning |
javadoc | JavadocMethod | Expected @param tag for 'providedModelName'. | 127 |
| Warning |
misc | FinalParameters | Parameter providedModelId should be final. | 127 |
| Warning |
javadoc | JavadocMethod | Expected @param tag for 'providedModelId'. | 127 |
| Warning |
javadoc | JavadocMethod | Expected @throws tag for 'IMBException'. | 127 |
| Warning |
design | DesignForExtension | Method 'startModel' is not designed for extension - needs to be abstract, final or empty. | 161 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 221 |
| Warning |
design | DesignForExtension | Method 'stopModel' is not designed for extension - needs to be abstract, final or empty. | 242 |
| Warning |
design | DesignForExtension | Method 'quitApplication' is not designed for extension - needs to be abstract, final or empty. | 266 |
| Warning |
design | DesignForExtension | Method 'parameterRequest' is not designed for extension - needs to be abstract, final or empty. | 286 |
| Warning |
misc | FinalParameters | Parameter parameters should be final. | 287 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 325 |
| Warning |
javadoc | JavadocMethod | Expected @param tag for 'args'. | 331 |
| Warning |
javadoc | JavadocMethod | Expected @throws tag for 'InvocationTargetException'. | 331 |
| Warning |
javadoc | JavadocMethod | Expected @throws tag for 'InterruptedException'. | 331 |
| Warning |
javadoc | JavadocMethod | Expected @throws tag for 'PropertyException'. | 429 |
| Info |
sizes | MethodLength | Method length is 282 lines (max allowed is 150). | 519 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'imbConnector' must be private and have accessor methods. | 189 |
| Warning |
design | VisibilityModifier | Variable 'dx' must be private and have accessor methods. | 293 |
| Warning |
design | VisibilityModifier | Variable 'dy' must be private and have accessor methods. | 296 |
| Warning |
misc | FinalParameters | Parameter x should be final. | 310 |
| Warning |
misc | FinalParameters | Parameter y should be final. | 310 |
| Warning |
misc | FinalParameters | Parameter x should be final. | 318 |
| Warning |
misc | FinalParameters | Parameter y should be final. | 318 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 69 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 72 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | FinalParameters | Parameter imbNewPayload should be final. | 85 |
| Warning |
misc | FinalParameters | Parameter imbDeletePayload should be final. | 124 |
| Warning |
design | DesignForExtension | Method 'notify' is not designed for extension - needs to be abstract, final or empty. | 145 |
| Warning |
design | DesignForExtension | Method 'addIMBtoOTSChannel' is not designed for extension - needs to be abstract, final or empty. | 177 |
| Warning |
design | DesignForExtension | Method 'addIMBtoOTSChannel' is not designed for extension - needs to be abstract, final or empty. | 195 |
| Warning |
design | DesignForExtension | Method 'handleMessageFromIMB' is not designed for extension - needs to be abstract, final or empty. | 205 |
| Warning |
design | DesignForExtension | Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 214 |
| Warning |
design | DesignForExtension | Method 'getSimulator' is not designed for extension - needs to be abstract, final or empty. | 239 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | FinalParameters | Parameter eventContent should be final. | 35 |
| Warning |
misc | FinalParameters | Parameter eventListener should be final. | 35 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | DesignForExtension | Method 'handle' is not designed for extension - needs to be abstract, final or empty. | 66 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | DesignForExtension | Method 'notify' is not designed for extension - needs to be abstract, final or empty. | 365 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | FinalParameters | Parameter simulator should be final. | 237 |
| Warning |
misc | FinalParameters | Parameter network should be final. | 237 |
| Warning |
design | DesignForExtension | Method 'makePNG' is not designed for extension - needs to be abstract, final or empty. | 294 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | DesignForExtension | Method 'notify' is not designed for extension - needs to be abstract, final or empty. | 254 |
| Warning |
design | DesignForExtension | Method 'transformNew' is not designed for extension - needs to be abstract, final or empty. | 398 |
| Warning |
design | DesignForExtension | Method 'transformChange' is not designed for extension - needs to be abstract, final or empty. | 441 |
| Warning |
design | DesignForExtension | Method 'transformDelete' is not designed for extension - needs to be abstract, final or empty. | 467 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | DesignForExtension | Method 'notify' is not designed for extension - needs to be abstract, final or empty. | 242 |
| Warning |
design | DesignForExtension | Method 'transformNew' is not designed for extension - needs to be abstract, final or empty. | 335 |
| Warning |
design | DesignForExtension | Method 'transformChange' is not designed for extension - needs to be abstract, final or empty. | 377 |
| Warning |
design | DesignForExtension | Method 'transformDelete' is not designed for extension - needs to be abstract, final or empty. | 401 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Info |
sizes | LineLength | Line is longer than 128 characters (found 134). | 15 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | DesignForExtension | Method 'notify' is not designed for extension - needs to be abstract, final or empty. | 160 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | DesignForExtension | Method 'notify' is not designed for extension - needs to be abstract, final or empty. | 254 |
| Info |
sizes | MethodLength | Method length is 174 lines (max allowed is 150). | 254 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | FinalParameters | Parameter imbPayload should be final. | 70 |
| Warning |
misc | FinalParameters | Parameter imbPayload should be final. | 96 |
| Warning |
misc | FinalParameters | Parameter imbPayload should be final. | 115 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - org.opentrafficsim.core.network.Network. | 13 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 280 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 282 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 284 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 286 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 288 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 290 |
| Warning |
javadoc | JavadocVariable | Missing a Javadoc comment. | 292 |
| Warning |
misc | FinalParameters | Parameter simulator should be final. | 305 |
| Warning |
misc | FinalParameters | Parameter networkId should be final. | 305 |
| Warning |
design | DesignForExtension | Method 'sendStatisticsUpdate' is not designed for extension - needs to be abstract, final or empty. | 340 |
Errors