FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
64 37 0 0

Files

Class Bugs
nl.tno.imb.TByteBuffer 5
nl.tno.imb.TConnection 15
nl.tno.imb.TConnection$TEventEntryList 1
nl.tno.imb.TConnection$TEventNameEntry 1
nl.tno.imb.TConnection$TEventTranslation 1
nl.tno.imb.TEventEntry 4
nl.tno.imb.TEventEntry$TStreamCacheEntry 1
nl.tno.imb.TLocator 3
nl.tno.imb.mc.ModelEvent$DeleteEvent 1
nl.tno.imb.mc.ModelEvent$ModelChangeEvent 1
nl.tno.imb.mc.ModelStarter 1
nl.tno.imb.mc.ModelState 1
nl.tno.imb.mc.Parameter$PropertyIterator 2

nl.tno.imb.TByteBuffer

Bug Category Details Line Priority
Dead store to len in nl.tno.imb.TByteBuffer.readByteBuffer(TByteBuffer) STYLE DLS_DEAD_LOCAL_STORE 399 Medium
nl.tno.imb.TByteBuffer.readByteBuffer(TByteBuffer) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 399 Medium
nl.tno.imb.TByteBuffer.getBuffer() may expose internal representation by returning TByteBuffer.fBuffer MALICIOUS_CODE EI_EXPOSE_REP 95 Medium
new nl.tno.imb.TByteBuffer(byte[]) may expose internal representation by storing an externally mutable object into TByteBuffer.fBuffer MALICIOUS_CODE EI_EXPOSE_REP2 44 Medium
The method name nl.tno.imb.TByteBuffer.ReadStart() doesn't start with a lower case letter BAD_PRACTICE NM_METHOD_NAMING_CONVENTION 137-138 Medium

nl.tno.imb.TConnection

Bug Category Details Line Priority
Synchronization on Integer in nl.tno.imb.TConnection.writeCommand(int, byte[]) MT_CORRECTNESS DL_SYNCHRONIZATION_ON_UNSHARED_BOXED_PRIMITIVE 351 Medium
new nl.tno.imb.TConnection(String, int, String, int, String, boolean) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 342 Medium
Comparison of String parameter using == or != in nl.tno.imb.TConnection.setOwnerName(String) BAD_PRACTICE ES_COMPARING_PARAMETER_STRING_WITH_EQ 913 High
Comparison of String objects using == or != in nl.tno.imb.TConnection.setFederation(String) BAD_PRACTICE ES_COMPARING_STRINGS_WITH_EQ 710 Medium
nl.tno.imb.TConnection.MAGIC_BYTES should be package protected MALICIOUS_CODE MS_PKGPROTECT 159 Medium
nl.tno.imb.TConnection.MAGIC_STRING_CHECK should be package protected MALICIOUS_CODE MS_PKGPROTECT 166 Medium
Exception is caught when Exception is not thrown in nl.tno.imb.TConnection.open(String, int, boolean) STYLE REC_CATCH_EXCEPTION 647 Medium
Switch statement found in nl.tno.imb.TConnection.handleSubAndPub(int, TByteBuffer) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 492-526 Medium
Field only ever set to null: nl.tno.imb.TConnection.onDisconnect CORRECTNESS UWF_NULL_FIELD Not available Medium
Field only ever set to null: nl.tno.imb.TConnection.onEventNames CORRECTNESS UWF_NULL_FIELD Not available Medium
Field only ever set to null: nl.tno.imb.TConnection.onSubAndPub CORRECTNESS UWF_NULL_FIELD Not available Medium

nl.tno.imb.TConnection$TEventEntryList

Bug Category Details Line Priority
Should nl.tno.imb.TConnection$TEventEntryList be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 105-148 Medium

nl.tno.imb.TConnection$TEventNameEntry

Bug Category Details Line Priority
Should nl.tno.imb.TConnection$TEventNameEntry be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 656 Medium
Unread public/protected field: nl.tno.imb.TConnection$TEventNameEntry.eventName STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 479 Medium
Unread public/protected field: nl.tno.imb.TConnection$TEventNameEntry.publishers STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 480 Medium
Unread public/protected field: nl.tno.imb.TConnection$TEventNameEntry.subscribers STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 481 Medium
Unread public/protected field: nl.tno.imb.TConnection$TEventNameEntry.timers STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 482 Medium

nl.tno.imb.TConnection$TEventTranslation

Bug Category Details Line Priority
Should nl.tno.imb.TConnection$TEventTranslation be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 73-101 Medium

nl.tno.imb.TEventEntry

Bug Category Details Line Priority
Invocation of hashCode on array in nl.tno.imb.TEventEntry.signalStream(String, InputStream) CORRECTNESS DMI_INVOKING_HASHCODE_ON_ARRAY 725 Medium
Switch statement found in nl.tno.imb.TEventEntry.handleStreamEvent(int, TByteBuffer) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 405-440 Medium
Switch statement found in nl.tno.imb.TEventEntry.handleSubAndPub(int) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 449-469 Medium
Field only ever set to null: nl.tno.imb.TEventEntry.onChildEvent CORRECTNESS UWF_NULL_FIELD Not available Medium

nl.tno.imb.TEventEntry$TStreamCacheEntry

Bug Category Details Line Priority
Should nl.tno.imb.TEventEntry$TStreamCacheEntry be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 153-162 Medium

nl.tno.imb.TLocator

Bug Category Details Line Priority
The method name nl.tno.imb.TLocator.DecodeServerURIPort(String) doesn't start with a lower case letter BAD_PRACTICE NM_METHOD_NAMING_CONVENTION 43-62 Medium
The method name nl.tno.imb.TLocator.DecodeServerURIServer(String) doesn't start with a lower case letter BAD_PRACTICE NM_METHOD_NAMING_CONVENTION 20-39 Medium
The method name nl.tno.imb.TLocator.LocateServerURI(boolean, int, int) doesn't start with a lower case letter BAD_PRACTICE NM_METHOD_NAMING_CONVENTION 67-118 Medium

nl.tno.imb.mc.ModelEvent$DeleteEvent

Bug Category Details Line Priority
Should nl.tno.imb.mc.ModelEvent$DeleteEvent be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 49-65 Medium

nl.tno.imb.mc.ModelEvent$ModelChangeEvent

Bug Category Details Line Priority
Should nl.tno.imb.mc.ModelEvent$ModelChangeEvent be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 88-119 Medium

nl.tno.imb.mc.ModelStarter

Bug Category Details Line Priority
nl.tno.imb.mc.ModelStarter.doQuitApplication() invokes System.exit(...), which shuts down the entire virtual machine BAD_PRACTICE DM_EXIT 324 Medium

nl.tno.imb.mc.ModelState

Bug Category Details Line Priority
nl.tno.imb.mc.ModelState.commandMap isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 30 High

nl.tno.imb.mc.Parameter$PropertyIterator

Bug Category Details Line Priority
nl.tno.imb.mc.Parameter$PropertyIterator is serializable but also an inner class of a non-serializable class BAD_PRACTICE SE_BAD_FIELD_INNER_CLASS 298-362 High
Should nl.tno.imb.mc.Parameter$PropertyIterator be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 298-362 Medium