Checkstyle Results

The following document contains the results of Checkstyle 6.2 with development/dsol-checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
4 2 56 0

Files

File  I  W  E
org/opentrafficsim/trafficcontrol/TrafficController.java 0 1 0
org/opentrafficsim/trafficcontrol/trafcod/TrafCOD.java 2 55 0

Rules

Category Rule Violations Severity
coding HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
 1  Warning
design DesignForExtension 4  Warning
VisibilityModifier 16  Warning
javadoc JavadocMethod 2  Warning
JavadocStyle
  • checkHtml: "false"
 3  Warning
misc FinalParameters 18  Warning
modifier ModifierOrder 9  Warning
RedundantModifier 1  Warning
naming StaticVariableName 1  Warning
sizes FileLength 1  Warning
MethodLength 2  Info

Details

org/opentrafficsim/trafficcontrol/TrafficController.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 23

org/opentrafficsim/trafficcontrol/trafcod/TrafCOD.java

Severity Category Rule Message Line
 Warning sizes FileLength File length is 2,057 lines (max allowed is 2,000). 1
 Warning design VisibilityModifier Variable 'controllerName' must be private and have accessor methods. 71
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 74
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 77
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 80
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 83
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 86
 Warning design VisibilityModifier Variable 'trafcodRules' must be private and have accessor methods. 89
 Warning design VisibilityModifier Variable 'tokenisedRules' must be private and have accessor methods. 92
 Warning design VisibilityModifier Variable 'variables' must be private and have accessor methods. 95
 Warning design VisibilityModifier Variable 'detectors' must be private and have accessor methods. 98
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 101
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 104
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 107
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 110
 Warning javadoc JavadocStyle First sentence should end with a period. 136
 Info sizes MethodLength Method length is 210 lines (max allowed is 150). 155
 Warning misc FinalParameters Parameter controllerName should be final. 155
 Warning naming StaticVariableName Name 'BIND_UNARY_MINUS' must match pattern '^[a-z][a-zA-Z0-9]*$'. 534
 Warning javadoc JavadocMethod Expected @throws tag for 'Exception'. 644
 Warning misc FinalParameters Parameter tokens should be final. 792
 Info sizes MethodLength Method length is 263 lines (max allowed is 150). 979
 Warning misc FinalParameters Parameter name should be final. 1284
 Warning misc FinalParameters Parameter stream should be final. 1284
 Warning misc FinalParameters Parameter flags should be final. 1284
 Warning misc FinalParameters Parameter location should be final. 1284
 Warning javadoc JavadocStyle First sentence should end with a period. 1316
 Warning misc FinalParameters Parameter theSimulator should be final. 1332
 Warning design DesignForExtension Method 'getSimulator' is not designed for extension - needs to be abstract, final or empty. 1385
 Warning design DesignForExtension Method 'getStructureNumber' is not designed for extension - needs to be abstract, final or empty. 1394
 Warning design DesignForExtension Method 'setStructureNumber' is not designed for extension - needs to be abstract, final or empty. 1403
 Warning misc FinalParameters Parameter structureNumber should be final. 1403
 Warning design DesignForExtension Method 'updateDetector' is not designed for extension - needs to be abstract, final or empty. 1409
 Warning misc FinalParameters Parameter detectorId should be final. 1410
 Warning misc FinalParameters Parameter detectingGTU should be final. 1410
 Warning design VisibilityModifier Variable 'flags' must be private and have accessor methods. 1580
 Warning design VisibilityModifier Variable 'value' must be private and have accessor methods. 1583
 Warning design VisibilityModifier Variable 'timerMax10' must be private and have accessor methods. 1586
 Warning design VisibilityModifier Variable 'color' must be private and have accessor methods. 1589
 Warning design VisibilityModifier Variable 'name' must be private and have accessor methods. 1592
 Warning design VisibilityModifier Variable 'listPos' must be private and have accessor methods. 1595
 Warning javadoc JavadocStyle First sentence should end with a period. 1597
 Warning design VisibilityModifier Variable 'stream' must be private and have accessor methods. 1598
 Warning design VisibilityModifier Variable 'refCount' must be private and have accessor methods. 1601
 Warning design VisibilityModifier Variable 'updateTime10' must be private and have accessor methods. 1604
 Warning design VisibilityModifier Variable 'startSource' must be private and have accessor methods. 1607
 Warning design VisibilityModifier Variable 'endSource' must be private and have accessor methods. 1610
 Warning misc FinalParameters Parameter newValue should be final. 1670
 Warning misc FinalParameters Parameter timeStamp10 should be final. 1670
 Warning javadoc JavadocMethod Expected @throws tag for 'Exception'. 1700
 Warning misc FinalParameters Parameter colorValue should be final. 1786
 Warning misc FinalParameters Parameter trafficLights should be final. 1786
 Warning coding HiddenField 'trafficLights' hides a field. 1786
 Warning misc FinalParameters Parameter value10 should be final. 1814
 Warning misc FinalParameters Parameter startSource should be final. 1837
 Warning misc FinalParameters Parameter endSource should be final. 1861
 Warning misc FinalParameters Parameter printFlags should be final. 1892