Checkstyle Results

The following document contains the results of Checkstyle 6.2 with development/dsol-checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
7 4 107 0

Files

File  I  W  E
org/opentrafficsim/trafficcontrol/TrafficController.java 0 1 0
org/opentrafficsim/trafficcontrol/trafcod/TrafCOD.java 4 58 0
org/opentrafficsim/trafficcontrol/trafcod/TrafCODDemo.java 0 9 0
org/opentrafficsim/trafficcontrol/trafcod/TrafCODDisplay.java 0 39 0

Rules

Category Rule Violations Severity
design DesignForExtension 16  Warning
VisibilityModifier 20  Warning
javadoc JavadocMethod 1  Warning
JavadocStyle
  • checkHtml: "false"
 3  Warning
misc FinalParameters 52  Warning
modifier ModifierOrder 10  Warning
RedundantModifier 1  Warning
naming ConstantName 2  Warning
StaticVariableName 1  Warning
sizes FileLength 1  Warning
LineLength
  • max: "128"
 2  Info
MethodLength 2  Info

Details

org/opentrafficsim/trafficcontrol/TrafficController.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 23

org/opentrafficsim/trafficcontrol/trafcod/TrafCOD.java

Severity Category Rule Message Line
 Warning sizes FileLength File length is 2,439 lines (max allowed is 2,000). 1
 Warning design VisibilityModifier Variable 'controllerName' must be private and have accessor methods. 60
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 63
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 66
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 69
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 72
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 75
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 78
 Warning design VisibilityModifier Variable 'trafcodRules' must be private and have accessor methods. 81
 Warning design VisibilityModifier Variable 'tokenisedRules' must be private and have accessor methods. 84
 Warning design VisibilityModifier Variable 'variables' must be private and have accessor methods. 87
 Warning design VisibilityModifier Variable 'variablesInDefinitionOrder' must be private and have accessor methods. 90
 Warning design VisibilityModifier Variable 'detectors' must be private and have accessor methods. 93
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 96
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 99
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 102
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 105
 Warning javadoc JavadocStyle First sentence should end with a period. 132
 Warning misc FinalParameters Parameter controllerName should be final. 154
 Warning misc FinalParameters Parameter display should be final. 156
 Info sizes MethodLength Method length is 213 lines (max allowed is 150). 200
 Info sizes LineLength Line is longer than 128 characters (found 129). 354
 Info sizes LineLength Line is longer than 128 characters (found 129). 359
 Warning misc FinalParameters Parameter sensors should be final. 424
 Warning naming StaticVariableName Name 'BIND_UNARY_MINUS' must match pattern '^[a-z][a-zA-Z0-9]*$'. 778
 Warning misc FinalParameters Parameter tokens should be final. 1034
 Info sizes MethodLength Method length is 271 lines (max allowed is 150). 1245
 Warning misc FinalParameters Parameter name should be final. 1558
 Warning misc FinalParameters Parameter stream should be final. 1558
 Warning misc FinalParameters Parameter flags should be final. 1558
 Warning misc FinalParameters Parameter location should be final. 1558
 Warning design DesignForExtension Method 'getSimulator' is not designed for extension - needs to be abstract, final or empty. 1596
 Warning design DesignForExtension Method 'getStructureNumber' is not designed for extension - needs to be abstract, final or empty. 1605
 Warning design DesignForExtension Method 'updateDetector' is not designed for extension - needs to be abstract, final or empty. 1611
 Warning misc FinalParameters Parameter detectorId should be final. 1612
 Warning misc FinalParameters Parameter detectingGTU should be final. 1612
 Warning design DesignForExtension Method 'traceVariablesOfStream' is not designed for extension - needs to be abstract, final or empty. 1629
 Warning design DesignForExtension Method 'traceVariable' is not designed for extension - needs to be abstract, final or empty. 1654
 Warning design VisibilityModifier Variable 'flags' must be private and have accessor methods. 1820
 Warning design VisibilityModifier Variable 'value' must be private and have accessor methods. 1823
 Warning design VisibilityModifier Variable 'timerMax10' must be private and have accessor methods. 1826
 Warning design VisibilityModifier Variable 'color' must be private and have accessor methods. 1829
 Warning design VisibilityModifier Variable 'name' must be private and have accessor methods. 1832
 Warning design VisibilityModifier Variable 'listPos' must be private and have accessor methods. 1835
 Warning javadoc JavadocStyle First sentence should end with a period. 1837
 Warning design VisibilityModifier Variable 'stream' must be private and have accessor methods. 1838
 Warning design VisibilityModifier Variable 'refCount' must be private and have accessor methods. 1841
 Warning design VisibilityModifier Variable 'updateTime10' must be private and have accessor methods. 1844
 Warning design VisibilityModifier Variable 'startSource' must be private and have accessor methods. 1847
 Warning design VisibilityModifier Variable 'endSource' must be private and have accessor methods. 1850
 Warning misc FinalParameters Parameter sensor should be final. 1888
 Warning misc FinalParameters Parameter newValue should be final. 1985
 Warning misc FinalParameters Parameter timeStamp10 should be final. 1985
 Warning misc FinalParameters Parameter cause should be final. 1985
 Warning misc FinalParameters Parameter colorValue should be final. 2096
 Warning misc FinalParameters Parameter value10 should be final. 2145
 Warning misc FinalParameters Parameter startSource should be final. 2169
 Warning misc FinalParameters Parameter endSource should be final. 2193
 Warning misc FinalParameters Parameter printFlags should be final. 2224
 Warning misc FinalParameters Parameter event should be final. 2333
 Warning design VisibilityModifier Variable 'cause' must be private and have accessor methods. 2354
 Warning javadoc JavadocMethod Missing a Javadoc comment. 2365

org/opentrafficsim/trafficcontrol/trafcod/TrafCODDemo.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'controllerDisplayPanel' must be private and have accessor methods. 96
 Warning design DesignForExtension Method 'shortName' is not designed for extension - needs to be abstract, final or empty. 99
 Warning design DesignForExtension Method 'description' is not designed for extension - needs to be abstract, final or empty. 106
 Warning design DesignForExtension Method 'makeCharts' is not designed for extension - needs to be abstract, final or empty. 113
 Warning misc FinalParameters Parameter simulator should be final. 114
 Warning design DesignForExtension Method 'makeModel' is not designed for extension - needs to be abstract, final or empty. 123
 Warning misc FinalParameters Parameter colorer should be final. 124
 Warning design DesignForExtension Method 'makeAnimationRectangle' is not designed for extension - needs to be abstract, final or empty. 130
 Warning misc FinalParameters Parameter theSimulator should be final. 148

org/opentrafficsim/trafficcontrol/trafcod/TrafCODDisplay.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'defaultInitialDelay' must be private and have accessor methods. 53
 Warning design DesignForExtension Method 'paintComponent' is not designed for extension - needs to be abstract, final or empty. 67
 Warning design DesignForExtension Method 'addTrafCODObject' is not designed for extension - needs to be abstract, final or empty. 82
 Warning design DesignForExtension Method 'mouseDragged' is not designed for extension - needs to be abstract, final or empty. 88
 Warning misc FinalParameters Parameter e should be final. 89
 Warning design DesignForExtension Method 'mouseMoved' is not designed for extension - needs to be abstract, final or empty. 95
 Warning misc FinalParameters Parameter e should be final. 96
 Warning misc FinalParameters Parameter e should be final. 113
 Warning misc FinalParameters Parameter e should be final. 120
 Warning misc FinalParameters Parameter e should be final. 127
 Warning design DesignForExtension Method 'mouseEntered' is not designed for extension - needs to be abstract, final or empty. 133
 Warning misc FinalParameters Parameter e should be final. 134
 Warning design DesignForExtension Method 'mouseExited' is not designed for extension - needs to be abstract, final or empty. 140
 Warning misc FinalParameters Parameter e should be final. 141
 Warning javadoc JavadocStyle First sentence should end with a period. 154
 Warning naming ConstantName Name 'xOffset' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 195
 Warning naming ConstantName Name 'yOffset' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 198
 Warning misc FinalParameters Parameter center should be final. 206
 Warning misc FinalParameters Parameter description should be final. 206
 Warning misc FinalParameters Parameter g2 should be final. 217
 Warning misc FinalParameters Parameter event should be final. 227
 Warning misc FinalParameters Parameter testX should be final. 292
 Warning misc FinalParameters Parameter testY should be final. 292
 Warning misc FinalParameters Parameter listener should be final. 353
 Warning misc FinalParameters Parameter eventType should be final. 353
 Warning misc FinalParameters Parameter listener should be final. 360
 Warning misc FinalParameters Parameter eventType should be final. 360
 Warning misc FinalParameters Parameter weak should be final. 360
 Warning misc FinalParameters Parameter listener should be final. 367
 Warning misc FinalParameters Parameter eventType should be final. 367
 Warning misc FinalParameters Parameter position should be final. 367
 Warning misc FinalParameters Parameter listener should be final. 374
 Warning misc FinalParameters Parameter eventType should be final. 374
 Warning misc FinalParameters Parameter position should be final. 374
 Warning misc FinalParameters Parameter weak should be final. 374
 Warning misc FinalParameters Parameter listener should be final. 382
 Warning misc FinalParameters Parameter eventType should be final. 382
 Warning misc FinalParameters Parameter trafficLightColor should be final. 396
 Warning misc FinalParameters Parameter g2 should be final. 407