FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
25 11 0 0

Files

Class Bugs
org.opentrafficsim.trafficcontrol.trafcod.Diagram 1
org.opentrafficsim.trafficcontrol.trafcod.Diagram$2 1
org.opentrafficsim.trafficcontrol.trafcod.Diagram$RouteStep 1
org.opentrafficsim.trafficcontrol.trafcod.TrafCOD 7
org.opentrafficsim.trafficcontrol.trafcod.Variable 1

org.opentrafficsim.trafficcontrol.trafcod.Diagram

Bug Category Details Line Priority
Integer is incompatible with expected argument type Short in org.opentrafficsim.trafficcontrol.trafcod.Diagram.routePoint(int, Diagram$RouteStep[]) CORRECTNESS GC_UNRELATED_TYPES 686 High

org.opentrafficsim.trafficcontrol.trafcod.Diagram$2

Bug Category Details Line Priority
Write to static field org.opentrafficsim.trafficcontrol.trafcod.Diagram.checkBoxPanel from instance method org.opentrafficsim.trafficcontrol.trafcod.Diagram$2.run() STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 810 Medium

org.opentrafficsim.trafficcontrol.trafcod.Diagram$RouteStep

Bug Category Details Line Priority
Should org.opentrafficsim.trafficcontrol.trafcod.Diagram$RouteStep be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 416-517 Medium

org.opentrafficsim.trafficcontrol.trafcod.TrafCOD

Bug Category Details Line Priority
Found reliance on default encoding in org.opentrafficsim.trafficcontrol.trafcod.TrafCOD.makeDisplay(URL, Set): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 499 High
Found reliance on default encoding in org.opentrafficsim.trafficcontrol.trafcod.TrafCOD.parseTrafCODRules(URL, Set, Set): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 232 High
org.opentrafficsim.trafficcontrol.trafcod.TrafCOD.evalRule(Object[]) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 856 Medium
org.opentrafficsim.trafficcontrol.trafcod.TrafCOD.parse(String, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 1496 Medium
Dereference of the result of readLine() without nullcheck in org.opentrafficsim.trafficcontrol.trafcod.TrafCOD.parseTrafCODRules(URL, Set, Set) STYLE NP_DEREFERENCE_OF_READLINE_VALUE 316 Medium
v could be null and is guaranteed to be dereferenced in org.opentrafficsim.trafficcontrol.trafcod.TrafCOD.notify(EventInterface) CORRECTNESS NP_GUARANTEED_DEREF 1826 High
org.opentrafficsim.trafficcontrol.trafcod.TrafCOD.makeDisplay(URL, Set) may fail to close stream BAD_PRACTICE OS_OPEN_STREAM 499 Medium

org.opentrafficsim.trafficcontrol.trafcod.Variable

Bug Category Details Line Priority
Unused field: org.opentrafficsim.trafficcontrol.trafcod.Variable.listPos PERFORMANCE UUF_UNUSED_FIELD Not available Medium