The following document contains the results of Checkstyle 6.2 with development/dsol-checks.xml ruleset.
Category | Rule | Violations | Severity |
---|---|---|---|
blocks | EmptyBlock | 6 | ![]() |
LeftCurly
|
30 | ![]() | |
RightCurly
|
6 | ![]() | |
coding | HiddenField
|
2 | ![]() |
design | DesignForExtension | 21 | ![]() |
VisibilityModifier | 9 | ![]() | |
imports | UnusedImports | 5 | ![]() |
javadoc | JavadocPackage | 3 | ![]() |
misc | FinalParameters | 7 | ![]() |
sizes | LineLength
|
8 | ![]() |
MethodLength | 5 | ![]() | |
ParameterNumber | 5 | ![]() | |
whitespace | FileTabCharacter | 1 | ![]() |
ParenPad | 2 | ![]() |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
design | VisibilityModifier | Variable 'sampler' must be private and have accessor methods. | 113 |
![]() |
design | DesignForExtension | Method 'getReplication' is not designed for extension - needs to be abstract, final or empty. | 150 |
![]() |
design | DesignForExtension | Method 'getAnticipationStrategy' is not designed for extension - needs to be abstract, final or empty. | 158 |
![]() |
design | DesignForExtension | Method 'getReactionTime' is not designed for extension - needs to be abstract, final or empty. | 166 |
![]() |
design | DesignForExtension | Method 'getAnticipationTime' is not designed for extension - needs to be abstract, final or empty. | 174 |
![]() |
design | DesignForExtension | Method 'getTruckFraction' is not designed for extension - needs to be abstract, final or empty. | 182 |
![]() |
design | DesignForExtension | Method 'getDistanceError' is not designed for extension - needs to be abstract, final or empty. | 190 |
![]() |
design | DesignForExtension | Method 'getSpeedError' is not designed for extension - needs to be abstract, final or empty. | 198 |
![]() |
design | DesignForExtension | Method 'getAccelerationError' is not designed for extension - needs to be abstract, final or empty. | 206 |
![]() |
design | DesignForExtension | Method 'getLeftDemand' is not designed for extension - needs to be abstract, final or empty. | 214 |
![]() |
design | DesignForExtension | Method 'getRightDemand' is not designed for extension - needs to be abstract, final or empty. | 222 |
![]() |
design | DesignForExtension | Method 'getLeftFraction' is not designed for extension - needs to be abstract, final or empty. | 230 |
![]() |
sizes | MethodLength | Method length is 302 lines (max allowed is 150). | 240 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | ParameterNumber | More than 7 parameters (found 14). | 310 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
design | DesignForExtension | Method 'canPlace' is not designed for extension - needs to be abstract, final or empty. | 32 |
![]() |
misc | FinalParameters | Parameter leaderSpeed should be final. | 33 |
![]() |
misc | FinalParameters | Parameter headway should be final. | 33 |
![]() |
misc | FinalParameters | Parameter laneBasedGTUCharacteristics should be final. | 34 |
![]() |
sizes | LineLength | Line is longer than 128 characters (found 131). | 56 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | MethodLength | Method length is 165 lines (max allowed is 150). | 372 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | MethodLength | Method length is 242 lines (max allowed is 150). | 421 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | LineLength | Line is longer than 128 characters (found 131). | 386 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
design | VisibilityModifier | Variable 'rectangle' must be private and have accessor methods. | 85 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
design | DesignForExtension | Method 'shortName' is not designed for extension - needs to be abstract, final or empty. | 104 |
![]() |
design | DesignForExtension | Method 'description' is not designed for extension - needs to be abstract, final or empty. | 111 |
![]() |
design | DesignForExtension | Method 'makeModel' is not designed for extension - needs to be abstract, final or empty. | 127 |
![]() |
design | DesignForExtension | Method 'getSimulator' is not designed for extension - needs to be abstract, final or empty. | 136 |
![]() |
design | DesignForExtension | Method 'setSimulator' is not designed for extension - needs to be abstract, final or empty. | 144 |
![]() |
sizes | ParameterNumber | More than 7 parameters (found 12). | 373 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | LineLength | Line is longer than 128 characters (found 129). | 441 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | LineLength | Line is longer than 128 characters (found 129). | 464 |
![]() |
blocks | EmptyBlock | Must have at least one statement. | 536 |
![]() |
coding | HiddenField | 'headway' hides a field. | 816 |
![]() |
sizes | LineLength | Line is longer than 128 characters (found 131). | 822 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | LineLength | Line is longer than 128 characters (found 129). | 290 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
design | VisibilityModifier | Variable 'headwayGenerator' must be private and have accessor methods. | 246 |
![]() |
design | VisibilityModifier | Variable 'gtuType' must be private and have accessor methods. | 255 |
![]() |
design | VisibilityModifier | Variable 'laneChangeModel' must be private and have accessor methods. | 264 |
![]() |
blocks | EmptyBlock | Must have at least one statement. | 298 |
![]() |
sizes | MethodLength | Method length is 349 lines (max allowed is 150). | 333 |
![]() |
sizes | ParameterNumber | More than 7 parameters (found 8). | 793 |
![]() |
sizes | LineLength | Line is longer than 128 characters (found 132). | 827 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
design | VisibilityModifier | Variable 'headwayGenerator' must be private and have accessor methods. | 250 |
![]() |
design | VisibilityModifier | Variable 'gtuType' must be private and have accessor methods. | 259 |
![]() |
design | VisibilityModifier | Variable 'laneChangeModel' must be private and have accessor methods. | 268 |
![]() |
blocks | EmptyBlock | Must have at least one statement. | 302 |
![]() |
sizes | MethodLength | Method length is 352 lines (max allowed is 150). | 337 |
![]() |
sizes | ParameterNumber | More than 7 parameters (found 8). | 803 |
![]() |
sizes | LineLength | Line is longer than 128 characters (found 132). | 837 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
design | DesignForExtension | Method 'draw' is not designed for extension - needs to be abstract, final or empty. | 458 |
![]() |
design | DesignForExtension | Method 'getSimulator' is not designed for extension - needs to be abstract, final or empty. | 532 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocPackage | Missing package-info.java file. | |
![]() |
imports | UnusedImports | Unused import - org.djunits.unit.SpeedUnit. | 33 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 92 |
![]() |
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 94 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 105 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 108 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 109 |
![]() |
blocks | RightCurly | '}' should be alone on a line. | 114 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 114 |
![]() |
design | VisibilityModifier | Variable 'trafCOD' must be private and have accessor methods. | 125 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 129 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 135 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 142 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 151 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 157 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 163 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 170 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 180 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 181 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 212 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 213 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 216 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 217 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 232 |
![]() |
whitespace | ParenPad | ')' is preceded with whitespace. | 233 |
![]() |
whitespace | ParenPad | ')' is preceded with whitespace. | 234 |
![]() |
blocks | RightCurly | '}' should be alone on a line. | 291 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 291 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 298 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 304 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 310 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 313 |
![]() |
blocks | RightCurly | '}' should be alone on a line. | 317 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 317 |
![]() |
blocks | RightCurly | '}' should be alone on a line. | 320 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 320 |
![]() |
blocks | RightCurly | '}' should be alone on a line. | 322 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 322 |
![]() |
blocks | RightCurly | '}' should be alone on a line. | 324 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 324 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 327 |
![]() |
misc | FinalParameters | Parameter theSimulator should be final. | 356 |
![]() |
misc | FinalParameters | Parameter gtuColorer should be final. | 356 |
![]() |
blocks | LeftCurly | '{' should be on a new line. | 357 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocPackage | Missing package-info.java file. |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
blocks | EmptyBlock | Must have at least one statement. | 200 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocPackage | Missing package-info.java file. | |
![]() |
imports | UnusedImports | Unused import - org.djunits.unit.FrequencyUnit. | 14 |
![]() |
imports | UnusedImports | Unused import - org.djunits.value.vdouble.scalar.DoubleScalar. | 16 |
![]() |
blocks | EmptyBlock | Must have at least one statement. | 473 |
![]() |
blocks | EmptyBlock | Must have at least one statement. | 541 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
imports | UnusedImports | Unused import - org.djunits.unit.TimeUnit. | 7 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
misc | FinalParameters | Parameter low should be final. | 273 |
![]() |
misc | FinalParameters | Parameter high should be final. | 273 |
![]() |
coding | HiddenField | 'network' hides a field. | 278 |
![]() |
sizes | ParameterNumber | More than 7 parameters (found 8). | 370 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
design | DesignForExtension | Method 'stop' is not designed for extension - needs to be abstract, final or empty. | 97 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
design | DesignForExtension | Method 'stop' is not designed for extension - needs to be abstract, final or empty. | 127 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
imports | UnusedImports | Unused import - org.opentrafficsim.road.network.lane.object.sensor.SinkSensor. | 32 |