PMD Results

The following document contains the results of PMD 5.3.5.

Files

org/opentrafficsim/graphs/ContourPlot.java

Violation Line
Avoid empty catch blocks 201–204

org/opentrafficsim/graphs/DataSampler.java

Violation Line
Avoid empty if statements 71–73

org/opentrafficsim/graphs/TrajectoryPlot.java

Violation Line
Avoid empty catch blocks 255–258

org/opentrafficsim/road/gtu/generator/AbstractGTUGenerator.java

Violation Line
Useless parentheses. 262
Useless parentheses. 262
Useless parentheses. 263
Useless parentheses. 263
These nested if statements could be combined 331–351
These nested if statements could be combined 391–411

org/opentrafficsim/road/gtu/generator/LaneBasedGTUGenerator.java

Violation Line
Avoid unused constructor parameters such as 'network'. 113
Avoid modifiers which are implied by the context 360–361

org/opentrafficsim/road/gtu/generator/ListGTUGenerator.java

Violation Line
Avoid unused constructor parameters such as 'position'. 102
Avoid unused constructor parameters such as 'direction'. 102

org/opentrafficsim/road/gtu/generator/SpaceChecker.java

Violation Line
Avoid modifiers which are implied by the context 24

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU.java

Violation Line
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 801
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 817
Avoid empty catch blocks 1029–1032
Avoid empty catch blocks 1044–1047

org/opentrafficsim/road/gtu/lane/LaneBasedGTUCharacteristics.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.core.network.route.RouteGenerator' 8

org/opentrafficsim/road/gtu/lane/LaneBasedTemplateGTUType.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.simulationengine.SimpleSimulator' 18

org/opentrafficsim/road/gtu/lane/perception/LaneStructure.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.road.gtu.lane.Break' 23
Useless parentheses. 247
Useless parentheses. 248
Useless parentheses. 314
Useless parentheses. 315
Useless parentheses. 382
Useless parentheses. 383
Useless parentheses. 412
Useless parentheses. 413
Useless parentheses. 438
Useless parentheses. 438
Useless parentheses. 455
Useless parentheses. 456
Useless parentheses. 484
Useless parentheses. 485

org/opentrafficsim/road/gtu/lane/perception/LaneStructureRecord.java

Violation Line
Useless parentheses. 286–287
Useless parentheses. 286
Useless parentheses. 287

org/opentrafficsim/road/gtu/lane/perception/categories/DelayedNeighborsPerception.java

Violation Line
Avoid empty catch blocks 290–293
Avoid unused method parameters such as 'egoSpeed'. 364

org/opentrafficsim/road/gtu/lane/perception/categories/DirectDefaultSimplePerception.java

Violation Line
These nested if statements could be combined 741–744
These nested if statements could be combined 873–890
Useless parentheses. 942
Useless parentheses. 942
Useless parentheses. 943
Useless parentheses. 943

org/opentrafficsim/road/gtu/lane/perception/categories/DirectInfrastructurePerception.java

Violation Line
Useless parentheses. 298
Useless parentheses. 298
Useless parentheses. 301
Useless parentheses. 301
Useless parentheses. 311
Useless parentheses. 311

org/opentrafficsim/road/gtu/lane/perception/categories/DirectIntersectionPerception.java

Violation Line
Useless parentheses. 225–226

org/opentrafficsim/road/gtu/lane/perception/categories/DirectNeighborsPerception.java

Violation Line
These nested if statements could be combined 379–382
Useless parentheses. 611–612
Useless parentheses. 613–614
Avoid unused private methods such as 'forwardHeadway(Length)'. 678
Avoid unused private methods such as 'backwardHeadway(Length)'. 796
These nested if statements could be combined 855–872

org/opentrafficsim/road/gtu/lane/perception/headway/HeadwayStopLine.java

Violation Line
Overriding method merely calls super 35–38

org/opentrafficsim/road/gtu/lane/plan/operational/LaneBasedOperationalPlan.java

Violation Line
Avoid unused imports such as 'org.djunits.value.vdouble.scalar.Length' 7

org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java

Violation Line
Avoid unused local variables such as 'fromFirst'. 414
Avoid unused local variables such as 'toFirst'. 415
Avoid unused local variables such as 't'. 426

org/opentrafficsim/road/gtu/lane/tactical/AbstractLaneBasedTacticalPlanner.java

Violation Line
Useless parentheses. 309
Useless parentheses. 310
Do not use if statements that are always true or always false 669
Useless parentheses. 722
Useless parentheses. 723

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCFLCTacticalPlanner.java

Violation Line
Avoid unused local variables such as 'maximumReverseHeadway'. 127
Avoid unused local variables such as 'now'. 128
Avoid unused local variables such as 'currentLaneFine'. 150

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedGTUFollowingDirectedChangeTacticalPlanner.java

Violation Line
Useless parentheses. 221
These nested if statements could be combined 223–230
Useless parentheses. 251
Useless parentheses. 253–254
Avoid unused method parameters such as 'lanePathInfo'. 492
Useless parentheses. 615

org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationBusStop.java

Violation Line
These nested if statements could be combined 69–78

org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveCourtesy.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.road.gtu.lane.tactical.util.lmrs.LmrsUtil' 16

org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveGetInLane.java

Violation Line
These nested if statements could be combined 61–82
Useless parentheses. 62–63
These nested if statements could be combined 86–105
Useless parentheses. 87–88

org/opentrafficsim/road/gtu/lane/tactical/lmrs/LMRS.java

Violation Line
These nested if statements could be combined 170–174

org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java

Violation Line
Useless parentheses. 155
Useless parentheses. 156–159

org/opentrafficsim/road/gtu/lane/tactical/util/AnticipationInfo.java

Violation Line
Avoid unused imports such as 'org.djunits.unit.SpeedUnit' 6

org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java

Violation Line
Avoid unused imports such as 'java.util.HashSet' 9
Avoid unused imports such as 'java.util.Iterator' 10
Avoid unused imports such as 'java.util.Map' 12
Avoid unused imports such as 'java.util.Set' 13
These nested if statements could be combined 428–444

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsUtil.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.road.gtu.lane.Break' 24
Useless parentheses. 451
These nested if statements could be combined 451–456
Useless parentheses. 452–453

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Synchronization.java

Violation Line
Useless parentheses. 89
Useless parentheses. 90
Useless parentheses. 181
Useless parentheses. 224–225
Useless parentheses. 344
Useless parentheses. 345
Useless parentheses. 586–589
Useless parentheses. 590

org/opentrafficsim/road/gtu/strategical/LaneBasedStrategicalPlannerFactory.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.core.gtu.behavioralcharacteristics.BehavioralCharacteristics' 4

org/opentrafficsim/road/gtu/strategical/od/ODMatrix.java

Violation Line
Avoid unused local variables such as 'e'. 510

org/opentrafficsim/road/gtu/strategical/route/LaneBasedStrategicalRoutePlanner.java

Violation Line
Useless parentheses. 162
Useless parentheses. 163
Useless parentheses. 177
Useless parentheses. 178

org/opentrafficsim/road/network/lane/CrossSectionElement.java

Violation Line
Avoid unused constructor parameters such as 'newSimulator'. 169
Avoid unused constructor parameters such as 'animation'. 170

org/opentrafficsim/road/network/lane/Lane.java

Violation Line
Useless parentheses. 491
Useless parentheses. 494
Useless parentheses. 505
Useless parentheses. 507
These nested if statements could be combined 510–514
These nested if statements could be combined 547–551
Useless parentheses. 655
Useless parentheses. 1372
Useless parentheses. 1373
Useless parentheses. 1409
Useless parentheses. 1410

org/opentrafficsim/road/network/lane/NoTrafficLane.java

Violation Line
Avoid unused imports such as 'org.djunits.unit.SpeedUnit' 7

org/opentrafficsim/road/network/lane/changing/OvertakingConditions.java

Violation Line
Avoid modifiers which are implied by the context 66–83
Avoid modifiers which are implied by the context 97–114
Avoid modifiers which are implied by the context 126–143
Avoid modifiers which are implied by the context 155–172
Avoid modifiers which are implied by the context 184–201
Avoid modifiers which are implied by the context 213–230
Avoid modifiers which are implied by the context 242–259
Avoid modifiers which are implied by the context 271–301
Avoid modifiers which are implied by the context 313–343
Avoid modifiers which are implied by the context 360–405
Useless parentheses. 391–392
Avoid modifiers which are implied by the context 422–467
Useless parentheses. 453–454
Avoid modifiers which are implied by the context 484–539
Useless parentheses. 522–523
Useless parentheses. 522–523
Avoid modifiers which are implied by the context 556–611
Useless parentheses. 594–595
Useless parentheses. 594–595

org/opentrafficsim/road/network/lane/conflict/Conflict.java

Violation Line
Useless parentheses. 117

org/opentrafficsim/road/network/lane/conflict/ConflictBuilder.java

Violation Line
Useless parentheses. 392
Useless parentheses. 393
Useless parentheses. 525
Useless parentheses. 525
Useless parentheses. 533
Useless parentheses. 533

org/opentrafficsim/road/network/lane/object/AbstractLaneBasedObject.java

Violation Line
Avoid unused imports such as 'org.opentrafficsim.core.gtu.GTUDirectionality' 6

org/opentrafficsim/road/network/lane/object/sensor/SinkSensor.java

Violation Line
Avoid unused constructor parameters such as 'dummy2'. 63
Avoid unused constructor parameters such as 'dummy1'. 63