Checkstyle Results

The following document contains the results of Checkstyle 6.2 with development/dsol-checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
9 7 172 0

Files

File  I  W  E
ccol/CCOL.java 0 16 0
org/opentrafficsim/trafficcontrol/TrafficController.java 2 10 0
org/opentrafficsim/trafficcontrol/trafcod/Diagram.java 0 39 0
org/opentrafficsim/trafficcontrol/trafcod/TrafCOD.java 5 68 0
org/opentrafficsim/trafficcontrol/trafcod/TrafCODDisplay.java 0 39 0

Rules

Category Rule Violations Severity
coding HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
 1  Warning
InnerAssignment 1  Warning
MissingSwitchDefault 2  Warning
design DesignForExtension 22  Warning
VisibilityModifier 28  Warning
javadoc JavadocMethod 1  Warning
JavadocStyle
  • checkHtml: "false"
 5  Warning
misc FinalParameters 61  Warning
modifier ModifierOrder 35  Warning
RedundantModifier 9  Warning
naming ConstantName 2  Warning
StaticVariableName 3  Warning
sizes FileLength 1  Warning
LineLength
  • max: "128"
 5  Info
MethodLength 2  Info
whitespace WhitespaceAfter 1  Warning

Details

ccol/CCOL.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'id' must be private and have accessor methods. 49
 Warning design VisibilityModifier Variable 'simulator' must be private and have accessor methods. 52
 Warning naming StaticVariableName Name 'PORT' must match pattern '^[a-z][a-zA-Z0-9]*$'. 55
 Warning design VisibilityModifier Variable 'PORT' must be private and have accessor methods. 55
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 58
 Warning design VisibilityModifier Variable 'serverSocket' must be private and have accessor methods. 61
 Warning design VisibilityModifier Variable 'acceptThread' must be private and have accessor methods. 73
 Warning design DesignForExtension Method 'setClientSocket' is not designed for extension - needs to be abstract, final or empty. 129
 Warning design DesignForExtension Method 'getClientSocket' is not designed for extension - needs to be abstract, final or empty. 161
 Warning design DesignForExtension Method 'notify' is not designed for extension - needs to be abstract, final or empty. 192
 Warning misc FinalParameters Parameter event should be final. 193
 Warning design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 227
 Warning design DesignForExtension Method 'updateDetector' is not designed for extension - needs to be abstract, final or empty. 234
 Warning design DesignForExtension Method 'clone' is not designed for extension - needs to be abstract, final or empty. 243
 Warning misc FinalParameters Parameter newSimulator should be final. 244
 Warning misc FinalParameters Parameter newNetwork should be final. 244

org/opentrafficsim/trafficcontrol/TrafficController.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 26
 Warning modifier RedundantModifier Redundant 'public' modifier. 33
 Warning modifier RedundantModifier Redundant 'final' modifier. 36
 Warning modifier RedundantModifier Redundant 'final' modifier. 39
 Warning modifier RedundantModifier Redundant 'final' modifier. 42
 Warning modifier RedundantModifier Redundant 'final' modifier. 45
 Warning modifier RedundantModifier Redundant 'final' modifier. 48
 Warning modifier RedundantModifier Redundant 'public' modifier. 51
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 51
 Warning modifier RedundantModifier Redundant 'public' modifier. 83
 Info sizes LineLength Line is longer than 128 characters (found 130). 87
 Info sizes LineLength Line is longer than 128 characters (found 133). 95

org/opentrafficsim/trafficcontrol/trafcod/Diagram.java

Severity Category Rule Message Line
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 49
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 52
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 55
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 58
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 61
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 64
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 67
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 70
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 73
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 76
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 79
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 82
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 85
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 88
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 91
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 94
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 97
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 100
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 103
 Warning design VisibilityModifier Variable 'streams' must be private and have accessor methods. 106
 Warning design VisibilityModifier Variable 'routes' must be private and have accessor methods. 109
 Warning misc FinalParameters Parameter o1 should be final. 123
 Warning misc FinalParameters Parameter o2 should be final. 123
 Warning whitespace WhitespaceAfter ',' is not followed by whitespace. 142
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 279
 Warning javadoc JavadocStyle First sentence should end with a period. 311
 Warning coding MissingSwitchDefault switch without "default" clause. 334
 Warning coding MissingSwitchDefault switch without "default" clause. 356
 Warning modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 399
 Warning modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 402
 Warning modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 405
 Warning modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 408
 Warning javadoc JavadocStyle First sentence should end with a period. 627
 Warning misc FinalParameters Parameter steps should be final. 633
 Warning coding InnerAssignment Inner assignments should be avoided. 637
 Warning design DesignForExtension Method 'render' is not designed for extension - needs to be abstract, final or empty. 714
 Warning misc FinalParameters Parameter e should be final. 862
 Warning design VisibilityModifier Variable 'testPanel' must be private and have accessor methods. 871
 Warning design VisibilityModifier Variable 'checkBoxPanel' must be private and have accessor methods. 874

org/opentrafficsim/trafficcontrol/trafcod/TrafCOD.java

Severity Category Rule Message Line
 Warning sizes FileLength File length is 2,826 lines (max allowed is 2,000). 1
 Warning design VisibilityModifier Variable 'controllerName' must be private and have accessor methods. 65
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 68
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 71
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 74
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 77
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 80
 Warning design VisibilityModifier Variable 'trafcodRules' must be private and have accessor methods. 83
 Warning design VisibilityModifier Variable 'tokenisedRules' must be private and have accessor methods. 86
 Warning design VisibilityModifier Variable 'variables' must be private and have accessor methods. 89
 Warning design VisibilityModifier Variable 'variablesInDefinitionOrder' must be private and have accessor methods. 92
 Warning design VisibilityModifier Variable 'detectors' must be private and have accessor methods. 95
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 98
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 101
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 104
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 107
 Warning design VisibilityModifier Variable 'numberOfConflictGroups' must be private and have accessor methods. 110
 Warning javadoc JavadocStyle First sentence should end with a period. 133
 Warning misc FinalParameters Parameter controllerName should be final. 155
 Warning misc FinalParameters Parameter display should be final. 157
 Warning misc FinalParameters Parameter controllerName should be final. 230
 Warning misc FinalParameters Parameter display should be final. 230
 Info sizes MethodLength Method length is 219 lines (max allowed is 150). 248
 Info sizes LineLength Line is longer than 128 characters (found 129). 408
 Info sizes LineLength Line is longer than 128 characters (found 129). 413
 Warning design DesignForExtension Method 'checkConsistency' is not designed for extension - needs to be abstract, final or empty. 473
 Warning misc FinalParameters Parameter sensors should be final. 512
 Warning naming StaticVariableName Name 'BIND_UNARY_MINUS' must match pattern '^[a-z][a-zA-Z0-9]*$'. 910
 Warning misc FinalParameters Parameter tokens should be final. 1166
 Info sizes MethodLength Method length is 271 lines (max allowed is 150). 1377
 Warning misc FinalParameters Parameter name should be final. 1690
 Warning misc FinalParameters Parameter stream should be final. 1690
 Warning misc FinalParameters Parameter flags should be final. 1690
 Warning misc FinalParameters Parameter location should be final. 1690
 Warning design DesignForExtension Method 'getSimulator' is not designed for extension - needs to be abstract, final or empty. 1728
 Warning design DesignForExtension Method 'getStructureNumber' is not designed for extension - needs to be abstract, final or empty. 1737
 Warning design DesignForExtension Method 'updateDetector' is not designed for extension - needs to be abstract, final or empty. 1743
 Warning misc FinalParameters Parameter detectorId should be final. 1744
 Warning misc FinalParameters Parameter detectingGTU should be final. 1744
 Warning design DesignForExtension Method 'traceVariablesOfStream' is not designed for extension - needs to be abstract, final or empty. 1761
 Warning design DesignForExtension Method 'traceVariable' is not designed for extension - needs to be abstract, final or empty. 1786
 Warning design DesignForExtension Method 'notify' is not designed for extension - needs to be abstract, final or empty. 1805
 Warning misc FinalParameters Parameter event should be final. 1806
 Warning design DesignForExtension Method 'fireTrafCODEvent' is not designed for extension - needs to be abstract, final or empty. 1876
 Warning design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 1889
 Warning design VisibilityModifier Variable 'flags' must be private and have accessor methods. 2100
 Warning design VisibilityModifier Variable 'value' must be private and have accessor methods. 2103
 Warning design VisibilityModifier Variable 'timerMax10' must be private and have accessor methods. 2106
 Warning design VisibilityModifier Variable 'color' must be private and have accessor methods. 2109
 Warning design VisibilityModifier Variable 'name' must be private and have accessor methods. 2112
 Warning javadoc JavadocStyle First sentence should end with a period. 2114
 Warning design VisibilityModifier Variable 'stream' must be private and have accessor methods. 2115
 Warning design VisibilityModifier Variable 'refCount' must be private and have accessor methods. 2118
 Warning design VisibilityModifier Variable 'updateTime10' must be private and have accessor methods. 2121
 Warning design VisibilityModifier Variable 'startSource' must be private and have accessor methods. 2124
 Warning design VisibilityModifier Variable 'endSource' must be private and have accessor methods. 2127
 Warning naming StaticVariableName Name 'ROWLETTERS' must match pattern '^[a-z][a-zA-Z0-9]*$'. 2133
 Warning misc FinalParameters Parameter trafCOD should be final. 2172
 Warning misc FinalParameters Parameter sensor should be final. 2206
 Warning misc FinalParameters Parameter newValue should be final. 2328
 Warning misc FinalParameters Parameter timeStamp10 should be final. 2328
 Warning misc FinalParameters Parameter cause should be final. 2328
 Warning misc FinalParameters Parameter trafCOD should be final. 2328
 Warning coding HiddenField 'trafCOD' hides a field. 2328
 Info sizes LineLength Line is longer than 128 characters (found 147). 2386
 Warning misc FinalParameters Parameter colorValue should be final. 2481
 Warning misc FinalParameters Parameter value10 should be final. 2530
 Warning misc FinalParameters Parameter startSource should be final. 2554
 Warning misc FinalParameters Parameter endSource should be final. 2578
 Warning misc FinalParameters Parameter printFlags should be final. 2609
 Warning misc FinalParameters Parameter event should be final. 2718
 Warning design VisibilityModifier Variable 'cause' must be private and have accessor methods. 2739
 Warning javadoc JavadocMethod Missing a Javadoc comment. 2750

org/opentrafficsim/trafficcontrol/trafcod/TrafCODDisplay.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'defaultInitialDelay' must be private and have accessor methods. 54
 Warning design DesignForExtension Method 'paintComponent' is not designed for extension - needs to be abstract, final or empty. 68
 Warning design DesignForExtension Method 'addTrafCODObject' is not designed for extension - needs to be abstract, final or empty. 83
 Warning design DesignForExtension Method 'mouseDragged' is not designed for extension - needs to be abstract, final or empty. 89
 Warning misc FinalParameters Parameter e should be final. 90
 Warning design DesignForExtension Method 'mouseMoved' is not designed for extension - needs to be abstract, final or empty. 96
 Warning misc FinalParameters Parameter e should be final. 97
 Warning misc FinalParameters Parameter e should be final. 114
 Warning misc FinalParameters Parameter e should be final. 121
 Warning misc FinalParameters Parameter e should be final. 128
 Warning design DesignForExtension Method 'mouseEntered' is not designed for extension - needs to be abstract, final or empty. 134
 Warning misc FinalParameters Parameter e should be final. 135
 Warning design DesignForExtension Method 'mouseExited' is not designed for extension - needs to be abstract, final or empty. 141
 Warning misc FinalParameters Parameter e should be final. 142
 Warning javadoc JavadocStyle First sentence should end with a period. 155
 Warning naming ConstantName Name 'xOffset' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 196
 Warning naming ConstantName Name 'yOffset' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 199
 Warning misc FinalParameters Parameter center should be final. 207
 Warning misc FinalParameters Parameter description should be final. 207
 Warning misc FinalParameters Parameter g2 should be final. 218
 Warning misc FinalParameters Parameter event should be final. 228
 Warning misc FinalParameters Parameter testX should be final. 293
 Warning misc FinalParameters Parameter testY should be final. 293
 Warning misc FinalParameters Parameter listener should be final. 361
 Warning misc FinalParameters Parameter eventType should be final. 361
 Warning misc FinalParameters Parameter listener should be final. 368
 Warning misc FinalParameters Parameter eventType should be final. 368
 Warning misc FinalParameters Parameter weak should be final. 368
 Warning misc FinalParameters Parameter listener should be final. 375
 Warning misc FinalParameters Parameter eventType should be final. 375
 Warning misc FinalParameters Parameter position should be final. 375
 Warning misc FinalParameters Parameter listener should be final. 382
 Warning misc FinalParameters Parameter eventType should be final. 382
 Warning misc FinalParameters Parameter position should be final. 382
 Warning misc FinalParameters Parameter weak should be final. 382
 Warning misc FinalParameters Parameter listener should be final. 390
 Warning misc FinalParameters Parameter eventType should be final. 390
 Warning misc FinalParameters Parameter trafficLightColor should be final. 404
 Warning misc FinalParameters Parameter g2 should be final. 415