FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
91 14 0 0

org.opentrafficsim.road.network.factory.vissim.FillTag

Bug Category Details Line Priority
Dead store to rg in org.opentrafficsim.road.network.factory.vissim.FillTag.makeFill(FillTag, VissimNetworkLaneParser, LinkTag, DEVSSimulatorInterface$TimeDoubleUnit) STYLE DLS_DEAD_LOCAL_STORE 254 High
Dead store to lane in org.opentrafficsim.road.network.factory.vissim.FillTag.makeFill(FillTag, VissimNetworkLaneParser, LinkTag, DEVSSimulatorInterface$TimeDoubleUnit) STYLE DLS_DEAD_LOCAL_STORE 247 Medium
Dead store of org.opentrafficsim.road.gtu.lane.LaneBasedIndividualGTU.class in org.opentrafficsim.road.network.factory.vissim.FillTag.makeFill(FillTag, VissimNetworkLaneParser, LinkTag, DEVSSimulatorInterface$TimeDoubleUnit) CORRECTNESS DLS_DEAD_STORE_OF_CLASS_LITERAL 248 Medium

org.opentrafficsim.road.network.factory.vissim.LinkTag

Bug Category Details Line Priority
org.opentrafficsim.road.network.factory.vissim.LinkTag.parseLinkGeometry(VissimNetworkLaneParser, Node, LinkTag) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 353 Medium
Class org.opentrafficsim.road.network.factory.vissim.LinkTag defines non-transient non-serializable instance field bezierTag BAD_PRACTICE SE_BAD_FIELD Not available High
Unwritten public or protected field: org.opentrafficsim.road.network.factory.vissim.LinkTag.roadLayoutTag STYLE UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD 48 Medium

org.opentrafficsim.road.network.factory.vissim.Links

Bug Category Details Line Priority
Dead store to linkDirection in org.opentrafficsim.road.network.factory.vissim.Links.applyRoadTypeToLink(LinkTag, VissimNetworkLaneParser, DEVSSimulatorInterface$TimeDoubleUnit) STYLE DLS_DEAD_LOCAL_STORE 491 Medium
Useless object stored in variable cseList of method org.opentrafficsim.road.network.factory.vissim.Links.applyRoadTypeToConnector(LinkTag, VissimNetworkLaneParser, DEVSSimulatorInterface$TimeDoubleUnit) STYLE UC_USELESS_OBJECT 606 Medium
Useless object stored in variable lanes of method org.opentrafficsim.road.network.factory.vissim.Links.applyRoadTypeToConnector(LinkTag, VissimNetworkLaneParser, DEVSSimulatorInterface$TimeDoubleUnit) STYLE UC_USELESS_OBJECT 607 Medium
Useless object stored in variable cseList of method org.opentrafficsim.road.network.factory.vissim.Links.applyRoadTypeToLink(LinkTag, VissimNetworkLaneParser, DEVSSimulatorInterface$TimeDoubleUnit) STYLE UC_USELESS_OBJECT 488 Medium
Useless object stored in variable lanes of method org.opentrafficsim.road.network.factory.vissim.Links.applyRoadTypeToLink(LinkTag, VissimNetworkLaneParser, DEVSSimulatorInterface$TimeDoubleUnit) STYLE UC_USELESS_OBJECT 489 Medium

org.opentrafficsim.road.network.factory.vissim.ListGeneratorTag

Bug Category Details Line Priority
Unwritten field: org.opentrafficsim.road.network.factory.vissim.ListGeneratorTag.gtuColorer CORRECTNESS UWF_UNWRITTEN_FIELD 169 Medium

org.opentrafficsim.road.network.factory.vissim.SinkTag

Bug Category Details Line Priority

org.opentrafficsim.road.network.factory.vissim.TestVissimParser$VissimImport

Bug Category Details Line Priority
Null passed for non-null parameter of VissimNetworkLaneParser.build(URL, File, OTSNetwork, String, String, String) in org.opentrafficsim.road.network.factory.vissim.TestVissimParser$VissimImport.constructModel(SimulatorInterface) CORRECTNESS NP_NULL_PARAM_DEREF 189 Medium
Should org.opentrafficsim.road.network.factory.vissim.TestVissimParser$VissimImport be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 129-233 Medium