Checkstyle Results

The following document contains the results of Checkstyle 6.18 with development/dsol-checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
6 3 185 0

Files

File  I  W  E
org/opentrafficsim/trafficcontrol/TrafficController.java 0 10 0
org/opentrafficsim/trafficcontrol/ccol/CCOL.java 1 17 0
org/opentrafficsim/trafficcontrol/trafcod/Diagram.java 0 46 0
org/opentrafficsim/trafficcontrol/trafcod/TrafCOD.java 2 71 0
org/opentrafficsim/trafficcontrol/trafcod/TrafCODDisplay.java 0 41 0

Rules

Category Rule Violations Severity
coding HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
 1  Warning
InnerAssignment 1  Warning
MissingSwitchDefault 2  Warning
design DesignForExtension 24  Warning
VisibilityModifier 28  Warning
javadoc JavadocStyle
  • checkHtml: "false"
 5  Warning
misc FinalParameters 61  Warning
modifier ModifierOrder 35  Warning
RedundantModifier 21  Warning
naming ConstantName 2  Warning
StaticVariableName 3  Warning
sizes FileLength 1  Warning
LineLength
  • max: "128"
 1  Info
MethodLength 2  Info
whitespace WhitespaceAfter 1  Warning

Details

org/opentrafficsim/trafficcontrol/TrafficController.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 27
 Warning modifier RedundantModifier Redundant 'public' modifier. 34
 Warning modifier RedundantModifier Redundant 'final' modifier. 37
 Warning modifier RedundantModifier Redundant 'final' modifier. 40
 Warning modifier RedundantModifier Redundant 'final' modifier. 43
 Warning modifier RedundantModifier Redundant 'final' modifier. 46
 Warning modifier RedundantModifier Redundant 'final' modifier. 49
 Warning modifier RedundantModifier Redundant 'public' modifier. 52
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 52
 Warning modifier RedundantModifier Redundant 'public' modifier. 84

org/opentrafficsim/trafficcontrol/ccol/CCOL.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'id' must be private and have accessor methods. 48
 Warning design VisibilityModifier Variable 'simulator' must be private and have accessor methods. 51
 Warning naming StaticVariableName Name 'PORT' must match pattern '^[a-z][a-zA-Z0-9]*$'. 54
 Warning design VisibilityModifier Variable 'PORT' must be private and have accessor methods. 54
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 57
 Warning design VisibilityModifier Variable 'serverSocket' must be private and have accessor methods. 60
 Warning design VisibilityModifier Variable 'acceptThread' must be private and have accessor methods. 72
 Warning design DesignForExtension Method 'setClientSocket' is not designed for extension - needs to be abstract, final or empty. 128
 Warning design DesignForExtension Method 'getClientSocket' is not designed for extension - needs to be abstract, final or empty. 160
 Warning design DesignForExtension Method 'notify' is not designed for extension - needs to be abstract, final or empty. 191
 Warning misc FinalParameters Parameter event should be final. 192
 Warning design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 226
 Warning design DesignForExtension Method 'getFullId' is not designed for extension - needs to be abstract, final or empty. 233
 Warning design DesignForExtension Method 'updateDetector' is not designed for extension - needs to be abstract, final or empty. 240
 Warning design DesignForExtension Method 'clone' is not designed for extension - needs to be abstract, final or empty. 249
 Info sizes LineLength Line is longer than 128 characters (found 133). 250
 Warning misc FinalParameters Parameter newSimulator should be final. 250
 Warning misc FinalParameters Parameter newNetwork should be final. 250

org/opentrafficsim/trafficcontrol/trafcod/Diagram.java

Severity Category Rule Message Line
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 49
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 52
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 55
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 58
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 61
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 64
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 67
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 70
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 73
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 76
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 79
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 82
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 85
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 88
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 91
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 94
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 97
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 100
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 103
 Warning design VisibilityModifier Variable 'streams' must be private and have accessor methods. 106
 Warning design VisibilityModifier Variable 'routes' must be private and have accessor methods. 109
 Warning misc FinalParameters Parameter o1 should be final. 123
 Warning misc FinalParameters Parameter o2 should be final. 123
 Warning whitespace WhitespaceAfter ',' is not followed by whitespace. 142
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 279
 Warning javadoc JavadocStyle First sentence should end with a period. 311
 Warning coding MissingSwitchDefault switch without "default" clause. 334
 Warning coding MissingSwitchDefault switch without "default" clause. 356
 Warning modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 399
 Warning modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 402
 Warning modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 405
 Warning modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 408
 Warning modifier RedundantModifier Redundant 'public' modifier. 415
 Warning modifier RedundantModifier Redundant 'public' modifier. 431
 Warning modifier RedundantModifier Redundant 'public' modifier. 452
 Warning modifier RedundantModifier Redundant 'public' modifier. 469
 Warning modifier RedundantModifier Redundant 'public' modifier. 541
 Warning modifier RedundantModifier Redundant 'public' modifier. 551
 Warning modifier RedundantModifier Redundant 'public' modifier. 562
 Warning javadoc JavadocStyle First sentence should end with a period. 629
 Warning misc FinalParameters Parameter steps should be final. 635
 Warning coding InnerAssignment Inner assignments should be avoided. 639
 Warning design DesignForExtension Method 'render' is not designed for extension - needs to be abstract, final or empty. 716
 Warning misc FinalParameters Parameter e should be final. 864
 Warning design VisibilityModifier Variable 'testPanel' must be private and have accessor methods. 873
 Warning design VisibilityModifier Variable 'checkBoxPanel' must be private and have accessor methods. 876

org/opentrafficsim/trafficcontrol/trafcod/TrafCOD.java

Severity Category Rule Message Line
 Warning sizes FileLength File length is 2,822 lines (max allowed is 2,000). 1
 Warning design VisibilityModifier Variable 'controllerName' must be private and have accessor methods. 64
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 67
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 70
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 73
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 76
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 79
 Warning design VisibilityModifier Variable 'trafcodRules' must be private and have accessor methods. 82
 Warning design VisibilityModifier Variable 'tokenisedRules' must be private and have accessor methods. 85
 Warning design VisibilityModifier Variable 'variables' must be private and have accessor methods. 88
 Warning design VisibilityModifier Variable 'variablesInDefinitionOrder' must be private and have accessor methods. 91
 Warning design VisibilityModifier Variable 'detectors' must be private and have accessor methods. 94
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 97
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 100
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 103
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 106
 Warning design VisibilityModifier Variable 'numberOfConflictGroups' must be private and have accessor methods. 109
 Warning javadoc JavadocStyle First sentence should end with a period. 132
 Warning misc FinalParameters Parameter controllerName should be final. 154
 Warning misc FinalParameters Parameter display should be final. 156
 Warning misc FinalParameters Parameter controllerName should be final. 229
 Warning misc FinalParameters Parameter display should be final. 229
 Info sizes MethodLength Method length is 219 lines (max allowed is 150). 247
 Warning design DesignForExtension Method 'checkConsistency' is not designed for extension - needs to be abstract, final or empty. 472
 Warning misc FinalParameters Parameter sensors should be final. 511
 Warning naming StaticVariableName Name 'BIND_UNARY_MINUS' must match pattern '^[a-z][a-zA-Z0-9]*$'. 908
 Warning misc FinalParameters Parameter tokens should be final. 1164
 Info sizes MethodLength Method length is 269 lines (max allowed is 150). 1375
 Warning misc FinalParameters Parameter name should be final. 1686
 Warning misc FinalParameters Parameter stream should be final. 1686
 Warning misc FinalParameters Parameter flags should be final. 1686
 Warning misc FinalParameters Parameter location should be final. 1686
 Warning design DesignForExtension Method 'getSimulator' is not designed for extension - needs to be abstract, final or empty. 1724
 Warning design DesignForExtension Method 'getStructureNumber' is not designed for extension - needs to be abstract, final or empty. 1733
 Warning design DesignForExtension Method 'updateDetector' is not designed for extension - needs to be abstract, final or empty. 1739
 Warning misc FinalParameters Parameter detectorId should be final. 1740
 Warning misc FinalParameters Parameter detectingGTU should be final. 1740
 Warning design DesignForExtension Method 'traceVariablesOfStream' is not designed for extension - needs to be abstract, final or empty. 1756
 Warning design DesignForExtension Method 'traceVariable' is not designed for extension - needs to be abstract, final or empty. 1781
 Warning design DesignForExtension Method 'notify' is not designed for extension - needs to be abstract, final or empty. 1800
 Warning misc FinalParameters Parameter event should be final. 1801
 Warning design DesignForExtension Method 'fireTrafCODEvent' is not designed for extension - needs to be abstract, final or empty. 1871
 Warning design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 1877
 Warning design DesignForExtension Method 'getFullId' is not designed for extension - needs to be abstract, final or empty. 1884
 Warning modifier RedundantModifier Redundant 'public' modifier. 1969
 Warning design VisibilityModifier Variable 'flags' must be private and have accessor methods. 2095
 Warning design VisibilityModifier Variable 'value' must be private and have accessor methods. 2098
 Warning design VisibilityModifier Variable 'timerMax10' must be private and have accessor methods. 2101
 Warning design VisibilityModifier Variable 'color' must be private and have accessor methods. 2104
 Warning design VisibilityModifier Variable 'name' must be private and have accessor methods. 2107
 Warning javadoc JavadocStyle First sentence should end with a period. 2109
 Warning design VisibilityModifier Variable 'stream' must be private and have accessor methods. 2110
 Warning design VisibilityModifier Variable 'refCount' must be private and have accessor methods. 2113
 Warning design VisibilityModifier Variable 'updateTime10' must be private and have accessor methods. 2116
 Warning design VisibilityModifier Variable 'startSource' must be private and have accessor methods. 2119
 Warning design VisibilityModifier Variable 'endSource' must be private and have accessor methods. 2122
 Warning naming StaticVariableName Name 'ROWLETTERS' must match pattern '^[a-z][a-zA-Z0-9]*$'. 2128
 Warning modifier RedundantModifier Redundant 'public' modifier. 2166
 Warning misc FinalParameters Parameter trafCOD should be final. 2166
 Warning misc FinalParameters Parameter sensor should be final. 2200
 Warning misc FinalParameters Parameter newValue should be final. 2322
 Warning misc FinalParameters Parameter timeStamp10 should be final. 2322
 Warning misc FinalParameters Parameter cause should be final. 2322
 Warning misc FinalParameters Parameter trafCOD should be final. 2322
 Warning coding HiddenField 'trafCOD' hides a field. 2322
 Warning misc FinalParameters Parameter colorValue should be final. 2476
 Warning misc FinalParameters Parameter value10 should be final. 2525
 Warning misc FinalParameters Parameter startSource should be final. 2549
 Warning misc FinalParameters Parameter endSource should be final. 2573
 Warning misc FinalParameters Parameter printFlags should be final. 2604
 Warning misc FinalParameters Parameter event should be final. 2713
 Warning design VisibilityModifier Variable 'cause' must be private and have accessor methods. 2734
 Warning modifier RedundantModifier Redundant 'public' modifier. 2740

org/opentrafficsim/trafficcontrol/trafcod/TrafCODDisplay.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'defaultInitialDelay' must be private and have accessor methods. 54
 Warning design DesignForExtension Method 'paintComponent' is not designed for extension - needs to be abstract, final or empty. 68
 Warning design DesignForExtension Method 'addTrafCODObject' is not designed for extension - needs to be abstract, final or empty. 83
 Warning design DesignForExtension Method 'mouseDragged' is not designed for extension - needs to be abstract, final or empty. 89
 Warning misc FinalParameters Parameter e should be final. 90
 Warning design DesignForExtension Method 'mouseMoved' is not designed for extension - needs to be abstract, final or empty. 96
 Warning misc FinalParameters Parameter e should be final. 97
 Warning misc FinalParameters Parameter e should be final. 114
 Warning misc FinalParameters Parameter e should be final. 121
 Warning misc FinalParameters Parameter e should be final. 128
 Warning design DesignForExtension Method 'mouseEntered' is not designed for extension - needs to be abstract, final or empty. 134
 Warning misc FinalParameters Parameter e should be final. 135
 Warning design DesignForExtension Method 'mouseExited' is not designed for extension - needs to be abstract, final or empty. 141
 Warning misc FinalParameters Parameter e should be final. 142
 Warning javadoc JavadocStyle First sentence should end with a period. 155
 Warning naming ConstantName Name 'xOffset' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 196
 Warning naming ConstantName Name 'yOffset' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 199
 Warning modifier RedundantModifier Redundant 'public' modifier. 207
 Warning misc FinalParameters Parameter center should be final. 207
 Warning misc FinalParameters Parameter description should be final. 207
 Warning misc FinalParameters Parameter g2 should be final. 218
 Warning misc FinalParameters Parameter event should be final. 228
 Warning modifier RedundantModifier Redundant 'public' modifier. 282
 Warning misc FinalParameters Parameter testX should be final. 293
 Warning misc FinalParameters Parameter testY should be final. 293
 Warning misc FinalParameters Parameter listener should be final. 368
 Warning misc FinalParameters Parameter eventType should be final. 368
 Warning misc FinalParameters Parameter listener should be final. 375
 Warning misc FinalParameters Parameter eventType should be final. 375
 Warning misc FinalParameters Parameter weak should be final. 375
 Warning misc FinalParameters Parameter listener should be final. 382
 Warning misc FinalParameters Parameter eventType should be final. 382
 Warning misc FinalParameters Parameter position should be final. 382
 Warning misc FinalParameters Parameter listener should be final. 389
 Warning misc FinalParameters Parameter eventType should be final. 389
 Warning misc FinalParameters Parameter position should be final. 389
 Warning misc FinalParameters Parameter weak should be final. 389
 Warning misc FinalParameters Parameter listener should be final. 397
 Warning misc FinalParameters Parameter eventType should be final. 397
 Warning misc FinalParameters Parameter trafficLightColor should be final. 411
 Warning misc FinalParameters Parameter g2 should be final. 422