The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Invocation of toString on SchedulableMethod.args in org.opentrafficsim.water.SchedulableMethod.toString() | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 130 | High |
| org.opentrafficsim.water.SchedulableMethod.getArgs() may expose internal representation by returning SchedulableMethod.args | MALICIOUS_CODE | EI_EXPOSE_REP | 107 | Medium |
| new org.opentrafficsim.water.SchedulableMethod(Object, String, Object[]) may expose internal representation by storing an externally mutable object into SchedulableMethod.args | MALICIOUS_CODE | EI_EXPOSE_REP2 | 63 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.opentrafficsim.water.demand.OtherDemand defines non-transient non-serializable instance field otherDemandSet | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.opentrafficsim.water.demand.OtherDemand$OtherDemandCell be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 110-148 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.opentrafficsim.water.demand.Region defines compareTo(Region) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 299 | Medium |
| Write to static field org.opentrafficsim.water.demand.Region.randomStream from instance method new org.opentrafficsim.water.demand.Region(String, Region, Coordinate) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 86 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.opentrafficsim.water.demand.ShipperNameGenerator.counter from instance method org.opentrafficsim.water.demand.ShipperNameGenerator.getShipperName() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 66 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.opentrafficsim.water.demand.TransportDemand defines non-transient non-serializable instance field demandMap | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
| org.opentrafficsim.water.demand.TransportDemand.getDemandMapTo(Terminal) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 136 | Medium |
| org.opentrafficsim.water.demand.TransportDemand.getDemandSetTo(Terminal) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 165 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.opentrafficsim.water.demand.TransportDemand$DemandCell be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 218-285 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.opentrafficsim.water.network.Waterway doesn't override org.opentrafficsim.core.network.OTSLink.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 1 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.opentrafficsim.water.network.infra.Lock.estimatedAverageLockageTime | CORRECTNESS | UWF_UNWRITTEN_FIELD | 80 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.opentrafficsim.water.network.infra.MovableBridge.waitingTime | CORRECTNESS | UWF_UNWRITTEN_FIELD | 99 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.opentrafficsim.water.statistics.XFrequency.writeToExcel(Sheet, int) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 184 | Medium |