Checkstyle Results

The following document contains the results of Checkstyle 6.18 with development/dsol-checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
50 2 92 0

Files

File  I  W  E
org/opentrafficsim/kpi/interfaces/GtuDataInterface.java 1 0 0
org/opentrafficsim/kpi/sampling/KpiDirectedLanePosition.java 0 11 0
org/opentrafficsim/kpi/sampling/KpiLaneDirection.java 0 2 0
org/opentrafficsim/kpi/sampling/Sampler.java 1 7 0
org/opentrafficsim/kpi/sampling/Trajectory.java 0 6 0
org/opentrafficsim/kpi/sampling/TrajectoryGroup.java 0 1 0
org/opentrafficsim/kpi/sampling/data/ExtendedDataTypeDuration.java 0 2 0
org/opentrafficsim/kpi/sampling/data/ExtendedDataTypeFloat.java 0 2 0
org/opentrafficsim/kpi/sampling/data/ExtendedDataTypeLength.java 0 2 0
org/opentrafficsim/kpi/sampling/data/ExtendedDataTypeList.java 0 8 0
org/opentrafficsim/kpi/sampling/data/ExtendedDataTypeNumber.java 0 6 0
org/opentrafficsim/kpi/sampling/data/ExtendedDataTypeSpeed.java 0 2 0
org/opentrafficsim/kpi/sampling/indicator/ConfidenceInterval.java 0 2 0
org/opentrafficsim/kpi/sampling/indicator/MeanDensity.java 0 1 0
org/opentrafficsim/kpi/sampling/indicator/MeanIntensity.java 0 1 0
org/opentrafficsim/kpi/sampling/indicator/MeanSpeed.java 0 1 0
org/opentrafficsim/kpi/sampling/indicator/MeanTravelTimePerDistance.java 0 1 0
org/opentrafficsim/kpi/sampling/indicator/MeanTripLength.java 0 1 0
org/opentrafficsim/kpi/sampling/indicator/Persistent.java 0 5 0
org/opentrafficsim/kpi/sampling/indicator/PersistentStatistic.java 0 11 0
org/opentrafficsim/kpi/sampling/indicator/TotalDelay.java 0 2 0
org/opentrafficsim/kpi/sampling/indicator/TotalNumberOfStops.java 0 1 0
org/opentrafficsim/kpi/sampling/indicator/TotalTravelDistance.java 0 1 0
org/opentrafficsim/kpi/sampling/indicator/TotalTravelTime.java 0 1 0
org/opentrafficsim/kpi/sampling/meta/MetaDataCrossSections.java 0 3 0
org/opentrafficsim/kpi/sampling/meta/MetaDataDestination.java 0 3 0
org/opentrafficsim/kpi/sampling/meta/MetaDataGtuType.java 0 3 0
org/opentrafficsim/kpi/sampling/meta/MetaDataOrigin.java 0 3 0
org/opentrafficsim/kpi/sampling/meta/MetaDataRoute.java 0 3 0

Rules

Category Rule Violations Severity
blocks NeedBraces 8  Warning
design DesignForExtension 51  Warning
FinalClass 1  Warning
VisibilityModifier 2  Warning
javadoc JavadocMethod 6  Warning
JavadocPackage 1  Info
misc FinalParameters 21  Warning
TodoComment 1  Warning
modifier RedundantModifier 2  Warning
sizes MethodLength 1  Info

Details

org/opentrafficsim/kpi/interfaces/GtuDataInterface.java

Severity Category Rule Message Line
 Info javadoc JavadocPackage Missing package-info.java file.

org/opentrafficsim/kpi/sampling/KpiDirectedLanePosition.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 80
 Warning design DesignForExtension Method 'equals' is not designed for extension - needs to be abstract, final or empty. 92
 Warning blocks NeedBraces 'if' construct must use '{}'s. 95
 Warning blocks NeedBraces 'if' construct must use '{}'s. 97
 Warning blocks NeedBraces 'if' construct must use '{}'s. 99
 Warning blocks NeedBraces 'if' construct must use '{}'s. 102
 Warning blocks NeedBraces 'if' construct must use '{}'s. 106
 Warning blocks NeedBraces 'if' construct must use '{}'s. 109
 Warning blocks NeedBraces 'if' construct must use '{}'s. 113
 Warning blocks NeedBraces 'if' construct must use '{}'s. 116
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 122

org/opentrafficsim/kpi/sampling/KpiLaneDirection.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter position should be final. 64
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 71

org/opentrafficsim/kpi/sampling/Sampler.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'contains' is not designed for extension - needs to be abstract, final or empty. 136
 Info sizes MethodLength Method length is 162 lines (max allowed is 150). 334
 Warning javadoc JavadocMethod Expected @param tag for '<T>'. 504
 Warning javadoc JavadocMethod Expected @param tag for '<T>'. 518
 Warning javadoc JavadocMethod Expected @param tag for '<O>'. 518
 Warning javadoc JavadocMethod Expected @param tag for '<S>'. 518
 Warning design DesignForExtension Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 527
 Warning design DesignForExtension Method 'equals' is not designed for extension - needs to be abstract, final or empty. 541

org/opentrafficsim/kpi/sampling/Trajectory.java

Severity Category Rule Message Line
 Warning javadoc JavadocMethod Expected @param tag for '<T>'. 171
 Warning javadoc JavadocMethod Expected @param tag for '<S>'. 171
 Warning design DesignForExtension Method 'getValue' is not designed for extension - needs to be abstract, final or empty. 962
 Warning design FinalClass Class SpaceTimeView should be declared as final. 1089
 Warning design VisibilityModifier Variable 'distance' must be private and have accessor methods. 1093
 Warning design VisibilityModifier Variable 'time' must be private and have accessor methods. 1096

org/opentrafficsim/kpi/sampling/TrajectoryGroup.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'iterator' is not designed for extension - needs to be abstract, final or empty. 291

org/opentrafficsim/kpi/sampling/data/ExtendedDataTypeDuration.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter id should be final. 32
 Warning design DesignForExtension Method 'interpolate' is not designed for extension - needs to be abstract, final or empty. 52

org/opentrafficsim/kpi/sampling/data/ExtendedDataTypeFloat.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'getStorageValue' is not designed for extension - needs to be abstract, final or empty. 88
 Warning design DesignForExtension Method 'convert' is not designed for extension - needs to be abstract, final or empty. 103

org/opentrafficsim/kpi/sampling/data/ExtendedDataTypeLength.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter id should be final. 32
 Warning design DesignForExtension Method 'interpolate' is not designed for extension - needs to be abstract, final or empty. 52

org/opentrafficsim/kpi/sampling/data/ExtendedDataTypeList.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'getOutputValue' is not designed for extension - needs to be abstract, final or empty. 36
 Warning misc FinalParameters Parameter output should be final. 37
 Warning misc FinalParameters Parameter i should be final. 37
 Warning design DesignForExtension Method 'getStorageValue' is not designed for extension - needs to be abstract, final or empty. 44
 Warning misc FinalParameters Parameter output should be final. 45
 Warning misc FinalParameters Parameter i should be final. 45
 Warning design DesignForExtension Method 'initializeStorage' is not designed for extension - needs to be abstract, final or empty. 52
 Warning design DesignForExtension Method 'convert' is not designed for extension - needs to be abstract, final or empty. 59

org/opentrafficsim/kpi/sampling/data/ExtendedDataTypeNumber.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'setValue' is not designed for extension - needs to be abstract, final or empty. 34
 Warning design DesignForExtension Method 'getOutputValue' is not designed for extension - needs to be abstract, final or empty. 52
 Warning design DesignForExtension Method 'getStorageValue' is not designed for extension - needs to be abstract, final or empty. 59
 Warning design DesignForExtension Method 'initializeStorage' is not designed for extension - needs to be abstract, final or empty. 67
 Warning design DesignForExtension Method 'convert' is not designed for extension - needs to be abstract, final or empty. 74
 Warning design DesignForExtension Method 'formatValue' is not designed for extension - needs to be abstract, final or empty. 81

org/opentrafficsim/kpi/sampling/data/ExtendedDataTypeSpeed.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter id should be final. 32
 Warning design DesignForExtension Method 'interpolate' is not designed for extension - needs to be abstract, final or empty. 52

org/opentrafficsim/kpi/sampling/indicator/ConfidenceInterval.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'getLowerValue' is not designed for extension - needs to be abstract, final or empty. 39
 Warning design DesignForExtension Method 'getUpperValue' is not designed for extension - needs to be abstract, final or empty. 47

org/opentrafficsim/kpi/sampling/indicator/MeanDensity.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'calculate' is not designed for extension - needs to be abstract, final or empty. 38

org/opentrafficsim/kpi/sampling/indicator/MeanIntensity.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'calculate' is not designed for extension - needs to be abstract, final or empty. 38

org/opentrafficsim/kpi/sampling/indicator/MeanSpeed.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'calculate' is not designed for extension - needs to be abstract, final or empty. 42

org/opentrafficsim/kpi/sampling/indicator/MeanTravelTimePerDistance.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'calculate' is not designed for extension - needs to be abstract, final or empty. 38

org/opentrafficsim/kpi/sampling/indicator/MeanTripLength.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'calculate' is not designed for extension - needs to be abstract, final or empty. 29

org/opentrafficsim/kpi/sampling/indicator/Persistent.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter value should be final. 83
 Warning misc FinalParameters Parameter weight should be final. 83
 Warning modifier RedundantModifier Redundant 'final' modifier. 246
 Warning misc FinalParameters Parameter valueSI should be final. 246
 Warning modifier RedundantModifier Redundant 'final' modifier. 495

org/opentrafficsim/kpi/sampling/indicator/PersistentStatistic.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'getConfidenceInterval' is not designed for extension - needs to be abstract, final or empty. 36
 Warning design DesignForExtension Method 'getConfidenceInterval' is not designed for extension - needs to be abstract, final or empty. 46
 Warning design DesignForExtension Method 'getSum' is not designed for extension - needs to be abstract, final or empty. 54
 Warning design DesignForExtension Method 'getMin' is not designed for extension - needs to be abstract, final or empty. 62
 Warning design DesignForExtension Method 'getMax' is not designed for extension - needs to be abstract, final or empty. 70
 Warning design DesignForExtension Method 'getMean' is not designed for extension - needs to be abstract, final or empty. 78
 Warning design DesignForExtension Method 'getStDev' is not designed for extension - needs to be abstract, final or empty. 86
 Warning design DesignForExtension Method 'getVariance' is not designed for extension - needs to be abstract, final or empty. 94
 Warning design DesignForExtension Method 'getN' is not designed for extension - needs to be abstract, final or empty. 102
 Warning design DesignForExtension Method 'getSI' is not designed for extension - needs to be abstract, final or empty. 108
 Warning design DesignForExtension Method 'getInUnit' is not designed for extension - needs to be abstract, final or empty. 115

org/opentrafficsim/kpi/sampling/indicator/TotalDelay.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'calculate' is not designed for extension - needs to be abstract, final or empty. 41
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 49

org/opentrafficsim/kpi/sampling/indicator/TotalNumberOfStops.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'calculate' is not designed for extension - needs to be abstract, final or empty. 28

org/opentrafficsim/kpi/sampling/indicator/TotalTravelDistance.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'calculate' is not designed for extension - needs to be abstract, final or empty. 27

org/opentrafficsim/kpi/sampling/indicator/TotalTravelTime.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'calculate' is not designed for extension - needs to be abstract, final or empty. 27

org/opentrafficsim/kpi/sampling/meta/MetaDataCrossSections.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'formatValue' is not designed for extension - needs to be abstract, final or empty. 44
 Warning misc FinalParameters Parameter format should be final. 45
 Warning misc FinalParameters Parameter value should be final. 45

org/opentrafficsim/kpi/sampling/meta/MetaDataDestination.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'formatValue' is not designed for extension - needs to be abstract, final or empty. 38
 Warning misc FinalParameters Parameter format should be final. 39
 Warning misc FinalParameters Parameter value should be final. 39

org/opentrafficsim/kpi/sampling/meta/MetaDataGtuType.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'formatValue' is not designed for extension - needs to be abstract, final or empty. 38
 Warning misc FinalParameters Parameter format should be final. 39
 Warning misc FinalParameters Parameter value should be final. 39

org/opentrafficsim/kpi/sampling/meta/MetaDataOrigin.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'formatValue' is not designed for extension - needs to be abstract, final or empty. 38
 Warning misc FinalParameters Parameter format should be final. 39
 Warning misc FinalParameters Parameter value should be final. 39

org/opentrafficsim/kpi/sampling/meta/MetaDataRoute.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'formatValue' is not designed for extension - needs to be abstract, final or empty. 38
 Warning misc FinalParameters Parameter format should be final. 39
 Warning misc FinalParameters Parameter value should be final. 39