Checkstyle Results

The following document contains the results of Checkstyle 6.18 with development/dsol-checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
38 2 54 0

Files

File  I  W  E
org/opentrafficsim/road/network/factory/xml/ConnectorTag.java 0 5 0
org/opentrafficsim/road/network/factory/xml/CrossSectionElementTag.java 0 3 0
org/opentrafficsim/road/network/factory/xml/GTUColorerTag.java 0 5 0
org/opentrafficsim/road/network/factory/xml/GeneratorTag.java 0 1 0
org/opentrafficsim/road/network/factory/xml/LinkTag.java 0 1 0
org/opentrafficsim/road/network/factory/xml/Links.java 0 3 0
org/opentrafficsim/road/network/factory/xml/PolyLineTag.java 0 1 0
org/opentrafficsim/road/network/factory/xml/XmlNetworkLaneParser.java 1 8 0
org/opentrafficsim/road/network/factory/xml/XmlParserException.java 0 4 0
org/opentrafficsim/road/network/factory/xml/demand/CategoryTag.java 0 2 0
org/opentrafficsim/road/network/factory/xml/demand/DemandTag.java 0 11 0
org/opentrafficsim/road/network/factory/xml/demand/XmlOdParser.java 1 10 0

Rules

Category Rule Violations Severity
blocks EmptyBlock 1  Warning
NeedBraces 6  Warning
coding InnerAssignment 2  Warning
design DesignForExtension 6  Warning
VisibilityModifier 27  Warning
javadoc JavadocStyle
  • checkHtml: "false"
 1  Warning
misc FinalParameters 8  Warning
TodoComment 1  Warning
modifier ModifierOrder 2  Warning
sizes MethodLength 2  Info

Details

org/opentrafficsim/road/network/factory/xml/ConnectorTag.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'name' must be private and have accessor methods. 30
 Warning design VisibilityModifier Variable 'nodeStartTag' must be private and have accessor methods. 33
 Warning design VisibilityModifier Variable 'nodeEndTag' must be private and have accessor methods. 36
 Warning design VisibilityModifier Variable 'demandWeight' must be private and have accessor methods. 39
 Warning design VisibilityModifier Variable 'connector' must be private and have accessor methods. 42

org/opentrafficsim/road/network/factory/xml/CrossSectionElementTag.java

Severity Category Rule Message Line
 Warning blocks NeedBraces 'if' construct must use '{}'s. 483
 Warning blocks NeedBraces 'if' construct must use '{}'s. 486
 Warning blocks NeedBraces 'if' construct must use '{}'s. 489

org/opentrafficsim/road/network/factory/xml/GTUColorerTag.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle First sentence should end with a period. 31
 Warning design VisibilityModifier Variable 'defaultColorer' must be private and have accessor methods. 33
 Warning blocks NeedBraces 'if' construct must use '{}'s. 69
 Warning blocks NeedBraces 'if' construct must use '{}'s. 84
 Warning blocks NeedBraces 'if' construct must use '{}'s. 97

org/opentrafficsim/road/network/factory/xml/GeneratorTag.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'gtuDirection' must be private and have accessor methods. 77

org/opentrafficsim/road/network/factory/xml/LinkTag.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'priority' must be private and have accessor methods. 128

org/opentrafficsim/road/network/factory/xml/Links.java

Severity Category Rule Message Line
 Warning coding InnerAssignment Inner assignments should be avoided. 418
 Warning coding InnerAssignment Inner assignments should be avoided. 422
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 483

org/opentrafficsim/road/network/factory/xml/PolyLineTag.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'coordinates' must be private and have accessor methods. 33

org/opentrafficsim/road/network/factory/xml/XmlNetworkLaneParser.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'xmlComments' must be private and have accessor methods. 151
 Warning misc FinalParameters Parameter interpretXMLComments should be final. 194
 Warning misc FinalParameters Parameter interpretXMLComments should be final. 218
 Warning misc FinalParameters Parameter interpretXMLComments should be final. 243
 Warning misc FinalParameters Parameter interpretXMLComments should be final. 268
 Warning blocks EmptyBlock Must have at least one statement. 358
 Info sizes MethodLength Method length is 161 lines (max allowed is 150). 404
 Warning design DesignForExtension Method 'getXMLComments' is not designed for extension - needs to be abstract, final or empty. 616
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 630

org/opentrafficsim/road/network/factory/xml/XmlParserException.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter message should be final. 33
 Warning misc FinalParameters Parameter cause should be final. 33
 Warning misc FinalParameters Parameter message should be final. 41
 Warning misc FinalParameters Parameter cause should be final. 49

org/opentrafficsim/road/network/factory/xml/demand/CategoryTag.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'factor' must be private and have accessor methods. 48
 Warning design DesignForExtension Method 'getCategory' is not designed for extension - needs to be abstract, final or empty. 174

org/opentrafficsim/road/network/factory/xml/demand/DemandTag.java

Severity Category Rule Message Line
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 45
 Warning design VisibilityModifier Variable 'origin' must be private and have accessor methods. 48
 Warning design VisibilityModifier Variable 'destination' must be private and have accessor methods. 51
 Warning design VisibilityModifier Variable 'interpolation' must be private and have accessor methods. 54
 Warning design VisibilityModifier Variable 'category' must be private and have accessor methods. 57
 Warning design VisibilityModifier Variable 'categoryName' must be private and have accessor methods. 60
 Warning design VisibilityModifier Variable 'demandType' must be private and have accessor methods. 63
 Warning design VisibilityModifier Variable 'timeVector' must be private and have accessor methods. 66
 Warning design VisibilityModifier Variable 'demandVector' must be private and have accessor methods. 69
 Warning design VisibilityModifier Variable 'factor' must be private and have accessor methods. 72
 Warning design VisibilityModifier Variable 'factors' must be private and have accessor methods. 75

org/opentrafficsim/road/network/factory/xml/demand/XmlOdParser.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'network' must be private and have accessor methods. 72
 Warning design VisibilityModifier Variable 'categorization' must be private and have accessor methods. 78
 Warning design VisibilityModifier Variable 'categories' must be private and have accessor methods. 81
 Warning design VisibilityModifier Variable 'globalTime' must be private and have accessor methods. 84
 Warning design VisibilityModifier Variable 'globalInterpolation' must be private and have accessor methods. 87
 Warning design VisibilityModifier Variable 'demand' must be private and have accessor methods. 90
 Warning design DesignForExtension Method 'getGTUType' is not designed for extension - needs to be abstract, final or empty. 117
 Warning design DesignForExtension Method 'apply' is not designed for extension - needs to be abstract, final or empty. 139
 Warning design DesignForExtension Method 'apply' is not designed for extension - needs to be abstract, final or empty. 188
 Info sizes MethodLength Method length is 172 lines (max allowed is 150). 256
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 436