Checkstyle Results

The following document contains the results of Checkstyle 6.18 with development/dsol-checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
16 0 29 0

Files

File  I  W  E
org/opentrafficsim/swing/gui/AnimationToggles.java 0 4 0
org/opentrafficsim/swing/gui/JFileChooserWithSettings.java 0 1 0
org/opentrafficsim/swing/gui/OTSAnimationPanel.java 0 3 0
org/opentrafficsim/swing/gui/OTSControlPanel.java 0 7 0
org/opentrafficsim/swing/gui/OTSSimulationApplication.java 0 3 0
org/opentrafficsim/swing/gui/OTSSimulationPanel.java 0 1 0
org/opentrafficsim/swing/gui/OTSSwingApplication.java 0 3 0
org/opentrafficsim/swing/script/AbstractSimulationScript.java 0 7 0

Rules

Category Rule Violations Severity
blocks EmptyBlock 1  Warning
coding HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
 1  Warning
design DesignForExtension 15  Warning
VisibilityModifier 5  Warning
misc TodoComment 3  Warning
modifier ModifierOrder 2  Warning
RedundantModifier 2  Warning

Details

org/opentrafficsim/swing/gui/AnimationToggles.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'final' modifier. 177
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 177
 Warning modifier RedundantModifier Redundant 'final' modifier. 188
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 188

org/opentrafficsim/swing/gui/JFileChooserWithSettings.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 60

org/opentrafficsim/swing/gui/OTSAnimationPanel.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'getDemoPanel' is not designed for extension - needs to be abstract, final or empty. 582
 Warning blocks EmptyBlock Must have at least one statement. 597
 Warning design DesignForExtension Method 'notify' is not designed for extension - needs to be abstract, final or empty. 788

org/opentrafficsim/swing/gui/OTSControlPanel.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 436
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 472
 Warning design DesignForExtension Method 'cancelTimer' is not designed for extension - needs to be abstract, final or empty. 962
 Warning design DesignForExtension Method 'getSpeedLabel' is not designed for extension - needs to be abstract, final or empty. 1017
 Warning design DesignForExtension Method 'getSpeed' is not designed for extension - needs to be abstract, final or empty. 1027
 Warning design DesignForExtension Method 'isForeground' is not designed for extension - needs to be abstract, final or empty. 1035
 Warning design DesignForExtension Method 'setTime' is not designed for extension - needs to be abstract, final or empty. 1085

org/opentrafficsim/swing/gui/OTSSimulationApplication.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'animateNetwork' is not designed for extension - needs to be abstract, final or empty. 47
 Warning design DesignForExtension Method 'setAnimationToggles' is not designed for extension - needs to be abstract, final or empty. 56
 Warning design DesignForExtension Method 'getAnimationPanel' is not designed for extension - needs to be abstract, final or empty. 73

org/opentrafficsim/swing/gui/OTSSimulationPanel.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 104

org/opentrafficsim/swing/gui/OTSSwingApplication.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'frameProperties' must be private and have accessor methods. 70
 Warning design DesignForExtension Method 'setAppearance' is not designed for extension - needs to be abstract, final or empty. 216
 Warning design DesignForExtension Method 'getAppearance' is not designed for extension - needs to be abstract, final or empty. 297

org/opentrafficsim/swing/script/AbstractSimulationScript.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'name' must be private and have accessor methods. 52
 Warning design VisibilityModifier Variable 'description' must be private and have accessor methods. 55
 Warning design VisibilityModifier Variable 'simulator' must be private and have accessor methods. 58
 Warning design VisibilityModifier Variable 'animationPanel' must be private and have accessor methods. 70
 Warning design DesignForExtension Method 'animateNetwork' is not designed for extension - needs to be abstract, final or empty. 291
 Warning coding HiddenField 'animationPanel' hides a field. 341
 Warning design DesignForExtension Method 'addAnimationToggles' is not designed for extension - needs to be abstract, final or empty. 350