Checkstyle Results

The following document contains the results of Checkstyle 6.18 with development/dsol-checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
9 2 185 0

Files

File  I  W  E
org/opentrafficsim/trafficcontrol/TrafficController.java 0 10 0
org/opentrafficsim/trafficcontrol/ccol/CCOL.java 0 17 0
org/opentrafficsim/trafficcontrol/trafcod/Diagram.java 0 46 0
org/opentrafficsim/trafficcontrol/trafcod/TrafCOD.java 2 71 0
org/opentrafficsim/trafficcontrol/trafcod/TrafCODDisplay.java 0 41 0

Rules

Category Rule Violations Severity
coding HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
 1  Warning
InnerAssignment 1  Warning
MissingSwitchDefault 2  Warning
design DesignForExtension 24  Warning
VisibilityModifier 28  Warning
javadoc JavadocStyle
  • checkHtml: "false"
 5  Warning
misc FinalParameters 61  Warning
modifier ModifierOrder 35  Warning
RedundantModifier 21  Warning
naming ConstantName 2  Warning
StaticVariableName 3  Warning
sizes FileLength 1  Warning
MethodLength 2  Info
whitespace WhitespaceAfter 1  Warning

Details

org/opentrafficsim/trafficcontrol/TrafficController.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 27
 Warning modifier RedundantModifier Redundant 'public' modifier. 34
 Warning modifier RedundantModifier Redundant 'final' modifier. 37
 Warning modifier RedundantModifier Redundant 'final' modifier. 40
 Warning modifier RedundantModifier Redundant 'final' modifier. 43
 Warning modifier RedundantModifier Redundant 'final' modifier. 46
 Warning modifier RedundantModifier Redundant 'final' modifier. 49
 Warning modifier RedundantModifier Redundant 'public' modifier. 52
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 52
 Warning modifier RedundantModifier Redundant 'public' modifier. 84

org/opentrafficsim/trafficcontrol/ccol/CCOL.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'id' must be private and have accessor methods. 49
 Warning design VisibilityModifier Variable 'simulator' must be private and have accessor methods. 52
 Warning naming StaticVariableName Name 'PORT' must match pattern '^[a-z][a-zA-Z0-9]*$'. 55
 Warning design VisibilityModifier Variable 'PORT' must be private and have accessor methods. 55
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 58
 Warning design VisibilityModifier Variable 'serverSocket' must be private and have accessor methods. 61
 Warning design VisibilityModifier Variable 'acceptThread' must be private and have accessor methods. 73
 Warning design DesignForExtension Method 'setClientSocket' is not designed for extension - needs to be abstract, final or empty. 129
 Warning design DesignForExtension Method 'getClientSocket' is not designed for extension - needs to be abstract, final or empty. 161
 Warning design DesignForExtension Method 'notify' is not designed for extension - needs to be abstract, final or empty. 192
 Warning misc FinalParameters Parameter event should be final. 193
 Warning design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 227
 Warning design DesignForExtension Method 'getFullId' is not designed for extension - needs to be abstract, final or empty. 234
 Warning design DesignForExtension Method 'updateDetector' is not designed for extension - needs to be abstract, final or empty. 241
 Warning design DesignForExtension Method 'clone' is not designed for extension - needs to be abstract, final or empty. 250
 Warning misc FinalParameters Parameter newSimulator should be final. 251
 Warning misc FinalParameters Parameter newNetwork should be final. 251

org/opentrafficsim/trafficcontrol/trafcod/Diagram.java

Severity Category Rule Message Line
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 48
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 51
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 54
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 57
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 60
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 63
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 66
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 69
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 72
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 75
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 78
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 81
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 84
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 87
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 90
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 93
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 96
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 99
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 102
 Warning design VisibilityModifier Variable 'streams' must be private and have accessor methods. 105
 Warning design VisibilityModifier Variable 'routes' must be private and have accessor methods. 108
 Warning misc FinalParameters Parameter o1 should be final. 122
 Warning misc FinalParameters Parameter o2 should be final. 122
 Warning whitespace WhitespaceAfter ',' is not followed by whitespace. 141
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 278
 Warning javadoc JavadocStyle First sentence should end with a period. 310
 Warning coding MissingSwitchDefault switch without "default" clause. 333
 Warning coding MissingSwitchDefault switch without "default" clause. 355
 Warning modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 398
 Warning modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 401
 Warning modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 404
 Warning modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 407
 Warning modifier RedundantModifier Redundant 'public' modifier. 414
 Warning modifier RedundantModifier Redundant 'public' modifier. 430
 Warning modifier RedundantModifier Redundant 'public' modifier. 451
 Warning modifier RedundantModifier Redundant 'public' modifier. 468
 Warning modifier RedundantModifier Redundant 'public' modifier. 540
 Warning modifier RedundantModifier Redundant 'public' modifier. 550
 Warning modifier RedundantModifier Redundant 'public' modifier. 561
 Warning javadoc JavadocStyle First sentence should end with a period. 628
 Warning misc FinalParameters Parameter steps should be final. 634
 Warning coding InnerAssignment Inner assignments should be avoided. 638
 Warning design DesignForExtension Method 'render' is not designed for extension - needs to be abstract, final or empty. 715
 Warning misc FinalParameters Parameter e should be final. 863
 Warning design VisibilityModifier Variable 'testPanel' must be private and have accessor methods. 872
 Warning design VisibilityModifier Variable 'checkBoxPanel' must be private and have accessor methods. 875

org/opentrafficsim/trafficcontrol/trafcod/TrafCOD.java

Severity Category Rule Message Line
 Warning sizes FileLength File length is 2,821 lines (max allowed is 2,000). 1
 Warning design VisibilityModifier Variable 'controllerName' must be private and have accessor methods. 64
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 67
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 70
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 73
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 76
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 79
 Warning design VisibilityModifier Variable 'trafcodRules' must be private and have accessor methods. 82
 Warning design VisibilityModifier Variable 'tokenisedRules' must be private and have accessor methods. 85
 Warning design VisibilityModifier Variable 'variables' must be private and have accessor methods. 88
 Warning design VisibilityModifier Variable 'variablesInDefinitionOrder' must be private and have accessor methods. 91
 Warning design VisibilityModifier Variable 'detectors' must be private and have accessor methods. 94
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 97
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 100
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 103
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 106
 Warning design VisibilityModifier Variable 'numberOfConflictGroups' must be private and have accessor methods. 109
 Warning javadoc JavadocStyle First sentence should end with a period. 132
 Warning misc FinalParameters Parameter controllerName should be final. 154
 Warning misc FinalParameters Parameter display should be final. 155
 Warning misc FinalParameters Parameter controllerName should be final. 229
 Warning misc FinalParameters Parameter display should be final. 229
 Info sizes MethodLength Method length is 219 lines (max allowed is 150). 247
 Warning design DesignForExtension Method 'checkConsistency' is not designed for extension - needs to be abstract, final or empty. 472
 Warning misc FinalParameters Parameter sensors should be final. 511
 Warning naming StaticVariableName Name 'BIND_UNARY_MINUS' must match pattern '^[a-z][a-zA-Z0-9]*$'. 908
 Warning misc FinalParameters Parameter tokens should be final. 1164
 Info sizes MethodLength Method length is 269 lines (max allowed is 150). 1375
 Warning misc FinalParameters Parameter name should be final. 1686
 Warning misc FinalParameters Parameter stream should be final. 1686
 Warning misc FinalParameters Parameter flags should be final. 1686
 Warning misc FinalParameters Parameter location should be final. 1686
 Warning design DesignForExtension Method 'getSimulator' is not designed for extension - needs to be abstract, final or empty. 1724
 Warning design DesignForExtension Method 'getStructureNumber' is not designed for extension - needs to be abstract, final or empty. 1733
 Warning design DesignForExtension Method 'updateDetector' is not designed for extension - needs to be abstract, final or empty. 1739
 Warning misc FinalParameters Parameter detectorId should be final. 1740
 Warning misc FinalParameters Parameter detectingGTU should be final. 1740
 Warning design DesignForExtension Method 'traceVariablesOfStream' is not designed for extension - needs to be abstract, final or empty. 1756
 Warning design DesignForExtension Method 'traceVariable' is not designed for extension - needs to be abstract, final or empty. 1781
 Warning design DesignForExtension Method 'notify' is not designed for extension - needs to be abstract, final or empty. 1800
 Warning misc FinalParameters Parameter event should be final. 1801
 Warning design DesignForExtension Method 'fireTrafCODEvent' is not designed for extension - needs to be abstract, final or empty. 1871
 Warning design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 1877
 Warning design DesignForExtension Method 'getFullId' is not designed for extension - needs to be abstract, final or empty. 1884
 Warning modifier RedundantModifier Redundant 'public' modifier. 1968
 Warning design VisibilityModifier Variable 'flags' must be private and have accessor methods. 2094
 Warning design VisibilityModifier Variable 'value' must be private and have accessor methods. 2097
 Warning design VisibilityModifier Variable 'timerMax10' must be private and have accessor methods. 2100
 Warning design VisibilityModifier Variable 'color' must be private and have accessor methods. 2103
 Warning design VisibilityModifier Variable 'name' must be private and have accessor methods. 2106
 Warning javadoc JavadocStyle First sentence should end with a period. 2108
 Warning design VisibilityModifier Variable 'stream' must be private and have accessor methods. 2109
 Warning design VisibilityModifier Variable 'refCount' must be private and have accessor methods. 2112
 Warning design VisibilityModifier Variable 'updateTime10' must be private and have accessor methods. 2115
 Warning design VisibilityModifier Variable 'startSource' must be private and have accessor methods. 2118
 Warning design VisibilityModifier Variable 'endSource' must be private and have accessor methods. 2121
 Warning naming StaticVariableName Name 'ROWLETTERS' must match pattern '^[a-z][a-zA-Z0-9]*$'. 2127
 Warning modifier RedundantModifier Redundant 'public' modifier. 2165
 Warning misc FinalParameters Parameter trafCOD should be final. 2165
 Warning misc FinalParameters Parameter sensor should be final. 2199
 Warning misc FinalParameters Parameter newValue should be final. 2321
 Warning misc FinalParameters Parameter timeStamp10 should be final. 2321
 Warning misc FinalParameters Parameter cause should be final. 2321
 Warning misc FinalParameters Parameter trafCOD should be final. 2321
 Warning coding HiddenField 'trafCOD' hides a field. 2321
 Warning misc FinalParameters Parameter colorValue should be final. 2475
 Warning misc FinalParameters Parameter value10 should be final. 2524
 Warning misc FinalParameters Parameter startSource should be final. 2548
 Warning misc FinalParameters Parameter endSource should be final. 2572
 Warning misc FinalParameters Parameter printFlags should be final. 2603
 Warning misc FinalParameters Parameter event should be final. 2712
 Warning design VisibilityModifier Variable 'cause' must be private and have accessor methods. 2733
 Warning modifier RedundantModifier Redundant 'public' modifier. 2739

org/opentrafficsim/trafficcontrol/trafcod/TrafCODDisplay.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'defaultInitialDelay' must be private and have accessor methods. 54
 Warning design DesignForExtension Method 'paintComponent' is not designed for extension - needs to be abstract, final or empty. 69
 Warning design DesignForExtension Method 'addTrafCODObject' is not designed for extension - needs to be abstract, final or empty. 84
 Warning design DesignForExtension Method 'mouseDragged' is not designed for extension - needs to be abstract, final or empty. 90
 Warning misc FinalParameters Parameter e should be final. 91
 Warning design DesignForExtension Method 'mouseMoved' is not designed for extension - needs to be abstract, final or empty. 97
 Warning misc FinalParameters Parameter e should be final. 98
 Warning misc FinalParameters Parameter e should be final. 115
 Warning misc FinalParameters Parameter e should be final. 122
 Warning misc FinalParameters Parameter e should be final. 129
 Warning design DesignForExtension Method 'mouseEntered' is not designed for extension - needs to be abstract, final or empty. 135
 Warning misc FinalParameters Parameter e should be final. 136
 Warning design DesignForExtension Method 'mouseExited' is not designed for extension - needs to be abstract, final or empty. 142
 Warning misc FinalParameters Parameter e should be final. 143
 Warning javadoc JavadocStyle First sentence should end with a period. 156
 Warning naming ConstantName Name 'xOffset' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 197
 Warning naming ConstantName Name 'yOffset' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 200
 Warning modifier RedundantModifier Redundant 'public' modifier. 208
 Warning misc FinalParameters Parameter center should be final. 208
 Warning misc FinalParameters Parameter description should be final. 208
 Warning misc FinalParameters Parameter g2 should be final. 219
 Warning misc FinalParameters Parameter event should be final. 229
 Warning modifier RedundantModifier Redundant 'public' modifier. 283
 Warning misc FinalParameters Parameter testX should be final. 294
 Warning misc FinalParameters Parameter testY should be final. 294
 Warning misc FinalParameters Parameter listener should be final. 369
 Warning misc FinalParameters Parameter eventType should be final. 369
 Warning misc FinalParameters Parameter listener should be final. 376
 Warning misc FinalParameters Parameter eventType should be final. 376
 Warning misc FinalParameters Parameter weak should be final. 376
 Warning misc FinalParameters Parameter listener should be final. 383
 Warning misc FinalParameters Parameter eventType should be final. 383
 Warning misc FinalParameters Parameter position should be final. 383
 Warning misc FinalParameters Parameter listener should be final. 390
 Warning misc FinalParameters Parameter eventType should be final. 390
 Warning misc FinalParameters Parameter position should be final. 390
 Warning misc FinalParameters Parameter weak should be final. 390
 Warning misc FinalParameters Parameter listener should be final. 398
 Warning misc FinalParameters Parameter eventType should be final. 398
 Warning misc FinalParameters Parameter trafficLightColor should be final. 412
 Warning misc FinalParameters Parameter g2 should be final. 423