Checkstyle Results

The following document contains the results of Checkstyle 6.18 with development/dsol-checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
10 0 79 0

Files

File  I  W  E
org/opentrafficsim/sim0mq/kpi/GtuData.java 0 9 0
org/opentrafficsim/sim0mq/kpi/GtuTypeData.java 0 10 0
org/opentrafficsim/sim0mq/kpi/LaneData.java 0 12 0
org/opentrafficsim/sim0mq/kpi/LinkData.java 0 13 0
org/opentrafficsim/sim0mq/kpi/NodeData.java 0 10 0
org/opentrafficsim/sim0mq/kpi/RouteData.java 0 13 0
org/opentrafficsim/sim0mq/kpi/Sim0MQKpiTransceiver.java 0 7 0
org/opentrafficsim/sim0mq/kpi/Sim0MQSampler.java 0 5 0

Rules

Category Rule Violations Severity
blocks NeedBraces 30  Warning
design DesignForExtension 24  Warning
VisibilityModifier 8  Warning
javadoc JavadocVariable 7  Warning
misc FinalParameters 10  Warning

Details

org/opentrafficsim/sim0mq/kpi/GtuData.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 77
 Warning design DesignForExtension Method 'equals' is not designed for extension - needs to be abstract, final or empty. 87
 Warning misc FinalParameters Parameter obj should be final. 88
 Warning blocks NeedBraces 'if' construct must use '{}'s. 90
 Warning blocks NeedBraces 'if' construct must use '{}'s. 92
 Warning blocks NeedBraces 'if' construct must use '{}'s. 94
 Warning blocks NeedBraces 'if' construct must use '{}'s. 99
 Warning blocks NeedBraces 'if' construct must use '{}'s. 102
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 108

org/opentrafficsim/sim0mq/kpi/GtuTypeData.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 37
 Warning design DesignForExtension Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 44
 Warning design DesignForExtension Method 'equals' is not designed for extension - needs to be abstract, final or empty. 54
 Warning misc FinalParameters Parameter obj should be final. 55
 Warning blocks NeedBraces 'if' construct must use '{}'s. 57
 Warning blocks NeedBraces 'if' construct must use '{}'s. 59
 Warning blocks NeedBraces 'if' construct must use '{}'s. 61
 Warning blocks NeedBraces 'if' construct must use '{}'s. 66
 Warning blocks NeedBraces 'if' construct must use '{}'s. 69
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 75

org/opentrafficsim/sim0mq/kpi/LaneData.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'length' must be private and have accessor methods. 26
 Warning design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 64
 Warning misc FinalParameters Parameter linkData should be final. 73
 Warning design DesignForExtension Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 79
 Warning design DesignForExtension Method 'equals' is not designed for extension - needs to be abstract, final or empty. 89
 Warning misc FinalParameters Parameter obj should be final. 90
 Warning blocks NeedBraces 'if' construct must use '{}'s. 92
 Warning blocks NeedBraces 'if' construct must use '{}'s. 94
 Warning blocks NeedBraces 'if' construct must use '{}'s. 96
 Warning blocks NeedBraces 'if' construct must use '{}'s. 101
 Warning blocks NeedBraces 'if' construct must use '{}'s. 104
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 110

org/opentrafficsim/sim0mq/kpi/LinkData.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'startNode' must be private and have accessor methods. 27
 Warning design VisibilityModifier Variable 'endNode' must be private and have accessor methods. 30
 Warning design DesignForExtension Method 'addLaneData' is not designed for extension - needs to be abstract, final or empty. 56
 Warning design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 100
 Warning design DesignForExtension Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 107
 Warning design DesignForExtension Method 'equals' is not designed for extension - needs to be abstract, final or empty. 120
 Warning misc FinalParameters Parameter obj should be final. 121
 Warning blocks NeedBraces 'if' construct must use '{}'s. 123
 Warning blocks NeedBraces 'if' construct must use '{}'s. 125
 Warning blocks NeedBraces 'if' construct must use '{}'s. 127
 Warning blocks NeedBraces 'if' construct must use '{}'s. 132
 Warning blocks NeedBraces 'if' construct must use '{}'s. 135
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 141

org/opentrafficsim/sim0mq/kpi/NodeData.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 53
 Warning design DesignForExtension Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 60
 Warning design DesignForExtension Method 'equals' is not designed for extension - needs to be abstract, final or empty. 70
 Warning misc FinalParameters Parameter obj should be final. 71
 Warning blocks NeedBraces 'if' construct must use '{}'s. 73
 Warning blocks NeedBraces 'if' construct must use '{}'s. 75
 Warning blocks NeedBraces 'if' construct must use '{}'s. 77
 Warning blocks NeedBraces 'if' construct must use '{}'s. 82
 Warning blocks NeedBraces 'if' construct must use '{}'s. 85
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 91

org/opentrafficsim/sim0mq/kpi/RouteData.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter routeName should be final. 31
 Warning misc FinalParameters Parameter startNode should be final. 31
 Warning misc FinalParameters Parameter endNode should be final. 31
 Warning design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 64
 Warning design DesignForExtension Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 71
 Warning design DesignForExtension Method 'equals' is not designed for extension - needs to be abstract, final or empty. 81
 Warning misc FinalParameters Parameter obj should be final. 82
 Warning blocks NeedBraces 'if' construct must use '{}'s. 84
 Warning blocks NeedBraces 'if' construct must use '{}'s. 86
 Warning blocks NeedBraces 'if' construct must use '{}'s. 88
 Warning blocks NeedBraces 'if' construct must use '{}'s. 93
 Warning blocks NeedBraces 'if' construct must use '{}'s. 96
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 102

org/opentrafficsim/sim0mq/kpi/Sim0MQKpiTransceiver.java

Severity Category Rule Message Line
 Warning javadoc JavadocVariable Missing a Javadoc comment. 269
 Warning javadoc JavadocVariable Missing a Javadoc comment. 271
 Warning javadoc JavadocVariable Missing a Javadoc comment. 273
 Warning javadoc JavadocVariable Missing a Javadoc comment. 275
 Warning javadoc JavadocVariable Missing a Javadoc comment. 277
 Warning javadoc JavadocVariable Missing a Javadoc comment. 279
 Warning javadoc JavadocVariable Missing a Javadoc comment. 281

org/opentrafficsim/sim0mq/kpi/Sim0MQSampler.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'nodes' must be private and have accessor methods. 39
 Warning design VisibilityModifier Variable 'links' must be private and have accessor methods. 42
 Warning design VisibilityModifier Variable 'lanes' must be private and have accessor methods. 45
 Warning design VisibilityModifier Variable 'gtus' must be private and have accessor methods. 48
 Warning design VisibilityModifier Variable 'lastLanes' must be private and have accessor methods. 51