Checkstyle Results

The following document contains the results of Checkstyle 6.18 with development/dsol-checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
12 4 205 0

Files

File  I  W  E
org/opentrafficsim/trafficcontrol/AbstractTrafficController.java 0 2 0
org/opentrafficsim/trafficcontrol/ActuatedTrafficController.java 0 1 0
org/opentrafficsim/trafficcontrol/FixedTimeController.java 1 19 0
org/opentrafficsim/trafficcontrol/TrafficController.java 0 9 0
org/opentrafficsim/trafficcontrol/ccol/CCOL.java 0 17 0
org/opentrafficsim/trafficcontrol/trafcod/Diagram.java 0 46 0
org/opentrafficsim/trafficcontrol/trafcod/TrafCOD.java 3 68 0
org/opentrafficsim/trafficcontrol/trafcod/TrafCODDisplay.java 0 43 0

Rules

Category Rule Violations Severity
coding HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
 2  Warning
InnerAssignment 1  Warning
MissingSwitchDefault 2  Warning
design DesignForExtension 35  Warning
VisibilityModifier 30  Warning
javadoc JavadocStyle
  • checkHtml: "false"
 5  Warning
misc FinalParameters 63  Warning
TodoComment 1  Warning
modifier ModifierOrder 36  Warning
RedundantModifier 22  Warning
naming ConstantName 3  Warning
StaticVariableName 3  Warning
sizes FileLength 1  Warning
MethodLength 4  Info
whitespace WhitespaceAfter 1  Warning

Details

org/opentrafficsim/trafficcontrol/AbstractTrafficController.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'id' must be private and have accessor methods. 25
 Warning design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 43

org/opentrafficsim/trafficcontrol/ActuatedTrafficController.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 21

org/opentrafficsim/trafficcontrol/FixedTimeController.java

Severity Category Rule Message Line
 Info sizes MethodLength Method length is 188 lines (max allowed is 150). 69
 Warning design DesignForExtension Method 'clone' is not designed for extension - needs to be abstract, final or empty. 283
 Warning design DesignForExtension Method 'getFullId' is not designed for extension - needs to be abstract, final or empty. 303
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 334
 Warning design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 436
 Warning design DesignForExtension Method 'startup' is not designed for extension - needs to be abstract, final or empty. 451
 Warning coding HiddenField 'simulator' hides a field. 451
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 471
 Warning design DesignForExtension Method 'clone' is not designed for extension - needs to be abstract, final or empty. 574
 Warning design DesignForExtension Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 581
 Warning design DesignForExtension Method 'equals' is not designed for extension - needs to be abstract, final or empty. 591
 Warning misc FinalParameters Parameter obj should be final. 592
 Warning design DesignForExtension Method 'getCurrentColor' is not designed for extension - needs to be abstract, final or empty. 681
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 687
 Warning design VisibilityModifier Variable 'offset' must be private and have accessor methods. 703
 Warning design VisibilityModifier Variable 'newColor' must be private and have accessor methods. 706
 Warning modifier RedundantModifier Redundant 'public' modifier. 713
 Warning modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 744
 Warning naming ConstantName Name 'compareMargin' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 744
 Warning misc FinalParameters Parameter o should be final. 747

org/opentrafficsim/trafficcontrol/TrafficController.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 29
 Warning modifier RedundantModifier Redundant 'final' modifier. 32
 Warning modifier RedundantModifier Redundant 'final' modifier. 35
 Warning modifier RedundantModifier Redundant 'final' modifier. 38
 Warning modifier RedundantModifier Redundant 'final' modifier. 41
 Warning modifier RedundantModifier Redundant 'final' modifier. 44
 Warning modifier RedundantModifier Redundant 'public' modifier. 47
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 47
 Warning modifier RedundantModifier Redundant 'public' modifier. 79

org/opentrafficsim/trafficcontrol/ccol/CCOL.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'id' must be private and have accessor methods. 49
 Warning design VisibilityModifier Variable 'simulator' must be private and have accessor methods. 52
 Warning naming StaticVariableName Name 'PORT' must match pattern '^[a-z][a-zA-Z0-9]*$'. 55
 Warning design VisibilityModifier Variable 'PORT' must be private and have accessor methods. 55
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 58
 Warning design VisibilityModifier Variable 'serverSocket' must be private and have accessor methods. 61
 Warning design VisibilityModifier Variable 'acceptThread' must be private and have accessor methods. 73
 Warning design DesignForExtension Method 'setClientSocket' is not designed for extension - needs to be abstract, final or empty. 129
 Warning design DesignForExtension Method 'getClientSocket' is not designed for extension - needs to be abstract, final or empty. 161
 Warning design DesignForExtension Method 'notify' is not designed for extension - needs to be abstract, final or empty. 192
 Warning misc FinalParameters Parameter event should be final. 193
 Warning design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 227
 Warning design DesignForExtension Method 'getFullId' is not designed for extension - needs to be abstract, final or empty. 234
 Warning design DesignForExtension Method 'updateDetector' is not designed for extension - needs to be abstract, final or empty. 241
 Warning design DesignForExtension Method 'clone' is not designed for extension - needs to be abstract, final or empty. 250
 Warning misc FinalParameters Parameter newSimulator should be final. 251
 Warning misc FinalParameters Parameter newNetwork should be final. 251

org/opentrafficsim/trafficcontrol/trafcod/Diagram.java

Severity Category Rule Message Line
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 48
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 51
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 54
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 57
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 60
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 63
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 66
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 69
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 72
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 75
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 78
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 81
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 84
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 87
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 90
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 93
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 96
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 99
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 102
 Warning design VisibilityModifier Variable 'streams' must be private and have accessor methods. 105
 Warning design VisibilityModifier Variable 'routes' must be private and have accessor methods. 108
 Warning misc FinalParameters Parameter o1 should be final. 122
 Warning misc FinalParameters Parameter o2 should be final. 122
 Warning whitespace WhitespaceAfter ',' is not followed by whitespace. 141
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 278
 Warning javadoc JavadocStyle First sentence should end with a period. 310
 Warning coding MissingSwitchDefault switch without "default" clause. 333
 Warning coding MissingSwitchDefault switch without "default" clause. 355
 Warning modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 398
 Warning modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 401
 Warning modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 404
 Warning modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 407
 Warning modifier RedundantModifier Redundant 'public' modifier. 414
 Warning modifier RedundantModifier Redundant 'public' modifier. 430
 Warning modifier RedundantModifier Redundant 'public' modifier. 451
 Warning modifier RedundantModifier Redundant 'public' modifier. 468
 Warning modifier RedundantModifier Redundant 'public' modifier. 540
 Warning modifier RedundantModifier Redundant 'public' modifier. 550
 Warning modifier RedundantModifier Redundant 'public' modifier. 561
 Warning javadoc JavadocStyle First sentence should end with a period. 628
 Warning misc FinalParameters Parameter steps should be final. 634
 Warning coding InnerAssignment Inner assignments should be avoided. 638
 Warning design DesignForExtension Method 'render' is not designed for extension - needs to be abstract, final or empty. 715
 Warning misc FinalParameters Parameter e should be final. 863
 Warning design VisibilityModifier Variable 'testPanel' must be private and have accessor methods. 872
 Warning design VisibilityModifier Variable 'checkBoxPanel' must be private and have accessor methods. 875

org/opentrafficsim/trafficcontrol/trafcod/TrafCOD.java

Severity Category Rule Message Line
 Warning sizes FileLength File length is 2,892 lines (max allowed is 2,000). 1
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 73
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 76
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 79
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 82
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 85
 Warning design VisibilityModifier Variable 'trafcodRules' must be private and have accessor methods. 88
 Warning design VisibilityModifier Variable 'tokenisedRules' must be private and have accessor methods. 91
 Warning design VisibilityModifier Variable 'variables' must be private and have accessor methods. 94
 Warning design VisibilityModifier Variable 'variablesInDefinitionOrder' must be private and have accessor methods. 97
 Warning design VisibilityModifier Variable 'detectors' must be private and have accessor methods. 100
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 103
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 106
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 109
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 112
 Warning design VisibilityModifier Variable 'numberOfConflictGroups' must be private and have accessor methods. 115
 Warning javadoc JavadocStyle First sentence should end with a period. 138
 Warning misc FinalParameters Parameter controllerName should be final. 159
 Warning misc FinalParameters Parameter display should be final. 159
 Warning misc FinalParameters Parameter controllerName should be final. 227
 Warning misc FinalParameters Parameter display should be final. 227
 Info sizes MethodLength Method length is 155 lines (max allowed is 150). 261
 Warning design DesignForExtension Method 'checkConsistency' is not designed for extension - needs to be abstract, final or empty. 424
 Info sizes MethodLength Method length is 154 lines (max allowed is 150). 424
 Warning naming StaticVariableName Name 'BIND_UNARY_MINUS' must match pattern '^[a-z][a-zA-Z0-9]*$'. 988
 Warning misc FinalParameters Parameter tokens should be final. 1244
 Info sizes MethodLength Method length is 269 lines (max allowed is 150). 1455
 Warning misc FinalParameters Parameter name should be final. 1766
 Warning misc FinalParameters Parameter stream should be final. 1766
 Warning misc FinalParameters Parameter flags should be final. 1766
 Warning misc FinalParameters Parameter location should be final. 1766
 Warning design DesignForExtension Method 'getSimulator' is not designed for extension - needs to be abstract, final or empty. 1804
 Warning design DesignForExtension Method 'getStructureNumber' is not designed for extension - needs to be abstract, final or empty. 1813
 Warning design DesignForExtension Method 'updateDetector' is not designed for extension - needs to be abstract, final or empty. 1819
 Warning misc FinalParameters Parameter detectorId should be final. 1820
 Warning misc FinalParameters Parameter detectingGTU should be final. 1820
 Warning design DesignForExtension Method 'traceVariablesOfStream' is not designed for extension - needs to be abstract, final or empty. 1836
 Warning design DesignForExtension Method 'traceVariable' is not designed for extension - needs to be abstract, final or empty. 1861
 Warning design DesignForExtension Method 'notify' is not designed for extension - needs to be abstract, final or empty. 1880
 Warning misc FinalParameters Parameter event should be final. 1881
 Warning design DesignForExtension Method 'fireTrafCODEvent' is not designed for extension - needs to be abstract, final or empty. 1949
 Warning design DesignForExtension Method 'getFullId' is not designed for extension - needs to be abstract, final or empty. 1955
 Warning modifier RedundantModifier Redundant 'public' modifier. 2039
 Warning design VisibilityModifier Variable 'flags' must be private and have accessor methods. 2165
 Warning design VisibilityModifier Variable 'value' must be private and have accessor methods. 2168
 Warning design VisibilityModifier Variable 'timerMax10' must be private and have accessor methods. 2171
 Warning design VisibilityModifier Variable 'color' must be private and have accessor methods. 2174
 Warning design VisibilityModifier Variable 'name' must be private and have accessor methods. 2177
 Warning javadoc JavadocStyle First sentence should end with a period. 2179
 Warning design VisibilityModifier Variable 'stream' must be private and have accessor methods. 2180
 Warning design VisibilityModifier Variable 'refCount' must be private and have accessor methods. 2183
 Warning design VisibilityModifier Variable 'updateTime10' must be private and have accessor methods. 2186
 Warning design VisibilityModifier Variable 'startSource' must be private and have accessor methods. 2189
 Warning design VisibilityModifier Variable 'endSource' must be private and have accessor methods. 2192
 Warning naming StaticVariableName Name 'ROWLETTERS' must match pattern '^[a-z][a-zA-Z0-9]*$'. 2198
 Warning modifier RedundantModifier Redundant 'public' modifier. 2236
 Warning misc FinalParameters Parameter trafCOD should be final. 2236
 Warning misc FinalParameters Parameter sensor should be final. 2270
 Warning misc FinalParameters Parameter newValue should be final. 2392
 Warning misc FinalParameters Parameter timeStamp10 should be final. 2392
 Warning misc FinalParameters Parameter cause should be final. 2392
 Warning misc FinalParameters Parameter trafCOD should be final. 2392
 Warning coding HiddenField 'trafCOD' hides a field. 2392
 Warning misc FinalParameters Parameter colorValue should be final. 2546
 Warning misc FinalParameters Parameter value10 should be final. 2595
 Warning misc FinalParameters Parameter startSource should be final. 2619
 Warning misc FinalParameters Parameter endSource should be final. 2643
 Warning misc FinalParameters Parameter printFlags should be final. 2674
 Warning misc FinalParameters Parameter event should be final. 2783
 Warning design VisibilityModifier Variable 'cause' must be private and have accessor methods. 2804
 Warning modifier RedundantModifier Redundant 'public' modifier. 2810

org/opentrafficsim/trafficcontrol/trafcod/TrafCODDisplay.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'defaultInitialDelay' must be private and have accessor methods. 54
 Warning design DesignForExtension Method 'getDetectorImage' is not designed for extension - needs to be abstract, final or empty. 74
 Warning design DesignForExtension Method 'paintComponent' is not designed for extension - needs to be abstract, final or empty. 86
 Warning design DesignForExtension Method 'addTrafCODObject' is not designed for extension - needs to be abstract, final or empty. 101
 Warning design DesignForExtension Method 'mouseDragged' is not designed for extension - needs to be abstract, final or empty. 107
 Warning misc FinalParameters Parameter e should be final. 108
 Warning design DesignForExtension Method 'mouseMoved' is not designed for extension - needs to be abstract, final or empty. 114
 Warning misc FinalParameters Parameter e should be final. 115
 Warning misc FinalParameters Parameter e should be final. 132
 Warning misc FinalParameters Parameter e should be final. 139
 Warning misc FinalParameters Parameter e should be final. 146
 Warning design DesignForExtension Method 'mouseEntered' is not designed for extension - needs to be abstract, final or empty. 152
 Warning misc FinalParameters Parameter e should be final. 153
 Warning design DesignForExtension Method 'mouseExited' is not designed for extension - needs to be abstract, final or empty. 159
 Warning misc FinalParameters Parameter e should be final. 160
 Warning javadoc JavadocStyle First sentence should end with a period. 173
 Warning naming ConstantName Name 'xOffset' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 217
 Warning naming ConstantName Name 'yOffset' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 220
 Warning modifier RedundantModifier Redundant 'public' modifier. 229
 Warning misc FinalParameters Parameter center should be final. 229
 Warning misc FinalParameters Parameter id should be final. 229
 Warning misc FinalParameters Parameter description should be final. 229
 Warning misc FinalParameters Parameter g2 should be final. 241
 Warning misc FinalParameters Parameter event should be final. 251
 Warning modifier RedundantModifier Redundant 'public' modifier. 314
 Warning misc FinalParameters Parameter testX should be final. 325
 Warning misc FinalParameters Parameter testY should be final. 325
 Warning misc FinalParameters Parameter listener should be final. 400
 Warning misc FinalParameters Parameter eventType should be final. 400
 Warning misc FinalParameters Parameter listener should be final. 407
 Warning misc FinalParameters Parameter eventType should be final. 407
 Warning misc FinalParameters Parameter weak should be final. 407
 Warning misc FinalParameters Parameter listener should be final. 414
 Warning misc FinalParameters Parameter eventType should be final. 414
 Warning misc FinalParameters Parameter position should be final. 414
 Warning misc FinalParameters Parameter listener should be final. 421
 Warning misc FinalParameters Parameter eventType should be final. 421
 Warning misc FinalParameters Parameter position should be final. 421
 Warning misc FinalParameters Parameter weak should be final. 421
 Warning misc FinalParameters Parameter listener should be final. 429
 Warning misc FinalParameters Parameter eventType should be final. 429
 Warning misc FinalParameters Parameter trafficLightColor should be final. 443
 Warning misc FinalParameters Parameter g2 should be final. 454