Checkstyle Results

The following document contains the results of Checkstyle 6.18 with development/dsol-checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
65 8 204 0

Files

File  I  W  E
org/opentrafficsim/water/AbstractLocated.java 0 1 0
org/opentrafficsim/water/demand/Container.java 0 1 0
org/opentrafficsim/water/network/StudyArea.java 0 6 0
org/opentrafficsim/water/role/Company.java 0 1 0
org/opentrafficsim/water/statistics/ContainerTransportCO2BreakdownEnum.java 4 10 0
org/opentrafficsim/water/statistics/ContainerTransportCostBreakdownEnum.java 0 13 0
org/opentrafficsim/water/statistics/ContainerTransportFeeBreakdownEnum.java 0 10 0
org/opentrafficsim/water/statistics/ContainerTransportTimeBreakdownEnum.java 4 10 0
org/opentrafficsim/water/statistics/DirectionEnum.java 0 5 0
org/opentrafficsim/water/statistics/FullEmptyEnum.java 0 5 0
org/opentrafficsim/water/statistics/LandWaterEnum.java 0 5 0
org/opentrafficsim/water/statistics/SailingServiceTimeBreakdownEnum.java 0 24 0
org/opentrafficsim/water/statistics/XCounter.java 0 12 0
org/opentrafficsim/water/statistics/XFrequency.java 0 29 0
org/opentrafficsim/water/statistics/XPersistent.java 0 17 0
org/opentrafficsim/water/statistics/XTally.java 0 19 0
org/opentrafficsim/water/statistics/XTimeTally.java 0 4 0
org/opentrafficsim/water/transfer/Terminal.java 0 2 0
org/opentrafficsim/water/transfer/TerminalPortTax.java 0 27 0
org/opentrafficsim/water/transport/SailingServiceType.java 0 3 0

Rules

Category Rule Violations Severity
blocks NeedBraces 11  Warning
design DesignForExtension 52  Warning
VisibilityModifier 7  Warning
javadoc JavadocMethod 8  Warning
JavadocStyle
  • checkHtml: "false"
 43  Warning
JavadocType 1  Warning
JavadocVariable 62  Warning
misc FinalParameters 11  Warning
TodoComment 1  Warning
modifier RedundantModifier 8  Warning
sizes LineLength
  • max: "128"
 8  Info

Details

org/opentrafficsim/water/AbstractLocated.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'getBounds' is not designed for extension - needs to be abstract, final or empty. 52

org/opentrafficsim/water/demand/Container.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 247

org/opentrafficsim/water/network/StudyArea.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle First sentence should end with a period. 28
 Warning javadoc JavadocStyle First sentence should end with a period. 31
 Warning design DesignForExtension Method 'addTerminal' is not designed for extension - needs to be abstract, final or empty. 45
 Warning design DesignForExtension Method 'getCode' is not designed for extension - needs to be abstract, final or empty. 53
 Warning design DesignForExtension Method 'getTerminals' is not designed for extension - needs to be abstract, final or empty. 61
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 69

org/opentrafficsim/water/role/Company.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'code' must be private and have accessor methods. 22

org/opentrafficsim/water/statistics/ContainerTransportCO2BreakdownEnum.java

Severity Category Rule Message Line
 Warning javadoc JavadocVariable Missing a Javadoc comment. 19
 Warning javadoc JavadocVariable Missing a Javadoc comment. 21
 Info sizes LineLength Line is longer than 128 characters (found 171). 22
 Warning javadoc JavadocVariable Missing a Javadoc comment. 24
 Info sizes LineLength Line is longer than 128 characters (found 201). 25
 Warning javadoc JavadocVariable Missing a Javadoc comment. 27
 Info sizes LineLength Line is longer than 128 characters (found 135). 28
 Warning javadoc JavadocVariable Missing a Javadoc comment. 30
 Info sizes LineLength Line is longer than 128 characters (found 161). 31
 Warning javadoc JavadocVariable Missing a Javadoc comment. 33
 Warning javadoc JavadocVariable Missing a Javadoc comment. 35
 Warning javadoc JavadocStyle First sentence should end with a period. 37
 Warning javadoc JavadocStyle First sentence should end with a period. 40
 Warning modifier RedundantModifier Redundant 'private' modifier. 47

org/opentrafficsim/water/statistics/ContainerTransportCostBreakdownEnum.java

Severity Category Rule Message Line
 Warning javadoc JavadocVariable Missing a Javadoc comment. 19
 Warning javadoc JavadocVariable Missing a Javadoc comment. 21
 Warning javadoc JavadocVariable Missing a Javadoc comment. 25
 Warning javadoc JavadocVariable Missing a Javadoc comment. 28
 Warning javadoc JavadocVariable Missing a Javadoc comment. 32
 Warning javadoc JavadocVariable Missing a Javadoc comment. 34
 Warning javadoc JavadocVariable Missing a Javadoc comment. 38
 Warning javadoc JavadocVariable Missing a Javadoc comment. 42
 Warning javadoc JavadocVariable Missing a Javadoc comment. 44
 Warning javadoc JavadocVariable Missing a Javadoc comment. 47
 Warning javadoc JavadocStyle First sentence should end with a period. 49
 Warning javadoc JavadocStyle First sentence should end with a period. 52
 Warning modifier RedundantModifier Redundant 'private' modifier. 59

org/opentrafficsim/water/statistics/ContainerTransportFeeBreakdownEnum.java

Severity Category Rule Message Line
 Warning javadoc JavadocVariable Missing a Javadoc comment. 19
 Warning javadoc JavadocVariable Missing a Javadoc comment. 21
 Warning javadoc JavadocVariable Missing a Javadoc comment. 24
 Warning javadoc JavadocVariable Missing a Javadoc comment. 28
 Warning javadoc JavadocVariable Missing a Javadoc comment. 31
 Warning javadoc JavadocVariable Missing a Javadoc comment. 35
 Warning javadoc JavadocVariable Missing a Javadoc comment. 37
 Warning javadoc JavadocStyle First sentence should end with a period. 50
 Warning javadoc JavadocStyle First sentence should end with a period. 53
 Warning modifier RedundantModifier Redundant 'private' modifier. 60

org/opentrafficsim/water/statistics/ContainerTransportTimeBreakdownEnum.java

Severity Category Rule Message Line
 Warning javadoc JavadocVariable Missing a Javadoc comment. 19
 Warning javadoc JavadocVariable Missing a Javadoc comment. 21
 Info sizes LineLength Line is longer than 128 characters (found 168). 22
 Warning javadoc JavadocVariable Missing a Javadoc comment. 24
 Info sizes LineLength Line is longer than 128 characters (found 160). 25
 Warning javadoc JavadocVariable Missing a Javadoc comment. 27
 Warning javadoc JavadocVariable Missing a Javadoc comment. 29
 Info sizes LineLength Line is longer than 128 characters (found 135). 30
 Warning javadoc JavadocVariable Missing a Javadoc comment. 32
 Info sizes LineLength Line is longer than 128 characters (found 154). 33
 Warning javadoc JavadocVariable Missing a Javadoc comment. 35
 Warning javadoc JavadocStyle First sentence should end with a period. 37
 Warning javadoc JavadocStyle First sentence should end with a period. 40
 Warning modifier RedundantModifier Redundant 'private' modifier. 47

org/opentrafficsim/water/statistics/DirectionEnum.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle First sentence should end with a period. 18
 Warning javadoc JavadocStyle First sentence should end with a period. 21
 Warning javadoc JavadocStyle First sentence should end with a period. 24
 Warning javadoc JavadocStyle First sentence should end with a period. 27
 Warning modifier RedundantModifier Redundant 'private' modifier. 33

org/opentrafficsim/water/statistics/FullEmptyEnum.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle First sentence should end with a period. 18
 Warning javadoc JavadocStyle First sentence should end with a period. 21
 Warning javadoc JavadocStyle First sentence should end with a period. 24
 Warning javadoc JavadocStyle First sentence should end with a period. 27
 Warning modifier RedundantModifier Redundant 'private' modifier. 33

org/opentrafficsim/water/statistics/LandWaterEnum.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle First sentence should end with a period. 18
 Warning javadoc JavadocStyle First sentence should end with a period. 21
 Warning javadoc JavadocStyle First sentence should end with a period. 24
 Warning javadoc JavadocStyle First sentence should end with a period. 27
 Warning modifier RedundantModifier Redundant 'private' modifier. 33

org/opentrafficsim/water/statistics/SailingServiceTimeBreakdownEnum.java

Severity Category Rule Message Line
 Warning javadoc JavadocVariable Missing a Javadoc comment. 19
 Warning javadoc JavadocVariable Missing a Javadoc comment. 21
 Warning javadoc JavadocVariable Missing a Javadoc comment. 23
 Warning javadoc JavadocVariable Missing a Javadoc comment. 26
 Warning javadoc JavadocVariable Missing a Javadoc comment. 28
 Warning javadoc JavadocVariable Missing a Javadoc comment. 30
 Warning javadoc JavadocVariable Missing a Javadoc comment. 32
 Warning javadoc JavadocVariable Missing a Javadoc comment. 34
 Warning javadoc JavadocVariable Missing a Javadoc comment. 36
 Warning javadoc JavadocVariable Missing a Javadoc comment. 38
 Warning javadoc JavadocVariable Missing a Javadoc comment. 40
 Warning javadoc JavadocVariable Missing a Javadoc comment. 42
 Warning javadoc JavadocVariable Missing a Javadoc comment. 44
 Warning javadoc JavadocVariable Missing a Javadoc comment. 46
 Warning javadoc JavadocVariable Missing a Javadoc comment. 48
 Warning javadoc JavadocVariable Missing a Javadoc comment. 50
 Warning javadoc JavadocVariable Missing a Javadoc comment. 52
 Warning javadoc JavadocVariable Missing a Javadoc comment. 54
 Warning javadoc JavadocVariable Missing a Javadoc comment. 56
 Warning javadoc JavadocVariable Missing a Javadoc comment. 58
 Warning javadoc JavadocVariable Missing a Javadoc comment. 60
 Warning javadoc JavadocStyle First sentence should end with a period. 62
 Warning javadoc JavadocStyle First sentence should end with a period. 65
 Warning modifier RedundantModifier Redundant 'private' modifier. 72

org/opentrafficsim/water/statistics/XCounter.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'count' must be private and have accessor methods. 32
 Warning design VisibilityModifier Variable 'n' must be private and have accessor methods. 35
 Warning design VisibilityModifier Variable 'description' must be private and have accessor methods. 38
 Warning design DesignForExtension Method 'getCount' is not designed for extension - needs to be abstract, final or empty. 58
 Warning design DesignForExtension Method 'getN' is not designed for extension - needs to be abstract, final or empty. 67
 Warning design DesignForExtension Method 'count' is not designed for extension - needs to be abstract, final or empty. 75
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 87
 Warning design DesignForExtension Method 'initialize' is not designed for extension - needs to be abstract, final or empty. 96
 Warning design DesignForExtension Method 'isInitialized' is not designed for extension - needs to be abstract, final or empty. 109
 Warning javadoc JavadocStyle First sentence should end with a period. 123
 Warning design DesignForExtension Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. 136
 Warning design DesignForExtension Method 'writeToExcel' is not designed for extension - needs to be abstract, final or empty. 147

org/opentrafficsim/water/statistics/XFrequency.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle First sentence should end with a period. 33
 Warning design VisibilityModifier Variable 'frequency' must be private and have accessor methods. 34
 Warning javadoc JavadocStyle First sentence should end with a period. 36
 Warning design VisibilityModifier Variable 'n' must be private and have accessor methods. 37
 Warning javadoc JavadocStyle First sentence should end with a period. 39
 Warning design VisibilityModifier Variable 'description' must be private and have accessor methods. 40
 Warning javadoc JavadocStyle First sentence should end with a period. 42
 Warning misc FinalParameters Parameter description should be final. 49
 Warning javadoc JavadocStyle First sentence should end with a period. 55
 Warning design DesignForExtension Method 'getFrequency' is not designed for extension - needs to be abstract, final or empty. 60
 Warning javadoc JavadocStyle First sentence should end with a period. 65
 Warning design DesignForExtension Method 'getFrequencies' is not designed for extension - needs to be abstract, final or empty. 69
 Warning javadoc JavadocStyle First sentence should end with a period. 74
 Warning design DesignForExtension Method 'getN' is not designed for extension - needs to be abstract, final or empty. 78
 Warning javadoc JavadocStyle First sentence should end with a period. 83
 Warning design DesignForExtension Method 'count' is not designed for extension - needs to be abstract, final or empty. 88
 Warning blocks NeedBraces 'if' construct must use '{}'s. 92
 Warning blocks NeedBraces 'else' construct must use '{}'s. 94
 Warning javadoc JavadocStyle First sentence should end with a period. 100
 Warning design DesignForExtension Method 'count' is not designed for extension - needs to be abstract, final or empty. 104
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 112
 Warning javadoc JavadocStyle First sentence should end with a period. 118
 Warning design DesignForExtension Method 'initialize' is not designed for extension - needs to be abstract, final or empty. 121
 Warning design DesignForExtension Method 'isInitialized' is not designed for extension - needs to be abstract, final or empty. 134
 Warning javadoc JavadocStyle First sentence should end with a period. 139
 Warning javadoc JavadocStyle First sentence should end with a period. 148
 Warning design DesignForExtension Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. 152
 Warning javadoc JavadocStyle First sentence should end with a period. 157
 Warning design DesignForExtension Method 'writeToExcel' is not designed for extension - needs to be abstract, final or empty. 163

org/opentrafficsim/water/statistics/XPersistent.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle First sentence should end with a period. 37
 Warning javadoc JavadocStyle First sentence should end with a period. 41
 Warning javadoc JavadocStyle First sentence should end with a period. 44
 Warning misc FinalParameters Parameter description should be final. 52
 Warning misc FinalParameters Parameter simulator should be final. 52
 Warning design DesignForExtension Method 'getSampleMean' is not designed for extension - needs to be abstract, final or empty. 59
 Warning blocks NeedBraces 'if' construct must use '{}'s. 62
 Warning blocks NeedBraces 'else' construct must use '{}'s. 64
 Warning design DesignForExtension Method 'getStdDev' is not designed for extension - needs to be abstract, final or empty. 69
 Warning design DesignForExtension Method 'getSampleVariance' is not designed for extension - needs to be abstract, final or empty. 83
 Warning design DesignForExtension Method 'initialize' is not designed for extension - needs to be abstract, final or empty. 97
 Warning javadoc JavadocStyle First sentence should end with a period. 108
 Warning design DesignForExtension Method 'persist' is not designed for extension - needs to be abstract, final or empty. 112
 Warning blocks NeedBraces 'if' construct must use '{}'s. 120
 Warning blocks NeedBraces 'if' construct must use '{}'s. 122
 Warning blocks NeedBraces 'if' construct must use '{}'s. 125
 Warning design DesignForExtension Method 'writeToExcel' is not designed for extension - needs to be abstract, final or empty. 145

org/opentrafficsim/water/statistics/XTally.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'getSampleMean' is not designed for extension - needs to be abstract, final or empty. 89
 Warning blocks NeedBraces 'if' construct must use '{}'s. 91
 Warning blocks NeedBraces 'else' construct must use '{}'s. 93
 Warning design DesignForExtension Method 'getConfidenceInterval' is not designed for extension - needs to be abstract, final or empty. 103
 Warning design DesignForExtension Method 'getConfidenceInterval' is not designed for extension - needs to be abstract, final or empty. 115
 Warning design DesignForExtension Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. 157
 Warning design DesignForExtension Method 'getMax' is not designed for extension - needs to be abstract, final or empty. 166
 Warning design DesignForExtension Method 'getMin' is not designed for extension - needs to be abstract, final or empty. 175
 Warning design DesignForExtension Method 'getN' is not designed for extension - needs to be abstract, final or empty. 184
 Warning design DesignForExtension Method 'getStdDev' is not designed for extension - needs to be abstract, final or empty. 193
 Warning design DesignForExtension Method 'getSum' is not designed for extension - needs to be abstract, final or empty. 209
 Warning design DesignForExtension Method 'getSampleVariance' is not designed for extension - needs to be abstract, final or empty. 218
 Warning design DesignForExtension Method 'initialize' is not designed for extension - needs to be abstract, final or empty. 233
 Warning design DesignForExtension Method 'isInitialized' is not designed for extension - needs to be abstract, final or empty. 249
 Warning design DesignForExtension Method 'tally' is not designed for extension - needs to be abstract, final or empty. 258
 Warning blocks NeedBraces 'if' construct must use '{}'s. 267
 Warning blocks NeedBraces 'if' construct must use '{}'s. 269
 Warning design DesignForExtension Method 'writeToExcel' is not designed for extension - needs to be abstract, final or empty. 281
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 314

org/opentrafficsim/water/statistics/XTimeTally.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter description should be final. 34
 Warning misc FinalParameters Parameter simulator should be final. 34
 Warning javadoc JavadocStyle First sentence should end with a period. 40
 Warning design DesignForExtension Method 'tally' is not designed for extension - needs to be abstract, final or empty. 44

org/opentrafficsim/water/transfer/Terminal.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter name should be final. 25
 Warning misc FinalParameters Parameter location should be final. 25

org/opentrafficsim/water/transfer/TerminalPortTax.java

Severity Category Rule Message Line
 Warning javadoc JavadocType Missing a Javadoc comment. 3
 Warning javadoc JavadocVariable Missing a Javadoc comment. 6
 Warning javadoc JavadocVariable Missing a Javadoc comment. 8
 Warning javadoc JavadocVariable Missing a Javadoc comment. 10
 Warning javadoc JavadocVariable Missing a Javadoc comment. 12
 Warning javadoc JavadocVariable Missing a Javadoc comment. 14
 Warning javadoc JavadocVariable Missing a Javadoc comment. 16
 Warning javadoc JavadocVariable Missing a Javadoc comment. 18
 Warning javadoc JavadocMethod Missing a Javadoc comment. 20
 Warning misc FinalParameters Parameter feePortPerFullMove should be final. 20
 Warning misc FinalParameters Parameter feePortPerEmptyMove should be final. 20
 Warning misc FinalParameters Parameter feePortPerDWT should be final. 20
 Warning misc FinalParameters Parameter feeStrategy should be final. 20
 Warning design DesignForExtension Method 'getFeePortPerShipDWT' is not designed for extension - needs to be abstract, final or empty. 51
 Warning javadoc JavadocMethod Missing a Javadoc comment. 51
 Warning design DesignForExtension Method 'getFeePortPerFullMove' is not designed for extension - needs to be abstract, final or empty. 57
 Warning javadoc JavadocMethod Missing a Javadoc comment. 57
 Warning design DesignForExtension Method 'getFeePortPerEmptyMove' is not designed for extension - needs to be abstract, final or empty. 62
 Warning javadoc JavadocMethod Missing a Javadoc comment. 62
 Warning design DesignForExtension Method 'isUsePortFeePerEmptyMove' is not designed for extension - needs to be abstract, final or empty. 67
 Warning javadoc JavadocMethod Missing a Javadoc comment. 67
 Warning design DesignForExtension Method 'isUsePortFeePerFullMove' is not designed for extension - needs to be abstract, final or empty. 72
 Warning javadoc JavadocMethod Missing a Javadoc comment. 72
 Warning design DesignForExtension Method 'isUsePortFeePerShipDWT' is not designed for extension - needs to be abstract, final or empty. 77
 Warning javadoc JavadocMethod Missing a Javadoc comment. 77
 Warning design DesignForExtension Method 'getFeeStrategy' is not designed for extension - needs to be abstract, final or empty. 82
 Warning javadoc JavadocMethod Missing a Javadoc comment. 82

org/opentrafficsim/water/transport/SailingServiceType.java

Severity Category Rule Message Line
 Warning javadoc JavadocVariable Missing a Javadoc comment. 20
 Warning javadoc JavadocVariable Missing a Javadoc comment. 21
 Warning javadoc JavadocVariable Missing a Javadoc comment. 22