SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

SpotBugs Version is 3.1.12

Threshold is medium

Effort is default

Summary

Classes Bugs Errors Missing Classes
302 65 0 0

Files

Class Bugs
org.opentrafficsim.core.compatibility.GTUCompatibility 2
org.opentrafficsim.core.distributions.Distribution 1
org.opentrafficsim.core.dsol.OTSDEVSRTParallelMove 1
org.opentrafficsim.core.dsol.OTSLoggingAnimator 1
org.opentrafficsim.core.dsol.OTSReplication 1
org.opentrafficsim.core.egtf.EGTF 1
org.opentrafficsim.core.egtf.EGTF$DualWeightedMean 1
org.opentrafficsim.core.egtf.EGTF$WeightedMean 1
org.opentrafficsim.core.egtf.FilterDouble 2
org.opentrafficsim.core.geometry.OTS2DSet 1
org.opentrafficsim.core.geometry.OTS2DSet$QuadTreeIterator 1
org.opentrafficsim.core.geometry.OTS2DSet$QuadTreeNode 1
org.opentrafficsim.core.geometry.OTSLine3D 2
org.opentrafficsim.core.geometry.OTSShape 1
org.opentrafficsim.core.gtu.AbstractGTU 3
org.opentrafficsim.core.gtu.GTUDumper 2
org.opentrafficsim.core.gtu.GTUType 3
org.opentrafficsim.core.gtu.perception.AbstractPerception 2
org.opentrafficsim.core.gtu.plan.operational.OperationalPlan 2
org.opentrafficsim.core.gtu.plan.operational.OperationalPlan$SegmentProgress 2
org.opentrafficsim.core.math.Draw 1
org.opentrafficsim.core.network.CapacityOTSLink 1
org.opentrafficsim.core.network.DirectedLinkPosition 1
org.opentrafficsim.core.network.LinkType 2
org.opentrafficsim.core.network.LinkType$ReversedLinkType 1
org.opentrafficsim.core.network.OTSNetwork 4
org.opentrafficsim.core.network.OTSNetworkUtils 1
org.opentrafficsim.core.network.OTSNode 1
org.opentrafficsim.core.network.factory.xml.units.AccelerationUnits 1
org.opentrafficsim.core.network.factory.xml.units.AngleUnits 2
org.opentrafficsim.core.network.factory.xml.units.DurationUnits 2
org.opentrafficsim.core.network.factory.xml.units.LengthUnits 2
org.opentrafficsim.core.network.factory.xml.units.PositionUnits 1
org.opentrafficsim.core.network.factory.xml.units.SpeedUnits 1
org.opentrafficsim.core.network.factory.xml.units.TimeUnits 1
org.opentrafficsim.core.network.route.FixedRouteGenerator 1
org.opentrafficsim.core.parameters.ParameterFactoryByType 2
org.opentrafficsim.core.parameters.ParameterFactoryByType$DistributedEntry 2
org.opentrafficsim.core.parameters.ParameterFactoryByType$DistributedEntryDouble 2
org.opentrafficsim.core.parameters.ParameterFactoryByType$DistributedEntryInteger 2
org.opentrafficsim.core.parameters.ParameterFactoryByType$FixedEntry 2
org.opentrafficsim.core.perception.collections.AbstractHistoricalList 1

org.opentrafficsim.core.compatibility.GTUCompatibility

Bug Category Details Line Priority
org.opentrafficsim.core.compatibility.GTUCompatibility.isCompatible(GTUType, GTUDirectionality) has Boolean return type and returns explicit null BAD_PRACTICE NP_BOOLEAN_RETURN_NULL 69 High
org.opentrafficsim.core.compatibility.GTUCompatibility.isCompatibleWith(Compatibility, boolean) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 176 Medium

org.opentrafficsim.core.distributions.Distribution

Bug Category Details Line Priority
Null passed for non-null parameter of java.util.List.addAll(Collection) in new org.opentrafficsim.core.distributions.Distribution(List, StreamInterface) CORRECTNESS NP_NULL_PARAM_DEREF 48 High

org.opentrafficsim.core.dsol.OTSDEVSRTParallelMove

Bug Category Details Line Priority
Class org.opentrafficsim.core.dsol.OTSDEVSRTParallelMove defines non-transient non-serializable instance field executor BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.core.dsol.OTSLoggingAnimator

Bug Category Details Line Priority
Class org.opentrafficsim.core.dsol.OTSLoggingAnimator defines non-transient non-serializable instance field animationThread BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.core.dsol.OTSReplication

Bug Category Details Line Priority
org.opentrafficsim.core.perception.HistoryManagerDEVS stored into non-transient field OTSReplication.historyManager BAD_PRACTICE SE_BAD_FIELD_STORE 72 Medium

org.opentrafficsim.core.egtf.EGTF

Bug Category Details Line Priority
Possible null pointer dereference of wMean in org.opentrafficsim.core.egtf.EGTF.filterSI(double[], double[], Quantity[]) CORRECTNESS NP_NULL_ON_SOME_PATH 663 Medium

org.opentrafficsim.core.egtf.EGTF$DualWeightedMean

Bug Category Details Line Priority
Should org.opentrafficsim.core.egtf.EGTF$DualWeightedMean be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 1067-1143 Medium

org.opentrafficsim.core.egtf.EGTF$WeightedMean

Bug Category Details Line Priority
Should org.opentrafficsim.core.egtf.EGTF$WeightedMean be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 1152-1184 Medium

org.opentrafficsim.core.egtf.FilterDouble

Bug Category Details Line Priority
org.opentrafficsim.core.egtf.FilterDouble.getLocation() may expose internal representation by returning FilterDouble.location MALICIOUS_CODE EI_EXPOSE_REP 44 Medium
org.opentrafficsim.core.egtf.FilterDouble.getTime() may expose internal representation by returning FilterDouble.time MALICIOUS_CODE EI_EXPOSE_REP 51 Medium

org.opentrafficsim.core.geometry.OTS2DSet

Bug Category Details Line Priority
Possible null pointer dereference of boundingBox in new org.opentrafficsim.core.geometry.OTS2DSet(Rectangle2D, double) CORRECTNESS NP_NULL_ON_SOME_PATH 60 High

org.opentrafficsim.core.geometry.OTS2DSet$QuadTreeIterator

Bug Category Details Line Priority
org.opentrafficsim.core.geometry.OTS2DSet$QuadTreeIterator is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 276-319 Medium

org.opentrafficsim.core.geometry.OTS2DSet$QuadTreeNode

Bug Category Details Line Priority
org.opentrafficsim.core.geometry.OTS2DSet$QuadTreeNode is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 333-759 Medium

org.opentrafficsim.core.geometry.OTSLine3D

Bug Category Details Line Priority
org.opentrafficsim.core.geometry.OTSLine3D.getPoints() may expose internal representation by returning OTSLine3D.points MALICIOUS_CODE EI_EXPOSE_REP 893 Medium
Test for floating point equality in org.opentrafficsim.core.geometry.OTSLine3D.extract(double, double) STYLE FE_FLOATING_POINT_EQUALITY 614 High

org.opentrafficsim.core.geometry.OTSShape

Bug Category Details Line Priority
org.opentrafficsim.core.geometry.OTSShape doesn't override OTSLine3D.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium

org.opentrafficsim.core.gtu.AbstractGTU

Bug Category Details Line Priority
org.opentrafficsim.core.gtu.AbstractGTU.ALIGN_COUNT should be package protected MALICIOUS_CODE MS_PKGPROTECT 107 Medium
org.opentrafficsim.core.gtu.AbstractGTU.ALIGNED isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 103 High
Write to static field org.opentrafficsim.core.gtu.AbstractGTU.staticUNIQUENUMBER from instance method new org.opentrafficsim.core.gtu.AbstractGTU(String, GTUType, OTSSimulatorInterface, PerceivableContext) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 150 Medium

org.opentrafficsim.core.gtu.GTUDumper

Bug Category Details Line Priority
Found reliance on default encoding in org.opentrafficsim.core.gtu.GTUDumper.dump(): new java.io.PrintWriter(File) I18N DM_DEFAULT_ENCODING 36 High
Format string should use %n rather than \n in org.opentrafficsim.core.gtu.GTUDumper.dump() BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 40 Medium

org.opentrafficsim.core.gtu.GTUType

Bug Category Details Line Priority
GTUType is incompatible with expected argument type GTUType$DEFAULTS in org.opentrafficsim.core.gtu.GTUType.defaultCharacteristics(GTUType, Network, StreamInterface) CORRECTNESS GC_UNRELATED_TYPES 203 High
GTUType is incompatible with expected argument type GTUType$DEFAULTS in org.opentrafficsim.core.gtu.GTUType.defaultCharacteristics(GTUType, Network, StreamInterface) CORRECTNESS GC_UNRELATED_TYPES 205 High
org.opentrafficsim.core.gtu.GTUType is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 131-280 High

org.opentrafficsim.core.gtu.perception.AbstractPerception

Bug Category Details Line Priority
org.opentrafficsim.core.gtu.perception.AbstractPerception.contains(Class) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 80 Medium
org.opentrafficsim.core.gtu.perception.AbstractPerception.getPerceptionCategoryOrNull(Class) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 116 Medium

org.opentrafficsim.core.gtu.plan.operational.OperationalPlan

Bug Category Details Line Priority
Dead store to p in org.opentrafficsim.core.gtu.plan.operational.OperationalPlan.getLocation(Time) STYLE DLS_DEAD_LOCAL_STORE 439 Medium
Redundant nullcheck of p, which is known to be non-null in org.opentrafficsim.core.gtu.plan.operational.OperationalPlan.timeAtPoint(DirectedPoint, boolean) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 610 Medium

org.opentrafficsim.core.gtu.plan.operational.OperationalPlan$SegmentProgress

Bug Category Details Line Priority
org.opentrafficsim.core.gtu.plan.operational.OperationalPlan$SegmentProgress is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 320-357 Medium
Should org.opentrafficsim.core.gtu.plan.operational.OperationalPlan$SegmentProgress be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 320-357 Medium

org.opentrafficsim.core.math.Draw

Bug Category Details Line Priority
org.opentrafficsim.core.math.Draw.drawWeighted(Map, StreamInterface) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 46 Medium

org.opentrafficsim.core.network.CapacityOTSLink

Bug Category Details Line Priority
org.opentrafficsim.core.network.CapacityOTSLink doesn't override OTSLink.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium

org.opentrafficsim.core.network.DirectedLinkPosition

Bug Category Details Line Priority
org.opentrafficsim.core.network.DirectedLinkPosition doesn't override LinkDirection.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium

org.opentrafficsim.core.network.LinkType

Bug Category Details Line Priority
Class org.opentrafficsim.core.network.LinkType defines non-transient non-serializable instance field compatibility BAD_PRACTICE SE_BAD_FIELD Not available High
org.opentrafficsim.core.network.LinkType is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 25-202 High

org.opentrafficsim.core.network.LinkType$ReversedLinkType

Bug Category Details Line Priority
Should org.opentrafficsim.core.network.LinkType$ReversedLinkType be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 217-248 Medium

org.opentrafficsim.core.network.OTSNetwork

Bug Category Details Line Priority
org.opentrafficsim.core.network.OTSNetwork.buildGraph(GTUType, LinkWeight) allocates an object, only to get the class object PERFORMANCE DM_NEW_FOR_GETCLASS 620 Medium
Class org.opentrafficsim.core.network.OTSNetwork defines non-transient non-serializable instance field invisibleObjectMap BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.opentrafficsim.core.network.OTSNetwork.getObjectMap(Class) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 306 Medium
org.opentrafficsim.core.network.OTSNetwork.getRoute(String) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 556 Medium

org.opentrafficsim.core.network.OTSNetworkUtils

Bug Category Details Line Priority
Return value of OTSNode.clone1(Network, SimulatorInterface$TimeDoubleUnit) ignored, is this OK in org.opentrafficsim.core.network.OTSNetworkUtils.clone(OTSNetwork, String, SimulatorInterface$TimeDoubleUnit, OTSSimulatorInterface) STYLE RV_RETURN_VALUE_IGNORED_INFERRED 50 Medium

org.opentrafficsim.core.network.OTSNode

Bug Category Details Line Priority
org.opentrafficsim.core.network.OTSNode.clone2(Network, SimulatorInterface$TimeDoubleUnit) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 445 Medium

org.opentrafficsim.core.network.factory.xml.units.AccelerationUnits

Bug Category Details Line Priority
org.opentrafficsim.core.network.factory.xml.units.AccelerationUnits.ACCELERATION_UNITS is a mutable collection which should be package protected MALICIOUS_CODE MS_MUTABLE_COLLECTION_PKGPROTECT 24 Medium

org.opentrafficsim.core.network.factory.xml.units.AngleUnits

Bug Category Details Line Priority
org.opentrafficsim.core.network.factory.xml.units.AngleUnits.ANGLE_UNITS is a mutable collection which should be package protected MALICIOUS_CODE MS_MUTABLE_COLLECTION_PKGPROTECT 27 Medium
org.opentrafficsim.core.network.factory.xml.units.AngleUnits.DIRECTION_UNITS is a mutable collection which should be package protected MALICIOUS_CODE MS_MUTABLE_COLLECTION_PKGPROTECT 30 Medium

org.opentrafficsim.core.network.factory.xml.units.DurationUnits

Bug Category Details Line Priority
org.opentrafficsim.core.network.factory.xml.units.DurationUnits.DURATION_UNITS is a mutable collection which should be package protected MALICIOUS_CODE MS_MUTABLE_COLLECTION_PKGPROTECT 26 Medium
org.opentrafficsim.core.network.factory.xml.units.DurationUnits.FREQUENCY_UNITS is a mutable collection which should be package protected MALICIOUS_CODE MS_MUTABLE_COLLECTION_PKGPROTECT 29 Medium

org.opentrafficsim.core.network.factory.xml.units.LengthUnits

Bug Category Details Line Priority
org.opentrafficsim.core.network.factory.xml.units.LengthUnits.LENGTH_UNITS is a mutable collection which should be package protected MALICIOUS_CODE MS_MUTABLE_COLLECTION_PKGPROTECT 26 Medium
org.opentrafficsim.core.network.factory.xml.units.LengthUnits.PER_LENGTH_UNITS is a mutable collection which should be package protected MALICIOUS_CODE MS_MUTABLE_COLLECTION_PKGPROTECT 29 Medium

org.opentrafficsim.core.network.factory.xml.units.PositionUnits

Bug Category Details Line Priority
org.opentrafficsim.core.network.factory.xml.units.PositionUnits.POSITION_UNITS is a mutable collection which should be package protected MALICIOUS_CODE MS_MUTABLE_COLLECTION_PKGPROTECT 23 Medium

org.opentrafficsim.core.network.factory.xml.units.SpeedUnits

Bug Category Details Line Priority
org.opentrafficsim.core.network.factory.xml.units.SpeedUnits.SPEED_UNITS is a mutable collection which should be package protected MALICIOUS_CODE MS_MUTABLE_COLLECTION_PKGPROTECT 24 Medium

org.opentrafficsim.core.network.factory.xml.units.TimeUnits

Bug Category Details Line Priority
org.opentrafficsim.core.network.factory.xml.units.TimeUnits.TIME_UNITS is a mutable collection which should be package protected MALICIOUS_CODE MS_MUTABLE_COLLECTION_PKGPROTECT 23 Medium

org.opentrafficsim.core.network.route.FixedRouteGenerator

Bug Category Details Line Priority
org.opentrafficsim.core.network.route.FixedRouteGenerator is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 29-46 High

org.opentrafficsim.core.parameters.ParameterFactoryByType

Bug Category Details Line Priority
org.opentrafficsim.core.parameters.ParameterFactoryByType.setParameter(ParameterType, Object, Parameters, Map) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 187 Medium
org.opentrafficsim.core.parameters.ParameterFactoryByType.setValues(Parameters, GTUType) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 93 Medium

org.opentrafficsim.core.parameters.ParameterFactoryByType$DistributedEntry

Bug Category Details Line Priority
org.opentrafficsim.core.parameters.ParameterFactoryByType$DistributedEntry is serializable but also an inner class of a non-serializable class BAD_PRACTICE SE_BAD_FIELD_INNER_CLASS 456-496 High
Should org.opentrafficsim.core.parameters.ParameterFactoryByType$DistributedEntry be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 456-496 Medium

org.opentrafficsim.core.parameters.ParameterFactoryByType$DistributedEntryDouble

Bug Category Details Line Priority
org.opentrafficsim.core.parameters.ParameterFactoryByType$DistributedEntryDouble is serializable but also an inner class of a non-serializable class BAD_PRACTICE SE_BAD_FIELD_INNER_CLASS 512-551 High
Should org.opentrafficsim.core.parameters.ParameterFactoryByType$DistributedEntryDouble be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 512-551 Medium

org.opentrafficsim.core.parameters.ParameterFactoryByType$DistributedEntryInteger

Bug Category Details Line Priority
org.opentrafficsim.core.parameters.ParameterFactoryByType$DistributedEntryInteger is serializable but also an inner class of a non-serializable class BAD_PRACTICE SE_BAD_FIELD_INNER_CLASS 567-606 High
Should org.opentrafficsim.core.parameters.ParameterFactoryByType$DistributedEntryInteger be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 567-606 Medium

org.opentrafficsim.core.parameters.ParameterFactoryByType$FixedEntry

Bug Category Details Line Priority
org.opentrafficsim.core.parameters.ParameterFactoryByType$FixedEntry is serializable but also an inner class of a non-serializable class BAD_PRACTICE SE_BAD_FIELD_INNER_CLASS 414-437 High
Should org.opentrafficsim.core.parameters.ParameterFactoryByType$FixedEntry be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 414-437 Medium

org.opentrafficsim.core.perception.collections.AbstractHistoricalList

Bug Category Details Line Priority
org.opentrafficsim.core.perception.collections.AbstractHistoricalList.get(int) is unsynchronized, org.opentrafficsim.core.perception.collections.AbstractHistoricalList.set(int, Object) is synchronized MT_CORRECTNESS UG_SYNC_SET_UNSYNC_GET 114 Medium