PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 2

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU.java

Rule Violation Line
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 1463
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 1472

Priority 3

org/opentrafficsim/road/gtu/generator/AbstractGTUGeneratorOld.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 358378
CollapsibleIfStatements These nested if statements could be combined 418438

org/opentrafficsim/road/gtu/generator/CFRoomChecker.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 5457

org/opentrafficsim/road/gtu/generator/GeneratorPositions.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 293296
UnnecessaryModifier Unnecessary modifier 'public' on class 'ByValue': members of interface types are implicitly public 10211081
UnnecessaryModifier Unnecessary modifier 'public' on class 'BySpeed': members of interface types are implicitly public 10951180

org/opentrafficsim/road/gtu/generator/od/StrategicalPlannerFactorySupplierOD.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'TacticalPlannerFactorySupplierOD': members of interface types are implicitly public 106118

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 15711574
EmptyCatchBlock Avoid empty catch blocks 15871590

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU2.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 12361239

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedIndividualGTU.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 96

org/opentrafficsim/road/gtu/lane/perception/AbstractPerceptionReiterable.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 125
UselessQualifiedThis Useless qualified this usage in the same class. 127
UselessQualifiedThis Useless qualified this usage in the same class. 128
UselessQualifiedThis Useless qualified this usage in the same class. 132
UselessQualifiedThis Useless qualified this usage in the same class. 133
UselessQualifiedThis Useless qualified this usage in the same class. 316

org/opentrafficsim/road/gtu/lane/perception/DownstreamNeighborsIterable.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 120124

org/opentrafficsim/road/gtu/lane/perception/PerceptionCollectable.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionCollector': members of interface types are implicitly public 7695
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionAccumulator': members of interface types are implicitly public 111121
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionFinalizer': members of interface types are implicitly public 137145

org/opentrafficsim/road/gtu/lane/perception/RollingLaneStructureRecord.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 344350

org/opentrafficsim/road/gtu/lane/perception/categories/DirectDefaultSimplePerception.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 749752
CollapsibleIfStatements These nested if statements could be combined 883900

org/opentrafficsim/road/gtu/lane/perception/categories/LaneBasedAbstractPerceptionCategory.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'context'. 126

org/opentrafficsim/road/gtu/lane/perception/headway/HeadwayStopLine.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 3740

org/opentrafficsim/road/gtu/lane/plan/operational/LaneChange.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'planDistance'. 712
UnusedFormalParameter Avoid unused method parameters such as 'from'. 713
UnusedFormalParameter Avoid unused method parameters such as 'startPosition'. 713
UnusedFormalParameter Avoid unused method parameters such as 'width'. 713
UnusedFormalParameter Avoid unused method parameters such as 'toLine'. 714
UnusedFormalParameter Avoid unused method parameters such as 'fromLine'. 714
UnusedLocalVariable Avoid unused local variables such as 'f'. 726
UnusedLocalVariable Avoid unused local variables such as 'cumulLcLength'. 730

org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'startSpeed'. 469

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCFLCTacticalPlanner.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'currentLaneFine'. 151

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedGTUFollowingDirectedChangeTacticalPlanner.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 238245
UnusedFormalParameter Avoid unused method parameters such as 'lanePathInfo'. 508
UnusedFormalParameter Avoid unused method parameters such as 'perception'. 508

org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationBusStop.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 7584

org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'gtu'. 716

org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 188200
CollapsibleIfStatements These nested if statements could be combined 498514

org/opentrafficsim/road/gtu/lane/tactical/util/Steering.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'speed'. 94
UnusedLocalVariable Avoid unused local variables such as 'realPlan'. 128

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Cooperation.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'b'. 85
SimplifiedTernary Ternary operators that can be simplified with || or && 93

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsData.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 110

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsUtil.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 186203
UnusedPrivateMethod Avoid unused private methods such as 'quickIntersectionScan(Parameters,SpeedLimitInfo,CarFollowingModel,Speed,LateralDirectionality,IntersectionPerception)'. 593595

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Synchronization.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 1836
SimplifiedTernary Ternary operators that can be simplified with || or && 397398
SimplifiedTernary Ternary operators that can be simplified with || or && 414415
UnnecessaryModifier Unnecessary modifier 'public' on method 'getMergeDistance': the method is declared in an interface type 499511

org/opentrafficsim/road/network/factory/LaneFactory.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'simulator'. 388

org/opentrafficsim/road/network/lane/CrossSectionElement.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'newSimulator'. 352

org/opentrafficsim/road/network/lane/Lane.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 533537
CollapsibleIfStatements These nested if statements could be combined 573577

org/opentrafficsim/road/network/lane/LaneType.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'inverted'. 144

org/opentrafficsim/road/network/lane/NoTrafficLane.java

Rule Violation Line
UnusedPrivateMethod Avoid unused private methods such as 'directionalityNone(RoadNetwork)'. 35

org/opentrafficsim/road/network/lane/conflict/Conflict.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 417437
CollapsibleIfStatements These nested if statements could be combined 843862

org/opentrafficsim/road/network/lane/object/BusStop.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 62

org/opentrafficsim/road/network/lane/object/Distraction.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 41

org/opentrafficsim/road/network/lane/object/SpeedSign.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 62

Priority 4

org/opentrafficsim/road/gtu/generator/AbstractGTUGeneratorOld.java

Rule Violation Line
UselessParentheses Useless parentheses. 289
UselessParentheses Useless parentheses. 289
UselessParentheses Useless parentheses. 290
UselessParentheses Useless parentheses. 290

org/opentrafficsim/road/gtu/generator/GeneratorPositions.java

Rule Violation Line
UselessParentheses Useless parentheses. 915
UselessParentheses Useless parentheses. 1124

org/opentrafficsim/road/gtu/generator/od/ODApplier.java

Rule Violation Line
UselessParentheses Useless parentheses. 300

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedMoveChecker.java

Rule Violation Line
UselessParentheses Useless parentheses. 48

org/opentrafficsim/road/gtu/lane/VehicleModel.java

Rule Violation Line
UselessParentheses Useless parentheses. 44

org/opentrafficsim/road/gtu/lane/perception/DownstreamNeighborsIterable.java

Rule Violation Line
UselessParentheses Useless parentheses. 102

org/opentrafficsim/road/gtu/lane/perception/RollingLaneStructure.java

Rule Violation Line
UselessParentheses Useless parentheses. 478
UselessParentheses Useless parentheses. 1328
UselessParentheses Useless parentheses. 1329
UselessParentheses Useless parentheses. 1416
UselessParentheses Useless parentheses. 1417
UselessParentheses Useless parentheses. 1500
UselessParentheses Useless parentheses. 1501
UselessParentheses Useless parentheses. 1530
UselessParentheses Useless parentheses. 1531

org/opentrafficsim/road/gtu/lane/perception/RollingLaneStructureRecord.java

Rule Violation Line
UselessParentheses Useless parentheses. 344345
UselessParentheses Useless parentheses. 346347

org/opentrafficsim/road/gtu/lane/perception/UpstreamNeighborsIterable.java

Rule Violation Line
UselessParentheses Useless parentheses. 75

org/opentrafficsim/road/gtu/lane/perception/categories/DirectDefaultSimplePerception.java

Rule Violation Line
UselessParentheses Useless parentheses. 952
UselessParentheses Useless parentheses. 952
UselessParentheses Useless parentheses. 953
UselessParentheses Useless parentheses. 953

org/opentrafficsim/road/gtu/lane/perception/categories/DirectInfrastructurePerception.java

Rule Violation Line
UselessParentheses Useless parentheses. 411
UselessParentheses Useless parentheses. 411
UselessParentheses Useless parentheses. 426
UselessParentheses Useless parentheses. 426
UselessParentheses Useless parentheses. 439
UselessParentheses Useless parentheses. 439
UselessParentheses Useless parentheses. 443
UselessParentheses Useless parentheses. 443
UselessParentheses Useless parentheses. 454
UselessParentheses Useless parentheses. 454
UselessParentheses Useless parentheses. 653
UselessParentheses Useless parentheses. 654

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/DirectNeighborsPerception.java

Rule Violation Line
UselessParentheses Useless parentheses. 273274
UselessParentheses Useless parentheses. 275276

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/HeadwayGtuType.java

Rule Violation Line
UselessParentheses Useless parentheses. 211

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/TaskHeadwayCollector.java

Rule Violation Line
UselessParentheses Useless parentheses. 81

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationHeadway.java

Rule Violation Line
UselessParentheses Useless parentheses. 46

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSituationalAwareness.java

Rule Violation Line
UselessParentheses Useless parentheses. 88

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSpeed.java

Rule Violation Line
UselessParentheses Useless parentheses. 41

org/opentrafficsim/road/gtu/lane/perception/mental/Fuller.java

Rule Violation Line
UselessParentheses Useless parentheses. 180

org/opentrafficsim/road/gtu/lane/perception/mental/TaskHeadwayBased.java

Rule Violation Line
UselessParentheses Useless parentheses. 56

org/opentrafficsim/road/gtu/lane/plan/operational/LaneChange.java

Rule Violation Line
UselessParentheses Useless parentheses. 641
UselessParentheses Useless parentheses. 826

org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java

Rule Violation Line
UselessParentheses Useless parentheses. 409

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedGTUFollowingDirectedChangeTacticalPlanner.java

Rule Violation Line
UselessParentheses Useless parentheses. 236
UselessParentheses Useless parentheses. 266
UselessParentheses Useless parentheses. 629

org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveGetInLane.java

Rule Violation Line
UselessParentheses Useless parentheses. 90

org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java

Rule Violation Line
UselessParentheses Useless parentheses. 162
UselessParentheses Useless parentheses. 163164

org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java

Rule Violation Line
UselessParentheses Useless parentheses. 849850

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Cooperation.java

Rule Violation Line
UselessParentheses Useless parentheses. 43
UselessParentheses Useless parentheses. 44
UselessParentheses Useless parentheses. 79
UselessParentheses Useless parentheses. 80
UselessParentheses Useless parentheses. 124
UselessParentheses Useless parentheses. 125

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Synchronization.java

Rule Violation Line
UselessParentheses Useless parentheses. 350
UselessParentheses Useless parentheses. 401402
UselessParentheses Useless parentheses. 426
UselessParentheses Useless parentheses. 736
UselessParentheses Useless parentheses. 736

org/opentrafficsim/road/gtu/strategical/od/SplitFraction.java

Rule Violation Line
UselessParentheses Useless parentheses. 199
UselessParentheses Useless parentheses. 200

org/opentrafficsim/road/gtu/strategical/route/LaneBasedStrategicalRoutePlanner.java

Rule Violation Line
UselessParentheses Useless parentheses. 222
UselessParentheses Useless parentheses. 223
UselessParentheses Useless parentheses. 238239
UselessParentheses Useless parentheses. 240241

org/opentrafficsim/road/network/control/rampmetering/AlineaSwitch.java

Rule Violation Line
UselessParentheses Useless parentheses. 60

org/opentrafficsim/road/network/control/rampmetering/RwsSwitch.java

Rule Violation Line
UselessParentheses Useless parentheses. 64

org/opentrafficsim/road/network/lane/CrossSectionElement.java

Rule Violation Line
UselessParentheses Useless parentheses. 269
UselessParentheses Useless parentheses. 270
UselessParentheses Useless parentheses. 270

org/opentrafficsim/road/network/lane/Lane.java

Rule Violation Line
UselessParentheses Useless parentheses. 528529
UselessParentheses Useless parentheses. 530531
UselessParentheses Useless parentheses. 568569
UselessParentheses Useless parentheses. 570571
UselessParentheses Useless parentheses. 1506
UselessParentheses Useless parentheses. 1507
UselessParentheses Useless parentheses. 1534
UselessParentheses Useless parentheses. 1535

org/opentrafficsim/road/network/lane/conflict/Conflict.java

Rule Violation Line
UselessParentheses Useless parentheses. 187
UselessParentheses Useless parentheses. 188

org/opentrafficsim/road/network/lane/conflict/ConflictBuilder.java

Rule Violation Line
UselessParentheses Useless parentheses. 420
UselessParentheses Useless parentheses. 421
UselessParentheses Useless parentheses. 566
UselessParentheses Useless parentheses. 566
UselessParentheses Useless parentheses. 574
UselessParentheses Useless parentheses. 574

org/opentrafficsim/road/network/lane/conflict/DefaultConflictRule.java

Rule Violation Line
UselessParentheses Useless parentheses. 111
UselessParentheses Useless parentheses. 112

Files

org/opentrafficsim/road/gtu/generator/AbstractGTUGeneratorOld.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 289
UselessParentheses Useless parentheses. 4 289
UselessParentheses Useless parentheses. 4 290
UselessParentheses Useless parentheses. 4 290
CollapsibleIfStatements These nested if statements could be combined 3 358378
CollapsibleIfStatements These nested if statements could be combined 3 418438

org/opentrafficsim/road/gtu/generator/CFRoomChecker.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 5457

org/opentrafficsim/road/gtu/generator/GeneratorPositions.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 293296
UselessParentheses Useless parentheses. 4 915
UnnecessaryModifier Unnecessary modifier 'public' on class 'ByValue': members of interface types are implicitly public 3 10211081
UnnecessaryModifier Unnecessary modifier 'public' on class 'BySpeed': members of interface types are implicitly public 3 10951180
UselessParentheses Useless parentheses. 4 1124

org/opentrafficsim/road/gtu/generator/od/ODApplier.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 300

org/opentrafficsim/road/gtu/generator/od/StrategicalPlannerFactorySupplierOD.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'TacticalPlannerFactorySupplierOD': members of interface types are implicitly public 3 106118

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU.java

Rule Violation Priority Line
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 2 1463
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 2 1472
EmptyCatchBlock Avoid empty catch blocks 3 15711574
EmptyCatchBlock Avoid empty catch blocks 3 15871590

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU2.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 12361239

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedIndividualGTU.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 96

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedMoveChecker.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 48

org/opentrafficsim/road/gtu/lane/VehicleModel.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 44

org/opentrafficsim/road/gtu/lane/perception/AbstractPerceptionReiterable.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 125
UselessQualifiedThis Useless qualified this usage in the same class. 3 127
UselessQualifiedThis Useless qualified this usage in the same class. 3 128
UselessQualifiedThis Useless qualified this usage in the same class. 3 132
UselessQualifiedThis Useless qualified this usage in the same class. 3 133
UselessQualifiedThis Useless qualified this usage in the same class. 3 316

org/opentrafficsim/road/gtu/lane/perception/DownstreamNeighborsIterable.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 102
CollapsibleIfStatements These nested if statements could be combined 3 120124

org/opentrafficsim/road/gtu/lane/perception/PerceptionCollectable.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionCollector': members of interface types are implicitly public 3 7695
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionAccumulator': members of interface types are implicitly public 3 111121
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionFinalizer': members of interface types are implicitly public 3 137145

org/opentrafficsim/road/gtu/lane/perception/RollingLaneStructure.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 478
UselessParentheses Useless parentheses. 4 1328
UselessParentheses Useless parentheses. 4 1329
UselessParentheses Useless parentheses. 4 1416
UselessParentheses Useless parentheses. 4 1417
UselessParentheses Useless parentheses. 4 1500
UselessParentheses Useless parentheses. 4 1501
UselessParentheses Useless parentheses. 4 1530
UselessParentheses Useless parentheses. 4 1531

org/opentrafficsim/road/gtu/lane/perception/RollingLaneStructureRecord.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 344350
UselessParentheses Useless parentheses. 4 344345
UselessParentheses Useless parentheses. 4 346347

org/opentrafficsim/road/gtu/lane/perception/UpstreamNeighborsIterable.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 75

org/opentrafficsim/road/gtu/lane/perception/categories/DirectDefaultSimplePerception.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 749752
CollapsibleIfStatements These nested if statements could be combined 3 883900
UselessParentheses Useless parentheses. 4 952
UselessParentheses Useless parentheses. 4 952
UselessParentheses Useless parentheses. 4 953
UselessParentheses Useless parentheses. 4 953

org/opentrafficsim/road/gtu/lane/perception/categories/DirectInfrastructurePerception.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 411
UselessParentheses Useless parentheses. 4 411
UselessParentheses Useless parentheses. 4 426
UselessParentheses Useless parentheses. 4 426
UselessParentheses Useless parentheses. 4 439
UselessParentheses Useless parentheses. 4 439
UselessParentheses Useless parentheses. 4 443
UselessParentheses Useless parentheses. 4 443
UselessParentheses Useless parentheses. 4 454
UselessParentheses Useless parentheses. 4 454
UselessParentheses Useless parentheses. 4 653
UselessParentheses Useless parentheses. 4 654

org/opentrafficsim/road/gtu/lane/perception/categories/LaneBasedAbstractPerceptionCategory.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'context'. 3 126

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/DirectNeighborsPerception.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 273274
UselessParentheses Useless parentheses. 4 275276

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/HeadwayGtuType.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 211

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/TaskHeadwayCollector.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 81

org/opentrafficsim/road/gtu/lane/perception/headway/HeadwayStopLine.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 3740

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationHeadway.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 46

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSituationalAwareness.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 88

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSpeed.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 41

org/opentrafficsim/road/gtu/lane/perception/mental/Fuller.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 180

org/opentrafficsim/road/gtu/lane/perception/mental/TaskHeadwayBased.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 56

org/opentrafficsim/road/gtu/lane/plan/operational/LaneChange.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 641
UnusedFormalParameter Avoid unused method parameters such as 'planDistance'. 3 712
UnusedFormalParameter Avoid unused method parameters such as 'from'. 3 713
UnusedFormalParameter Avoid unused method parameters such as 'startPosition'. 3 713
UnusedFormalParameter Avoid unused method parameters such as 'width'. 3 713
UnusedFormalParameter Avoid unused method parameters such as 'toLine'. 3 714
UnusedFormalParameter Avoid unused method parameters such as 'fromLine'. 3 714
UnusedLocalVariable Avoid unused local variables such as 'f'. 3 726
UnusedLocalVariable Avoid unused local variables such as 'cumulLcLength'. 3 730
UselessParentheses Useless parentheses. 4 826

org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 409
UnusedFormalParameter Avoid unused method parameters such as 'startSpeed'. 3 469

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCFLCTacticalPlanner.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'currentLaneFine'. 3 151

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedGTUFollowingDirectedChangeTacticalPlanner.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 236
CollapsibleIfStatements These nested if statements could be combined 3 238245
UselessParentheses Useless parentheses. 4 266
UnusedFormalParameter Avoid unused method parameters such as 'lanePathInfo'. 3 508
UnusedFormalParameter Avoid unused method parameters such as 'perception'. 3 508
UselessParentheses Useless parentheses. 4 629

org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationBusStop.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 7584

org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveGetInLane.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 90

org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 162
UselessParentheses Useless parentheses. 4 163164
UnusedFormalParameter Avoid unused method parameters such as 'gtu'. 3 716

org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 188200
CollapsibleIfStatements These nested if statements could be combined 3 498514
UselessParentheses Useless parentheses. 4 849850

org/opentrafficsim/road/gtu/lane/tactical/util/Steering.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'speed'. 3 94
UnusedLocalVariable Avoid unused local variables such as 'realPlan'. 3 128

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Cooperation.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 43
UselessParentheses Useless parentheses. 4 44
UselessParentheses Useless parentheses. 4 79
UselessParentheses Useless parentheses. 4 80
UnusedLocalVariable Avoid unused local variables such as 'b'. 3 85
SimplifiedTernary Ternary operators that can be simplified with || or && 3 93
UselessParentheses Useless parentheses. 4 124
UselessParentheses Useless parentheses. 4 125

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsData.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 110

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsUtil.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 186203
UnusedPrivateMethod Avoid unused private methods such as 'quickIntersectionScan(Parameters,SpeedLimitInfo,CarFollowingModel,Speed,LateralDirectionality,IntersectionPerception)'. 3 593595

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Synchronization.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 1836
UselessParentheses Useless parentheses. 4 350
SimplifiedTernary Ternary operators that can be simplified with || or && 3 397398
UselessParentheses Useless parentheses. 4 401402
SimplifiedTernary Ternary operators that can be simplified with || or && 3 414415
UselessParentheses Useless parentheses. 4 426
UnnecessaryModifier Unnecessary modifier 'public' on method 'getMergeDistance': the method is declared in an interface type 3 499511
UselessParentheses Useless parentheses. 4 736
UselessParentheses Useless parentheses. 4 736

org/opentrafficsim/road/gtu/strategical/od/SplitFraction.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 199
UselessParentheses Useless parentheses. 4 200

org/opentrafficsim/road/gtu/strategical/route/LaneBasedStrategicalRoutePlanner.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 222
UselessParentheses Useless parentheses. 4 223
UselessParentheses Useless parentheses. 4 238239
UselessParentheses Useless parentheses. 4 240241

org/opentrafficsim/road/network/control/rampmetering/AlineaSwitch.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 60

org/opentrafficsim/road/network/control/rampmetering/RwsSwitch.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 64

org/opentrafficsim/road/network/factory/LaneFactory.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'simulator'. 3 388

org/opentrafficsim/road/network/lane/CrossSectionElement.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 269
UselessParentheses Useless parentheses. 4 270
UselessParentheses Useless parentheses. 4 270
UnusedFormalParameter Avoid unused constructor parameters such as 'newSimulator'. 3 352

org/opentrafficsim/road/network/lane/Lane.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 528529
UselessParentheses Useless parentheses. 4 530531
CollapsibleIfStatements These nested if statements could be combined 3 533537
UselessParentheses Useless parentheses. 4 568569
UselessParentheses Useless parentheses. 4 570571
CollapsibleIfStatements These nested if statements could be combined 3 573577
UselessParentheses Useless parentheses. 4 1506
UselessParentheses Useless parentheses. 4 1507
UselessParentheses Useless parentheses. 4 1534
UselessParentheses Useless parentheses. 4 1535

org/opentrafficsim/road/network/lane/LaneType.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'inverted'. 3 144

org/opentrafficsim/road/network/lane/NoTrafficLane.java

Rule Violation Priority Line
UnusedPrivateMethod Avoid unused private methods such as 'directionalityNone(RoadNetwork)'. 3 35

org/opentrafficsim/road/network/lane/conflict/Conflict.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 187
UselessParentheses Useless parentheses. 4 188
CollapsibleIfStatements These nested if statements could be combined 3 417437
CollapsibleIfStatements These nested if statements could be combined 3 843862

org/opentrafficsim/road/network/lane/conflict/ConflictBuilder.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 420
UselessParentheses Useless parentheses. 4 421
UselessParentheses Useless parentheses. 4 566
UselessParentheses Useless parentheses. 4 566
UselessParentheses Useless parentheses. 4 574
UselessParentheses Useless parentheses. 4 574

org/opentrafficsim/road/network/lane/conflict/DefaultConflictRule.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 111
UselessParentheses Useless parentheses. 4 112

org/opentrafficsim/road/network/lane/object/BusStop.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 3 62

org/opentrafficsim/road/network/lane/object/Distraction.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 3 41

org/opentrafficsim/road/network/lane/object/SpeedSign.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 3 62