SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

SpotBugs Version is 3.1.12

Threshold is medium

Effort is default

Summary

Classes Bugs Errors Missing Classes
63 14 0 0

Files

Class Bugs
org.opentrafficsim.swing.graphs.SwingContourPlot 2
org.opentrafficsim.swing.gui.OTSAnimationPanel 1
org.opentrafficsim.swing.gui.OTSAnimationPanel$DisposeOnCloseThread 1
org.opentrafficsim.swing.gui.OTSControlPanel 1
org.opentrafficsim.swing.gui.OTSControlPanel$DisposeOnCloseThread 1
org.opentrafficsim.swing.gui.OTSSwingApplication 3
org.opentrafficsim.swing.gui.OTSSwingApplication$2 4
org.opentrafficsim.swing.script.AbstractSimulationScript 1

org.opentrafficsim.swing.graphs.SwingContourPlot

Bug Category Details Line Priority
org.opentrafficsim.swing.graphs.SwingContourPlot.setSpaceGranularityRadioButton(double) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 165 Medium
org.opentrafficsim.swing.graphs.SwingContourPlot.setTimeGranularityRadioButton(double) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 179 Medium

org.opentrafficsim.swing.gui.OTSAnimationPanel

Bug Category Details Line Priority
new org.opentrafficsim.swing.gui.OTSAnimationPanel(Rectangle2D, Dimension, OTSAnimator, OTSModelInterface, GTUColorer, OTSNetwork) invokes org.opentrafficsim.swing.gui.OTSAnimationPanel$UpdateTimer.start() MT_CORRECTNESS SC_START_IN_CTOR 267 Medium

org.opentrafficsim.swing.gui.OTSAnimationPanel$DisposeOnCloseThread

Bug Category Details Line Priority
Should org.opentrafficsim.swing.gui.OTSAnimationPanel$DisposeOnCloseThread be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 697-734 Medium

org.opentrafficsim.swing.gui.OTSControlPanel

Bug Category Details Line Priority
Dead store to rect in org.opentrafficsim.swing.gui.OTSControlPanel.actionPerformed(ActionEvent) STYLE DLS_DEAD_LOCAL_STORE 432 Medium

org.opentrafficsim.swing.gui.OTSControlPanel$DisposeOnCloseThread

Bug Category Details Line Priority
Should org.opentrafficsim.swing.gui.OTSControlPanel$DisposeOnCloseThread be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 320-358 Medium

org.opentrafficsim.swing.gui.OTSSwingApplication

Bug Category Details Line Priority
Found reliance on default encoding in new org.opentrafficsim.swing.gui.OTSSwingApplication(OTSModelInterface, JPanel): new java.io.FileReader(String) I18N DM_DEFAULT_ENCODING 134 High
new org.opentrafficsim.swing.gui.OTSSwingApplication(OTSModelInterface, JPanel) may fail to clean up java.io.Reader EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 134 Medium
new org.opentrafficsim.swing.gui.OTSSwingApplication(OTSModelInterface, JPanel) may fail to close stream BAD_PRACTICE OS_OPEN_STREAM 134 Medium

org.opentrafficsim.swing.gui.OTSSwingApplication$2

Bug Category Details Line Priority
Found reliance on default encoding in org.opentrafficsim.swing.gui.OTSSwingApplication$2.windowClosing(WindowEvent): new java.io.FileWriter(File) I18N DM_DEFAULT_ENCODING 118 High
org.opentrafficsim.swing.gui.OTSSwingApplication$2.windowClosing(WindowEvent) may fail to clean up java.io.Writer EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 118 Medium
org.opentrafficsim.swing.gui.OTSSwingApplication$2.windowClosing(WindowEvent) may fail to close stream BAD_PRACTICE OS_OPEN_STREAM 118 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.opentrafficsim.swing.gui.OTSSwingApplication$2.windowClosing(WindowEvent) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 117 Medium

org.opentrafficsim.swing.script.AbstractSimulationScript

Bug Category Details Line Priority
org.opentrafficsim.swing.script.AbstractSimulationScript.start() invokes System.exit(...), which shuts down the entire virtual machine BAD_PRACTICE DM_EXIT 220 Medium