Checkstyle Results

The following document contains the results of Checkstyle 8.26 with development/dsol-checks.xml ruleset. 

rss feed

Summary

Files
 Info
 Warnings
 Errors
12 4 171 0

Files

File
 I
 W
 E
org/opentrafficsim/trafficcontrol/AbstractTrafficController.java 0 1 0
org/opentrafficsim/trafficcontrol/ActuatedTrafficController.java 0 1 0
org/opentrafficsim/trafficcontrol/FixedTimeController.java 1 9 0
org/opentrafficsim/trafficcontrol/TrafficController.java 0 9 0
org/opentrafficsim/trafficcontrol/ccol/CCOL.java 0 10 0
org/opentrafficsim/trafficcontrol/trafcod/Diagram.java 0 45 0
org/opentrafficsim/trafficcontrol/trafcod/TrafCOD.java 3 59 0
org/opentrafficsim/trafficcontrol/trafcod/TrafCODDisplay.java 0 37 0

Rules

Category Rule Violations Severity
coding HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
 2
 Warning
InnerAssignment 1
 Warning
MissingSwitchDefault 2
 Warning
design DesignForExtension 1
 Warning
VisibilityModifier 31
 Warning
javadoc JavadocStyle
  • checkHtml: "false"
 5
 Warning
misc FinalParameters 62
 Warning
TodoComment 1
 Warning
modifier ModifierOrder 36
 Warning
RedundantModifier 22
 Warning
naming ConstantName 3
 Warning
StaticVariableName 3
 Warning
sizes FileLength 1
 Warning
LineLength
  • max: "128"
 1
 Info
MethodLength 3
 Info
whitespace WhitespaceAfter 1
 Warning

Details

org/opentrafficsim/trafficcontrol/AbstractTrafficController.java

Severity Category Rule Message Line
 Warning		 design VisibilityModifier Variable 'id' must be private and have accessor methods. 25

org/opentrafficsim/trafficcontrol/ActuatedTrafficController.java

Severity Category Rule Message Line
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 21

org/opentrafficsim/trafficcontrol/FixedTimeController.java

Severity Category Rule Message Line
 Info		 sizes MethodLength Method length is 194 lines (max allowed is 150). 68
 Warning		 coding HiddenField 'simulator' hides a field. 456
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 476
 Warning		 misc FinalParameters Parameter obj should be final. 597
 Warning		 design VisibilityModifier Variable 'offset' must be private and have accessor methods. 708
 Warning		 design VisibilityModifier Variable 'newColor' must be private and have accessor methods. 711
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 718
 Warning		 modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 749
 Warning		 naming ConstantName Name 'compareMargin' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 749
 Warning		 misc FinalParameters Parameter o should be final. 752

org/opentrafficsim/trafficcontrol/TrafficController.java

Severity Category Rule Message Line
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 29
 Warning		 modifier RedundantModifier Redundant 'final' modifier. 32
 Warning		 modifier RedundantModifier Redundant 'final' modifier. 35
 Warning		 modifier RedundantModifier Redundant 'final' modifier. 38
 Warning		 modifier RedundantModifier Redundant 'final' modifier. 41
 Warning		 modifier RedundantModifier Redundant 'final' modifier. 44
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 47
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 47
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 79

org/opentrafficsim/trafficcontrol/ccol/CCOL.java

Severity Category Rule Message Line
 Warning		 design VisibilityModifier Variable 'id' must be private and have accessor methods. 49
 Warning		 design VisibilityModifier Variable 'simulator' must be private and have accessor methods. 52
 Warning		 naming StaticVariableName Name 'PORT' must match pattern '^[a-z][a-zA-Z0-9]*$'. 55
 Warning		 design VisibilityModifier Variable 'PORT' must be private and have accessor methods. 55
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 58
 Warning		 design VisibilityModifier Variable 'serverSocket' must be private and have accessor methods. 61
 Warning		 design VisibilityModifier Variable 'acceptThread' must be private and have accessor methods. 73
 Warning		 misc FinalParameters Parameter event should be final. 193
 Warning		 misc FinalParameters Parameter newSimulator should be final. 251
 Warning		 misc FinalParameters Parameter newNetwork should be final. 251

org/opentrafficsim/trafficcontrol/trafcod/Diagram.java

Severity Category Rule Message Line
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 48
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 51
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 54
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 57
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 60
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 63
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 66
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 69
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 72
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 75
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 78
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 81
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 84
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 87
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 90
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 93
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 96
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 99
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 102
 Warning		 design VisibilityModifier Variable 'streams' must be private and have accessor methods. 105
 Warning		 design VisibilityModifier Variable 'routes' must be private and have accessor methods. 108
 Warning		 misc FinalParameters Parameter o1 should be final. 122
 Warning		 misc FinalParameters Parameter o2 should be final. 122
 Warning		 whitespace WhitespaceAfter ',' is not followed by whitespace. 141
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 278
 Warning		 javadoc JavadocStyle First sentence should end with a period. 310
 Warning		 coding MissingSwitchDefault switch without "default" clause. 333
 Warning		 coding MissingSwitchDefault switch without "default" clause. 355
 Warning		 modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 398
 Warning		 modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 401
 Warning		 modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 404
 Warning		 modifier ModifierOrder 'private' modifier out of order with the JLS suggestions. 407
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 414
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 430
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 451
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 468
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 540
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 550
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 561
 Warning		 javadoc JavadocStyle First sentence should end with a period. 628
 Warning		 misc FinalParameters Parameter steps should be final. 634
 Warning		 coding InnerAssignment Inner assignments should be avoided. 638
 Warning		 misc FinalParameters Parameter e should be final. 863
 Warning		 design VisibilityModifier Variable 'testPanel' must be private and have accessor methods. 872
 Warning		 design VisibilityModifier Variable 'checkBoxPanel' must be private and have accessor methods. 875

org/opentrafficsim/trafficcontrol/trafcod/TrafCOD.java

Severity Category Rule Message Line
 Warning		 sizes FileLength File length is 2,838 lines (max allowed is 2,000). 1
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 65
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 68
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 71
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 74
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 77
 Warning		 design VisibilityModifier Variable 'tokenisedRules' must be private and have accessor methods. 80
 Warning		 design VisibilityModifier Variable 'variables' must be private and have accessor methods. 83
 Warning		 design VisibilityModifier Variable 'variablesInDefinitionOrder' must be private and have accessor methods. 86
 Warning		 design VisibilityModifier Variable 'detectors' must be private and have accessor methods. 89
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 92
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 95
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 98
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 101
 Warning		 design VisibilityModifier Variable 'numberOfConflictGroups' must be private and have accessor methods. 104
 Warning		 javadoc JavadocStyle First sentence should end with a period. 127
 Warning		 design VisibilityModifier Variable 'displayBackground' must be private and have accessor methods. 137
 Warning		 design VisibilityModifier Variable 'displayObjectLocations' must be private and have accessor methods. 140
 Warning		 misc FinalParameters Parameter controllerName should be final. 164
 Warning		 misc FinalParameters Parameter display should be final. 164
 Warning		 misc FinalParameters Parameter controllerName should be final. 183
 Info		 sizes MethodLength Method length is 151 lines (max allowed is 150). 252
 Info		 sizes LineLength Line is longer than 128 characters (found 134). 556
 Warning		 naming StaticVariableName Name 'BIND_UNARY_MINUS' must match pattern '^[a-z][a-zA-Z0-9]*$'. 919
 Warning		 misc FinalParameters Parameter tokens should be final. 1175
 Info		 sizes MethodLength Method length is 269 lines (max allowed is 150). 1386
 Warning		 misc FinalParameters Parameter name should be final. 1697
 Warning		 misc FinalParameters Parameter stream should be final. 1697
 Warning		 misc FinalParameters Parameter flags should be final. 1697
 Warning		 misc FinalParameters Parameter location should be final. 1697
 Warning		 misc FinalParameters Parameter detectorId should be final. 1751
 Warning		 misc FinalParameters Parameter detectingGTU should be final. 1751
 Warning		 misc FinalParameters Parameter event should be final. 1812
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 1970
 Warning		 design VisibilityModifier Variable 'flags' must be private and have accessor methods. 2096
 Warning		 design VisibilityModifier Variable 'value' must be private and have accessor methods. 2099
 Warning		 design VisibilityModifier Variable 'timerMax10' must be private and have accessor methods. 2102
 Warning		 design VisibilityModifier Variable 'color' must be private and have accessor methods. 2105
 Warning		 design VisibilityModifier Variable 'name' must be private and have accessor methods. 2108
 Warning		 javadoc JavadocStyle First sentence should end with a period. 2110
 Warning		 design VisibilityModifier Variable 'stream' must be private and have accessor methods. 2111
 Warning		 design VisibilityModifier Variable 'refCount' must be private and have accessor methods. 2114
 Warning		 design VisibilityModifier Variable 'updateTime10' must be private and have accessor methods. 2117
 Warning		 design VisibilityModifier Variable 'startSource' must be private and have accessor methods. 2120
 Warning		 design VisibilityModifier Variable 'endSource' must be private and have accessor methods. 2123
 Warning		 naming StaticVariableName Name 'ROWLETTERS' must match pattern '^[a-z][a-zA-Z0-9]*$'. 2129
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 2182
 Warning		 misc FinalParameters Parameter trafCOD should be final. 2182
 Warning		 misc FinalParameters Parameter sensor should be final. 2216
 Warning		 misc FinalParameters Parameter newValue should be final. 2338
 Warning		 misc FinalParameters Parameter timeStamp10 should be final. 2338
 Warning		 misc FinalParameters Parameter cause should be final. 2338
 Warning		 misc FinalParameters Parameter trafCOD should be final. 2338
 Warning		 coding HiddenField 'trafCOD' hides a field. 2338
 Warning		 misc FinalParameters Parameter colorValue should be final. 2492
 Warning		 misc FinalParameters Parameter value10 should be final. 2541
 Warning		 misc FinalParameters Parameter startSource should be final. 2565
 Warning		 misc FinalParameters Parameter endSource should be final. 2589
 Warning		 misc FinalParameters Parameter printFlags should be final. 2620
 Warning		 misc FinalParameters Parameter event should be final. 2729
 Warning		 design VisibilityModifier Variable 'cause' must be private and have accessor methods. 2750
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 2756

org/opentrafficsim/trafficcontrol/trafcod/TrafCODDisplay.java

Severity Category Rule Message Line
 Warning		 design VisibilityModifier Variable 'defaultInitialDelay' must be private and have accessor methods. 54
 Warning		 design DesignForExtension Class 'TrafCODDisplay' looks like designed for extension (can be subclassed), but the method 'paintComponent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TrafCODDisplay' final or making the method 'paintComponent' static/final/abstract/empty, or adding allowed annotation for the method. 86
 Warning		 misc FinalParameters Parameter e should be final. 108
 Warning		 misc FinalParameters Parameter e should be final. 115
 Warning		 misc FinalParameters Parameter e should be final. 132
 Warning		 misc FinalParameters Parameter e should be final. 139
 Warning		 misc FinalParameters Parameter e should be final. 146
 Warning		 misc FinalParameters Parameter e should be final. 153
 Warning		 misc FinalParameters Parameter e should be final. 160
 Warning		 javadoc JavadocStyle First sentence should end with a period. 173
 Warning		 naming ConstantName Name 'xOffset' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 217
 Warning		 naming ConstantName Name 'yOffset' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 220
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 229
 Warning		 misc FinalParameters Parameter center should be final. 229
 Warning		 misc FinalParameters Parameter id should be final. 229
 Warning		 misc FinalParameters Parameter description should be final. 229
 Warning		 misc FinalParameters Parameter g2 should be final. 241
 Warning		 misc FinalParameters Parameter event should be final. 251
 Warning		 modifier RedundantModifier Redundant 'public' modifier. 314
 Warning		 misc FinalParameters Parameter testX should be final. 325
 Warning		 misc FinalParameters Parameter testY should be final. 325
 Warning		 misc FinalParameters Parameter listener should be final. 400
 Warning		 misc FinalParameters Parameter eventType should be final. 400
 Warning		 misc FinalParameters Parameter listener should be final. 407
 Warning		 misc FinalParameters Parameter eventType should be final. 407
 Warning		 misc FinalParameters Parameter weak should be final. 407
 Warning		 misc FinalParameters Parameter listener should be final. 414
 Warning		 misc FinalParameters Parameter eventType should be final. 414
 Warning		 misc FinalParameters Parameter position should be final. 414
 Warning		 misc FinalParameters Parameter listener should be final. 421
 Warning		 misc FinalParameters Parameter eventType should be final. 421
 Warning		 misc FinalParameters Parameter position should be final. 421
 Warning		 misc FinalParameters Parameter weak should be final. 421
 Warning		 misc FinalParameters Parameter listener should be final. 429
 Warning		 misc FinalParameters Parameter eventType should be final. 429
 Warning		 misc FinalParameters Parameter trafficLightColor should be final. 443
 Warning		 misc FinalParameters Parameter g2 should be final. 454