SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

SpotBugs Version is 3.1.12

Threshold is medium

Effort is default

Summary

Classes Bugs Errors Missing Classes
118 41 0 0

Files

Class Bugs
org.opentrafficsim.draw.core.BoundsPaintScale 2
org.opentrafficsim.draw.core.TextAnimation$AnimationImpl 1
org.opentrafficsim.draw.graphs.ContourDataSource 9
org.opentrafficsim.draw.graphs.FundamentalDiagram 2
org.opentrafficsim.draw.graphs.FundamentalDiagram$AbstractSpaceSamplerFdSource 2
org.opentrafficsim.draw.graphs.GraphUpdater 1
org.opentrafficsim.draw.graphs.TrajectoryPlot$OffsetTrajectory 1
org.opentrafficsim.draw.graphs.XYInterpolatedBlockRenderer 1
org.opentrafficsim.draw.graphs.XYInterpolatedBlockRenderer$1$1 1
org.opentrafficsim.draw.graphs.road.GraphLaneUtil 1
org.opentrafficsim.draw.graphs.road.GraphLaneUtil$4 1
org.opentrafficsim.draw.gtu.DefaultCarAnimation 2
org.opentrafficsim.draw.gtu.DefaultCarAnimation$Text 1
org.opentrafficsim.draw.gtu.GtuGeneratorQueueAnimation 1
org.opentrafficsim.draw.network.LinkAnimation 1
org.opentrafficsim.draw.network.NodeAnimation 1
org.opentrafficsim.draw.object.StaticObjectAnimation 1
org.opentrafficsim.draw.road.BusStopAnimation 1
org.opentrafficsim.draw.road.ConflictAnimation 1
org.opentrafficsim.draw.road.DestinationAnimation 1
org.opentrafficsim.draw.road.LaneAnimation 1
org.opentrafficsim.draw.road.LaneAnimation$CenterLineAnimation 1
org.opentrafficsim.draw.road.SensorAnimation 1
org.opentrafficsim.draw.road.ShoulderAnimation 1
org.opentrafficsim.draw.road.SinkAnimation 1
org.opentrafficsim.draw.road.SpeedSignAnimation 1
org.opentrafficsim.draw.road.StripeAnimation 1
org.opentrafficsim.draw.road.TrafficLightAnimation 1
org.opentrafficsim.draw.road.TrafficLightSensorAnimation 1

org.opentrafficsim.draw.core.BoundsPaintScale

Bug Category Details Line Priority
org.opentrafficsim.draw.core.BoundsPaintScale.GREEN_RED is a mutable array MALICIOUS_CODE MS_MUTABLE_ARRAY 27 High
org.opentrafficsim.draw.core.BoundsPaintScale.GREEN_RED_DARK is a mutable array MALICIOUS_CODE MS_MUTABLE_ARRAY 31 High

org.opentrafficsim.draw.core.TextAnimation$AnimationImpl

Bug Category Details Line Priority
org.opentrafficsim.draw.core.TextAnimation$AnimationImpl is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 482-504 High

org.opentrafficsim.draw.graphs.ContourDataSource

Bug Category Details Line Priority
Inconsistent synchronization of org.opentrafficsim.draw.graphs.ContourDataSource.redo; locked 75% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 791 Medium
Inconsistent synchronization of org.opentrafficsim.draw.graphs.ContourDataSource.smooth; locked 66% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 444 Medium
Inconsistent synchronization of org.opentrafficsim.draw.graphs.ContourDataSource.toTime; locked 83% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 512 Medium
org.opentrafficsim.draw.graphs.ContourDataSource.DEFAULT_SPACE_GRANULARITIES should be package protected MALICIOUS_CODE MS_PKGPROTECT 59 Medium
org.opentrafficsim.draw.graphs.ContourDataSource.DEFAULT_TIME_GRANULARITIES should be package protected MALICIOUS_CODE MS_PKGPROTECT 65 Medium
Method org.opentrafficsim.draw.graphs.ContourDataSource.setStatusLabel(String) seems to be useless STYLE UC_USELESS_VOID_METHOD 894 Medium
org.opentrafficsim.draw.graphs.ContourDataSource.getGranularity(ContourDataSource$Dimension) is unsynchronized, org.opentrafficsim.draw.graphs.ContourDataSource.setGranularity(ContourDataSource$Dimension, double) is synchronized MT_CORRECTNESS UG_SYNC_SET_UNSYNC_GET 366 Medium
org.opentrafficsim.draw.graphs.ContourDataSource.update(Time) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 768 Medium
org.opentrafficsim.draw.graphs.ContourDataSource.update(Time) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 785 Medium

org.opentrafficsim.draw.graphs.FundamentalDiagram

Bug Category Details Line Priority
org.opentrafficsim.draw.graphs.FundamentalDiagram.DEFAULT_PERIODS should be package protected MALICIOUS_CODE MS_PKGPROTECT 50 Medium
org.opentrafficsim.draw.graphs.FundamentalDiagram.DEFAULT_UPDATE_FREQUENCIES should be package protected MALICIOUS_CODE MS_PKGPROTECT 53 Medium

org.opentrafficsim.draw.graphs.FundamentalDiagram$AbstractSpaceSamplerFdSource

Bug Category Details Line Priority
Inconsistent synchronization of org.opentrafficsim.draw.graphs.FundamentalDiagram$AbstractSpaceSamplerFdSource.firstMeasurement; locked 75% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 1049 Medium
Inconsistent synchronization of org.opentrafficsim.draw.graphs.FundamentalDiagram$AbstractSpaceSamplerFdSource.secondMeasurement; locked 71% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 1049 Medium

org.opentrafficsim.draw.graphs.GraphUpdater

Bug Category Details Line Priority
Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.opentrafficsim.draw.graphs.GraphUpdater.offer(Object) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 69 Medium

org.opentrafficsim.draw.graphs.TrajectoryPlot$OffsetTrajectory

Bug Category Details Line Priority
Should org.opentrafficsim.draw.graphs.TrajectoryPlot$OffsetTrajectory be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 473-568 Medium

org.opentrafficsim.draw.graphs.XYInterpolatedBlockRenderer

Bug Category Details Line Priority
org.opentrafficsim.draw.graphs.XYInterpolatedBlockRenderer doesn't override org.jfree.chart.renderer.xy.XYBlockRenderer.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium

org.opentrafficsim.draw.graphs.XYInterpolatedBlockRenderer$1$1

Bug Category Details Line Priority
Integral division result cast to double or float in org.opentrafficsim.draw.graphs.XYInterpolatedBlockRenderer$1$1.getRaster(int, int, int, int) STYLE ICAST_IDIV_CAST_TO_DOUBLE 184 Medium

org.opentrafficsim.draw.graphs.road.GraphLaneUtil

Bug Category Details Line Priority
Null passed for non-null parameter of java.util.List.addAll(Collection) in org.opentrafficsim.draw.graphs.road.GraphLaneUtil.createPath(List, List) CORRECTNESS NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS 211 Medium

org.opentrafficsim.draw.graphs.road.GraphLaneUtil$4

Bug Category Details Line Priority
org.opentrafficsim.draw.graphs.road.GraphLaneUtil$4.compare(Lane, Lane) negates the return value of org.djunits.value.vdouble.scalar.base.AbstractDoubleScalar.compareTo(AbstractDoubleScalar) BAD_PRACTICE RV_NEGATING_RESULT_OF_COMPARETO 341 Medium

org.opentrafficsim.draw.gtu.DefaultCarAnimation

Bug Category Details Line Priority
org.opentrafficsim.core.animation.gtu.colorer.IDGTUColorer stored into non-transient field DefaultCarAnimation.gtuColorer BAD_PRACTICE SE_BAD_FIELD_STORE 109 High
org.opentrafficsim.draw.gtu.DefaultCarAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 42-284 High

org.opentrafficsim.draw.gtu.DefaultCarAnimation$Text

Bug Category Details Line Priority
Potentially ambiguous invocation of either an outer or inherited method org.opentrafficsim.draw.core.TextAnimation.destroy() in org.opentrafficsim.draw.gtu.DefaultCarAnimation$Text.paint(Graphics2D, ImageObserver) STYLE IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD 358 High

org.opentrafficsim.draw.gtu.GtuGeneratorQueueAnimation

Bug Category Details Line Priority
org.opentrafficsim.draw.gtu.GtuGeneratorQueueAnimation.paint(Graphics2D, ImageObserver) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 64 Medium

org.opentrafficsim.draw.network.LinkAnimation

Bug Category Details Line Priority
org.opentrafficsim.draw.network.LinkAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 38-141 High

org.opentrafficsim.draw.network.NodeAnimation

Bug Category Details Line Priority
org.opentrafficsim.draw.network.NodeAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 62-122 High

org.opentrafficsim.draw.object.StaticObjectAnimation

Bug Category Details Line Priority
org.opentrafficsim.draw.object.StaticObjectAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 54-126 High

org.opentrafficsim.draw.road.BusStopAnimation

Bug Category Details Line Priority
org.opentrafficsim.draw.road.BusStopAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 48-74 High

org.opentrafficsim.draw.road.ConflictAnimation

Bug Category Details Line Priority
org.opentrafficsim.draw.road.ConflictAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 49-133 High

org.opentrafficsim.draw.road.DestinationAnimation

Bug Category Details Line Priority
org.opentrafficsim.draw.road.DestinationAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 44-59 High

org.opentrafficsim.draw.road.LaneAnimation

Bug Category Details Line Priority
org.opentrafficsim.draw.road.LaneAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 36-106 High

org.opentrafficsim.draw.road.LaneAnimation$CenterLineAnimation

Bug Category Details Line Priority
org.opentrafficsim.draw.road.LaneAnimation$CenterLineAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 153-188 High

org.opentrafficsim.draw.road.SensorAnimation

Bug Category Details Line Priority
org.opentrafficsim.draw.road.SensorAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 33-106 High

org.opentrafficsim.draw.road.ShoulderAnimation

Bug Category Details Line Priority
org.opentrafficsim.draw.road.ShoulderAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 44-60 High

org.opentrafficsim.draw.road.SinkAnimation

Bug Category Details Line Priority
org.opentrafficsim.draw.road.SinkAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 44-59 High

org.opentrafficsim.draw.road.SpeedSignAnimation

Bug Category Details Line Priority
org.opentrafficsim.draw.road.SpeedSignAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 52-85 High

org.opentrafficsim.draw.road.StripeAnimation

Bug Category Details Line Priority
org.opentrafficsim.draw.road.StripeAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 38-272 High

org.opentrafficsim.draw.road.TrafficLightAnimation

Bug Category Details Line Priority
org.opentrafficsim.draw.road.TrafficLightAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 32-120 High

org.opentrafficsim.draw.road.TrafficLightSensorAnimation

Bug Category Details Line Priority
org.opentrafficsim.draw.road.TrafficLightSensorAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 55-90 High