PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 3

org/opentrafficsim/trafficcontrol/ActuatedTrafficController.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'updateDetector': the method is declared in an interface type 21

org/opentrafficsim/trafficcontrol/TrafficController.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getId': the method is declared in an interface type 29
UnnecessaryModifier Unnecessary modifier 'final' on field 'STARTING_UP': the field is declared in an interface type 32
UnnecessaryModifier Unnecessary modifier 'final' on field 'BEING_CLONED': the field is declared in an interface type 35
UnnecessaryModifier Unnecessary modifier 'final' on field 'RUNNING': the field is declared in an interface type 38
UnnecessaryModifier Unnecessary modifier 'final' on field 'SHUTTING_DOWN': the field is declared in an interface type 41
UnnecessaryModifier Unnecessary modifier 'final' on field 'OFF': the field is declared in an interface type 44
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_STREAM': the field is declared in an interface type 47
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'TRAFFIC_LIGHT_CHANGED': the field is declared in an interface type 79

org/opentrafficsim/trafficcontrol/ccol/CCOL.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'trafficLights'. 87
UnusedFormalParameter Avoid unused constructor parameters such as 'sensors'. 88

org/opentrafficsim/trafficcontrol/trafcod/Diagram.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 668–671

Priority 4

org/opentrafficsim/trafficcontrol/trafcod/TrafCOD.java

Rule Violation Line
UselessParentheses Useless parentheses. 414
UselessParentheses Useless parentheses. 414
UselessParentheses Useless parentheses. 430
UselessParentheses Useless parentheses. 430
UselessParentheses Useless parentheses. 1669
UselessParentheses Useless parentheses. 1756
UselessParentheses Useless parentheses. 2012
UselessParentheses Useless parentheses. 2777

Files

org/opentrafficsim/trafficcontrol/ActuatedTrafficController.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'updateDetector': the method is declared in an interface type 3 21

org/opentrafficsim/trafficcontrol/TrafficController.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getId': the method is declared in an interface type 3 29
UnnecessaryModifier Unnecessary modifier 'final' on field 'STARTING_UP': the field is declared in an interface type 3 32
UnnecessaryModifier Unnecessary modifier 'final' on field 'BEING_CLONED': the field is declared in an interface type 3 35
UnnecessaryModifier Unnecessary modifier 'final' on field 'RUNNING': the field is declared in an interface type 3 38
UnnecessaryModifier Unnecessary modifier 'final' on field 'SHUTTING_DOWN': the field is declared in an interface type 3 41
UnnecessaryModifier Unnecessary modifier 'final' on field 'OFF': the field is declared in an interface type 3 44
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_STREAM': the field is declared in an interface type 3 47
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'TRAFFIC_LIGHT_CHANGED': the field is declared in an interface type 3 79

org/opentrafficsim/trafficcontrol/ccol/CCOL.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'trafficLights'. 3 87
UnusedFormalParameter Avoid unused constructor parameters such as 'sensors'. 3 88

org/opentrafficsim/trafficcontrol/trafcod/Diagram.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 668–671

org/opentrafficsim/trafficcontrol/trafcod/TrafCOD.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 414
UselessParentheses Useless parentheses. 4 414
UselessParentheses Useless parentheses. 4 430
UselessParentheses Useless parentheses. 4 430
UselessParentheses Useless parentheses. 4 1669
UselessParentheses Useless parentheses. 4 1756
UselessParentheses Useless parentheses. 4 2012
UselessParentheses Useless parentheses. 4 2777