PMD Results

The following document contains the results of PMD 6.21.0.

Violations By Priority

Priority 2

org/opentrafficsim/demo/geometry/shape/ShapeFileReader.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 323

Priority 3

loadfromxml/LoadXML.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 199–202

org/opentrafficsim/ahfe/AHFEAnimation.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 86

org/opentrafficsim/ahfe/AHFEUtil.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'generationSpeed'. 354
UnusedFormalParameter Avoid unused method parameters such as 'gtuColorer'. 357
UnusedFormalParameter Avoid unused method parameters such as 'bcFactory'. 357
UnusedFormalParameter Avoid unused method parameters such as 'simulationTime'. 358
UnusedFormalParameter Avoid unused method parameters such as 'tacticalFactory'. 358

org/opentrafficsim/ahfe/DelayedNeighborsPerception.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'perc'. 271
EmptyCatchBlock Avoid empty catch blocks 314–317
EmptyCatchBlock Avoid empty catch blocks 351–354
UnusedFormalParameter Avoid unused method parameters such as 'egoSpeed'. 423

org/opentrafficsim/demo/CircularLaneSwing.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 60

org/opentrafficsim/demo/CircularRoadSwing.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 74

org/opentrafficsim/demo/CrossingTrafficLightsSwing.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 43

org/opentrafficsim/demo/FundamentalDiagrams.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 92

org/opentrafficsim/demo/NetworksSwing.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 68

org/opentrafficsim/demo/RampMeteringDemo.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'part'. 230
UnusedLocalVariable Avoid unused local variables such as 'lanesBC'. 283
UnusedLocalVariable Avoid unused local variables such as 'lanesFB'. 290

org/opentrafficsim/demo/SequentialLanes.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 100

org/opentrafficsim/demo/ShortMerge.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 154
EmptyIfStmt Avoid empty if statements 293–295
UnusedFormalParameter Avoid unused method parameters such as 'generationSpeed'. 440
UnusedFormalParameter Avoid unused method parameters such as 'gtuColorer'. 442
UnusedFormalParameter Avoid unused method parameters such as 'bcFactory'. 442
UnusedFormalParameter Avoid unused method parameters such as 'simulationTime'. 443
UnusedFormalParameter Avoid unused method parameters such as 'tacticalFactory'. 443

org/opentrafficsim/demo/StraightSwing.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 60

org/opentrafficsim/demo/conflictAndControl/DemoTrafcodAndTurbo.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 75

org/opentrafficsim/demo/conflict/BusStreetDemo.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 111

org/opentrafficsim/demo/conflict/TJunctionDemo.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 59
EmptyStatementBlock Avoid empty block statements. 185–187

org/opentrafficsim/demo/conflict/TestNetworkDemo.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 55

org/opentrafficsim/demo/conflict/TurboRoundaboutDemo.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 58
EmptyStatementBlock Avoid empty block statements. 200–202

org/opentrafficsim/demo/geometry/TestModel.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 199–202

org/opentrafficsim/demo/geometry/shape/ShapeFileReader.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'line'. 223
UnusedLocalVariable Avoid unused local variables such as 'length'. 230
UnusedLocalVariable Avoid unused local variables such as 'linkTag'. 235
UnusedLocalVariable Avoid unused local variables such as 'wegtype'. 236
UnusedLocalVariable Avoid unused local variables such as 'typeWeg'. 238
UnusedLocalVariable Avoid unused local variables such as 'speed'. 240
UnusedLocalVariable Avoid unused local variables such as 'capacity'. 242
UnusedLocalVariable Avoid unused local variables such as 'dir'. 438
EmptyCatchBlock Avoid empty catch blocks 472–475
UnusedLocalVariable Avoid unused local variables such as 'dir'. 504
EmptyCatchBlock Avoid empty catch blocks 540–543

org/opentrafficsim/demo/lanechange/LaneChangeGraph.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'speed'. 418

org/opentrafficsim/demo/network/xml/Grid10X10.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'defaultAnimationFactory'. 214

org/opentrafficsim/demo/network/xml/N201ODfactory.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'colorer'. 149

org/opentrafficsim/demo/network/xml/TestXMLParserAmsterdam.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'defaultAnimationFactory'. 72

org/opentrafficsim/demo/sdm/SdmSimulation.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 475
UselessQualifiedThis Useless qualified this usage in the same class. 479
UselessQualifiedThis Useless qualified this usage in the same class. 483
UselessQualifiedThis Useless qualified this usage in the same class. 484

org/opentrafficsim/demo/trafficcontrol/TrafCODDemo1.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 66
UnusedFormalParameter Avoid unused constructor parameters such as 'shortName'. 158
UnusedFormalParameter Avoid unused constructor parameters such as 'description'. 158

org/opentrafficsim/demo/trafficcontrol/TrafCODDemo2.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 66

org/opentrafficsim/demo/trafficcontrol/TrafCODDemo2_Generators.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 59

org/opentrafficsim/demo/web/OTSDemoServer.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 192–195
EmptyCatchBlock Avoid empty catch blocks 201–204
CollapsibleIfStatements These nested if statements could be combined 263–267
EmptyIfStmt Avoid empty if statements 589–591
EmptyIfStmt Avoid empty if statements 593–595
EmptyIfStmt Avoid empty if statements 597–599
EmptyIfStmt Avoid empty if statements 601–603

org/opentrafficsim/demo/web/OTSFederatedDemoServer.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 470–472
EmptyIfStmt Avoid empty if statements 474–476
EmptyIfStmt Avoid empty if statements 478–480
EmptyIfStmt Avoid empty if statements 482–484

org/opentrafficsim/demo/web/SimpleLoadBalancer.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'lbSocket'. 45
UnusedPrivateField Avoid unused private fields such as 'lbContext'. 48
UnusedPrivateField Avoid unused private fields such as 'messageCount'. 51

org/opentrafficsim/demo/web/SuperDemoWebApplication.java

Rule Violation Line
EmptyTryBlock Avoid empty try blocks 363–389
EmptyTryBlock Avoid empty try blocks 458–481

strategies/LmrsStrategies.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 972
UselessQualifiedThis Useless qualified this usage in the same class. 974
UselessQualifiedThis Useless qualified this usage in the same class. 978
UselessQualifiedThis Useless qualified this usage in the same class. 1007
UselessQualifiedThis Useless qualified this usage in the same class. 1009
UselessQualifiedThis Useless qualified this usage in the same class. 1009
UselessQualifiedThis Useless qualified this usage in the same class. 1013
UselessQualifiedThis Useless qualified this usage in the same class. 1013

strategies/StrategiesDemo.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 354

Priority 4

org/opentrafficsim/ahfe/AHFESimulation.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.Double.parseDouble' due to existing implicit import 'java.lang.*' 153
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.Double.parseDouble' due to existing implicit import 'java.lang.*' 164
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.Double.parseDouble' due to existing implicit import 'java.lang.*' 175
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.Double.parseDouble' due to existing implicit import 'java.lang.*' 188
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.Double.parseDouble' due to existing implicit import 'java.lang.*' 199
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.Double.parseDouble' due to existing implicit import 'java.lang.*' 210
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.Double.parseDouble' due to existing implicit import 'java.lang.*' 221
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.Double.parseDouble' due to existing implicit import 'java.lang.*' 232
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.Double.parseDouble' due to existing implicit import 'java.lang.*' 243

org/opentrafficsim/demo/CircularRoadSwing.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.awt.Window' 6

org/opentrafficsim/demo/RampMeteringDemo.java

Rule Violation Line
UselessParentheses Useless parentheses. 639
UselessParentheses Useless parentheses. 640

org/opentrafficsim/demo/geometry/shape/ShapeFileReader.java

Rule Violation Line
UselessParentheses Useless parentheses. 439
UselessParentheses Useless parentheses. 505

org/opentrafficsim/demo/steering/SteeringSimulation.java

Rule Violation Line
UselessParentheses Useless parentheses. 177

strategies/LmrsStrategies.java

Rule Violation Line
UselessParentheses Useless parentheses. 367–368

strategies/StrategiesDemo.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.awt.BorderLayout' 3

Files

loadfromxml/LoadXML.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 199–202

org/opentrafficsim/ahfe/AHFEAnimation.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 86

org/opentrafficsim/ahfe/AHFESimulation.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.Double.parseDouble' due to existing implicit import 'java.lang.*' 4 153
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.Double.parseDouble' due to existing implicit import 'java.lang.*' 4 164
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.Double.parseDouble' due to existing implicit import 'java.lang.*' 4 175
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.Double.parseDouble' due to existing implicit import 'java.lang.*' 4 188
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.Double.parseDouble' due to existing implicit import 'java.lang.*' 4 199
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.Double.parseDouble' due to existing implicit import 'java.lang.*' 4 210
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.Double.parseDouble' due to existing implicit import 'java.lang.*' 4 221
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.Double.parseDouble' due to existing implicit import 'java.lang.*' 4 232
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.Double.parseDouble' due to existing implicit import 'java.lang.*' 4 243

org/opentrafficsim/ahfe/AHFEUtil.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'generationSpeed'. 3 354
UnusedFormalParameter Avoid unused method parameters such as 'gtuColorer'. 3 357
UnusedFormalParameter Avoid unused method parameters such as 'bcFactory'. 3 357
UnusedFormalParameter Avoid unused method parameters such as 'simulationTime'. 3 358
UnusedFormalParameter Avoid unused method parameters such as 'tacticalFactory'. 3 358

org/opentrafficsim/ahfe/DelayedNeighborsPerception.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'perc'. 3 271
EmptyCatchBlock Avoid empty catch blocks 3 314–317
EmptyCatchBlock Avoid empty catch blocks 3 351–354
UnusedFormalParameter Avoid unused method parameters such as 'egoSpeed'. 3 423

org/opentrafficsim/demo/CircularLaneSwing.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 60

org/opentrafficsim/demo/CircularRoadSwing.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.awt.Window' 4 6
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 74

org/opentrafficsim/demo/CrossingTrafficLightsSwing.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 43

org/opentrafficsim/demo/FundamentalDiagrams.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 92

org/opentrafficsim/demo/NetworksSwing.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 68

org/opentrafficsim/demo/RampMeteringDemo.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'part'. 3 230
UnusedLocalVariable Avoid unused local variables such as 'lanesBC'. 3 283
UnusedLocalVariable Avoid unused local variables such as 'lanesFB'. 3 290
UselessParentheses Useless parentheses. 4 639
UselessParentheses Useless parentheses. 4 640

org/opentrafficsim/demo/SequentialLanes.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 100

org/opentrafficsim/demo/ShortMerge.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 154
EmptyIfStmt Avoid empty if statements 3 293–295
UnusedFormalParameter Avoid unused method parameters such as 'generationSpeed'. 3 440
UnusedFormalParameter Avoid unused method parameters such as 'gtuColorer'. 3 442
UnusedFormalParameter Avoid unused method parameters such as 'bcFactory'. 3 442
UnusedFormalParameter Avoid unused method parameters such as 'simulationTime'. 3 443
UnusedFormalParameter Avoid unused method parameters such as 'tacticalFactory'. 3 443

org/opentrafficsim/demo/StraightSwing.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 60

org/opentrafficsim/demo/conflictAndControl/DemoTrafcodAndTurbo.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 75

org/opentrafficsim/demo/conflict/BusStreetDemo.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 111

org/opentrafficsim/demo/conflict/TJunctionDemo.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 59
EmptyStatementBlock Avoid empty block statements. 3 185–187

org/opentrafficsim/demo/conflict/TestNetworkDemo.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 55

org/opentrafficsim/demo/conflict/TurboRoundaboutDemo.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 58
EmptyStatementBlock Avoid empty block statements. 3 200–202

org/opentrafficsim/demo/geometry/TestModel.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 199–202

org/opentrafficsim/demo/geometry/shape/ShapeFileReader.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'line'. 3 223
UnusedLocalVariable Avoid unused local variables such as 'length'. 3 230
UnusedLocalVariable Avoid unused local variables such as 'linkTag'. 3 235
UnusedLocalVariable Avoid unused local variables such as 'wegtype'. 3 236
UnusedLocalVariable Avoid unused local variables such as 'typeWeg'. 3 238
UnusedLocalVariable Avoid unused local variables such as 'speed'. 3 240
UnusedLocalVariable Avoid unused local variables such as 'capacity'. 3 242
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 323
UnusedLocalVariable Avoid unused local variables such as 'dir'. 3 438
UselessParentheses Useless parentheses. 4 439
EmptyCatchBlock Avoid empty catch blocks 3 472–475
UnusedLocalVariable Avoid unused local variables such as 'dir'. 3 504
UselessParentheses Useless parentheses. 4 505
EmptyCatchBlock Avoid empty catch blocks 3 540–543

org/opentrafficsim/demo/lanechange/LaneChangeGraph.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'speed'. 3 418

org/opentrafficsim/demo/network/xml/Grid10X10.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'defaultAnimationFactory'. 3 214

org/opentrafficsim/demo/network/xml/N201ODfactory.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'colorer'. 3 149

org/opentrafficsim/demo/network/xml/TestXMLParserAmsterdam.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'defaultAnimationFactory'. 3 72

org/opentrafficsim/demo/sdm/SdmSimulation.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 475
UselessQualifiedThis Useless qualified this usage in the same class. 3 479
UselessQualifiedThis Useless qualified this usage in the same class. 3 483
UselessQualifiedThis Useless qualified this usage in the same class. 3 484

org/opentrafficsim/demo/steering/SteeringSimulation.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 177

org/opentrafficsim/demo/trafficcontrol/TrafCODDemo1.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 66
UnusedFormalParameter Avoid unused constructor parameters such as 'shortName'. 3 158
UnusedFormalParameter Avoid unused constructor parameters such as 'description'. 3 158

org/opentrafficsim/demo/trafficcontrol/TrafCODDemo2.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 66

org/opentrafficsim/demo/trafficcontrol/TrafCODDemo2_Generators.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'title'. 3 59

org/opentrafficsim/demo/web/OTSDemoServer.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 192–195
EmptyCatchBlock Avoid empty catch blocks 3 201–204
CollapsibleIfStatements These nested if statements could be combined 3 263–267
EmptyIfStmt Avoid empty if statements 3 589–591
EmptyIfStmt Avoid empty if statements 3 593–595
EmptyIfStmt Avoid empty if statements 3 597–599
EmptyIfStmt Avoid empty if statements 3 601–603

org/opentrafficsim/demo/web/OTSFederatedDemoServer.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 470–472
EmptyIfStmt Avoid empty if statements 3 474–476
EmptyIfStmt Avoid empty if statements 3 478–480
EmptyIfStmt Avoid empty if statements 3 482–484

org/opentrafficsim/demo/web/SimpleLoadBalancer.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'lbSocket'. 3 45
UnusedPrivateField Avoid unused private fields such as 'lbContext'. 3 48
UnusedPrivateField Avoid unused private fields such as 'messageCount'. 3 51

org/opentrafficsim/demo/web/SuperDemoWebApplication.java

Rule Violation Priority Line
EmptyTryBlock Avoid empty try blocks 3 363–389
EmptyTryBlock Avoid empty try blocks 3 458–481

strategies/LmrsStrategies.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 367–368
UselessQualifiedThis Useless qualified this usage in the same class. 3 972
UselessQualifiedThis Useless qualified this usage in the same class. 3 974
UselessQualifiedThis Useless qualified this usage in the same class. 3 978
UselessQualifiedThis Useless qualified this usage in the same class. 3 1007
UselessQualifiedThis Useless qualified this usage in the same class. 3 1009
UselessQualifiedThis Useless qualified this usage in the same class. 3 1009
UselessQualifiedThis Useless qualified this usage in the same class. 3 1013
UselessQualifiedThis Useless qualified this usage in the same class. 3 1013

strategies/StrategiesDemo.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.awt.BorderLayout' 4 3
UselessQualifiedThis Useless qualified this usage in the same class. 3 354