Checkstyle Results

The following document contains the results of Checkstyle 8.35 with development/dsol-checks.xml ruleset. 

rss feed

Summary

Files
 Info
 Warnings
 Errors
24 3 356 0

Files

File
 I
 W
 E
nl/tudelft/simulation/dsol/jetty/sse/OTSWebModel.java 0 2 0
nl/tudelft/simulation/dsol/jetty/sse/OTSWebServer.java 1 20 0
nl/tudelft/simulation/dsol/jetty/sse/TestDemoServer.java 0 32 0
nl/tudelft/simulation/dsol/web/animation/D2/HTMLGridPanel.java 0 14 0
nl/tudelft/simulation/dsol/web/animation/D2/ToggleButtonInfo.java 0 13 0
nl/tudelft/simulation/dsol/web/animation/HTMLDevice.java 0 1 0
nl/tudelft/simulation/dsol/web/animation/HTMLGraphics2D.java 2 235 0
nl/tudelft/simulation/dsol/web/animation/HTMLGraphicsConfiguration.java 0 6 0
nl/tudelft/simulation/dsol/web/animation/HTMLGraphicsEnvironment.java 0 5 0
nl/tudelft/simulation/dsol/web/animation/HTMLToolkit.java 0 24 0
org/opentrafficsim/web/animation/WebAnimationToggles.java 0 4 0

Rules

Category Rule Violations Severity
blocks EmptyBlock 4
 Warning
NeedBraces 57
 Warning
coding HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
3
 Warning
design DesignForExtension 1
 Warning
VisibilityModifier 22
 Warning
imports UnusedImports 1
 Warning
javadoc JavadocMethod 8
 Warning
misc FinalParameters 250
 Warning
TodoComment 4
 Warning
modifier ModifierOrder 2
 Warning
RedundantModifier 2
 Warning
naming ParameterName 2
 Warning
sizes MethodLength 1
 Info
ParameterNumber 2
 Info

Details

nl/tudelft/simulation/dsol/jetty/sse/OTSWebModel.java

Severity Category Rule Message Line
 Warning
imports UnusedImports Unused import - org.djutils.event.Event. 18
 Warning
coding HiddenField 'animationPanel' hides a field. 253

nl/tudelft/simulation/dsol/jetty/sse/OTSWebServer.java

Severity Category Rule Message Line
 Warning
misc FinalParameters Parameter event should be final. 228
 Warning
design VisibilityModifier Variable 'webServer' must be private and have accessor methods. 251
 Warning
design DesignForExtension Class 'XHRHandler' looks like designed for extension (can be subclassed), but the method 'handle' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'XHRHandler' final or making the method 'handle' static/final/abstract/empty, or adding allowed annotation for the method. 268
 Info
sizes MethodLength Method length is 319 lines (max allowed is 150). 268
 Warning
misc FinalParameters Parameter target should be final. 269
 Warning
misc FinalParameters Parameter baseRequest should be final. 269
 Warning
misc FinalParameters Parameter request should be final. 269
 Warning
misc FinalParameters Parameter response should be final. 269
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 306
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 321
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 323
 Warning
blocks NeedBraces 'for' construct must use '{}'s. 430
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 450
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 463
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 525
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 534
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 536
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 541
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 543
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 567
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 569

nl/tudelft/simulation/dsol/jetty/sse/TestDemoServer.java

Severity Category Rule Message Line
 Warning
design VisibilityModifier Variable 'sessionModelMap' must be private and have accessor methods. 68
 Warning
design VisibilityModifier Variable 'sessionWebModelMap' must be private and have accessor methods. 71
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 169
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 171
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 173
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 175
 Warning
misc FinalParameters Parameter model should be final. 300
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 378
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 380
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 395
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 397
 Warning
blocks EmptyBlock Must have at least one statement. 403
 Warning
blocks EmptyBlock Must have at least one statement. 407
 Warning
blocks EmptyBlock Must have at least one statement. 411
 Warning
blocks EmptyBlock Must have at least one statement. 415
 Warning
javadoc JavadocMethod Expected @param tag for '<U>'. 424
 Warning
javadoc JavadocMethod Expected @param tag for '<T>'. 425
 Warning
misc FinalParameters Parameter parameter should be final. 425
 Warning
javadoc JavadocMethod Expected @param tag for '<U>'. 434
 Warning
javadoc JavadocMethod Expected @param tag for '<T>'. 435
 Warning
misc FinalParameters Parameter parameter should be final. 435
 Warning
javadoc JavadocMethod Expected @param tag for '<U>'. 449
 Warning
javadoc JavadocMethod Expected @param tag for '<T>'. 450
 Warning
misc FinalParameters Parameter parameter should be final. 450
 Warning
javadoc JavadocMethod Expected @param tag for '<U>'. 459
 Warning
javadoc JavadocMethod Expected @param tag for '<T>'. 460
 Warning
misc FinalParameters Parameter parameter should be final. 460
 Warning
misc FinalParameters Parameter model should be final. 476
 Warning
misc FinalParameters Parameter message should be final. 476
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 535
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 540
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 553

nl/tudelft/simulation/dsol/web/animation/D2/HTMLGridPanel.java

Severity Category Rule Message Line
 Warning
design VisibilityModifier Variable 'htmlGraphics2D' must be private and have accessor methods. 106
 Warning
misc FinalParameters Parameter size should be final. 404
 Warning
misc FinalParameters Parameter background should be final. 420
 Warning
misc FinalParameters Parameter preferredSize should be final. 452
 Warning
misc FinalParameters Parameter toolTipText should be final. 468
 Warning
misc FinalParameters Parameter showing should be final. 484
 Warning
misc FinalParameters Parameter font should be final. 500
 Warning
misc FinalParameters Parameter font should be final. 509
 Warning
misc FinalParameters Parameter img should be final. 524
 Warning
misc FinalParameters Parameter infoflags should be final. 524
 Warning
misc FinalParameters Parameter x should be final. 524
 Warning
misc FinalParameters Parameter y should be final. 524
 Warning
misc FinalParameters Parameter width should be final. 524
 Warning
misc FinalParameters Parameter height should be final. 524

nl/tudelft/simulation/dsol/web/animation/D2/ToggleButtonInfo.java

Severity Category Rule Message Line
 Warning
misc FinalParameters Parameter name should be final. 25
 Warning
misc FinalParameters Parameter visible should be final. 25
 Warning
misc FinalParameters Parameter visible should be final. 42
 Warning
misc FinalParameters Parameter name should be final. 77
 Warning
misc FinalParameters Parameter locatableClass should be final. 77
 Warning
misc FinalParameters Parameter toolTipText should be final. 77
 Warning
misc FinalParameters Parameter visible should be final. 77
 Warning
misc FinalParameters Parameter name should be final. 115
 Warning
misc FinalParameters Parameter visible should be final. 115
 Warning
misc FinalParameters Parameter name should be final. 143
 Warning
misc FinalParameters Parameter layerName should be final. 143
 Warning
misc FinalParameters Parameter toolTipText should be final. 143
 Warning
misc FinalParameters Parameter visible should be final. 143

nl/tudelft/simulation/dsol/web/animation/HTMLDevice.java

Severity Category Rule Message Line
 Warning
misc FinalParameters Parameter htmlGraphicsConfiguration should be final. 27

nl/tudelft/simulation/dsol/web/animation/HTMLGraphics2D.java

Severity Category Rule Message Line
 Warning
design VisibilityModifier Variable 'background' must be private and have accessor methods. 53
 Warning
design VisibilityModifier Variable 'color' must be private and have accessor methods. 56
 Warning
design VisibilityModifier Variable 'font' must be private and have accessor methods. 59
 Warning
design VisibilityModifier Variable 'canvas' must be private and have accessor methods. 62
 Warning
design VisibilityModifier Variable 'fontMetrics' must be private and have accessor methods. 65
 Warning
design VisibilityModifier Variable 'paint' must be private and have accessor methods. 68
 Warning
design VisibilityModifier Variable 'stroke' must be private and have accessor methods. 71
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 73
 Warning
design VisibilityModifier Variable 'renderingHints' must be private and have accessor methods. 74
 Warning
design VisibilityModifier Variable 'affineTransform' must be private and have accessor methods. 77
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 79
 Warning
design VisibilityModifier Variable 'composite' must be private and have accessor methods. 80
 Warning
design VisibilityModifier Variable 'commands' must be private and have accessor methods. 83
 Warning
misc FinalParameters Parameter drawCommand should be final. 109
 Warning
misc FinalParameters Parameter params should be final. 109
 Warning
misc FinalParameters Parameter c should be final. 142
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 164
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 167
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 170
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 172
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 178
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 180
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 182
 Warning
misc FinalParameters Parameter fillCommand should be final. 193
 Warning
misc FinalParameters Parameter params should be final. 193
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 197
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 199
 Warning
misc FinalParameters Parameter drawCommand should be final. 215
 Warning
misc FinalParameters Parameter params should be final. 215
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 219
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 221
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 223
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 225
 Warning
misc FinalParameters Parameter path should be final. 278
 Warning
misc FinalParameters Parameter fill should be final. 278
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 280
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 282
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 288
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 290
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 295
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 297
 Warning
misc FinalParameters Parameter path should be final. 352
 Warning
misc FinalParameters Parameter fill should be final. 352
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 354
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 356
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 362
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 364
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 369
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 371
 Warning
misc FinalParameters Parameter drawCommand should be final. 415
 Warning
misc FinalParameters Parameter params should be final. 415
 Warning
misc FinalParameters Parameter shape should be final. 430
 Warning
misc FinalParameters Parameter shape should be final. 440
 Warning
misc FinalParameters Parameter fill should be final. 440
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 446
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 449
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 456
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 459
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 476
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 478
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 484
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 486
 Warning
misc FinalParameters Parameter img should be final. 510
 Warning
misc FinalParameters Parameter xform should be final. 510
 Warning
misc FinalParameters Parameter obs should be final. 510
 Warning
misc FinalParameters Parameter img should be final. 518
 Warning
misc FinalParameters Parameter op should be final. 518
 Warning
misc FinalParameters Parameter x should be final. 518
 Warning
misc FinalParameters Parameter y should be final. 518
 Warning
misc FinalParameters Parameter img should be final. 525
 Warning
misc FinalParameters Parameter xform should be final. 525
 Warning
misc FinalParameters Parameter img should be final. 532
 Warning
misc FinalParameters Parameter xform should be final. 532
 Warning
misc FinalParameters Parameter str should be final. 539
 Warning
misc FinalParameters Parameter x should be final. 539
 Warning
misc FinalParameters Parameter y should be final. 539
 Warning
misc FinalParameters Parameter str should be final. 547
 Warning
misc FinalParameters Parameter x should be final. 547
 Warning
misc FinalParameters Parameter y should be final. 547
 Warning
misc FinalParameters Parameter iterator should be final. 555
 Warning
misc FinalParameters Parameter x should be final. 555
 Warning
misc FinalParameters Parameter y should be final. 555
 Warning
misc FinalParameters Parameter iterator should be final. 562
 Warning
misc FinalParameters Parameter x should be final. 562
 Warning
misc FinalParameters Parameter y should be final. 562
 Warning
misc FinalParameters Parameter g should be final. 569
 Warning
misc FinalParameters Parameter x should be final. 569
 Warning
misc FinalParameters Parameter y should be final. 569
 Warning
misc FinalParameters Parameter shape should be final. 576
 Warning
misc FinalParameters Parameter rect should be final. 584
 Warning
misc FinalParameters Parameter s should be final. 584
 Warning
misc FinalParameters Parameter onStroke should be final. 584
 Warning
misc FinalParameters Parameter comp should be final. 600
 Warning
misc FinalParameters Parameter paint should be final. 607
 Warning
misc FinalParameters Parameter s should be final. 615
 Warning
misc FinalParameters Parameter hintKey should be final. 623
 Warning
misc FinalParameters Parameter hintValue should be final. 623
 Warning
misc FinalParameters Parameter hintKey should be final. 631
 Warning
misc FinalParameters Parameter hints should be final. 639
 Warning
misc FinalParameters Parameter hints should be final. 648
 Warning
misc FinalParameters Parameter x should be final. 664
 Warning
misc FinalParameters Parameter y should be final. 664
 Warning
misc FinalParameters Parameter tx should be final. 672
 Warning
misc FinalParameters Parameter ty should be final. 672
 Warning
misc FinalParameters Parameter theta should be final. 680
 Warning
misc FinalParameters Parameter theta should be final. 688
 Warning
misc FinalParameters Parameter x should be final. 688
 Warning
misc FinalParameters Parameter y should be final. 688
 Warning
misc FinalParameters Parameter sx should be final. 696
 Warning
misc FinalParameters Parameter sy should be final. 696
 Warning
misc FinalParameters Parameter shx should be final. 704
 Warning
misc FinalParameters Parameter shy should be final. 704
 Warning
misc FinalParameters Parameter Tx should be final. 712
 Warning
naming ParameterName Name 'Tx' must match pattern '^[a-z][a-zA-Z0-9]*$'. 712
 Warning
misc FinalParameters Parameter Tx should be final. 719
 Warning
naming ParameterName Name 'Tx' must match pattern '^[a-z][a-zA-Z0-9]*$'. 719
 Warning
misc FinalParameters Parameter color should be final. 751
 Warning
coding HiddenField 'color' hides a field. 751
 Warning
misc FinalParameters Parameter s should be final. 775
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 793
 Warning
misc FinalParameters Parameter c should be final. 806
 Warning
misc FinalParameters Parameter c1 should be final. 822
 Warning
misc FinalParameters Parameter font should be final. 837
 Warning
misc FinalParameters Parameter f should be final. 846
 Warning
misc FinalParameters Parameter x should be final. 862
 Warning
misc FinalParameters Parameter y should be final. 862
 Warning
misc FinalParameters Parameter width should be final. 862
 Warning
misc FinalParameters Parameter height should be final. 862
 Warning
misc FinalParameters Parameter x should be final. 869
 Warning
misc FinalParameters Parameter y should be final. 869
 Warning
misc FinalParameters Parameter width should be final. 869
 Warning
misc FinalParameters Parameter height should be final. 869
 Warning
misc FinalParameters Parameter clip should be final. 884
 Warning
misc FinalParameters Parameter x should be final. 891
 Warning
misc FinalParameters Parameter y should be final. 891
 Warning
misc FinalParameters Parameter width should be final. 891
 Warning
misc FinalParameters Parameter height should be final. 891
 Warning
misc FinalParameters Parameter dx should be final. 891
 Warning
misc FinalParameters Parameter dy should be final. 891
 Warning
misc FinalParameters Parameter x1 should be final. 898
 Warning
misc FinalParameters Parameter y1 should be final. 898
 Warning
misc FinalParameters Parameter x2 should be final. 898
 Warning
misc FinalParameters Parameter y2 should be final. 898
 Warning
misc FinalParameters Parameter x should be final. 906
 Warning
misc FinalParameters Parameter y should be final. 906
 Warning
misc FinalParameters Parameter width should be final. 906
 Warning
misc FinalParameters Parameter height should be final. 906
 Warning
misc FinalParameters Parameter x should be final. 914
 Warning
misc FinalParameters Parameter y should be final. 914
 Warning
misc FinalParameters Parameter width should be final. 914
 Warning
misc FinalParameters Parameter height should be final. 914
 Warning
misc FinalParameters Parameter x should be final. 922
 Warning
misc FinalParameters Parameter y should be final. 922
 Warning
misc FinalParameters Parameter width should be final. 922
 Warning
misc FinalParameters Parameter height should be final. 922
 Warning
misc FinalParameters Parameter arcWidth should be final. 922
 Warning
misc FinalParameters Parameter arcHeight should be final. 922
 Warning
misc FinalParameters Parameter x should be final. 929
 Warning
misc FinalParameters Parameter y should be final. 929
 Warning
misc FinalParameters Parameter width should be final. 929
 Warning
misc FinalParameters Parameter height should be final. 929
 Warning
misc FinalParameters Parameter arcWidth should be final. 929
 Warning
misc FinalParameters Parameter arcHeight should be final. 929
 Warning
misc FinalParameters Parameter x should be final. 936
 Warning
misc FinalParameters Parameter y should be final. 936
 Warning
misc FinalParameters Parameter width should be final. 936
 Warning
misc FinalParameters Parameter height should be final. 936
 Warning
misc FinalParameters Parameter x should be final. 944
 Warning
misc FinalParameters Parameter y should be final. 944
 Warning
misc FinalParameters Parameter width should be final. 944
 Warning
misc FinalParameters Parameter height should be final. 944
 Warning
misc FinalParameters Parameter x should be final. 952
 Warning
misc FinalParameters Parameter y should be final. 952
 Warning
misc FinalParameters Parameter width should be final. 952
 Warning
misc FinalParameters Parameter height should be final. 952
 Warning
misc FinalParameters Parameter startAngle should be final. 952
 Warning
misc FinalParameters Parameter arcAngle should be final. 952
 Warning
misc FinalParameters Parameter x should be final. 959
 Warning
misc FinalParameters Parameter y should be final. 959
 Warning
misc FinalParameters Parameter width should be final. 959
 Warning
misc FinalParameters Parameter height should be final. 959
 Warning
misc FinalParameters Parameter startAngle should be final. 959
 Warning
misc FinalParameters Parameter arcAngle should be final. 959
 Warning
misc FinalParameters Parameter xPoints should be final. 966
 Warning
misc FinalParameters Parameter yPoints should be final. 966
 Warning
misc FinalParameters Parameter nPoints should be final. 966
 Warning
misc FinalParameters Parameter xPoints should be final. 973
 Warning
misc FinalParameters Parameter yPoints should be final. 973
 Warning
misc FinalParameters Parameter nPoints should be final. 973
 Warning
misc FinalParameters Parameter xPoints should be final. 980
 Warning
misc FinalParameters Parameter yPoints should be final. 980
 Warning
misc FinalParameters Parameter nPoints should be final. 980
 Warning
misc FinalParameters Parameter img should be final. 987
 Warning
misc FinalParameters Parameter x should be final. 987
 Warning
misc FinalParameters Parameter y should be final. 987
 Warning
misc FinalParameters Parameter observer should be final. 987
 Warning
misc FinalParameters Parameter img should be final. 995
 Warning
misc FinalParameters Parameter x should be final. 995
 Warning
misc FinalParameters Parameter y should be final. 995
 Warning
misc FinalParameters Parameter width should be final. 995
 Warning
misc FinalParameters Parameter height should be final. 995
 Warning
misc FinalParameters Parameter observer should be final. 995
 Warning
misc FinalParameters Parameter img should be final. 1003
 Warning
misc FinalParameters Parameter x should be final. 1003
 Warning
misc FinalParameters Parameter y should be final. 1003
 Warning
misc FinalParameters Parameter bgcolor should be final. 1003
 Warning
misc FinalParameters Parameter observer should be final. 1003
 Warning
misc FinalParameters Parameter img should be final. 1011
 Warning
misc FinalParameters Parameter x should be final. 1011
 Warning
misc FinalParameters Parameter y should be final. 1011
 Warning
misc FinalParameters Parameter width should be final. 1011
 Warning
misc FinalParameters Parameter height should be final. 1011
 Warning
misc FinalParameters Parameter bgcolor should be final. 1011
 Warning
misc FinalParameters Parameter observer should be final. 1011
 Info
sizes ParameterNumber More than 7 parameters (found 10). 1019
 Warning
misc FinalParameters Parameter img should be final. 1019
 Warning
misc FinalParameters Parameter dx1 should be final. 1019
 Warning
misc FinalParameters Parameter dy1 should be final. 1019
 Warning
misc FinalParameters Parameter dx2 should be final. 1019
 Warning
misc FinalParameters Parameter dy2 should be final. 1019
 Warning
misc FinalParameters Parameter sx1 should be final. 1019
 Warning
misc FinalParameters Parameter sy1 should be final. 1019
 Warning
misc FinalParameters Parameter sx2 should be final. 1019
 Warning
misc FinalParameters Parameter sy2 should be final. 1019
 Warning
misc FinalParameters Parameter observer should be final. 1020
 Info
sizes ParameterNumber More than 7 parameters (found 11). 1028
 Warning
misc FinalParameters Parameter img should be final. 1028
 Warning
misc FinalParameters Parameter dx1 should be final. 1028
 Warning
misc FinalParameters Parameter dy1 should be final. 1028
 Warning
misc FinalParameters Parameter dx2 should be final. 1028
 Warning
misc FinalParameters Parameter dy2 should be final. 1028
 Warning
misc FinalParameters Parameter sx1 should be final. 1028
 Warning
misc FinalParameters Parameter sy1 should be final. 1028
 Warning
misc FinalParameters Parameter sx2 should be final. 1028
 Warning
misc FinalParameters Parameter sy2 should be final. 1028
 Warning
misc FinalParameters Parameter bgcolor should be final. 1028
 Warning
misc FinalParameters Parameter observer should be final. 1029

nl/tudelft/simulation/dsol/web/animation/HTMLGraphicsConfiguration.java

Severity Category Rule Message Line
 Warning
design VisibilityModifier Variable 'htmlDevice' must be private and have accessor methods. 27
 Warning
design VisibilityModifier Variable 'identityTransform' must be private and have accessor methods. 30
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 32
 Warning
design VisibilityModifier Variable 'bounds' must be private and have accessor methods. 33
 Warning
coding HiddenField 'htmlDevice' hides a field. 56
 Warning
misc FinalParameters Parameter transparency should be final. 72

nl/tudelft/simulation/dsol/web/animation/HTMLGraphicsEnvironment.java

Severity Category Rule Message Line
 Warning
design VisibilityModifier Variable 'htmlDevice' must be private and have accessor methods. 27
 Warning
design VisibilityModifier Variable 'graphics2D' must be private and have accessor methods. 30
 Warning
design VisibilityModifier Variable 'graphicsConfiguration' must be private and have accessor methods. 33
 Warning
misc FinalParameters Parameter img should be final. 65
 Warning
misc FinalParameters Parameter l should be final. 89

nl/tudelft/simulation/dsol/web/animation/HTMLToolkit.java

Severity Category Rule Message Line
 Warning
design VisibilityModifier Variable 'eventQueue' must be private and have accessor methods. 40
 Warning
misc FinalParameters Parameter font should be final. 83
 Warning
misc FinalParameters Parameter filename should be final. 98
 Warning
misc FinalParameters Parameter url should be final. 106
 Warning
misc FinalParameters Parameter filename should be final. 114
 Warning
misc FinalParameters Parameter url should be final. 122
 Warning
misc FinalParameters Parameter image should be final. 130
 Warning
misc FinalParameters Parameter width should be final. 130
 Warning
misc FinalParameters Parameter height should be final. 130
 Warning
misc FinalParameters Parameter observer should be final. 130
 Warning
misc FinalParameters Parameter image should be final. 138
 Warning
misc FinalParameters Parameter width should be final. 138
 Warning
misc FinalParameters Parameter height should be final. 138
 Warning
misc FinalParameters Parameter observer should be final. 138
 Warning
misc FinalParameters Parameter producer should be final. 146
 Warning
misc FinalParameters Parameter imagedata should be final. 154
 Warning
misc FinalParameters Parameter imageoffset should be final. 154
 Warning
misc FinalParameters Parameter imagelength should be final. 154
 Warning
misc FinalParameters Parameter frame should be final. 162
 Warning
misc FinalParameters Parameter jobtitle should be final. 162
 Warning
misc FinalParameters Parameter props should be final. 162
 Warning
misc FinalParameters Parameter modalityType should be final. 194
 Warning
misc FinalParameters Parameter modalExclusionType should be final. 202
 Warning
misc FinalParameters Parameter highlight should be final. 210

org/opentrafficsim/web/animation/WebAnimationToggles.java

Severity Category Rule Message Line
 Warning
modifier RedundantModifier Redundant 'final' modifier. 105
 Warning
modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 105
 Warning
modifier RedundantModifier Redundant 'final' modifier. 115
 Warning
modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 115