Checkstyle Results

The following document contains the results of Checkstyle 8.35 with development/dsol-checks.xml ruleset. 

rss feed

Summary

Files
 Info
 Warnings
 Errors
24 8 51 0

Files

File
 I
 W
 E
org/opentrafficsim/road/network/factory/xml/demand/CategoryTag.java 0 1 0
org/opentrafficsim/road/network/factory/xml/demand/DemandTag.java 2 11 0
org/opentrafficsim/road/network/factory/xml/demand/XmlOdParser.java 1 7 0
org/opentrafficsim/road/network/factory/xml/parser/DefinitionsParser.java 0 6 0
org/opentrafficsim/road/network/factory/xml/parser/GeneratorSinkParser.java 0 3 0
org/opentrafficsim/road/network/factory/xml/parser/ModelParser.java 3 3 0
org/opentrafficsim/road/network/factory/xml/parser/NetworkParser.java 1 5 0
org/opentrafficsim/road/network/factory/xml/parser/ODParser.java 1 5 0
org/opentrafficsim/road/network/factory/xml/parser/RunParser.java 0 1 0
org/opentrafficsim/road/network/factory/xml/parser/ScenarioParser.java 0 2 0
org/opentrafficsim/road/network/factory/xml/parser/XmlNetworkLaneParser.java 0 1 0
org/opentrafficsim/road/network/factory/xml/utils/Cloner.java 0 2 0
org/opentrafficsim/road/network/factory/xml/utils/ParseDistribution.java 0 1 0
org/opentrafficsim/road/network/factory/xml/utils/StreamInformation.java 0 1 0
org/opentrafficsim/road/network/factory/xml/utils/Transformer.java 0 2 0

Rules

Category Rule Violations Severity
blocks EmptyBlock 1
 Warning
NeedBraces 4
 Warning
design FinalClass 1
 Warning
HideUtilityClassConstructor 1
 Warning
VisibilityModifier 17
 Warning
misc FinalParameters 6
 Warning
TodoComment 19
 Warning
modifier ModifierOrder 2
 Warning
sizes LineLength
  • max: "128"
 3
 Info
MethodLength 5
 Info

Details

org/opentrafficsim/road/network/factory/xml/demand/CategoryTag.java

Severity Category Rule Message Line
 Warning		 design VisibilityModifier Variable 'factor' must be private and have accessor methods. 47

org/opentrafficsim/road/network/factory/xml/demand/DemandTag.java

Severity Category Rule Message Line
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 44
 Warning		 design VisibilityModifier Variable 'origin' must be private and have accessor methods. 47
 Warning		 design VisibilityModifier Variable 'destination' must be private and have accessor methods. 50
 Warning		 design VisibilityModifier Variable 'interpolation' must be private and have accessor methods. 53
 Warning		 design VisibilityModifier Variable 'category' must be private and have accessor methods. 56
 Warning		 design VisibilityModifier Variable 'categoryName' must be private and have accessor methods. 59
 Warning		 design VisibilityModifier Variable 'demandType' must be private and have accessor methods. 62
 Warning		 design VisibilityModifier Variable 'timeVector' must be private and have accessor methods. 65
 Warning		 design VisibilityModifier Variable 'demandVector' must be private and have accessor methods. 68
 Warning		 design VisibilityModifier Variable 'factor' must be private and have accessor methods. 71
 Warning		 design VisibilityModifier Variable 'factors' must be private and have accessor methods. 74
 Info		 sizes LineLength Line is longer than 128 characters (found 141). 179
 Info		 sizes LineLength Line is longer than 128 characters (found 130). 190

org/opentrafficsim/road/network/factory/xml/demand/XmlOdParser.java

Severity Category Rule Message Line
 Warning		 design VisibilityModifier Variable 'network' must be private and have accessor methods. 70
 Warning		 design VisibilityModifier Variable 'categorization' must be private and have accessor methods. 76
 Warning		 design VisibilityModifier Variable 'categories' must be private and have accessor methods. 79
 Warning		 design VisibilityModifier Variable 'globalTime' must be private and have accessor methods. 82
 Warning		 design VisibilityModifier Variable 'globalInterpolation' must be private and have accessor methods. 85
 Warning		 design VisibilityModifier Variable 'demand' must be private and have accessor methods. 88
 Info		 sizes MethodLength Method length is 172 lines (max allowed is 150). 254
 Warning		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 434

org/opentrafficsim/road/network/factory/xml/parser/DefinitionsParser.java

Severity Category Rule Message Line
 Warning		 misc FinalParameters Parameter streamMap should be final. 63
 Warning		 misc FinalParameters Parameter linkTypeSpeedLimitMap should be final. 64
 Warning		 blocks NeedBraces 'else' construct must use '{}'s. 108
 Warning		 blocks NeedBraces 'else' construct must use '{}'s. 215
 Warning		 misc FinalParameters Parameter gtuTemplates should be final. 231
 Warning		 misc FinalParameters Parameter streamMap should be final. 231

org/opentrafficsim/road/network/factory/xml/parser/GeneratorSinkParser.java

Severity Category Rule Message Line
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 138
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 332
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 347

org/opentrafficsim/road/network/factory/xml/parser/ModelParser.java

Severity Category Rule Message Line
 Warning		 design FinalClass Class ModelParser should be declared as final. 149
 Info		 sizes MethodLength Method length is 166 lines (max allowed is 150). 170
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 398
 Info		 sizes MethodLength Method length is 199 lines (max allowed is 150). 475
 Info		 sizes MethodLength Method length is 240 lines (max allowed is 150). 896
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 1087

org/opentrafficsim/road/network/factory/xml/parser/NetworkParser.java

Severity Category Rule Message Line
 Info		 sizes MethodLength Method length is 165 lines (max allowed is 150). 156
 Warning		 blocks EmptyBlock Must have at least one statement. 296
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 299
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 310
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 418
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 485

org/opentrafficsim/road/network/factory/xml/parser/ODParser.java

Severity Category Rule Message Line
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 149
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 163
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 323
 Info		 sizes LineLength Line is longer than 128 characters (found 136). 373
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 441
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 489

org/opentrafficsim/road/network/factory/xml/parser/RunParser.java

Severity Category Rule Message Line
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 102

org/opentrafficsim/road/network/factory/xml/parser/ScenarioParser.java

Severity Category Rule Message Line
 Warning		 design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 22
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 34

org/opentrafficsim/road/network/factory/xml/parser/XmlNetworkLaneParser.java

Severity Category Rule Message Line
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 271

org/opentrafficsim/road/network/factory/xml/utils/Cloner.java

Severity Category Rule Message Line
 Warning		 misc FinalParameters Parameter object should be final. 41
 Warning		 misc FinalParameters Parameter in should be final. 63

org/opentrafficsim/road/network/factory/xml/utils/ParseDistribution.java

Severity Category Rule Message Line
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 154

org/opentrafficsim/road/network/factory/xml/utils/StreamInformation.java

Severity Category Rule Message Line
 Warning		 misc TodoComment Comment matches to-do format 'TODO:'. 38

org/opentrafficsim/road/network/factory/xml/utils/Transformer.java

Severity Category Rule Message Line
 Warning		 blocks NeedBraces 'if' construct must use '{}'s. 45
 Warning		 blocks NeedBraces 'else' construct must use '{}'s. 47