PMD Results

The following document contains the results of PMD 6.46.0.

Violations By Priority

Priority 3

org/opentrafficsim/road/gtu/generator/AbstractGTUGeneratorOld.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 347367
CollapsibleIfStatements These nested if statements could be combined 407427

org/opentrafficsim/road/gtu/generator/CFRoomChecker.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 5457

org/opentrafficsim/road/gtu/generator/GeneratorPositions.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'biases'. 78
EmptyCatchBlock Avoid empty catch blocks 296299
EmptyCatchBlock Avoid empty catch blocks 608611
UnnecessaryModifier Unnecessary modifier 'public' on class 'ByValue': members of interface types are implicitly public 10641124

org/opentrafficsim/road/gtu/generator/od/StrategicalPlannerFactorySupplierOD.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'TacticalPlannerFactorySupplierOD': members of interface types are implicitly public 106118

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 1041
PrimitiveWrapperInstantiation Do not use `Boolean.valueOf(false)`, prefer `Boolean.FALSE` 1462
PrimitiveWrapperInstantiation Do not use `Boolean.valueOf(false)`, prefer `Boolean.FALSE` 1471
EmptyCatchBlock Avoid empty catch blocks 15701573
EmptyCatchBlock Avoid empty catch blocks 15861589

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU2.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 14091412

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedIndividualGTU.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 52
SimplifiedTernary Ternary operators that can be simplified with || or && 96

org/opentrafficsim/road/gtu/lane/perception/AbstractPerceptionReiterable.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 125
UselessQualifiedThis Useless qualified this usage in the same class. 127
UselessQualifiedThis Useless qualified this usage in the same class. 128
UselessQualifiedThis Useless qualified this usage in the same class. 132
UselessQualifiedThis Useless qualified this usage in the same class. 133
UselessQualifiedThis Useless qualified this usage in the same class. 316

org/opentrafficsim/road/gtu/lane/perception/DownstreamNeighborsIterable.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 120124

org/opentrafficsim/road/gtu/lane/perception/PerceptionCollectable.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionCollector': members of interface types are implicitly public 7695
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionAccumulator': members of interface types are implicitly public 111121
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionFinalizer': members of interface types are implicitly public 137145

org/opentrafficsim/road/gtu/lane/perception/RollingLaneStructureRecord.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 343348

org/opentrafficsim/road/gtu/lane/perception/categories/DirectDefaultSimplePerception.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 749752
CollapsibleIfStatements These nested if statements could be combined 883900

org/opentrafficsim/road/gtu/lane/perception/categories/LaneBasedAbstractPerceptionCategory.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'context'. 126

org/opentrafficsim/road/gtu/lane/perception/headway/HeadwayStopLine.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 3740

org/opentrafficsim/road/gtu/lane/plan/operational/LaneChange.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'planDistance'. 711
UnusedFormalParameter Avoid unused method parameters such as 'width'. 712
UnusedFormalParameter Avoid unused method parameters such as 'startPosition'. 712
UnusedFormalParameter Avoid unused method parameters such as 'from'. 712
UnusedFormalParameter Avoid unused method parameters such as 'toLine'. 713
UnusedFormalParameter Avoid unused method parameters such as 'fromLine'. 713
UnusedLocalVariable Avoid unused local variables such as 'f'. 725
UnusedLocalVariable Avoid unused local variables such as 'cumulLcLength'. 729

org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'alternativeTried'. 346
UnusedFormalParameter Avoid unused method parameters such as 'startSpeed'. 552

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCFLCTacticalPlanner.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'currentLaneFine'. 150

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedGTUFollowingDirectedChangeTacticalPlanner.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 238245
UnusedFormalParameter Avoid unused method parameters such as 'perception'. 508
UnusedFormalParameter Avoid unused method parameters such as 'lanePathInfo'. 508

org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationBusStop.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 7584

org/opentrafficsim/road/gtu/lane/tactical/routesystem/DefaultRouteSystem.java

Rule Violation Line
UnusedPrivateMethod Avoid unused private methods such as 'determineSet(DirectedLanePosition,Length,Route,GTUType,Length)'. 7879
UnusedFormalParameter Avoid unused method parameters such as 'route'. 78
UnusedFormalParameter Avoid unused method parameters such as 'distance'. 79

org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'gtu'. 715

org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 188200
CollapsibleIfStatements These nested if statements could be combined 498514

org/opentrafficsim/road/gtu/lane/tactical/util/Steering.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'speed'. 93
UnusedLocalVariable Avoid unused local variables such as 'realPlan'. 127

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Cooperation.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'b'. 85
SimplifiedTernary Ternary operators that can be simplified with || or && 93

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsData.java

Rule Violation Line
SimplifiedTernary Ternary operators that can be simplified with || or && 110

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsUtil.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 186203
UnusedPrivateMethod Avoid unused private methods such as 'quickIntersectionScan(Parameters,SpeedLimitInfo,CarFollowingModel,Speed,LateralDirectionality,IntersectionPerception)'. 593595

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Synchronization.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 1836
SimplifiedTernary Ternary operators that can be simplified with || or && 397398
SimplifiedTernary Ternary operators that can be simplified with || or && 414415
UnnecessaryModifier Unnecessary modifier 'public' on method 'getMergeDistance': the method is declared in an interface type 499511

org/opentrafficsim/road/gtu/strategical/route/RouteGeneratorOD.java

Rule Violation Line
UnnecessarySemicolon Unnecessary semicolon 174

org/opentrafficsim/road/network/factory/LaneFactory.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 106
UnusedFormalParameter Avoid unused method parameters such as 'simulator'. 385

org/opentrafficsim/road/network/lane/CrossSectionElement.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'newSimulator'. 346

org/opentrafficsim/road/network/lane/Lane.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 536540
CollapsibleIfStatements These nested if statements could be combined 576580

org/opentrafficsim/road/network/lane/LaneType.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'inverted'. 144

org/opentrafficsim/road/network/lane/NoTrafficLane.java

Rule Violation Line
UnusedPrivateMethod Avoid unused private methods such as 'directionalityNone(RoadNetwork)'. 35

org/opentrafficsim/road/network/lane/conflict/Conflict.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 418439
CollapsibleIfStatements These nested if statements could be combined 848867

org/opentrafficsim/road/network/lane/conflict/ConflictBuilder.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 291294

org/opentrafficsim/road/network/lane/object/BusStop.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 61

org/opentrafficsim/road/network/lane/object/Distraction.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 40

org/opentrafficsim/road/network/lane/object/SpeedSign.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 61

Priority 4

org/opentrafficsim/road/gtu/generator/AbstractGTUGeneratorOld.java

Rule Violation Line
UselessParentheses Useless parentheses. 278
UselessParentheses Useless parentheses. 278
UselessParentheses Useless parentheses. 279
UselessParentheses Useless parentheses. 279

org/opentrafficsim/road/gtu/generator/GeneratorPositions.java

Rule Violation Line
UselessParentheses Useless parentheses. 958
UselessParentheses Useless parentheses. 1167

org/opentrafficsim/road/gtu/generator/od/ODApplier.java

Rule Violation Line
UselessParentheses Useless parentheses. 303

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU2.java

Rule Violation Line
UselessParentheses Useless parentheses. 1158

org/opentrafficsim/road/gtu/lane/VehicleModel.java

Rule Violation Line
UselessParentheses Useless parentheses. 44

org/opentrafficsim/road/gtu/lane/perception/DownstreamNeighborsIterable.java

Rule Violation Line
UselessParentheses Useless parentheses. 102

org/opentrafficsim/road/gtu/lane/perception/RelativeLane.java

Rule Violation Line
UselessParentheses Useless parentheses. 65

org/opentrafficsim/road/gtu/lane/perception/RollingLaneStructure.java

Rule Violation Line
UselessParentheses Useless parentheses. 481
UselessParentheses Useless parentheses. 13331334
UselessParentheses Useless parentheses. 13341335
UselessParentheses Useless parentheses. 14201421
UselessParentheses Useless parentheses. 14211422
UselessParentheses Useless parentheses. 15031504
UselessParentheses Useless parentheses. 1504
UselessParentheses Useless parentheses. 15321533
UselessParentheses Useless parentheses. 1533

org/opentrafficsim/road/gtu/lane/perception/RollingLaneStructureRecord.java

Rule Violation Line
UselessParentheses Useless parentheses. 343344
UselessParentheses Useless parentheses. 344345

org/opentrafficsim/road/gtu/lane/perception/UpstreamNeighborsIterable.java

Rule Violation Line
UselessParentheses Useless parentheses. 75

org/opentrafficsim/road/gtu/lane/perception/categories/DirectDefaultSimplePerception.java

Rule Violation Line
UselessParentheses Useless parentheses. 952
UselessParentheses Useless parentheses. 952
UselessParentheses Useless parentheses. 953
UselessParentheses Useless parentheses. 953

org/opentrafficsim/road/gtu/lane/perception/categories/DirectInfrastructurePerception.java

Rule Violation Line
UselessParentheses Useless parentheses. 411412
UselessParentheses Useless parentheses. 412
UselessParentheses Useless parentheses. 427
UselessParentheses Useless parentheses. 427
UselessParentheses Useless parentheses. 440
UselessParentheses Useless parentheses. 440
UselessParentheses Useless parentheses. 443444
UselessParentheses Useless parentheses. 443
UselessParentheses Useless parentheses. 454
UselessParentheses Useless parentheses. 454455
UselessParentheses Useless parentheses. 654
UselessParentheses Useless parentheses. 654655

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/DirectNeighborsPerception.java

Rule Violation Line
UselessParentheses Useless parentheses. 273274
UselessParentheses Useless parentheses. 275276

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/HeadwayGtuType.java

Rule Violation Line
UselessParentheses Useless parentheses. 211

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/TaskHeadwayCollector.java

Rule Violation Line
UselessParentheses Useless parentheses. 81

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationHeadway.java

Rule Violation Line
UselessParentheses Useless parentheses. 46

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSituationalAwareness.java

Rule Violation Line
UselessParentheses Useless parentheses. 88

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSpeed.java

Rule Violation Line
UselessParentheses Useless parentheses. 41

org/opentrafficsim/road/gtu/lane/perception/mental/Fuller.java

Rule Violation Line
UselessParentheses Useless parentheses. 180

org/opentrafficsim/road/gtu/lane/perception/mental/TaskHeadwayBased.java

Rule Violation Line
UselessParentheses Useless parentheses. 56

org/opentrafficsim/road/gtu/lane/plan/operational/LaneChange.java

Rule Violation Line
UselessParentheses Useless parentheses. 640
UselessParentheses Useless parentheses. 826

org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java

Rule Violation Line
UselessParentheses Useless parentheses. 492

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedGTUFollowingDirectedChangeTacticalPlanner.java

Rule Violation Line
UselessParentheses Useless parentheses. 236
UselessParentheses Useless parentheses. 266
UselessParentheses Useless parentheses. 629

org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveGetInLane.java

Rule Violation Line
UselessParentheses Useless parentheses. 90

org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java

Rule Violation Line
UselessParentheses Useless parentheses. 161
UselessParentheses Useless parentheses. 162163

org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java

Rule Violation Line
UselessParentheses Useless parentheses. 849850

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Cooperation.java

Rule Violation Line
UselessParentheses Useless parentheses. 43
UselessParentheses Useless parentheses. 44
UselessParentheses Useless parentheses. 79
UselessParentheses Useless parentheses. 80
UselessParentheses Useless parentheses. 124
UselessParentheses Useless parentheses. 125

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Synchronization.java

Rule Violation Line
UselessParentheses Useless parentheses. 350
UselessParentheses Useless parentheses. 401402
UselessParentheses Useless parentheses. 426
UselessParentheses Useless parentheses. 736
UselessParentheses Useless parentheses. 736

org/opentrafficsim/road/gtu/strategical/od/SplitFraction.java

Rule Violation Line
UselessParentheses Useless parentheses. 199
UselessParentheses Useless parentheses. 200

org/opentrafficsim/road/gtu/strategical/route/LaneBasedStrategicalRoutePlanner.java

Rule Violation Line
UselessParentheses Useless parentheses. 164
UselessParentheses Useless parentheses. 164
UselessParentheses Useless parentheses. 234
UselessParentheses Useless parentheses. 234235
UselessParentheses Useless parentheses. 250251
UselessParentheses Useless parentheses. 251252

org/opentrafficsim/road/gtu/strategical/route/RouteGeneratorOD.java

Rule Violation Line
UselessParentheses Useless parentheses. 128

org/opentrafficsim/road/network/control/rampmetering/AlineaSwitch.java

Rule Violation Line
UselessParentheses Useless parentheses. 60

org/opentrafficsim/road/network/control/rampmetering/RwsSwitch.java

Rule Violation Line
UselessParentheses Useless parentheses. 63

org/opentrafficsim/road/network/lane/CrossSectionElement.java

Rule Violation Line
UselessParentheses Useless parentheses. 269
UselessParentheses Useless parentheses. 270
UselessParentheses Useless parentheses. 270

org/opentrafficsim/road/network/lane/Lane.java

Rule Violation Line
UselessParentheses Useless parentheses. 531532
UselessParentheses Useless parentheses. 533534
UselessParentheses Useless parentheses. 571572
UselessParentheses Useless parentheses. 573574
UselessParentheses Useless parentheses. 1516
UselessParentheses Useless parentheses. 1517
UselessParentheses Useless parentheses. 1545
UselessParentheses Useless parentheses. 1546

org/opentrafficsim/road/network/lane/conflict/Conflict.java

Rule Violation Line
UselessParentheses Useless parentheses. 186
UselessParentheses Useless parentheses. 187

org/opentrafficsim/road/network/lane/conflict/ConflictBuilder.java

Rule Violation Line
UselessParentheses Useless parentheses. 299
UselessParentheses Useless parentheses. 467
UselessParentheses Useless parentheses. 468
UselessParentheses Useless parentheses. 618
UselessParentheses Useless parentheses. 618
UselessParentheses Useless parentheses. 626
UselessParentheses Useless parentheses. 626

org/opentrafficsim/road/network/lane/conflict/ConflictBuilderParallel.java

Rule Violation Line
UselessParentheses Useless parentheses. 725
UselessParentheses Useless parentheses. 726
UselessParentheses Useless parentheses. 875
UselessParentheses Useless parentheses. 875
UselessParentheses Useless parentheses. 883
UselessParentheses Useless parentheses. 883

org/opentrafficsim/road/network/lane/conflict/DefaultConflictRule.java

Rule Violation Line
UselessParentheses Useless parentheses. 110
UselessParentheses Useless parentheses. 111

Files

org/opentrafficsim/road/gtu/generator/AbstractGTUGeneratorOld.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 278
UselessParentheses Useless parentheses. 4 278
UselessParentheses Useless parentheses. 4 279
UselessParentheses Useless parentheses. 4 279
CollapsibleIfStatements These nested if statements could be combined 3 347367
CollapsibleIfStatements These nested if statements could be combined 3 407427

org/opentrafficsim/road/gtu/generator/CFRoomChecker.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 5457

org/opentrafficsim/road/gtu/generator/GeneratorPositions.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'biases'. 3 78
EmptyCatchBlock Avoid empty catch blocks 3 296299
EmptyCatchBlock Avoid empty catch blocks 3 608611
UselessParentheses Useless parentheses. 4 958
UnnecessaryModifier Unnecessary modifier 'public' on class 'ByValue': members of interface types are implicitly public 3 10641124
UselessParentheses Useless parentheses. 4 1167

org/opentrafficsim/road/gtu/generator/od/ODApplier.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 303

org/opentrafficsim/road/gtu/generator/od/StrategicalPlannerFactorySupplierOD.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'TacticalPlannerFactorySupplierOD': members of interface types are implicitly public 3 106118

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 1041
PrimitiveWrapperInstantiation Do not use `Boolean.valueOf(false)`, prefer `Boolean.FALSE` 3 1462
PrimitiveWrapperInstantiation Do not use `Boolean.valueOf(false)`, prefer `Boolean.FALSE` 3 1471
EmptyCatchBlock Avoid empty catch blocks 3 15701573
EmptyCatchBlock Avoid empty catch blocks 3 15861589

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU2.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 1158
EmptyCatchBlock Avoid empty catch blocks 3 14091412

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedIndividualGTU.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 3 52
SimplifiedTernary Ternary operators that can be simplified with || or && 3 96

org/opentrafficsim/road/gtu/lane/VehicleModel.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 44

org/opentrafficsim/road/gtu/lane/perception/AbstractPerceptionReiterable.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 125
UselessQualifiedThis Useless qualified this usage in the same class. 3 127
UselessQualifiedThis Useless qualified this usage in the same class. 3 128
UselessQualifiedThis Useless qualified this usage in the same class. 3 132
UselessQualifiedThis Useless qualified this usage in the same class. 3 133
UselessQualifiedThis Useless qualified this usage in the same class. 3 316

org/opentrafficsim/road/gtu/lane/perception/DownstreamNeighborsIterable.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 102
CollapsibleIfStatements These nested if statements could be combined 3 120124

org/opentrafficsim/road/gtu/lane/perception/PerceptionCollectable.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionCollector': members of interface types are implicitly public 3 7695
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionAccumulator': members of interface types are implicitly public 3 111121
UnnecessaryModifier Unnecessary modifier 'public' on interface 'PerceptionFinalizer': members of interface types are implicitly public 3 137145

org/opentrafficsim/road/gtu/lane/perception/RelativeLane.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 65

org/opentrafficsim/road/gtu/lane/perception/RollingLaneStructure.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 481
UselessParentheses Useless parentheses. 4 13331334
UselessParentheses Useless parentheses. 4 13341335
UselessParentheses Useless parentheses. 4 14201421
UselessParentheses Useless parentheses. 4 14211422
UselessParentheses Useless parentheses. 4 15031504
UselessParentheses Useless parentheses. 4 1504
UselessParentheses Useless parentheses. 4 15321533
UselessParentheses Useless parentheses. 4 1533

org/opentrafficsim/road/gtu/lane/perception/RollingLaneStructureRecord.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 343344
CollapsibleIfStatements These nested if statements could be combined 3 343348
UselessParentheses Useless parentheses. 4 344345

org/opentrafficsim/road/gtu/lane/perception/UpstreamNeighborsIterable.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 75

org/opentrafficsim/road/gtu/lane/perception/categories/DirectDefaultSimplePerception.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 749752
CollapsibleIfStatements These nested if statements could be combined 3 883900
UselessParentheses Useless parentheses. 4 952
UselessParentheses Useless parentheses. 4 952
UselessParentheses Useless parentheses. 4 953
UselessParentheses Useless parentheses. 4 953

org/opentrafficsim/road/gtu/lane/perception/categories/DirectInfrastructurePerception.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 411412
UselessParentheses Useless parentheses. 4 412
UselessParentheses Useless parentheses. 4 427
UselessParentheses Useless parentheses. 4 427
UselessParentheses Useless parentheses. 4 440
UselessParentheses Useless parentheses. 4 440
UselessParentheses Useless parentheses. 4 443444
UselessParentheses Useless parentheses. 4 443
UselessParentheses Useless parentheses. 4 454
UselessParentheses Useless parentheses. 4 454455
UselessParentheses Useless parentheses. 4 654
UselessParentheses Useless parentheses. 4 654655

org/opentrafficsim/road/gtu/lane/perception/categories/LaneBasedAbstractPerceptionCategory.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'context'. 3 126

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/DirectNeighborsPerception.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 273274
UselessParentheses Useless parentheses. 4 275276

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/HeadwayGtuType.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 211

org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/TaskHeadwayCollector.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 81

org/opentrafficsim/road/gtu/lane/perception/headway/HeadwayStopLine.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 3740

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationHeadway.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 46

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSituationalAwareness.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 88

org/opentrafficsim/road/gtu/lane/perception/mental/AdaptationSpeed.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 41

org/opentrafficsim/road/gtu/lane/perception/mental/Fuller.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 180

org/opentrafficsim/road/gtu/lane/perception/mental/TaskHeadwayBased.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 56

org/opentrafficsim/road/gtu/lane/plan/operational/LaneChange.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 640
UnusedFormalParameter Avoid unused method parameters such as 'planDistance'. 3 711
UnusedFormalParameter Avoid unused method parameters such as 'width'. 3 712
UnusedFormalParameter Avoid unused method parameters such as 'startPosition'. 3 712
UnusedFormalParameter Avoid unused method parameters such as 'from'. 3 712
UnusedFormalParameter Avoid unused method parameters such as 'toLine'. 3 713
UnusedFormalParameter Avoid unused method parameters such as 'fromLine'. 3 713
UnusedLocalVariable Avoid unused local variables such as 'f'. 3 725
UnusedLocalVariable Avoid unused local variables such as 'cumulLcLength'. 3 729
UselessParentheses Useless parentheses. 4 826

org/opentrafficsim/road/gtu/lane/plan/operational/LaneOperationalPlanBuilder.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'alternativeTried'. 3 346
UselessParentheses Useless parentheses. 4 492
UnusedFormalParameter Avoid unused method parameters such as 'startSpeed'. 3 552

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCFLCTacticalPlanner.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'currentLaneFine'. 3 150

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedGTUFollowingDirectedChangeTacticalPlanner.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 236
CollapsibleIfStatements These nested if statements could be combined 3 238245
UselessParentheses Useless parentheses. 4 266
UnusedFormalParameter Avoid unused method parameters such as 'perception'. 3 508
UnusedFormalParameter Avoid unused method parameters such as 'lanePathInfo'. 3 508
UselessParentheses Useless parentheses. 4 629

org/opentrafficsim/road/gtu/lane/tactical/lmrs/AccelerationBusStop.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 7584

org/opentrafficsim/road/gtu/lane/tactical/lmrs/IncentiveGetInLane.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 90

org/opentrafficsim/road/gtu/lane/tactical/routesystem/DefaultRouteSystem.java

Rule Violation Priority Line
UnusedPrivateMethod Avoid unused private methods such as 'determineSet(DirectedLanePosition,Length,Route,GTUType,Length)'. 3 7879
UnusedFormalParameter Avoid unused method parameters such as 'route'. 3 78
UnusedFormalParameter Avoid unused method parameters such as 'distance'. 3 79

org/opentrafficsim/road/gtu/lane/tactical/toledo/Toledo.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 161
UselessParentheses Useless parentheses. 4 162163
UnusedFormalParameter Avoid unused method parameters such as 'gtu'. 3 715

org/opentrafficsim/road/gtu/lane/tactical/util/ConflictUtil.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 188200
CollapsibleIfStatements These nested if statements could be combined 3 498514
UselessParentheses Useless parentheses. 4 849850

org/opentrafficsim/road/gtu/lane/tactical/util/Steering.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'speed'. 3 93
UnusedLocalVariable Avoid unused local variables such as 'realPlan'. 3 127

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Cooperation.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 43
UselessParentheses Useless parentheses. 4 44
UselessParentheses Useless parentheses. 4 79
UselessParentheses Useless parentheses. 4 80
UnusedLocalVariable Avoid unused local variables such as 'b'. 3 85
SimplifiedTernary Ternary operators that can be simplified with || or && 3 93
UselessParentheses Useless parentheses. 4 124
UselessParentheses Useless parentheses. 4 125

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsData.java

Rule Violation Priority Line
SimplifiedTernary Ternary operators that can be simplified with || or && 3 110

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/LmrsUtil.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 186203
UnusedPrivateMethod Avoid unused private methods such as 'quickIntersectionScan(Parameters,SpeedLimitInfo,CarFollowingModel,Speed,LateralDirectionality,IntersectionPerception)'. 3 593595

org/opentrafficsim/road/gtu/lane/tactical/util/lmrs/Synchronization.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 1836
UselessParentheses Useless parentheses. 4 350
SimplifiedTernary Ternary operators that can be simplified with || or && 3 397398
UselessParentheses Useless parentheses. 4 401402
SimplifiedTernary Ternary operators that can be simplified with || or && 3 414415
UselessParentheses Useless parentheses. 4 426
UnnecessaryModifier Unnecessary modifier 'public' on method 'getMergeDistance': the method is declared in an interface type 3 499511
UselessParentheses Useless parentheses. 4 736
UselessParentheses Useless parentheses. 4 736

org/opentrafficsim/road/gtu/strategical/od/SplitFraction.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 199
UselessParentheses Useless parentheses. 4 200

org/opentrafficsim/road/gtu/strategical/route/LaneBasedStrategicalRoutePlanner.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 164
UselessParentheses Useless parentheses. 4 164
UselessParentheses Useless parentheses. 4 234
UselessParentheses Useless parentheses. 4 234235
UselessParentheses Useless parentheses. 4 250251
UselessParentheses Useless parentheses. 4 251252

org/opentrafficsim/road/gtu/strategical/route/RouteGeneratorOD.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 128
UnnecessarySemicolon Unnecessary semicolon 3 174

org/opentrafficsim/road/network/control/rampmetering/AlineaSwitch.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 60

org/opentrafficsim/road/network/control/rampmetering/RwsSwitch.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 63

org/opentrafficsim/road/network/factory/LaneFactory.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 3 106
UnusedFormalParameter Avoid unused method parameters such as 'simulator'. 3 385

org/opentrafficsim/road/network/lane/CrossSectionElement.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 269
UselessParentheses Useless parentheses. 4 270
UselessParentheses Useless parentheses. 4 270
UnusedFormalParameter Avoid unused constructor parameters such as 'newSimulator'. 3 346

org/opentrafficsim/road/network/lane/Lane.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 531532
UselessParentheses Useless parentheses. 4 533534
CollapsibleIfStatements These nested if statements could be combined 3 536540
UselessParentheses Useless parentheses. 4 571572
UselessParentheses Useless parentheses. 4 573574
CollapsibleIfStatements These nested if statements could be combined 3 576580
UselessParentheses Useless parentheses. 4 1516
UselessParentheses Useless parentheses. 4 1517
UselessParentheses Useless parentheses. 4 1545
UselessParentheses Useless parentheses. 4 1546

org/opentrafficsim/road/network/lane/LaneType.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'inverted'. 3 144

org/opentrafficsim/road/network/lane/NoTrafficLane.java

Rule Violation Priority Line
UnusedPrivateMethod Avoid unused private methods such as 'directionalityNone(RoadNetwork)'. 3 35

org/opentrafficsim/road/network/lane/conflict/Conflict.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 186
UselessParentheses Useless parentheses. 4 187
CollapsibleIfStatements These nested if statements could be combined 3 418439
CollapsibleIfStatements These nested if statements could be combined 3 848867

org/opentrafficsim/road/network/lane/conflict/ConflictBuilder.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 291294
UselessParentheses Useless parentheses. 4 299
UselessParentheses Useless parentheses. 4 467
UselessParentheses Useless parentheses. 4 468
UselessParentheses Useless parentheses. 4 618
UselessParentheses Useless parentheses. 4 618
UselessParentheses Useless parentheses. 4 626
UselessParentheses Useless parentheses. 4 626

org/opentrafficsim/road/network/lane/conflict/ConflictBuilderParallel.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 725
UselessParentheses Useless parentheses. 4 726
UselessParentheses Useless parentheses. 4 875
UselessParentheses Useless parentheses. 4 875
UselessParentheses Useless parentheses. 4 883
UselessParentheses Useless parentheses. 4 883

org/opentrafficsim/road/network/lane/conflict/DefaultConflictRule.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 110
UselessParentheses Useless parentheses. 4 111

org/opentrafficsim/road/network/lane/object/BusStop.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 3 61

org/opentrafficsim/road/network/lane/object/Distraction.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 3 40

org/opentrafficsim/road/network/lane/object/SpeedSign.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simulator'. 3 61

Suppressed Violations

Filename Rule message Suppression type Reason
org/opentrafficsim/road/gtu/generator/LaneBasedGTUGenerator.java Avoid unused private methods such as 'disable(Set)'. annotation
org/opentrafficsim/road/gtu/generator/LaneBasedGTUGenerator.java Avoid unused private methods such as 'enable()'. annotation
org/opentrafficsim/road/gtu/generator/LaneBasedGTUGenerator.java Avoid unused private methods such as 'tryToPlaceGTU(GeneratorLanePosition)'. annotation
org/opentrafficsim/road/gtu/generator/LaneBasedGTUGenerator.java Avoid unused private methods such as 'generateCharacteristics()'. annotation
org/opentrafficsim/road/gtu/lane/perception/categories/neighbors/NeighborsUtil.java Avoid unused local variables such as 'gtu'. annotation