Checkstyle Results

The following document contains the results of Checkstyle 8.35 with /config/dsol-checks.xml ruleset. 

rss feed

Summary

Files
 Info
 Warnings
 Errors
24 5 153 0

Files

File
 I
 W
 E
nl/tudelft/simulation/dsol/jetty/sse/OTSWebModel.java 0 1 0
nl/tudelft/simulation/dsol/jetty/sse/OTSWebServer.java 2 15 0
nl/tudelft/simulation/dsol/jetty/sse/TestDemoServer.java 0 32 0
nl/tudelft/simulation/dsol/web/animation/D2/HTMLAnimationPanel.java 0 1 0
nl/tudelft/simulation/dsol/web/animation/D2/HTMLGridPanel.java 1 0 0
nl/tudelft/simulation/dsol/web/animation/D2/ToggleButtonInfo.java 0 13 0
nl/tudelft/simulation/dsol/web/animation/HTMLDevice.java 0 1 0
nl/tudelft/simulation/dsol/web/animation/HTMLGraphics2D.java 2 50 0
nl/tudelft/simulation/dsol/web/animation/HTMLGraphicsConfiguration.java 0 6 0
nl/tudelft/simulation/dsol/web/animation/HTMLGraphicsEnvironment.java 0 5 0
nl/tudelft/simulation/dsol/web/animation/HTMLToolkit.java 0 24 0
org/opentrafficsim/web/animation/WebAnimationToggles.java 0 4 0
org/opentrafficsim/web/test/CircularRoadModel.java 0 1 0

Rules

Category Rule Violations Severity
blocks EmptyBlock 4
 Warning
NeedBraces 57
 Warning
coding HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
3
 Warning
design DesignForExtension 1
 Warning
VisibilityModifier 21
 Warning
imports UnusedImports 2
 Warning
javadoc JavadocMethod 8
 Warning
misc FinalParameters 47
 Warning
TodoComment 4
 Warning
modifier ModifierOrder 2
 Warning
RedundantModifier 2
 Warning
naming ParameterName 2
 Warning
sizes LineLength
  • max: "128"
2
 Info
MethodLength 1
 Info
ParameterNumber 2
 Info

Details

nl/tudelft/simulation/dsol/jetty/sse/OTSWebModel.java

Severity Category Rule Message Line
 Warning
coding HiddenField 'animationPanel' hides a field. 254

nl/tudelft/simulation/dsol/jetty/sse/OTSWebServer.java

Severity Category Rule Message Line
 Warning
design VisibilityModifier Variable 'webServer' must be private and have accessor methods. 252
 Warning
design DesignForExtension Class 'XHRHandler' looks like designed for extension (can be subclassed), but the method 'handle' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'XHRHandler' final or making the method 'handle' static/final/abstract/empty, or adding allowed annotation for the method. 269
 Info
sizes MethodLength Method length is 322 lines (max allowed is 150). 269
 Info
sizes LineLength Line is longer than 128 characters (found 144). 270
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 307
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 322
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 324
 Warning
blocks NeedBraces 'for' construct must use '{}'s. 434
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 454
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 467
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 529
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 538
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 540
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 545
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 547
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 571
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 573

nl/tudelft/simulation/dsol/jetty/sse/TestDemoServer.java

Severity Category Rule Message Line
 Warning
design VisibilityModifier Variable 'sessionModelMap' must be private and have accessor methods. 68
 Warning
design VisibilityModifier Variable 'sessionWebModelMap' must be private and have accessor methods. 71
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 169
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 171
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 173
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 175
 Warning
misc FinalParameters Parameter model should be final. 300
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 378
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 380
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 395
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 397
 Warning
blocks EmptyBlock Must have at least one statement. 403
 Warning
blocks EmptyBlock Must have at least one statement. 407
 Warning
blocks EmptyBlock Must have at least one statement. 411
 Warning
blocks EmptyBlock Must have at least one statement. 415
 Warning
javadoc JavadocMethod Expected @param tag for '<U>'. 424
 Warning
javadoc JavadocMethod Expected @param tag for '<T>'. 425
 Warning
misc FinalParameters Parameter parameter should be final. 425
 Warning
javadoc JavadocMethod Expected @param tag for '<U>'. 434
 Warning
javadoc JavadocMethod Expected @param tag for '<T>'. 435
 Warning
misc FinalParameters Parameter parameter should be final. 435
 Warning
javadoc JavadocMethod Expected @param tag for '<U>'. 449
 Warning
javadoc JavadocMethod Expected @param tag for '<T>'. 450
 Warning
misc FinalParameters Parameter parameter should be final. 450
 Warning
javadoc JavadocMethod Expected @param tag for '<U>'. 459
 Warning
javadoc JavadocMethod Expected @param tag for '<T>'. 460
 Warning
misc FinalParameters Parameter parameter should be final. 460
 Warning
misc FinalParameters Parameter model should be final. 476
 Warning
misc FinalParameters Parameter message should be final. 476
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 535
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 540
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 553

nl/tudelft/simulation/dsol/web/animation/D2/HTMLAnimationPanel.java

Severity Category Rule Message Line
 Warning
imports UnusedImports Unused import - nl.tudelft.simulation.dsol.simulators.SimulatorInterface. 29

nl/tudelft/simulation/dsol/web/animation/D2/HTMLGridPanel.java

Severity Category Rule Message Line
 Info
sizes LineLength Line is longer than 128 characters (found 129). 597

nl/tudelft/simulation/dsol/web/animation/D2/ToggleButtonInfo.java

Severity Category Rule Message Line
 Warning
misc FinalParameters Parameter name should be final. 25
 Warning
misc FinalParameters Parameter visible should be final. 25
 Warning
misc FinalParameters Parameter visible should be final. 42
 Warning
misc FinalParameters Parameter name should be final. 77
 Warning
misc FinalParameters Parameter locatableClass should be final. 77
 Warning
misc FinalParameters Parameter toolTipText should be final. 77
 Warning
misc FinalParameters Parameter visible should be final. 77
 Warning
misc FinalParameters Parameter name should be final. 115
 Warning
misc FinalParameters Parameter visible should be final. 115
 Warning
misc FinalParameters Parameter name should be final. 143
 Warning
misc FinalParameters Parameter layerName should be final. 143
 Warning
misc FinalParameters Parameter toolTipText should be final. 143
 Warning
misc FinalParameters Parameter visible should be final. 143

nl/tudelft/simulation/dsol/web/animation/HTMLDevice.java

Severity Category Rule Message Line
 Warning
misc FinalParameters Parameter htmlGraphicsConfiguration should be final. 27

nl/tudelft/simulation/dsol/web/animation/HTMLGraphics2D.java

Severity Category Rule Message Line
 Warning
design VisibilityModifier Variable 'background' must be private and have accessor methods. 53
 Warning
design VisibilityModifier Variable 'color' must be private and have accessor methods. 56
 Warning
design VisibilityModifier Variable 'font' must be private and have accessor methods. 59
 Warning
design VisibilityModifier Variable 'canvas' must be private and have accessor methods. 62
 Warning
design VisibilityModifier Variable 'fontMetrics' must be private and have accessor methods. 65
 Warning
design VisibilityModifier Variable 'paint' must be private and have accessor methods. 68
 Warning
design VisibilityModifier Variable 'stroke' must be private and have accessor methods. 71
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 73
 Warning
design VisibilityModifier Variable 'renderingHints' must be private and have accessor methods. 74
 Warning
design VisibilityModifier Variable 'affineTransform' must be private and have accessor methods. 77
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 79
 Warning
design VisibilityModifier Variable 'composite' must be private and have accessor methods. 80
 Warning
design VisibilityModifier Variable 'commands' must be private and have accessor methods. 83
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 164
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 167
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 170
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 172
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 178
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 180
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 182
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 197
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 199
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 219
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 221
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 223
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 225
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 280
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 282
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 288
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 290
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 295
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 297
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 354
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 356
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 362
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 364
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 369
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 371
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 446
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 449
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 456
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 459
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 476
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 478
 Warning
blocks NeedBraces 'if' construct must use '{}'s. 484
 Warning
blocks NeedBraces 'else' construct must use '{}'s. 486
 Warning
naming ParameterName Name 'Tx' must match pattern '^[a-z][a-zA-Z0-9]*$'. 711
 Warning
naming ParameterName Name 'Tx' must match pattern '^[a-z][a-zA-Z0-9]*$'. 718
 Warning
coding HiddenField 'color' hides a field. 750
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 792
 Info
sizes ParameterNumber More than 7 parameters (found 10). 1022
 Info
sizes ParameterNumber More than 7 parameters (found 11). 1031

nl/tudelft/simulation/dsol/web/animation/HTMLGraphicsConfiguration.java

Severity Category Rule Message Line
 Warning
design VisibilityModifier Variable 'htmlDevice' must be private and have accessor methods. 27
 Warning
design VisibilityModifier Variable 'identityTransform' must be private and have accessor methods. 30
 Warning
misc TodoComment Comment matches to-do format 'TODO:'. 32
 Warning
design VisibilityModifier Variable 'bounds' must be private and have accessor methods. 33
 Warning
coding HiddenField 'htmlDevice' hides a field. 56
 Warning
misc FinalParameters Parameter transparency should be final. 72

nl/tudelft/simulation/dsol/web/animation/HTMLGraphicsEnvironment.java

Severity Category Rule Message Line
 Warning
design VisibilityModifier Variable 'htmlDevice' must be private and have accessor methods. 27
 Warning
design VisibilityModifier Variable 'graphics2D' must be private and have accessor methods. 30
 Warning
design VisibilityModifier Variable 'graphicsConfiguration' must be private and have accessor methods. 33
 Warning
misc FinalParameters Parameter img should be final. 65
 Warning
misc FinalParameters Parameter l should be final. 89

nl/tudelft/simulation/dsol/web/animation/HTMLToolkit.java

Severity Category Rule Message Line
 Warning
design VisibilityModifier Variable 'eventQueue' must be private and have accessor methods. 40
 Warning
misc FinalParameters Parameter font should be final. 83
 Warning
misc FinalParameters Parameter filename should be final. 98
 Warning
misc FinalParameters Parameter url should be final. 106
 Warning
misc FinalParameters Parameter filename should be final. 114
 Warning
misc FinalParameters Parameter url should be final. 122
 Warning
misc FinalParameters Parameter image should be final. 130
 Warning
misc FinalParameters Parameter width should be final. 130
 Warning
misc FinalParameters Parameter height should be final. 130
 Warning
misc FinalParameters Parameter observer should be final. 130
 Warning
misc FinalParameters Parameter image should be final. 138
 Warning
misc FinalParameters Parameter width should be final. 138
 Warning
misc FinalParameters Parameter height should be final. 138
 Warning
misc FinalParameters Parameter observer should be final. 138
 Warning
misc FinalParameters Parameter producer should be final. 146
 Warning
misc FinalParameters Parameter imagedata should be final. 154
 Warning
misc FinalParameters Parameter imageoffset should be final. 154
 Warning
misc FinalParameters Parameter imagelength should be final. 154
 Warning
misc FinalParameters Parameter frame should be final. 162
 Warning
misc FinalParameters Parameter jobtitle should be final. 162
 Warning
misc FinalParameters Parameter props should be final. 162
 Warning
misc FinalParameters Parameter modalityType should be final. 194
 Warning
misc FinalParameters Parameter modalExclusionType should be final. 202
 Warning
misc FinalParameters Parameter highlight should be final. 210

org/opentrafficsim/web/animation/WebAnimationToggles.java

Severity Category Rule Message Line
 Warning
modifier RedundantModifier Redundant 'final' modifier. 105
 Warning
modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 105
 Warning
modifier RedundantModifier Redundant 'final' modifier. 115
 Warning
modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 115

org/opentrafficsim/web/test/CircularRoadModel.java

Severity Category Rule Message Line
 Warning
imports UnusedImports Unused import - nl.tudelft.simulation.dsol.simulators.DEVSSimulatorInterface. 46