The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.
| Tag Class | Total number of occurrences | Tag strings used by tag class |
|---|---|---|
| Open issues in the code | 175 | TODO, FIXME, XXX |
Each tag is detailed below:
Number of occurrences found in the code: 175
| org.opentrafficsim.road.DefaultTestParameters | Line |
|---|---|
| add another else to catch any unanticipated cases? | 76 |
| Explain why this exception can/should be ignored. do not set parameter without default value | 80 |
| org.opentrafficsim.road.car.CarTest | Line |
| check with following model as part of tactical planner assertEquals("The gtu following model should be " + gtuFollowingModel, gtuFollowingModel, referenceCar .getBehavioralCharacteristics().getGtuFollowingModel()); There is (currently) no way to retrieve the lane change model of a GTU. | 93 |
| org.opentrafficsim.road.definitions.DefaultsRoadNl | Line |
| prepend all type id's with "NL." | 22 |
| org.opentrafficsim.road.gtu.AbstractLaneBasedGtuTest | Line |
| Test with gfm as part of tactical planner assertEquals("GTU following model should be identical to the provided one", gfm, car .getBehavioralCharacteristics().getGtuFollowingModel()); | 134 |
| removeLane should throw an Error when the car is not on that lane (currently this is silently ignored) | 382 |
| figure out why the added lane has a non-zero position | 383 |
| org.opentrafficsim.road.gtu.LaneBasedGtuTest | Line |
| see how we can ask the vehicle to look this far ahead | 173 |
| see how we can ask the vehicle to look this far behind | 181 |
| see how we can ask the vehicle to look 'forwardMaxDistance' ahead | 215 |
| follower = truck.headway(reverseMaxDistance); | 236 |
| org.opentrafficsim.road.gtu.generator.Platoons | Line |
| end time of platoon may be in next demand period, which makes the demand non-linear | 317 |
| org.opentrafficsim.road.gtu.lane.LaneBasedGtu | Line |
| should be indicated with a Parameter | 156 |
| can be removed after testing period | 160 |
| can be removed after testing period | 164 |
| move this to super.init(...), and remove setOperationalPlan(...) method Give the GTU a 1 micrometer long operational plan, or a stand-still plan, so the first move and events will work | 241 |
| the below 0 and above 0 is NOT what is tested | 374 |
| WRONG: this.fireTimedEvent(LaneBasedGtu.LANE_CHANGE_EVENT, new Object[] {getId(), laneChangeDirection, from}, | 528 |
| WRONG: getSimulator().getSimulatorTime()); | 529 |
| If there are still events left, clearly something went wrong? | 566 |
| Added boolean to indicate whether warnings need to be given when events were found | 567 |
| hard remove over whole network | 1438 |
| logger notification | 1439 |
| the next 2 events are never fired... | 1788 |
| org.opentrafficsim.road.gtu.lane.changing.LaneChangeModelTest | Line |
| create a LinkAnimation if the simulator is compatible with that. | 99 |
| The current LinkAnimation is too bad to use... | 100 |
| Decide what type of overtaking conditions we want in this test | 124 |
| test/prove the expected differences between Egoistic and Altruistic | 296 |
| prove that the most restrictive car in the other lane determines what happens | 297 |
| test merge into overtaking lane | 298 |
| org.opentrafficsim.road.gtu.lane.control.DelayedActuation | Line |
| numerical implementation of tau rule | 45 |
| org.opentrafficsim.road.gtu.lane.perception.AbstractPerceptionIterable | Line |
| this let's us ignore an object that is registered on the next lane, but who's tail may be on this lane | 269 |
| org.opentrafficsim.road.gtu.lane.perception.RollingLaneStructure | Line |
| on complex networks, e.g. with sections connectors where lane changes are not possible, the update may fail | 208 |
| we now assume everything is on the route, but merges could be ok without route so, without a route we should be able to recognize which upstream 'nextLane' is on the other link | 1037 |
| Temporary fix for Aimsun demo | 1211 |
| org.opentrafficsim.road.gtu.lane.perception.RollingLaneStructureRecord | Line |
| clear on network change, with an event listener? | 40 |
| org.opentrafficsim.road.gtu.lane.perception.categories.DefaultSimplePerception | Line |
| In other places in OTS LEFT is positive (and RIGHT is negative). This should be made more consistent. | 252 |
| org.opentrafficsim.road.gtu.lane.perception.categories.DirectDefaultSimplePerception | Line |
| end of lanepath | 624 |
| allow observation of other objects as well. | 813 |
| --No comment-- | 908 |
| calculate real overlaps | 924 |
| expand for other types of Headways result.add(new HeadwayGtuSimple(p.getId(), ((AbstractHeadwayGtu) p).getGtuType(), new Length(Double.NaN, LengthUnit.SI), p.getLength(), p.getSpeed(), p.getAcceleration())); | 983 |
| org.opentrafficsim.road.gtu.lane.perception.categories.DirectInfrastructurePerception | Line |
| more than the lane speed limit and maximum vehicle speed in the speed limit prospect | 45 |
| this is not suitable if we change lane and consider e.g. dynamic speed signs, they will be forgotten | 117 |
| for now, we do allow to lower speed for a DestinationSensor (e.g., to brake for parking) | 297 |
| splits | 446 |
| splits | 457 |
| org.opentrafficsim.road.gtu.lane.perception.categories.DirectIntersectionPerception | Line |
| if conflicts span multiple lanes, this within-lane search fails | 144 |
| get from link combination (needs to be a map property on the links) | 173 |
| limit 'conflictingVisibility' to first upstream traffic light, so GTU's behind it are ignored | 187 |
| stop lines (current models happen not to use this, but should be possible) | 197 |
| org.opentrafficsim.road.gtu.lane.perception.categories.neighbors.DirectNeighborsPerception | Line |
| not use this check when synchronizing or cooperating | 265 |
| org.opentrafficsim.road.gtu.lane.perception.headway.HeadwayGtuReal | Line |
| --No comment-- | 258 |
| --No comment-- | 287 |
| org.opentrafficsim.road.gtu.lane.perception.headway.HeadwayGtuType | Line |
| create SpeedLimitInfo on the basis of this.gtuTypeAssumptions.getLaneTypeMaxSpeed(...) | 149 |
| org.opentrafficsim.road.gtu.lane.perception.mental.TaskManager | Line |
| rename MentalTaskRegulator as in paper? (also sub-classes) | 21 |
| org.opentrafficsim.road.gtu.lane.plan.operational.LaneChange | Line |
| this assumes the time step will not be interrupted | 371 |
| sequential is disabled as LaneChangePath now uses 2 OtsLine3d's instead of 2 List<Lane>'s. This was done as the code using LaneChangePath (i.e. LaneChange) required more details on fractional positions itself. | 690 |
| org.opentrafficsim.road.gtu.lane.plan.operational.LaneOperationalPlanBuilder | Line |
| driving with negative speeds (backward driving) is not yet supported. <p> Copyright (c) 2013-2023 Delft University of Technology, PO Box 5, 2600 AA, Delft, the Netherlands. All rights reserved. <br> BSD-style license. See <a href="https://opentrafficsim.org/docs/license.html">OpenTrafficSim License</a>. </p> | 47 |
| for now, the same is not done for the DestinationSensor (e.g., decrease speed for parking) | 325 |
| org.opentrafficsim.road.gtu.lane.plan.operational.SimpleOperationalPlan | Line |
| AV | 123 |
| AV | 135 |
| org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCfLcTacticalPlanner | Line |
| how to handle objects on this lane or another lane??? | 130 |
| these two info's are not used | 145 |
| skip if: - we are in the right lane and drive at max speed or we accelerate maximally - there are no other lanes | 150 |
| whether we drive on the right should be stored in some central place. | 156 |
| move laneIncentives to LanePerception? Figure out if the default lane incentives are OK, or override them with values that should keep this GTU on the intended route. | 232 |
| these comparisons to -10 is ridiculous. | 288 |
| move suitability to LanePerception? Return the suitability for the current lane, left adjacent lane or right adjacent lane. | 380 |
| --No comment-- | 600 |
| this method should probably be moved into the CrossSectionLink class | 657 |
| org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGtuFollowingTacticalPlanner | Line |
| I really don't like this -- if there is a lane drop at 20 m, the GTU should stop... | 80 |
| org.opentrafficsim.road.gtu.lane.tactical.LaneBasedTacticalPlanner | Line |
| private when we use java 9 | 137 |
| org.opentrafficsim.road.gtu.lane.tactical.following.AbstractGtuFollowingModelMobil | Line |
| Under which circumstances can getDistance() be NULL? Should that indeed result in TOODANGEROUS? | 60 |
| org.opentrafficsim.road.gtu.lane.tactical.following.FixedAccelerationModel | Line |
| should be specified in constructor | 87 |
| org.opentrafficsim.road.gtu.lane.tactical.following.IdmOld | Line |
| maxDistance dV is the approach speed | 111 |
| org.opentrafficsim.road.gtu.lane.tactical.following.IdmPlusOld | Line |
| maxDistance | 117 |
| org.opentrafficsim.road.gtu.lane.tactical.following.SequentialFixedAccelerationModel | Line |
| incorporate stepSize | 153 |
| org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.AbstractLaneChangeModel | Line |
| make this driving side dependent; i.e. implement a general way to figure out on which side of the road cars are supposed to drive | 66 |
| org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.LaneChangeModel | Line |
| Lane change models should use the perceived nearby GTUs rather than a provided list of same lane traffic, etc. <p> Copyright (c) 2013-2023 Delft University of Technology, PO Box 5, 2600 AA, Delft, the Netherlands. All rights reserved. <br> BSD-style license. See <a href="https://opentrafficsim.org/docs/license.html">OpenTrafficSim License</a>. </p> | 15 |
| org.opentrafficsim.road.gtu.lane.tactical.lmrs.AccelerationBusStop | Line |
| this process is much more complex: tail blocking other traffic? other bus in front? many people at bus stop? | 40 |
| org.opentrafficsim.road.gtu.lane.tactical.lmrs.AccelerationNoRightOvertake | Line |
| ignore incentive if we need to change lane for the route | 50 |
| only sensible if the left leader can change right; add this info to HeadwayGtu? | 65 |
| org.opentrafficsim.road.gtu.lane.tactical.lmrs.IncentiveCourtesy | Line |
| factor -a/b as influence factor is heavy in calculation, consider v<vEgo & 1-s/x0 | 85 |
| org.opentrafficsim.road.gtu.lane.tactical.lmrs.IncentiveQueue | Line |
| a ramp-metering traffic light triggers this incentive with possible cooperation from the main line | 62 |
| org.opentrafficsim.road.gtu.lane.tactical.lmrs.IncentiveSocioSpeed | Line |
| keep left or right rules | 40 |
| org.opentrafficsim.road.gtu.lane.tactical.lmrs.IncentiveSpeed | Line |
| SpeedWithCourtesy now uses TrafficPerception, which embeds the courtesy part. How to do this? | 32 |
| org.opentrafficsim.road.gtu.lane.tactical.lmrs.Lmrs | Line |
| consider route in incentives (only if not on current lane?) | 124 |
| org.opentrafficsim.road.gtu.lane.tactical.lmrs.LmrsFactory | Line |
| use factory instead of constructors | 109 |
| org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo | Line |
| vehicle not ahead and not backwards but completely adjacent | 117 |
| infinite -> some limited space, speed also one leader | 350 |
| definition of 'right most lane' does not account for ramps and weaving sections | 638 |
| org.opentrafficsim.road.gtu.lane.tactical.toledo.ToledoCarFollowing | Line |
| speed difference with reaction time | 145 |
| org.opentrafficsim.road.gtu.lane.tactical.toledo.ToledoPerception | Line |
| updateInfrastructureLaneChangeInfo with split number | 32 |
| org.opentrafficsim.road.gtu.lane.tactical.util.ConflictUtil | Line |
| do not ignore vehicles upstream of conflict if they have green | 64 |
| conflict over multiple lanes (longitudinal in own direction) | 65 |
| a) yielding while having priority happens only when leaders is standing still on conflict (then its useless...) b) two vehicles can remain upstream of merge if vehicle stands on merge but leaves some space to move probably 1 is yielding, and 1 is courtesy yielding as the other stands still c) they might start moving together and collide further down (no response to negative headway on merge) | 66 |
| priority rules of busses should be handled differently, this also makes a GTU type unnecessary here | 189 |
| depending on left/right-hand traffic | 199 |
| depending on rules, we may need to stop and not just yield | 227 |
| --No comment-- | 283 |
| what to do when we happen to be in the stopping distance? Stopping might be reasonable, while car-following might give strong deceleration due to s < s0. | 293 |
| only within visibility | 447 |
| safety factor? | 497 |
| this check is simplistic, designed quick and dirty | 542 |
| conflicting vehicle on crossing conflict, but will leave sooner then we enter, so no problem? | 658 |
| more generally, also upstream conflicting vehicles at crossings may leave the conflict before we enter | 659 |
| stopping | 915 |
| all-stop behavior | 928 |
| org.opentrafficsim.road.gtu.lane.tactical.util.lmrs.Cooperation | Line |
| only cooperate if merger still quite fast or there's congestion downstream anyway (which we can better estimate than only considering the direct leader | 100 |
| org.opentrafficsim.road.gtu.lane.tactical.util.lmrs.GapAcceptance | Line |
| --No comment-- | 48 |
| org.opentrafficsim.road.gtu.lane.tactical.util.lmrs.LmrsUtil | Line |
| this approach is a hack | 521 |
| org.opentrafficsim.road.gtu.lane.tactical.util.lmrs.Synchronization | Line |
| replace this hack with something that properly accounts for overshoot this method also introduces very strong deceleration at low speeds, as the time step makes bMin go from 3.4 (ignored, so maybe 1.25 acceleration applied) to >10 remainingDist = remainingDist.minus(Length.instantiateSI(10)); | 90 |
| find a better solution for this inefficient hack... when to ignore a vehicle for synchronization? | 568 |
| org.opentrafficsim.road.gtu.perception.RelativeLaneTest | Line |
| Wait for Wouter to indicate whether numLanes == 0 is really permitted when lat != LateralDirectionality.NONE | 71 |
| fix if 0 is only permitted for LateralDirectionality.NONE | 75 |
| org.opentrafficsim.road.gtu.perception.VerifyPerceptionCategoryMethods | Line |
| to what extent do we want to prescribe this now that we have more flexible perception categories | 66 |
| fail("Class " + c + " does not have a field '" + field + "*', nor wraps a perception category that does."); | 184 |
| fail... | 215 |
| fail... | 221 |
| org.opentrafficsim.road.gtu.strategical.LaneBasedStrategicalRoutePlanner | Line |
| this takes the first in the set of links that connects the correct nodes; does not handle parallel links consistently | 211 |
| Probably this test can be removed since we only go "forward" | 216 |
| org.opentrafficsim.road.network.LinkLocationTest | Line |
| distance to location on another link (not yet possible; currently ALWAYS returns null) | 73 |
| org.opentrafficsim.road.network.RoadNetwork | Line |
| Is the GTU type actually relevant for physical? It is used still to find adjacent lanes. | 175 |
| isDeadEnd should be removed from LaneChangeInfo, behavior should consider legal vs. physical | 353 |
| org.opentrafficsim.road.network.lane.ConflictTest | Line |
| discuss if this method should be moved into the OtsLine3d class | 198 |
| org.opentrafficsim.road.network.lane.CrossSectionElement | Line |
| this produces near-duplicate points on lane 925_J1.FORWARD1 in the Aimsun network hack: clean nearby points | 293 |
| org.opentrafficsim.road.network.lane.CrossSectionLink | Line |
| work in a different way with lane numbers to align to standard lane numbering. | 57 |
| allow for the removal of a Lane; currently this is not possible. | 69 |
| org.opentrafficsim.road.network.lane.CurveTest | Line |
| finish writing this test | 103 |
| org.opentrafficsim.road.network.lane.DetectorTest | Line |
| this is not true anymore with OperationalPlans, Perception, etc => | 140 |
| the number of events that should be scheduled can vary per models chosen | 141 |
| assertEquals("There should be three scheduled events (trigger, leaveLane, | 142 |
| car.move, terminate)", 4, eventList.size()); The sensor should be triggered around t=38.3403 (exact value: 10 / 9 * (sqrt(3541) - 25)) System.out.println("trigger event is " + triggerEvent); / TODO not triggered in next half second. | 143 |
| assertEquals("Trigger event should be around 38.3403", 38.3403, | 147 |
| triggerEvent.getAbsoluteExecutionTime().get().getSI(), 0.0001); | 148 |
| check that the sensor is triggered at the right time. | 176 |
| org.opentrafficsim.road.network.lane.Lane | Line |
| constructor calls with this(...) | 277 |
| take the cross section slices into account... | 335 |
| take the cross section slices into account... | 351 |
| take the cross section slices into account... | 375 |
| take the cross section slices into account... | 391 |
| this is a hack for when sink detector aren't perfectly adjacent or the GTU overshoots with nose due to curvature | 617 |
| only center position? Or also width? What is a good cutoff? Base on average width of the GTU type that can drive on this Lane? E.g., for a Tram or Train, a 5 cm deviation is a problem; for a Car or a Bicycle, more deviation is acceptable. | 1076 |
| this should return something immutable | 1097 |
| determine if this should synchronize on this.nextLanes | 1102 |
| And is it aligned with its next lane? | 1122 |
| this should return something immutable | 1166 |
| And is it aligned with its next lane? | 1190 |
| let HistoricalArrayList return an Immutable (WRAP) of itself | 1384 |
| org.opentrafficsim.road.network.lane.LaneTest | Line |
| what overtaking conditions do we want to test in this unit test? | 97 |
| This test for expectedLateralCenterOffset fails | 112 |
| This is not correct... | 151 |
| what overtaking conditions do we want to test in this unit test? | 670 |
| org.opentrafficsim.road.network.lane.changing.OvertakingConditions | Line |
| All these "Right/LeftSet" classes should probably use Compatibility instead of full sets. <p> Copyright (c) 2013-2023 Delft University of Technology, PO Box 5, 2600 AA, Delft, the Netherlands. All rights reserved. BSD-style license. See <a href="https://opentrafficsim.org/docs/license.html">OpenTrafficSim License</a>. </p> | 284 |
| org.opentrafficsim.road.network.lane.conflict.Conflict | Line |
| the OtsLine3d object should be shared by all ConflictEnd objects (removing OtsGeometryException) | 486 |
| why not create a getter for the gtu in the super class? <p> Copyright (c) 2013-2023 Delft University of Technology, PO Box 5, 2600 AA, Delft, the Netherlands. All rights reserved. <br> BSD-style license. See <a href="https://opentrafficsim.org/docs/license.html">OpenTrafficSim License</a>. </p> | 515 |
| org.opentrafficsim.road.network.lane.conflict.ConflictBuilder | Line |
| use z-coordinate for intersections of lines | 40 |
| we cache, but the width generator may be different | 265 |
| handle bus priority on the model side | 491 |
| handle bus priority on the model side | 601 |
| make parallel simulator.getLogger().setAllLogLevel(Level.WARNING); | 1291 |
| org.opentrafficsim.road.network.lane.conflict.ConflictBuilderParallel | Line |
| use z-coordinate for intersections of lines | 41 |
| we cache, but the width generator may be different | 517 |
| handle bus priority on the model side | 740 |
| handle bus priority on the model side | 850 |
| org.opentrafficsim.road.network.lane.object.detector.DirectionalOccupancyDetector | Line |
| enforce clone method | 73 |
| org.opentrafficsim.road.network.lane.object.detector.TrafficLightDetector | Line |
| Possibly provide the GtuTypes that trigger the detector as an argument for the constructor | 101 |
| org.opentrafficsim.road.network.lane.object.sensor.TrafficLightDetectorTest | Line |
| @Test | 151 |
| THIS TEST FAILS!! assertEquals("event list should contain one event (due to creation of the GTU on the detector)", 1, this.loggedEvents.size()); | 236 |
| org.opentrafficsim.road.network.speed.package-info | Line |
| --No comment-- | 21 |
| org.opentrafficsim.road.od.OdApplier | Line |
| sinks? white extension links? | 137 |
| clean up stream acquiring code after task OTS-315 has been completed | 143 |
| should be GTU type dependent. | 653 |
| org.opentrafficsim.road.od.SplitFraction | Line |
| let interpolation interpolate itself | 153 |