Checkstyle Results
The following document contains the results of Checkstyle 10.17.0 with /config/dsol-checks.xml ruleset.
Summary
| Files | |||
|---|---|---|---|
| 10 | 0 | 47 | 0 |
Files
Rules
| Category | Rule | Violations | Severity |
|---|---|---|---|
| blocks | NeedBraces | 30 | |
| design | DesignForExtension
|
2 | |
| VisibilityModifier | 8 | ||
| javadoc | JavadocVariable | 7 |
Details
org/opentrafficsim/sim0mq/kpi/GtuDataSim0.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| blocks | NeedBraces | 'if' construct must use '{}'s. | 86 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 88 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 90 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 95 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 98 |
org/opentrafficsim/sim0mq/kpi/GtuTypeDataDeprecated.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| design | DesignForExtension | Class 'GtuTypeDataDeprecated' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GtuTypeDataDeprecated' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 34 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 51 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 53 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 55 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 60 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 63 |
org/opentrafficsim/sim0mq/kpi/LaneDataSim0.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| design | VisibilityModifier | Variable 'length' must be private and have accessor methods. | 24 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 85 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 87 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 89 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 94 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 97 |
org/opentrafficsim/sim0mq/kpi/LinkDataSim0.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| design | VisibilityModifier | Variable 'startNode' must be private and have accessor methods. | 25 | |
| design | VisibilityModifier | Variable 'endNode' must be private and have accessor methods. | 28 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 116 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 118 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 120 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 125 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 128 |
org/opentrafficsim/sim0mq/kpi/NodeDataDeprecated.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| design | DesignForExtension | Class 'NodeDataDeprecated' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'NodeDataDeprecated' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 50 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 67 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 69 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 71 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 76 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 79 |
org/opentrafficsim/sim0mq/kpi/RouteData.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| blocks | NeedBraces | 'if' construct must use '{}'s. | 79 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 81 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 83 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 88 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 91 |
org/opentrafficsim/sim0mq/kpi/Sim0mqKpiTransceiver.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocVariable | Missing a Javadoc comment. | 269 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 271 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 273 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 275 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 277 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 279 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 281 |
org/opentrafficsim/sim0mq/kpi/Sim0mqSampler.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| design | VisibilityModifier | Variable 'nodes' must be private and have accessor methods. | 39 | |
| design | VisibilityModifier | Variable 'links' must be private and have accessor methods. | 42 | |
| design | VisibilityModifier | Variable 'lanes' must be private and have accessor methods. | 45 | |
| design | VisibilityModifier | Variable 'gtus' must be private and have accessor methods. | 48 | |
| design | VisibilityModifier | Variable 'lastLanes' must be private and have accessor methods. | 51 |
