Checkstyle Results

The following document contains the results of Checkstyle 10.21.3 with config/dsol-checks.xml ruleset.

Summary

Files  Info  Warnings  Errors
10 0 47 0

Files

File  I  W  E
org/opentrafficsim/sim0mq/kpi/GtuDataSim0.java 0 5 0
org/opentrafficsim/sim0mq/kpi/GtuTypeDataDeprecated.java 0 6 0
org/opentrafficsim/sim0mq/kpi/LaneDataSim0.java 0 6 0
org/opentrafficsim/sim0mq/kpi/LinkDataSim0.java 0 7 0
org/opentrafficsim/sim0mq/kpi/NodeDataDeprecated.java 0 6 0
org/opentrafficsim/sim0mq/kpi/RouteData.java 0 5 0
org/opentrafficsim/sim0mq/kpi/Sim0mqKpiTransceiver.java 0 7 0
org/opentrafficsim/sim0mq/kpi/Sim0mqSampler.java 0 5 0

Rules

Category Rule Violations Severity
blocks NeedBraces 30  Warning
design DesignForExtension
  • ignoredAnnotations: "Override"
2  Warning
VisibilityModifier 8  Warning
javadoc JavadocVariable 7  Warning

Details

org/opentrafficsim/sim0mq/kpi/GtuDataSim0.java

Severity Category Rule Message Line
 Warning blocks NeedBraces 'if' construct must use '{}'s. 86
 Warning blocks NeedBraces 'if' construct must use '{}'s. 88
 Warning blocks NeedBraces 'if' construct must use '{}'s. 90
 Warning blocks NeedBraces 'if' construct must use '{}'s. 95
 Warning blocks NeedBraces 'if' construct must use '{}'s. 98

org/opentrafficsim/sim0mq/kpi/GtuTypeDataDeprecated.java

Severity Category Rule Message Line
 Warning design DesignForExtension Class 'GtuTypeDataDeprecated' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GtuTypeDataDeprecated' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. 34
 Warning blocks NeedBraces 'if' construct must use '{}'s. 51
 Warning blocks NeedBraces 'if' construct must use '{}'s. 53
 Warning blocks NeedBraces 'if' construct must use '{}'s. 55
 Warning blocks NeedBraces 'if' construct must use '{}'s. 60
 Warning blocks NeedBraces 'if' construct must use '{}'s. 63

org/opentrafficsim/sim0mq/kpi/LaneDataSim0.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'length' must be private and have accessor methods. 24
 Warning blocks NeedBraces 'if' construct must use '{}'s. 85
 Warning blocks NeedBraces 'if' construct must use '{}'s. 87
 Warning blocks NeedBraces 'if' construct must use '{}'s. 89
 Warning blocks NeedBraces 'if' construct must use '{}'s. 94
 Warning blocks NeedBraces 'if' construct must use '{}'s. 97

org/opentrafficsim/sim0mq/kpi/LinkDataSim0.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'startNode' must be private and have accessor methods. 25
 Warning design VisibilityModifier Variable 'endNode' must be private and have accessor methods. 28
 Warning blocks NeedBraces 'if' construct must use '{}'s. 116
 Warning blocks NeedBraces 'if' construct must use '{}'s. 118
 Warning blocks NeedBraces 'if' construct must use '{}'s. 120
 Warning blocks NeedBraces 'if' construct must use '{}'s. 125
 Warning blocks NeedBraces 'if' construct must use '{}'s. 128

org/opentrafficsim/sim0mq/kpi/NodeDataDeprecated.java

Severity Category Rule Message Line
 Warning design DesignForExtension Class 'NodeDataDeprecated' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'NodeDataDeprecated' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. 50
 Warning blocks NeedBraces 'if' construct must use '{}'s. 67
 Warning blocks NeedBraces 'if' construct must use '{}'s. 69
 Warning blocks NeedBraces 'if' construct must use '{}'s. 71
 Warning blocks NeedBraces 'if' construct must use '{}'s. 76
 Warning blocks NeedBraces 'if' construct must use '{}'s. 79

org/opentrafficsim/sim0mq/kpi/RouteData.java

Severity Category Rule Message Line
 Warning blocks NeedBraces 'if' construct must use '{}'s. 79
 Warning blocks NeedBraces 'if' construct must use '{}'s. 81
 Warning blocks NeedBraces 'if' construct must use '{}'s. 83
 Warning blocks NeedBraces 'if' construct must use '{}'s. 88
 Warning blocks NeedBraces 'if' construct must use '{}'s. 91

org/opentrafficsim/sim0mq/kpi/Sim0mqKpiTransceiver.java

Severity Category Rule Message Line
 Warning javadoc JavadocVariable Missing a Javadoc comment. 264
 Warning javadoc JavadocVariable Missing a Javadoc comment. 266
 Warning javadoc JavadocVariable Missing a Javadoc comment. 268
 Warning javadoc JavadocVariable Missing a Javadoc comment. 270
 Warning javadoc JavadocVariable Missing a Javadoc comment. 272
 Warning javadoc JavadocVariable Missing a Javadoc comment. 274
 Warning javadoc JavadocVariable Missing a Javadoc comment. 276

org/opentrafficsim/sim0mq/kpi/Sim0mqSampler.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'nodes' must be private and have accessor methods. 39
 Warning design VisibilityModifier Variable 'links' must be private and have accessor methods. 42
 Warning design VisibilityModifier Variable 'lanes' must be private and have accessor methods. 45
 Warning design VisibilityModifier Variable 'gtus' must be private and have accessor methods. 48
 Warning design VisibilityModifier Variable 'lastLanes' must be private and have accessor methods. 51