PMD Results
The following document contains the results of PMD 7.3.0.
Violations By Priority
Priority 3
org/opentrafficsim/trafficcontrol/ccol/Ccol.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'trafficLights'. | 81 |
| UnusedFormalParameter | Avoid unused constructor parameters such as 'sensors'. | 82 |
org/opentrafficsim/trafficcontrol/trafcod/Diagram.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | This if statement could be combined with its parent | 669–672 |
org/opentrafficsim/trafficcontrol/trafcod/TrafCod.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'display'. | 160 |
| UnusedLocalVariable | Avoid unused local variables such as 'tli'. | 588 |
| EmptyControlStatement | Empty if statement | 593–597 |
| PrimitiveWrapperInstantiation | Do not use `new Integer(...)`, prefer `Integer.valueOf(...)` | 1514 |
Priority 4
org/opentrafficsim/trafficcontrol/AbstractTrafficController.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficController': 'TRAFFICCONTROL_CONTROLLER_CREATED' is already in scope because it is inherited by an enclosing type | 34 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficController': 'STARTING_UP' is already in scope because it is inherited by an enclosing type | 35 |
org/opentrafficsim/trafficcontrol/trafcod/Diagram.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 253 |
org/opentrafficsim/trafficcontrol/trafcod/TrafCod.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficController': 'TRAFFICCONTROL_VARIABLE_CREATED' is already in scope because it is inherited by an enclosing type | 200 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficController': 'TRAFFICCONTROL_CONTROLLER_EVALUATING' is already in scope because it is inherited by an enclosing type | 705 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficController': 'TRAFFICCONTROL_CONTROLLER_WARNING' is already in scope because it is inherited by an enclosing type | 745 |
| UselessParentheses | Useless parentheses. | 1660 |
| UselessParentheses | Useless parentheses. | 1745 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficController': 'TRAFFICCONTROL_SET_TRACING' is already in scope because it is inherited by an enclosing type | 1803 |
| UselessParentheses | Useless parentheses. | 2697 |
Files
org/opentrafficsim/trafficcontrol/AbstractTrafficController.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficController': 'TRAFFICCONTROL_CONTROLLER_CREATED' is already in scope because it is inherited by an enclosing type | 4 | 34 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficController': 'STARTING_UP' is already in scope because it is inherited by an enclosing type | 4 | 35 |
org/opentrafficsim/trafficcontrol/ccol/Ccol.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'trafficLights'. | 3 | 81 |
| UnusedFormalParameter | Avoid unused constructor parameters such as 'sensors'. | 3 | 82 |
org/opentrafficsim/trafficcontrol/trafcod/Diagram.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 253 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 669–672 |
org/opentrafficsim/trafficcontrol/trafcod/TrafCod.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'display'. | 3 | 160 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficController': 'TRAFFICCONTROL_VARIABLE_CREATED' is already in scope because it is inherited by an enclosing type | 4 | 200 |
| UnusedLocalVariable | Avoid unused local variables such as 'tli'. | 3 | 588 |
| EmptyControlStatement | Empty if statement | 3 | 593–597 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficController': 'TRAFFICCONTROL_CONTROLLER_EVALUATING' is already in scope because it is inherited by an enclosing type | 4 | 705 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficController': 'TRAFFICCONTROL_CONTROLLER_WARNING' is already in scope because it is inherited by an enclosing type | 4 | 745 |
| PrimitiveWrapperInstantiation | Do not use `new Integer(...)`, prefer `Integer.valueOf(...)` | 3 | 1514 |
| UselessParentheses | Useless parentheses. | 4 | 1660 |
| UselessParentheses | Useless parentheses. | 4 | 1745 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TrafficController': 'TRAFFICCONTROL_SET_TRACING' is already in scope because it is inherited by an enclosing type | 4 | 1803 |
| UselessParentheses | Useless parentheses. | 4 | 2697 |
Suppressed Violations
| Filename | Rule message | Suppression type | Reason |
|---|---|---|---|
| org/opentrafficsim/trafficcontrol/FixedTimeController.java | Avoid unused private methods such as 'updateColors()'. | @suppresswarnings | |
| org/opentrafficsim/trafficcontrol/FixedTimeController.java | Avoid unused private methods such as 'setup(OtsSimulatorInterface, Network)'. | @suppresswarnings | |
| org/opentrafficsim/trafficcontrol/ccol/Ccol.java | Avoid unused local variables such as 'result'. | @suppresswarnings | |
| org/opentrafficsim/trafficcontrol/ccol/Ccol.java | Avoid unused private methods such as 'step()'. | @suppresswarnings | |
| org/opentrafficsim/trafficcontrol/trafcod/TrafCod.java | Avoid unused private methods such as 'evalExprs()'. | @suppresswarnings |