Checkstyle Results
The following document contains the results of Checkstyle 10.17.0 with /config/dsol-checks.xml ruleset.
Summary
| Files |  Info |
 Warnings |
 Errors |
|---|---|---|---|
| 24 | 3 | 143 | 0 |
Files
Rules
| Category | Rule | Violations | Severity |
|---|---|---|---|
| blocks | EmptyBlock | 4 | Warning |
| NeedBraces | 57 | Warning | |
| coding | HiddenField
|
3 | Warning |
| design | VisibilityModifier | 21 | Warning |
| javadoc | JavadocMethod | 8 | Warning |
| misc | FinalParameters | 40 | Warning |
| TodoComment | 4 | Warning | |
| modifier | ModifierOrder | 2 | Warning |
| RedundantModifier | 2 | Warning | |
| naming | ParameterName | 2 | Warning |
| sizes | MethodLength | 1 | Info |
| ParameterNumber | 2 | Info |
Details
nl/tudelft/simulation/dsol/jetty/sse/OtsWebModel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
coding | HiddenField | 'animationPanel' hides a field. | 252 |
nl/tudelft/simulation/dsol/jetty/sse/OtsWebServer.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'webServer' must be private and have accessor methods. | 250 |
| Info |
sizes | MethodLength | Method handle length is 322 lines (max allowed is 150). | 267 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 305 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 320 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 322 |
| Warning |
blocks | NeedBraces | 'for' construct must use '{}'s. | 432 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 452 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 465 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 527 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 536 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 538 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 543 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 545 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 569 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 571 |
nl/tudelft/simulation/dsol/jetty/sse/TestDemoServer.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'sessionModelMap' must be private and have accessor methods. | 68 |
| Warning |
design | VisibilityModifier | Variable 'sessionWebModelMap' must be private and have accessor methods. | 71 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 167 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 169 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 171 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 173 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 376 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 378 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 393 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 395 |
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 401 |
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 405 |
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 409 |
| Warning |
blocks | EmptyBlock | Must have at least one statement. | 413 |
| Warning |
javadoc | JavadocMethod | Expected @param tag for '<U>'. | 422 |
| Warning |
javadoc | JavadocMethod | Expected @param tag for '<T>'. | 423 |
| Warning |
javadoc | JavadocMethod | Expected @param tag for '<U>'. | 432 |
| Warning |
javadoc | JavadocMethod | Expected @param tag for '<T>'. | 433 |
| Warning |
javadoc | JavadocMethod | Expected @param tag for '<U>'. | 447 |
| Warning |
javadoc | JavadocMethod | Expected @param tag for '<T>'. | 448 |
| Warning |
javadoc | JavadocMethod | Expected @param tag for '<U>'. | 457 |
| Warning |
javadoc | JavadocMethod | Expected @param tag for '<T>'. | 458 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 533 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 538 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 551 |
nl/tudelft/simulation/dsol/web/animation/HtmlDevice.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | FinalParameters | Parameter htmlGraphicsConfiguration should be final. | 26 |
nl/tudelft/simulation/dsol/web/animation/HtmlGraphics2d.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'background' must be private and have accessor methods. | 53 |
| Warning |
design | VisibilityModifier | Variable 'color' must be private and have accessor methods. | 56 |
| Warning |
design | VisibilityModifier | Variable 'font' must be private and have accessor methods. | 59 |
| Warning |
design | VisibilityModifier | Variable 'canvas' must be private and have accessor methods. | 62 |
| Warning |
design | VisibilityModifier | Variable 'fontMetrics' must be private and have accessor methods. | 65 |
| Warning |
design | VisibilityModifier | Variable 'paint' must be private and have accessor methods. | 68 |
| Warning |
design | VisibilityModifier | Variable 'stroke' must be private and have accessor methods. | 71 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 73 |
| Warning |
design | VisibilityModifier | Variable 'renderingHints' must be private and have accessor methods. | 74 |
| Warning |
design | VisibilityModifier | Variable 'affineTransform' must be private and have accessor methods. | 77 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 79 |
| Warning |
design | VisibilityModifier | Variable 'composite' must be private and have accessor methods. | 80 |
| Warning |
design | VisibilityModifier | Variable 'commands' must be private and have accessor methods. | 83 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 164 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 167 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 170 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 172 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 178 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 180 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 182 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 197 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 199 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 219 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 221 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 223 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 225 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 280 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 282 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 288 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 290 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 295 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 297 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 354 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 356 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 362 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 364 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 369 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 371 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 445 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 448 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 455 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 458 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 475 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 477 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 483 |
| Warning |
blocks | NeedBraces | 'else' construct must use '{}'s. | 485 |
| Warning |
naming | ParameterName | Name 'Tx' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 686 |
| Warning |
naming | ParameterName | Name 'Tx' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 692 |
| Warning |
coding | HiddenField | 'color' hides a field. | 720 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 757 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 10). | 957 |
| Info |
sizes | ParameterNumber | More than 7 parameters (found 11). | 965 |
nl/tudelft/simulation/dsol/web/animation/HtmlGraphicsConfiguration.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'htmlDevice' must be private and have accessor methods. | 26 |
| Warning |
design | VisibilityModifier | Variable 'identityTransform' must be private and have accessor methods. | 29 |
| Warning |
misc | TodoComment | Comment matches to-do format 'TODO:'. | 31 |
| Warning |
design | VisibilityModifier | Variable 'bounds' must be private and have accessor methods. | 32 |
| Warning |
coding | HiddenField | 'htmlDevice' hides a field. | 54 |
| Warning |
misc | FinalParameters | Parameter transparency should be final. | 68 |
nl/tudelft/simulation/dsol/web/animation/HtmlGraphicsEnvironment.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'htmlDevice' must be private and have accessor methods. | 26 |
| Warning |
design | VisibilityModifier | Variable 'graphics2D' must be private and have accessor methods. | 29 |
| Warning |
design | VisibilityModifier | Variable 'graphicsConfiguration' must be private and have accessor methods. | 32 |
| Warning |
misc | FinalParameters | Parameter img should be final. | 61 |
| Warning |
misc | FinalParameters | Parameter l should be final. | 82 |
nl/tudelft/simulation/dsol/web/animation/HtmlToolkit.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
design | VisibilityModifier | Variable 'eventQueue' must be private and have accessor methods. | 40 |
| Warning |
misc | FinalParameters | Parameter font should be final. | 78 |
| Warning |
misc | FinalParameters | Parameter filename should be final. | 91 |
| Warning |
misc | FinalParameters | Parameter url should be final. | 98 |
| Warning |
misc | FinalParameters | Parameter filename should be final. | 105 |
| Warning |
misc | FinalParameters | Parameter url should be final. | 112 |
| Warning |
misc | FinalParameters | Parameter image should be final. | 119 |
| Warning |
misc | FinalParameters | Parameter width should be final. | 119 |
| Warning |
misc | FinalParameters | Parameter height should be final. | 119 |
| Warning |
misc | FinalParameters | Parameter observer should be final. | 119 |
| Warning |
misc | FinalParameters | Parameter image should be final. | 126 |
| Warning |
misc | FinalParameters | Parameter width should be final. | 126 |
| Warning |
misc | FinalParameters | Parameter height should be final. | 126 |
| Warning |
misc | FinalParameters | Parameter observer should be final. | 126 |
| Warning |
misc | FinalParameters | Parameter producer should be final. | 133 |
| Warning |
misc | FinalParameters | Parameter imagedata should be final. | 140 |
| Warning |
misc | FinalParameters | Parameter imageoffset should be final. | 140 |
| Warning |
misc | FinalParameters | Parameter imagelength should be final. | 140 |
| Warning |
misc | FinalParameters | Parameter frame should be final. | 147 |
| Warning |
misc | FinalParameters | Parameter jobtitle should be final. | 147 |
| Warning |
misc | FinalParameters | Parameter props should be final. | 147 |
| Warning |
misc | FinalParameters | Parameter modalityType should be final. | 175 |
| Warning |
misc | FinalParameters | Parameter modalExclusionType should be final. | 182 |
| Warning |
misc | FinalParameters | Parameter highlight should be final. | 189 |
nl/tudelft/simulation/dsol/web/animation/d2/ToggleButtonInfo.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
misc | FinalParameters | Parameter name should be final. | 25 |
| Warning |
misc | FinalParameters | Parameter visible should be final. | 25 |
| Warning |
misc | FinalParameters | Parameter visible should be final. | 42 |
| Warning |
misc | FinalParameters | Parameter name should be final. | 77 |
| Warning |
misc | FinalParameters | Parameter locatableClass should be final. | 77 |
| Warning |
misc | FinalParameters | Parameter toolTipText should be final. | 77 |
| Warning |
misc | FinalParameters | Parameter visible should be final. | 77 |
| Warning |
misc | FinalParameters | Parameter name should be final. | 115 |
| Warning |
misc | FinalParameters | Parameter visible should be final. | 115 |
| Warning |
misc | FinalParameters | Parameter name should be final. | 143 |
| Warning |
misc | FinalParameters | Parameter layerName should be final. | 143 |
| Warning |
misc | FinalParameters | Parameter toolTipText should be final. | 143 |
| Warning |
misc | FinalParameters | Parameter visible should be final. | 143 |
org/opentrafficsim/web/animation/WebAnimationToggles.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
modifier | RedundantModifier | Redundant 'final' modifier. | 108 |
| Warning |
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 108 |
| Warning |
modifier | RedundantModifier | Redundant 'final' modifier. | 118 |
| Warning |
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 118 |