Built by Maven

Checkstyle Results

The following document contains the results of Checkstyle 10.21.3 with config/dsol-checks.xml ruleset.

Summary

Files  Info  Warnings  Errors
22 3 57 0

Files

File  I  W  E
org/opentrafficsim/web/OtsWebModel.java 0 1 0
org/opentrafficsim/web/OtsWebServer.java 1 14 0
org/opentrafficsim/web/TestDemoServer.java 0 26 0
org/opentrafficsim/web/animation/HtmlGraphics2d.java 2 6 0
org/opentrafficsim/web/animation/HtmlGraphicsConfiguration.java 0 5 0
org/opentrafficsim/web/animation/WebAnimationToggles.java 0 4 0
org/opentrafficsim/web/animation/d2/HtmlGridPanel.java 0 1 0

Rules

Category Rule Violations Severity
blocks EmptyBlock 4  Warning
NeedBraces 24  Warning
coding HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
 4  Warning
design VisibilityModifier 6  Warning
javadoc JavadocMethod 8  Warning
misc TodoComment 4  Warning
modifier ModifierOrder 2  Warning
RedundantModifier 3  Warning
naming ParameterName 2  Warning
sizes MethodLength 1  Info
ParameterNumber 2  Info

Details

org/opentrafficsim/web/OtsWebModel.java

Severity Category Rule Message Line
 Warning coding HiddenField 'animationPanel' hides a field. 246

org/opentrafficsim/web/OtsWebServer.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'webServer' must be private and have accessor methods. 255
 Info sizes MethodLength Method handle length is 312 lines (max allowed is 150). 272
 Warning blocks NeedBraces 'if' construct must use '{}'s. 305
 Warning blocks NeedBraces 'if' construct must use '{}'s. 320
 Warning blocks NeedBraces 'if' construct must use '{}'s. 322
 Warning blocks NeedBraces 'for' construct must use '{}'s. 432
 Warning blocks NeedBraces 'if' construct must use '{}'s. 452
 Warning blocks NeedBraces 'if' construct must use '{}'s. 465
 Warning blocks NeedBraces 'if' construct must use '{}'s. 527
 Warning blocks NeedBraces 'if' construct must use '{}'s. 536
 Warning blocks NeedBraces 'else' construct must use '{}'s. 538
 Warning blocks NeedBraces 'if' construct must use '{}'s. 543
 Warning blocks NeedBraces 'else' construct must use '{}'s. 545
 Warning blocks NeedBraces 'if' construct must use '{}'s. 570
 Warning blocks NeedBraces 'else' construct must use '{}'s. 572

org/opentrafficsim/web/TestDemoServer.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'sessionModelMap' must be private and have accessor methods. 67
 Warning design VisibilityModifier Variable 'sessionWebModelMap' must be private and have accessor methods. 70
 Warning modifier RedundantModifier Redundant 'public' modifier. 97
 Warning blocks NeedBraces 'if' construct must use '{}'s. 177
 Warning blocks NeedBraces 'if' construct must use '{}'s. 179
 Warning blocks NeedBraces 'if' construct must use '{}'s. 181
 Warning blocks NeedBraces 'else' construct must use '{}'s. 183
 Warning blocks NeedBraces 'if' construct must use '{}'s. 393
 Warning blocks NeedBraces 'else' construct must use '{}'s. 395
 Warning blocks NeedBraces 'if' construct must use '{}'s. 410
 Warning blocks NeedBraces 'else' construct must use '{}'s. 412
 Warning blocks EmptyBlock Must have at least one statement. 418
 Warning blocks EmptyBlock Must have at least one statement. 422
 Warning blocks EmptyBlock Must have at least one statement. 426
 Warning blocks EmptyBlock Must have at least one statement. 430
 Warning javadoc JavadocMethod Expected @param tag for '<U>'. 439
 Warning javadoc JavadocMethod Expected @param tag for '<T>'. 440
 Warning javadoc JavadocMethod Expected @param tag for '<U>'. 449
 Warning javadoc JavadocMethod Expected @param tag for '<T>'. 450
 Warning javadoc JavadocMethod Expected @param tag for '<U>'. 464
 Warning javadoc JavadocMethod Expected @param tag for '<T>'. 465
 Warning javadoc JavadocMethod Expected @param tag for '<U>'. 474
 Warning javadoc JavadocMethod Expected @param tag for '<T>'. 475
 Warning blocks NeedBraces 'if' construct must use '{}'s. 550
 Warning blocks NeedBraces 'if' construct must use '{}'s. 555
 Warning blocks NeedBraces 'if' construct must use '{}'s. 568

org/opentrafficsim/web/animation/HtmlGraphics2d.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 71
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 77
 Warning naming ParameterName Name 'Tx' must match pattern '^[a-z][a-zA-Z0-9]*$'. 753
 Warning naming ParameterName Name 'Tx' must match pattern '^[a-z][a-zA-Z0-9]*$'. 759
 Warning coding HiddenField 'color' hides a field. 787
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 824
 Info sizes ParameterNumber More than 7 parameters (found 10). 1024
 Info sizes ParameterNumber More than 7 parameters (found 11). 1032

org/opentrafficsim/web/animation/HtmlGraphicsConfiguration.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'htmlDevice' must be private and have accessor methods. 24
 Warning design VisibilityModifier Variable 'identityTransform' must be private and have accessor methods. 27
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 29
 Warning design VisibilityModifier Variable 'bounds' must be private and have accessor methods. 30
 Warning coding HiddenField 'htmlDevice' hides a field. 52

org/opentrafficsim/web/animation/WebAnimationToggles.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'final' modifier. 108
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 108
 Warning modifier RedundantModifier Redundant 'final' modifier. 118
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 118

org/opentrafficsim/web/animation/d2/HtmlGridPanel.java

Severity Category Rule Message Line
 Warning coding HiddenField 'extent' hides a field. 652