Built by Maven

Checkstyle Results

The following document contains the results of Checkstyle 10.15.0 with /config/dsol-checks.xml ruleset.

Summary

Files  Info  Warnings  Errors
86 5 95 0

Files

File  I  W  E
org/opentrafficsim/editor/ApplicationStore.java 0 2 0
org/opentrafficsim/editor/EvalWrapper.java 0 1 0
org/opentrafficsim/editor/NodeActions.java 0 1 0
org/opentrafficsim/editor/OtsEditor.java 1 9 0
org/opentrafficsim/editor/Schema.java 1 1 0
org/opentrafficsim/editor/Undo.java 1 9 0
org/opentrafficsim/editor/XiIncludeNode.java 0 4 0
org/opentrafficsim/editor/XsdPaths.java 0 1 0
org/opentrafficsim/editor/XsdTreeNode.java 0 7 0
org/opentrafficsim/editor/XsdTreeNodeUtil.java 0 1 0
org/opentrafficsim/editor/decoration/AbstractNodeDecoratorAttribute.java 0 2 0
org/opentrafficsim/editor/decoration/AutomaticLinkId.java 0 2 0
org/opentrafficsim/editor/decoration/DefaultDecorator.java 0 1 0
org/opentrafficsim/editor/decoration/string/AbstractStringFunction.java 0 1 0
org/opentrafficsim/editor/decoration/string/XiIncludeStringFunction.java 0 1 0
org/opentrafficsim/editor/decoration/validation/CoupledValidator.java 0 1 0
org/opentrafficsim/editor/decoration/validation/KeyValidator.java 0 1 0
org/opentrafficsim/editor/decoration/validation/NoDuplicateChildrenValidator.java 0 2 0
org/opentrafficsim/editor/decoration/validation/ParentValidator.java 0 3 0
org/opentrafficsim/editor/decoration/validation/RoadLayoutElementValidator.java 0 6 0
org/opentrafficsim/editor/decoration/validation/XPathValidator.java 0 6 0
org/opentrafficsim/editor/decoration/validation/XsdAllValidator.java 0 2 0
org/opentrafficsim/editor/extensions/Adapters.java 0 2 0
org/opentrafficsim/editor/extensions/OdEditor.java 0 1 0
org/opentrafficsim/editor/extensions/RoadLayoutEditor.java 0 2 0
org/opentrafficsim/editor/extensions/RouteEditor.java 0 1 0
org/opentrafficsim/editor/extensions/TrafCodEditor.java 0 1 0
org/opentrafficsim/editor/extensions/map/ChangeListener.java 0 3 0
org/opentrafficsim/editor/extensions/map/EditorMap.java 0 3 0
org/opentrafficsim/editor/extensions/map/MapCrossSectionData.java 0 1 0
org/opentrafficsim/editor/extensions/map/MapData.java 0 1 0
org/opentrafficsim/editor/extensions/map/MapLinkData.java 0 13 0
org/opentrafficsim/editor/extensions/map/RoadLayoutListener.java 1 0 0
org/opentrafficsim/editor/listeners/ChangesListener.java 0 1 0
org/opentrafficsim/editor/listeners/XsdTreeMouseListener.java 1 1 0
org/opentrafficsim/editor/listeners/XsdTreeSelectionListener.java 0 1 0

Rules

Category Rule Violations Severity
blocks EmptyBlock 2  Warning
coding HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
 40  Warning
MissingSwitchDefault 1  Warning
design FinalClass 2  Warning
HideUtilityClassConstructor 2  Warning
VisibilityModifier 17  Warning
imports UnusedImports 1  Warning
misc TodoComment 9  Warning
modifier ModifierOrder 6  Warning
RedundantModifier 13  Warning
sizes FileLength 2  Warning
LineLength
  • max: "128"
 1  Info
MethodLength 4  Info

Details

org/opentrafficsim/editor/ApplicationStore.java

Severity Category Rule Message Line
 Warning coding HiddenField 'file' hides a field. 119
 Warning coding HiddenField 'file' hides a field. 141

org/opentrafficsim/editor/EvalWrapper.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 323

org/opentrafficsim/editor/NodeActions.java

Severity Category Rule Message Line
 Warning coding HiddenField 'editor' hides a field. 72

org/opentrafficsim/editor/OtsEditor.java

Severity Category Rule Message Line
 Warning sizes FileLength File length is 2,075 lines (max allowed is 2,000). 1
 Info sizes MethodLength Method OtsEditor length is 153 lines (max allowed is 150). 306
 Warning coding HiddenField 'scenario' hides a field. 500
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 517
 Warning coding HiddenField 'properties' hides a field. 653
 Warning coding HiddenField 'coupledNode' hides a field. 791
 Warning coding HiddenField 'backNode' hides a field. 791
 Warning coding HiddenField 'backAttribute' hides a field. 791
 Warning coding HiddenField 'clipboard' hides a field. 1974
 Warning coding HiddenField 'cut' hides a field. 1974

org/opentrafficsim/editor/Schema.java

Severity Category Rule Message Line
 Warning coding HiddenField 'elements' hides a field. 597
 Info sizes LineLength Line is longer than 128 characters (found 133). 753

org/opentrafficsim/editor/Undo.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'ignoreChanges' must be private and have accessor methods. 54
 Info sizes MethodLength Method notify length is 170 lines (max allowed is 150). 228
 Warning modifier RedundantModifier Redundant 'public' modifier. 458
 Warning design VisibilityModifier Variable 'type' must be private and have accessor methods. 499
 Warning design VisibilityModifier Variable 'subActions' must be private and have accessor methods. 502
 Warning design VisibilityModifier Variable 'node' must be private and have accessor methods. 505
 Warning design VisibilityModifier Variable 'parent' must be private and have accessor methods. 508
 Warning design VisibilityModifier Variable 'attribute' must be private and have accessor methods. 511
 Warning design VisibilityModifier Variable 'postActionShowNode' must be private and have accessor methods. 514
 Warning modifier RedundantModifier Redundant 'public' modifier. 524

org/opentrafficsim/editor/XiIncludeNode.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 335
 Warning modifier RedundantModifier Redundant 'public' modifier. 615
 Warning coding HiddenField 'name' hides a field. 883
 Warning coding HiddenField 'name' hides a field. 901

org/opentrafficsim/editor/XsdPaths.java

Severity Category Rule Message Line
 Warning design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 13

org/opentrafficsim/editor/XsdTreeNode.java

Severity Category Rule Message Line
 Warning sizes FileLength File length is 2,727 lines (max allowed is 2,000). 1
 Warning coding HiddenField 'children' hides a field. 353
 Warning coding HiddenField 'parent' hides a field. 1459
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 1632
 Warning coding HiddenField 'stringFunction' hides a field. 2132
 Warning coding HiddenField 'value' hides a field. 2375
 Warning coding HiddenField 'maxOccurs' hides a field. 2517

org/opentrafficsim/editor/XsdTreeNodeUtil.java

Severity Category Rule Message Line
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 34

org/opentrafficsim/editor/decoration/AbstractNodeDecoratorAttribute.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'predicate' must be private and have accessor methods. 28
 Warning design VisibilityModifier Variable 'attributes' must be private and have accessor methods. 31

org/opentrafficsim/editor/decoration/AutomaticLinkId.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'lastNode' must be private and have accessor methods. 27
 Warning design VisibilityModifier Variable 'lastId' must be private and have accessor methods. 30

org/opentrafficsim/editor/decoration/DefaultDecorator.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 191

org/opentrafficsim/editor/decoration/string/AbstractStringFunction.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'overwrite' must be private and have accessor methods. 28

org/opentrafficsim/editor/decoration/string/XiIncludeStringFunction.java

Severity Category Rule Message Line
 Warning imports UnusedImports Unused import - org.opentrafficsim.editor.XsdTreeNodeRoot. 8

org/opentrafficsim/editor/decoration/validation/CoupledValidator.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'final' modifier. 28

org/opentrafficsim/editor/decoration/validation/KeyValidator.java

Severity Category Rule Message Line
 Warning coding HiddenField 'nodes' hides a field. 164

org/opentrafficsim/editor/decoration/validation/NoDuplicateChildrenValidator.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'final' modifier. 126
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 126

org/opentrafficsim/editor/decoration/validation/ParentValidator.java

Severity Category Rule Message Line
 Warning coding HiddenField 'contextPath' hides a field. 63
 Warning coding HiddenField 'idAttribute' hides a field. 74
 Warning coding HiddenField 'parentAttribute' hides a field. 85

org/opentrafficsim/editor/decoration/validation/RoadLayoutElementValidator.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'final' modifier. 229
 Warning coding HiddenField 'attribute' hides a field. 380
 Warning modifier RedundantModifier Redundant 'final' modifier. 402
 Warning modifier RedundantModifier Redundant 'static' modifier. 432
 Warning modifier RedundantModifier Redundant 'public' modifier. 471
 Warning coding HiddenField 'attribute' hides a field. 501

org/opentrafficsim/editor/decoration/validation/XPathValidator.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'keyNode' must be private and have accessor methods. 25
 Warning design VisibilityModifier Variable 'keyPath' must be private and have accessor methods. 28
 Warning design VisibilityModifier Variable 'fields' must be private and have accessor methods. 31
 Warning coding HiddenField 'fields' hides a field. 44
 Warning modifier ModifierOrder 'public' modifier out of order with the JLS suggestions. 165
 Warning modifier ModifierOrder 'public' modifier out of order with the JLS suggestions. 172

org/opentrafficsim/editor/decoration/validation/XsdAllValidator.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'final' modifier. 94
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 94

org/opentrafficsim/editor/extensions/Adapters.java

Severity Category Rule Message Line
 Warning design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 38
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 42

org/opentrafficsim/editor/extensions/OdEditor.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 61

org/opentrafficsim/editor/extensions/RoadLayoutEditor.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 65
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 87

org/opentrafficsim/editor/extensions/RouteEditor.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 60

org/opentrafficsim/editor/extensions/TrafCodEditor.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 46

org/opentrafficsim/editor/extensions/map/ChangeListener.java

Severity Category Rule Message Line
 Warning coding HiddenField 'node' hides a field. 102
 Warning coding HiddenField 'node' hides a field. 127
 Warning coding HiddenField 'node' hides a field. 174

org/opentrafficsim/editor/extensions/map/EditorMap.java

Severity Category Rule Message Line
 Warning design FinalClass Class EditorMap should be declared as final. 86
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 421
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 739

org/opentrafficsim/editor/extensions/map/MapCrossSectionData.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'centerLine' must be private and have accessor methods. 32

org/opentrafficsim/editor/extensions/map/MapData.java

Severity Category Rule Message Line
 Warning coding HiddenField 'node' hides a field. 109

org/opentrafficsim/editor/extensions/map/MapLinkData.java

Severity Category Rule Message Line
 Warning blocks EmptyBlock Must have at least one statement. 385
 Warning blocks EmptyBlock Must have at least one statement. 389
 Warning coding HiddenField 'from' hides a field. 520
 Warning coding HiddenField 'to' hides a field. 523
 Warning coding HiddenField 'laneData' hides a field. 634
 Warning design FinalClass Class ShapeListener should be declared as final. 743
 Warning design VisibilityModifier Variable 'coordinates' must be private and have accessor methods. 776
 Warning coding MissingSwitchDefault switch without "default" clause. 855
 Warning coding HiddenField 'from' hides a field. 1061
 Warning coding HiddenField 'to' hides a field. 1061
 Warning coding HiddenField 'length' hides a field. 1068
 Warning coding HiddenField 'shape' hides a field. 1084
 Warning coding HiddenField 'weighted' hides a field. 1085

org/opentrafficsim/editor/extensions/map/RoadLayoutListener.java

Severity Category Rule Message Line
 Info sizes MethodLength Method calculateData length is 176 lines (max allowed is 150). 82

org/opentrafficsim/editor/listeners/ChangesListener.java

Severity Category Rule Message Line
 Warning coding HiddenField 'scenario' hides a field. 97

org/opentrafficsim/editor/listeners/XsdTreeMouseListener.java

Severity Category Rule Message Line
 Warning coding HiddenField 'editor' hides a field. 66
 Info sizes MethodLength Method addDefaultActions length is 270 lines (max allowed is 150). 251

org/opentrafficsim/editor/listeners/XsdTreeSelectionListener.java

Severity Category Rule Message Line
 Warning coding HiddenField 'editor' hides a field. 109