FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
345 106 0 0

Files

Class Bugs
org.opentrafficsim.graphs.Axis 2
org.opentrafficsim.graphs.ContourPlot 2
org.opentrafficsim.graphs.FundamentalDiagram$Sample 1
org.opentrafficsim.graphs.FundamentalDiagramLane$Sample 1
org.opentrafficsim.graphs.TrajectoryPlot 1
org.opentrafficsim.graphs.TrajectoryPlot$FixedSampleRateTrajectory 2
org.opentrafficsim.graphs.TrajectoryPlot$VariableSampleRateTrajectory 2
org.opentrafficsim.road.gtu.animation.DefaultCarAnimation 2
org.opentrafficsim.road.gtu.animation.DefaultCarAnimation$Text 1
org.opentrafficsim.road.gtu.generator.GTUTypeGenerator$GTUTypeInfo 1
org.opentrafficsim.road.gtu.generator.LaneBasedGTUGenerator 1
org.opentrafficsim.road.gtu.generator.ListGTUGenerator 2
org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU 13
org.opentrafficsim.road.gtu.lane.LaneBasedTemplateGTUType 1
org.opentrafficsim.road.gtu.lane.perception.AbstractLanePerception 4
org.opentrafficsim.road.gtu.lane.perception.InfrastructureLaneChangeInfo 1
org.opentrafficsim.road.gtu.lane.perception.categories.AbstractDelayedPerceptionCategory 2
org.opentrafficsim.road.gtu.lane.perception.categories.AbstractDelayedPerceptionCategory$DelayedInfoType 1
org.opentrafficsim.road.gtu.lane.perception.categories.DelayedNeighborsPerception 1
org.opentrafficsim.road.gtu.lane.perception.categories.DelayedNeighborsPerception$ErrorValue 1
org.opentrafficsim.road.gtu.lane.perception.categories.DirectBusStopPerception 1
org.opentrafficsim.road.gtu.lane.perception.categories.DirectDefaultSimplePerception 1
org.opentrafficsim.road.gtu.lane.perception.categories.DirectInfrastructurePerception 1
org.opentrafficsim.road.gtu.lane.perception.categories.DirectIntersectionPerception$LaneInfo 2
org.opentrafficsim.road.gtu.lane.perception.categories.DirectNeighborsPerception 1
org.opentrafficsim.road.gtu.lane.perception.categories.InfrastructurePerception 1
org.opentrafficsim.road.gtu.lane.plan.operational.LaneBasedOperationalPlan 1
org.opentrafficsim.road.gtu.lane.plan.operational.LaneOperationalPlanBuilder 2
org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner 3
org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingDirectedChangeTacticalPlanner 1
org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingDirectedChangeTacticalPlannerFactory 1
org.opentrafficsim.road.gtu.lane.tactical.following.AbstractGTUFollowingModelMobil 1
org.opentrafficsim.road.gtu.lane.tactical.following.IDMPlusMulti 1
org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.AbstractLaneChangeModel 1
org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS 4
org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRSFactory 5
org.opentrafficsim.road.gtu.lane.tactical.pt.BusSchedule 1
org.opentrafficsim.road.gtu.lane.tactical.pt.BusSchedule$BusStopInfo 1
org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo$GapAcceptanceInfo 2
org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo$GapInfo 2
org.opentrafficsim.road.gtu.strategical.od.ODMatrix 5
org.opentrafficsim.road.gtu.strategical.route.LaneBasedStrategicalRoutePlannerFactory 2
org.opentrafficsim.road.network.animation.BusStopAnimation 1
org.opentrafficsim.road.network.animation.ConflictAnimation 1
org.opentrafficsim.road.network.animation.LaneAnimation 1
org.opentrafficsim.road.network.animation.SensorAnimation 1
org.opentrafficsim.road.network.animation.ShoulderAnimation 1
org.opentrafficsim.road.network.animation.SinkAnimation 1
org.opentrafficsim.road.network.animation.SpeedSignAnimation 1
org.opentrafficsim.road.network.animation.StripeAnimation 1
org.opentrafficsim.road.network.animation.TrafficLightAnimation 1
org.opentrafficsim.road.network.animation.TrafficLightSensorAnimation 1
org.opentrafficsim.road.network.lane.CrossSectionLink 1
org.opentrafficsim.road.network.lane.Lane 6
org.opentrafficsim.road.network.lane.conflict.BusStopConflictRule 1
org.opentrafficsim.road.network.lane.conflict.Conflict 1
org.opentrafficsim.road.network.lane.object.BusStop 1
org.opentrafficsim.road.network.lane.object.trafficlight.AbstractTrafficLightController 1
org.opentrafficsim.road.network.sampling.data.TimeToCollision 1
org.opentrafficsim.road.network.sampling.indicator.TotalDelayReference 1
org.opentrafficsim.road.network.speed.SpeedLimitInfo 1

org.opentrafficsim.graphs.Axis

Bug Category Details Line Priority
org.opentrafficsim.graphs.Axis.getGranularities() may expose internal representation by returning Axis.granularities MALICIOUS_CODE EI_EXPOSE_REP 182 Medium
new org.opentrafficsim.graphs.Axis(DoubleScalarInterface, DoubleScalarInterface, double[], double, String, String, String) may expose internal representation by storing an externally mutable object into Axis.granularities MALICIOUS_CODE EI_EXPOSE_REP2 60 Medium

org.opentrafficsim.graphs.ContourPlot

Bug Category Details Line Priority
org.opentrafficsim.graphs.ContourPlot.STANDARDDISTANCEGRANULARITIES should be package protected MALICIOUS_CODE MS_PKGPROTECT 96 Medium
org.opentrafficsim.graphs.ContourPlot.STANDARDTIMEGRANULARITIES should be package protected MALICIOUS_CODE MS_PKGPROTECT 90 Medium

org.opentrafficsim.graphs.FundamentalDiagram$Sample

Bug Category Details Line Priority
org.opentrafficsim.graphs.FundamentalDiagram$Sample is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 464-520 Medium

org.opentrafficsim.graphs.FundamentalDiagramLane$Sample

Bug Category Details Line Priority
org.opentrafficsim.graphs.FundamentalDiagramLane$Sample is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 533-569 Medium

org.opentrafficsim.graphs.TrajectoryPlot

Bug Category Details Line Priority
org.opentrafficsim.graphs.TrajectoryPlot.sample() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 195 Medium

org.opentrafficsim.graphs.TrajectoryPlot$FixedSampleRateTrajectory

Bug Category Details Line Priority
org.opentrafficsim.graphs.TrajectoryPlot$FixedSampleRateTrajectory is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 742-892 Medium
Unwritten field: org.opentrafficsim.graphs.TrajectoryPlot$FixedSampleRateTrajectory.currentEndTime CORRECTNESS UWF_UNWRITTEN_FIELD 759 Medium

org.opentrafficsim.graphs.TrajectoryPlot$VariableSampleRateTrajectory

Bug Category Details Line Priority
Class org.opentrafficsim.graphs.TrajectoryPlot$VariableSampleRateTrajectory defines non-transient non-serializable instance field samples BAD_PRACTICE SE_BAD_FIELD Not available High
org.opentrafficsim.graphs.TrajectoryPlot$VariableSampleRateTrajectory is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 561-672 Medium

org.opentrafficsim.road.gtu.animation.DefaultCarAnimation

Bug Category Details Line Priority
org.opentrafficsim.core.gtu.animation.IDGTUColorer stored into non-transient field DefaultCarAnimation.gtuColorer BAD_PRACTICE SE_BAD_FIELD_STORE 79 High
org.opentrafficsim.road.gtu.animation.DefaultCarAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 50-186 High

org.opentrafficsim.road.gtu.animation.DefaultCarAnimation$Text

Bug Category Details Line Priority
Potentially ambiguous invocation of either an outer or inherited method org.opentrafficsim.core.animation.TextAnimation.destroy() in org.opentrafficsim.road.gtu.animation.DefaultCarAnimation$Text.paint(Graphics2D, ImageObserver) STYLE IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD 240 High

org.opentrafficsim.road.gtu.generator.GTUTypeGenerator$GTUTypeInfo

Bug Category Details Line Priority
Should org.opentrafficsim.road.gtu.generator.GTUTypeGenerator$GTUTypeInfo be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 155-191 Medium

org.opentrafficsim.road.gtu.generator.LaneBasedGTUGenerator

Bug Category Details Line Priority
Class org.opentrafficsim.road.gtu.generator.LaneBasedGTUGenerator defines non-transient non-serializable instance field roomChecker BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.road.gtu.generator.ListGTUGenerator

Bug Category Details Line Priority
Found reliance on default encoding in new org.opentrafficsim.road.gtu.generator.ListGTUGenerator(String, OTSDEVSSimulatorInterface, GTUType, Speed, Lane, Length, GTUDirectionality, GTUColorer, LaneBasedStrategicalPlanner, OTSNetwork, String): new java.io.FileReader(File) I18N DM_DEFAULT_ENCODING 120 High
Class org.opentrafficsim.road.gtu.generator.ListGTUGenerator defines non-transient non-serializable instance field reader BAD_PRACTICE SE_BAD_FIELD Not available High

org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.scheduleEnterLeaveTriggers() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 800 Medium
org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.CACHED_POSITION should be package protected MALICIOUS_CODE MS_PKGPROTECT 112 Medium
org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.NON_CACHED_POSITION should be package protected MALICIOUS_CODE MS_PKGPROTECT 116 Medium
org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.CACHING isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 108 High
org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.initialLocationThresholdDifference isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 104 High
Possible null pointer dereference of initialLongitudinalPositions in org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.init(LaneBasedStrategicalPlanner, Set, Speed) CORRECTNESS NP_NULL_ON_SOME_PATH 147 High
Write to static field org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.CACHED_POSITION from instance method org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.position(Lane, RelativePosition, Time) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 577 Medium
Write to static field org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.NON_CACHED_POSITION from instance method org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.position(Lane, RelativePosition, Time) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 586 Medium
Useless object stored in variable fractionalLanePositions of method org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.executeLaneChangeFinalization(LateralDirectionality) STYLE UC_USELESS_OBJECT 391 Medium
org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.changeLaneInstantaneously(LateralDirectionality) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 316 Medium
org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.initLaneChange(LateralDirectionality) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 355 Medium
org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.scheduleEnterLeaveTriggers() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 791 Medium
org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.scheduleEnterLeaveTriggers() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 677 Medium

org.opentrafficsim.road.gtu.lane.LaneBasedTemplateGTUType

Bug Category Details Line Priority
Class org.opentrafficsim.road.gtu.lane.LaneBasedTemplateGTUType defines non-transient non-serializable instance field routeGenerator BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.road.gtu.lane.perception.AbstractLanePerception

Bug Category Details Line Priority
Potentially dangerous use of non-short-circuit logic in org.opentrafficsim.road.gtu.lane.perception.AbstractLanePerception.extendLateral(Set, GTUType, Length, Length, Length, boolean) STYLE NS_DANGEROUS_NON_SHORT_CIRCUIT 424 High
Useless object stored in variable minStart of method org.opentrafficsim.road.gtu.lane.perception.AbstractLanePerception.buildUpstreamRecursive(Set, GTUType, Length, Length, Length) STYLE UC_USELESS_OBJECT 451 Medium
Useless object stored in variable laneSet of method org.opentrafficsim.road.gtu.lane.perception.AbstractLanePerception.startBuild(LaneStructureRecord, double, GTUType, Length, Length, Length, Length) STYLE UC_USELESS_OBJECT 164 Medium
org.opentrafficsim.road.gtu.lane.perception.AbstractLanePerception.connectLaterally(Map, GTUType) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 526 Medium

org.opentrafficsim.road.gtu.lane.perception.InfrastructureLaneChangeInfo

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.perception.InfrastructureLaneChangeInfo defines compareTo(InfrastructureLaneChangeInfo) and uses Object.equals() BAD_PRACTICE EQ_COMPARETO_USE_OBJECT_EQUALS 92 Medium

org.opentrafficsim.road.gtu.lane.perception.categories.AbstractDelayedPerceptionCategory

Bug Category Details Line Priority
Load of known null value in org.opentrafficsim.road.gtu.lane.perception.categories.AbstractDelayedPerceptionCategory.changeLane(LateralDirectionality) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 180 Medium
org.opentrafficsim.road.gtu.lane.perception.categories.AbstractDelayedPerceptionCategory.changeLane(LateralDirectionality) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 172 Medium

org.opentrafficsim.road.gtu.lane.perception.categories.AbstractDelayedPerceptionCategory$DelayedInfoType

Bug Category Details Line Priority
There is an apparent infinite recursive loop in org.opentrafficsim.road.gtu.lane.perception.categories.AbstractDelayedPerceptionCategory$DelayedInfoType.getId() CORRECTNESS IL_INFINITE_RECURSIVE_LOOP 226 High

org.opentrafficsim.road.gtu.lane.perception.categories.DelayedNeighborsPerception

Bug Category Details Line Priority
Class org.opentrafficsim.road.gtu.lane.perception.categories.DelayedNeighborsPerception defines non-transient non-serializable instance field errors BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.road.gtu.lane.perception.categories.DelayedNeighborsPerception$ErrorValue

Bug Category Details Line Priority
Should org.opentrafficsim.road.gtu.lane.perception.categories.DelayedNeighborsPerception$ErrorValue be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 453-480 Medium

org.opentrafficsim.road.gtu.lane.perception.categories.DirectBusStopPerception

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.perception.categories.DirectBusStopPerception.updateBusStops() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 57 Medium

org.opentrafficsim.road.gtu.lane.perception.categories.DirectDefaultSimplePerception

Bug Category Details Line Priority
Call to org.opentrafficsim.road.gtu.lane.LaneBasedGTU.equals(org.opentrafficsim.road.gtu.lane.perception.categories.DirectDefaultSimplePerception) in org.opentrafficsim.road.gtu.lane.perception.categories.DirectDefaultSimplePerception.parallel(Lane, Time) CORRECTNESS EC_UNRELATED_CLASS_AND_INTERFACE 929 Medium

org.opentrafficsim.road.gtu.lane.perception.categories.DirectInfrastructurePerception

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.perception.categories.DirectInfrastructurePerception.updateInfrastructureLaneChangeInfo(RelativeLane) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 155 Medium

org.opentrafficsim.road.gtu.lane.perception.categories.DirectIntersectionPerception$LaneInfo

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.perception.categories.DirectIntersectionPerception$LaneInfo.getDownstreamLaneInfos(Length) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 469 Medium
org.opentrafficsim.road.gtu.lane.perception.categories.DirectIntersectionPerception$LaneInfo.getUpstreamLaneInfos(Length) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 444 Medium

org.opentrafficsim.road.gtu.lane.perception.categories.DirectNeighborsPerception

Bug Category Details Line Priority
Private method org.opentrafficsim.road.gtu.lane.perception.categories.DirectNeighborsPerception.forwardHeadway(Length) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 676-677 Medium

org.opentrafficsim.road.gtu.lane.perception.categories.InfrastructurePerception

Bug Category Details Line Priority
Useless object stored in variable lanes of method org.opentrafficsim.road.gtu.lane.perception.categories.InfrastructurePerception.updateAll() STYLE UC_USELESS_OBJECT 146 Medium

org.opentrafficsim.road.gtu.lane.plan.operational.LaneBasedOperationalPlan

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.plan.operational.LaneBasedOperationalPlan doesn't override org.opentrafficsim.core.gtu.plan.operational.OperationalPlan.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium

org.opentrafficsim.road.gtu.lane.plan.operational.LaneOperationalPlanBuilder

Bug Category Details Line Priority
Dead store to fromFirst in org.opentrafficsim.road.gtu.lane.plan.operational.LaneOperationalPlanBuilder.buildAccelerationLaneChangePlan(LaneBasedGTU, List, LateralDirectionality, DirectedPoint, Time, Speed, Acceleration, Duration, LaneOperationalPlanBuilder$LaneChange) STYLE DLS_DEAD_LOCAL_STORE 416 Medium
Dead store to toFirst in org.opentrafficsim.road.gtu.lane.plan.operational.LaneOperationalPlanBuilder.buildAccelerationLaneChangePlan(LaneBasedGTU, List, LateralDirectionality, DirectedPoint, Time, Speed, Acceleration, Duration, LaneOperationalPlanBuilder$LaneChange) STYLE DLS_DEAD_LOCAL_STORE 417 Medium

org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner

Bug Category Details Line Priority
Dead store to currentLaneFine in org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner.generateOperationalPlan(Time, DirectedPoint) STYLE DLS_DEAD_LOCAL_STORE 150 Medium
Dead store to maximumReverseHeadway in org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner.generateOperationalPlan(Time, DirectedPoint) STYLE DLS_DEAD_LOCAL_STORE 127 Medium
Dead store to now in org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner.generateOperationalPlan(Time, DirectedPoint) STYLE DLS_DEAD_LOCAL_STORE 128 Medium

org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingDirectedChangeTacticalPlanner

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingDirectedChangeTacticalPlanner.canChange(LaneBasedGTU, LanePerception, LanePathInfo, LateralDirectionality) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 507 Medium

org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingDirectedChangeTacticalPlannerFactory

Bug Category Details Line Priority
Class org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingDirectedChangeTacticalPlannerFactory defines non-transient non-serializable instance field carFollowingModelFactory BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.road.gtu.lane.tactical.following.AbstractGTUFollowingModelMobil

Bug Category Details Line Priority
Dead store to maximumSIDeceleration in org.opentrafficsim.road.gtu.lane.tactical.following.AbstractGTUFollowingModelMobil.minimumHeadway(Speed, Speed, Length, Length, Speed, Speed) STYLE DLS_DEAD_LOCAL_STORE 236 Medium

org.opentrafficsim.road.gtu.lane.tactical.following.IDMPlusMulti

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.tactical.following.IDMPlusMulti.combineInteractionTerm(Acceleration, BehavioralCharacteristics, Speed, Speed, Length, SortedMap) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 54 Medium

org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.AbstractLaneChangeModel

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.AbstractLaneChangeModel.computeLaneChangeAndAcceleration(LaneBasedGTU, Collection, Collection, Collection, Speed, Acceleration, Acceleration, Acceleration) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 58 Medium

org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS

Bug Category Details Line Priority
Class org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS defines non-transient non-serializable instance field accelerationIncentives BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS defines non-transient non-serializable instance field lmrsData BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS defines non-transient non-serializable instance field mandatoryIncentives BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS defines non-transient non-serializable instance field voluntaryIncentives BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRSFactory

Bug Category Details Line Priority
Class org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRSFactory defines non-transient non-serializable instance field accelerationIncentives BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRSFactory defines non-transient non-serializable instance field carFollowingModelFactory BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRSFactory defines non-transient non-serializable instance field mandatoryIncentives BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRSFactory defines non-transient non-serializable instance field perceptionFactory BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRSFactory defines non-transient non-serializable instance field voluntaryIncentives BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.road.gtu.lane.tactical.pt.BusSchedule

Bug Category Details Line Priority
Class org.opentrafficsim.road.gtu.lane.tactical.pt.BusSchedule defines non-transient non-serializable instance field schedule BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.road.gtu.lane.tactical.pt.BusSchedule$BusStopInfo

Bug Category Details Line Priority
Should org.opentrafficsim.road.gtu.lane.tactical.pt.BusSchedule$BusStopInfo be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 216-243 Medium

org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo$GapAcceptanceInfo

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo$GapAcceptanceInfo is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 951-976 Medium
Should org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo$GapAcceptanceInfo be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 951-976 Medium

org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo$GapInfo

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo$GapInfo is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 873-916 Medium
Should org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo$GapInfo be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 873-916 Medium

org.opentrafficsim.road.gtu.strategical.od.ODMatrix

Bug Category Details Line Priority
Dead store to e in org.opentrafficsim.road.gtu.strategical.od.ODMatrix.main(String[]) STYLE DLS_DEAD_LOCAL_STORE 508 High
Null passed for non-null parameter of new java.util.ArrayList(Collection) in new org.opentrafficsim.road.gtu.strategical.od.ODMatrix(String, List, List, Categorization, DurationVector, Interpolation) CORRECTNESS NP_NULL_PARAM_DEREF 90 Medium
Null passed for non-null parameter of new java.util.ArrayList(Collection) in new org.opentrafficsim.road.gtu.strategical.od.ODMatrix(String, List, List, Categorization, DurationVector, Interpolation) CORRECTNESS NP_NULL_PARAM_DEREF 89 Medium
Class org.opentrafficsim.road.gtu.strategical.od.ODMatrix defines non-transient non-serializable instance field demandData BAD_PRACTICE SE_BAD_FIELD Not available High
org.opentrafficsim.road.gtu.strategical.od.ODMatrix.print() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 374 Medium

org.opentrafficsim.road.gtu.strategical.route.LaneBasedStrategicalRoutePlannerFactory

Bug Category Details Line Priority
Class org.opentrafficsim.road.gtu.strategical.route.LaneBasedStrategicalRoutePlannerFactory defines non-transient non-serializable instance field behavioralCharacteristicsFactory BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.opentrafficsim.core.gtu.behavioralcharacteristics.BehavioralCharacteristicsFactoryDefault stored into non-transient field LaneBasedStrategicalRoutePlannerFactory.behavioralCharacteristicsFactory BAD_PRACTICE SE_BAD_FIELD_STORE 50 High

org.opentrafficsim.road.network.animation.BusStopAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.network.animation.BusStopAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 47-73 High

org.opentrafficsim.road.network.animation.ConflictAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.network.animation.ConflictAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 46-109 High

org.opentrafficsim.road.network.animation.LaneAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.network.animation.LaneAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 35-122 High

org.opentrafficsim.road.network.animation.SensorAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.network.animation.SensorAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 33-106 High

org.opentrafficsim.road.network.animation.ShoulderAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.network.animation.ShoulderAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 44-60 High

org.opentrafficsim.road.network.animation.SinkAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.network.animation.SinkAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 42-57 High

org.opentrafficsim.road.network.animation.SpeedSignAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.network.animation.SpeedSignAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 53-83 High

org.opentrafficsim.road.network.animation.StripeAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.network.animation.StripeAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 38-258 High

org.opentrafficsim.road.network.animation.TrafficLightAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.network.animation.TrafficLightAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 32-120 High

org.opentrafficsim.road.network.animation.TrafficLightSensorAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.network.animation.TrafficLightSensorAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 55-90 High

org.opentrafficsim.road.network.lane.CrossSectionLink

Bug Category Details Line Priority
org.opentrafficsim.road.network.lane.CrossSectionLink doesn't override org.opentrafficsim.core.network.OTSLink.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium

org.opentrafficsim.road.network.lane.Lane

Bug Category Details Line Priority
org.opentrafficsim.road.network.lane.Lane.checkDirectionality() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 1604 Medium
org.opentrafficsim.road.network.lane.Lane.clone(CrossSectionLink, OTSSimulatorInterface, boolean) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 1713 Medium
org.opentrafficsim.road.network.lane.Lane.clone(CrossSectionLink, OTSSimulatorInterface, boolean) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 1699 Medium
org.opentrafficsim.road.network.lane.Lane.getHighestSpeedLimit() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 1482 Medium
org.opentrafficsim.road.network.lane.Lane.getLaneBasedObjectMap() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 897 Medium
org.opentrafficsim.road.network.lane.Lane.getObjectAhead(Length, GTUDirectionality) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 1137 Medium

org.opentrafficsim.road.network.lane.conflict.BusStopConflictRule

Bug Category Details Line Priority
org.opentrafficsim.road.network.lane.conflict.BusStopConflictRule.determinePriority(Conflict) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 86 Medium

org.opentrafficsim.road.network.lane.conflict.Conflict

Bug Category Details Line Priority
Class org.opentrafficsim.road.network.lane.conflict.Conflict defines non-transient non-serializable instance field conflictRule BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.road.network.lane.object.BusStop

Bug Category Details Line Priority
org.opentrafficsim.road.network.lane.object.BusStop.toString() concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 195 Medium

org.opentrafficsim.road.network.lane.object.trafficlight.AbstractTrafficLightController

Bug Category Details Line Priority
Unread public/protected field: org.opentrafficsim.road.network.lane.object.trafficlight.AbstractTrafficLightController.currentColor STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 38 Medium

org.opentrafficsim.road.network.sampling.data.TimeToCollision

Bug Category Details Line Priority
org.opentrafficsim.road.network.sampling.data.TimeToCollision.getValue(GtuDataInterface) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 63 Medium

org.opentrafficsim.road.network.sampling.indicator.TotalDelayReference

Bug Category Details Line Priority
org.opentrafficsim.road.network.sampling.indicator.TotalDelayReference.calculate(Query, Time, Time, List) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 102 Medium

org.opentrafficsim.road.network.speed.SpeedLimitInfo

Bug Category Details Line Priority
org.opentrafficsim.road.network.speed.SpeedLimitInfo.toString() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 129 Medium