The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.
| Tag Class | Total number of occurrences | Tag strings used by tag class |
|---|---|---|
| Open issues in the code | 214 | TODO, FIXME, XXX |
Each tag is detailed below:
Number of occurrences found in the code: 214
| org.opentrafficsim.graphs.ContourPlotTest | Line |
|---|---|
| @Test | 96 |
| @Test | 116 |
| @Test | 176 |
| @Test | 196 |
| looks wrong / PK | 516 |
| org.opentrafficsim.graphs.FundamentalDiagram | Line |
| --No comment-- | 622 |
| org.opentrafficsim.graphs.FundamentalDiagramPlotTest | Line |
| @Test | 79 |
| THIS TEST FAILS!!! assertEquals("Density should be " + expectedDensity, expectedDensity, value, 0.00001); | 177 |
| org.opentrafficsim.graphs.TrajectoryPlot | Line |
| ensure that shapes for all the data points don't get allocated. Currently JFreeChart allocates many megabytes of memory for Ellipses that are never drawn. | 399 |
| lane change causes error... | 850 |
| org.opentrafficsim.graphs.TrajectoryPlotTest | Line |
| we take the first (and only) lane on which the vehicle is registered. | 213 |
| org.opentrafficsim.road.car.CarTest | Line |
| check with following model as part of tactical planner assertEquals("The gtu following model should be " + gtuFollowingModel, gtuFollowingModel, referenceCar .getBehavioralCharacteristics().getGTUFollowingModel()); There is (currently) no way to retrieve the lane change model of a GTU. | 106 |
| org.opentrafficsim.road.gtu.AbstractLaneBasedGTUTest | Line |
| Test with gfm as part of tactical planner assertEquals("GTU following model should be identical to the provided one", gfm, car .getBehavioralCharacteristics().getGTUFollowingModel()); | 142 |
| removeLane should throw an Error when the car is not on that lane (currently this is silently ignored) | 385 |
| figure out why the added lane has a non-zero position | 386 |
| org.opentrafficsim.road.gtu.LaneBasedGTUTest | Line |
| see how we can ask the vehicle to look this far ahead | 179 |
| see how we can ask the vehicle to look this far behind | 187 |
| see how we can ask the vehicle to look 'forwardMaxDistance' ahead | 220 |
| follower = truck.headway(reverseMaxDistance); | 241 |
| org.opentrafficsim.road.gtu.LaneBasedTemplateGTUTypeTest | Line |
| assertTrue("Passengers cars are allowed on a no trucks lane", passengerCar.isCompatible(trucksForbidden)); | 283 |
| assertFalse("Trucks are not allowed on a no trucks lane", truck.isCompatible(trucksForbidden)); | 284 |
| assertFalse("Passenger cars are not allowed on a trucks only lane", passengerCar.isCompatible(trucksOnly)); | 285 |
| assertTrue("Trucks are allowed on a trucks only lane", truck.isCompatible(trucksOnly)); | 286 |
| assertTrue("Passenger cars are allowed on an urban road", passengerCar.isCompatible(urbanRoad)); | 287 |
| assertTrue("Trucks are allowed on an urban road", truck.isCompatible(urbanRoad)); | 288 |
| assertFalse("Passenger cars are not allowed on a bicycle path", passengerCar.isCompatible(bicycleLane)); | 289 |
| assertFalse("Trucks are not allowed on an urban road", truck.isCompatible(bicycleLane)); | 290 |
| org.opentrafficsim.road.gtu.animation.DefaultCarAnimation | Line |
| this could be a property of a GTU | 153 |
| org.opentrafficsim.road.gtu.animation.DefaultSwitchableGTUColorer | Line |
| same class name as in core, w\o additional functionality, while the core one is used in AbstractWrappableAnimation | 24 |
| LaneChangeUrgeGTUColorer COLORERS[3] = new LaneChangeUrgeGTUColorer(new Length(10, LengthUnit.METER), new Length(1000, LengthUnit.METER)); | 36 |
| org.opentrafficsim.road.gtu.generator.AbstractGTUGenerator | Line |
| different from this.direction? | 252 |
| THIS METHOD IS ALSO IN PERCEPTION -- DON'T DUPLICATE; ALSO, THIS VERSION IS WRONG. | 313 |
| Only follow links on the Route if there is a "real" Route if (routeNavigator.getRoute() == null || routeNavigator.getRoute().size() == 0 /* XXXXX STUB dummy route */ || routeNavigator.getRoute().containsLink((Link) theLane.getParentLink())) | 336 |
| XX STUB dummy route | 337 |
| THIS METHOD IS ALSO IN PERCEPTION -- DON'T DUPLICATE; ALSO, THIS VERSION IS WRONG. | 373 |
| Only follow links on the Route if there is a "real" Route if (routeNavigator.getRoute() == null || routeNavigator.getRoute().size() == 0 /* XXXXX STUB dummy route */ || routeNavigator.getRoute().containsLink((Link) theLane.getParentLink())) | 396 |
| XX STUB dummy route | 397 |
| org.opentrafficsim.road.gtu.generator.HeadwayGeneratorDemand | Line |
| Link this class to an OD | 30 |
| org.opentrafficsim.road.gtu.generator.LaneBasedGTUGenerator | Line |
| ALL? we need to stop for all gtus... | 190 |
| look beyond splitting lane | 201 |
| this is a hack, what if the reference position is not the middle? | 231 |
| org.opentrafficsim.road.gtu.generator.ListGTUGenerator | Line |
| use given position in the constructor? | 169 |
| use given directionality in the constructor? | 172 |
| org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU | Line |
| should be indicated with a Parameter | 107 |
| can be removed after testing period | 111 |
| can be removed after testing period | 115 |
| The above enterLane creates an event with speed = 0.0, while the below init creates a move event with speed at the same time. | 165 |
| The above enterLane creates link/lane messages for GTU's that other software might not be aware of, as no new/init message it given at that point. Problem: init event needs a referenceLane which is determined if the GTU is on the network, i.e. after the enterLane. | 167 |
| widest lane in case we are registered on more than one lane with the reference point | 647 |
| lane that leads to our location or not if we are registered on parallel lanes? | 648 |
| extra argument for DIR_MINUS driving direction? | 684 |
| PK: this goes very wrong for networks with short lanes with alternating GTUDireationality | 699 |
| extra argument for DIR_MINUS driving direction? | 723 |
| this does not account for the GTUDirectionality next lane | 732 |
| do this at the right time, scheduled with triggers. 4x | 755 |
| extra argument for DIR_MINUS driving direction? | 767 |
| look if more lanes are exited in one timestep, and continue the algorithm with the remainder of the time... | 789 |
| XXXXXXXXXXXXXXX Minus one ULP is not safe if you want to add the current time | 804 |
| XXXXXXXXXXXXXXX Should compute the time time at which the rear of the GTU exits the lane??? getSimulator().scheduleEventRel(new Duration(timestep - Math.ulp(timestep), TimeUnit.SI), this, this, "leaveLane", new Object[] { lane, new Boolean(true) }); // TODO should be false? | 805 |
| should be false? | 807 |
| should be false? | 822 |
| direction dependent... <br> | 829 |
| Hack - this should be done more considerate -- fails at loops... | 866 |
| direction dependent... <br> | 890 |
| Hack - this should be done more considerate -- fails at loops... | 927 |
| org.opentrafficsim.road.gtu.lane.LaneBasedIndividualGTU | Line |
| Should throw a more specific Exception type | 505 |
| org.opentrafficsim.road.gtu.lane.changing.LaneChangeModelTest | Line |
| create a LinkAnimation if the simulator is compatible with that. | 100 |
| The current LinkAnimation is too bad to use... Mock the simulator. Alternatively, provide the simulator from the constructModel. | 101 |
| Decide what type of overtaking conditions we want in this test | 134 |
| test/prove the expected differences between Egoistic and Altruistic | 310 |
| prove that the most restrictive car in the other lane determines what happens | 311 |
| test merge into overtaking lane | 312 |
| org.opentrafficsim.road.gtu.lane.perception.AbstractLanePerception | Line |
| possibly optimize by using a 'singleton' lane structure source, per GTUType | 118 |
| possibly build and destroy at edges only | 119 |
| org.opentrafficsim.road.gtu.lane.perception.categories.AbstractDelayedNeighborsPerception | Line |
| The reaction time may differ between observed objects and vary over time | 104 |
| private when DSOL allows | 231 |
| org.opentrafficsim.road.gtu.lane.perception.categories.DefaultSimplePerception | Line |
| In other places in OTS LEFT is positive (and RIGHT is negative). This should be made more consistent. | 254 |
| org.opentrafficsim.road.gtu.lane.perception.categories.DirectDefaultSimplePerception | Line |
| end of lanepath | 628 |
| allow observation of other objects as well. | 833 |
| --No comment-- | 929 |
| calculate real overlaps | 945 |
| expand for other types of Headways result.add(new HeadwayGTUSimple(p.getId(), ((AbstractHeadwayGTU) p).getGtuType(), new Length(Double.NaN, LengthUnit.SI), p.getLength(), p.getSpeed(), p.getAcceleration())); | 1003 |
| org.opentrafficsim.road.gtu.lane.perception.categories.DirectInfrastructurePerception | Line |
| implement this method, current implementation is a simple fix | 274 |
| merge | 309 |
| splits | 339 |
| splits | 349 |
| implement this method, lane map needs support for this (and legal lane changes) | 358 |
| org.opentrafficsim.road.gtu.lane.perception.categories.DirectIntersectionPerception | Line |
| get from link combination (needs to be a map property on the links) | 150 |
| stop lines (current models happen not to use this, but should be possible) | 162 |
| also other HeadwayGTU type (i.e. not real) | 228 |
| GTU status (blinkers) | 229 |
| also other HeadwayGTU type (i.e. not real) | 270 |
| GTU status (blinkers) | 271 |
| use set of gtu types that may be conflicting | 434 |
| use set of gtu types that may be conflicting | 459 |
| org.opentrafficsim.road.gtu.lane.perception.categories.DirectNeighborsPerception | Line |
| remove this line | 92 |
| remove this fix to ignore on-ramp block | 374 |
| break search, but how to guarantee that the rear of further GTU's is not within lookahead? | 386 |
| break search, but how to guarantee that the front of further GTU's is not within lookback? | 450 |
| not use this check when synchronizing or cooperating | 602 |
| remove code below | 620 |
| org.opentrafficsim.road.gtu.lane.perception.categories.HeadwayGtuType | Line |
| more GTU statuses | 48 |
| org.opentrafficsim.road.gtu.lane.perception.headway.HeadwayGTUReal | Line |
| this is a simple fix | 96 |
| --No comment-- | 245 |
| --No comment-- | 274 |
| org.opentrafficsim.road.gtu.lane.perception.headway.HeadwayGTURealCopy | Line |
| this is a simple fix | 127 |
| org.opentrafficsim.road.gtu.lane.perception.headway.HeadwayGTUType | Line |
| create SpeedLimitInfo on the basis of this.gtuTypeAssumptions.getLaneTypeMaxSpeed(...) | 143 |
| org.opentrafficsim.road.gtu.lane.plan.operational.LaneOperationalPlanBuilder | Line |
| driving with negative speeds (backward driving) is not yet supported. <p> Copyright (c) 2013-2017 Delft University of Technology, PO Box 5, 2600 AA, Delft, the Netherlands. All rights reserved. <br> BSD-style license. See <a href="http://opentrafficsim.org/docs/license.html">OpenTrafficSim License</a>. </p> $LastChangedDate: 2015-07-24 02:58:59 +0200 (Fri, 24 Jul 2015) $, @version $Revision: 1147 $, by $Author: averbraeck $, initial version Nov 15, 2015 <br> | 41 |
| also for other driving directions, additional arguments in projectFractional? | 383 |
| remove GTU argument (only needed for instantaneous lane change hack) | 571 |
| this elsewhere based on path | 595 |
| org.opentrafficsim.road.gtu.lane.tactical.AbstractLaneBasedTacticalPlanner | Line |
| this is wrong, the other direction may not be allowed, i.e. is not accessible | 694 |
| org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner | Line |
| how to handle objects on this lane or another lane??? | 133 |
| these two info's are not used | 148 |
| skip if: - we are in the right lane and drive at max speed or we accelerate maximally - there are no other lanes | 153 |
| whether we drive on the right should be stored in some central place. | 161 |
| move laneIncentives to LanePerception? Figure out if the default lane incentives are OK, or override them with values that should keep this GTU on the intended route. | 237 |
| these comparisons to -10 is ridiculous. | 293 |
| move suitability to LanePerception? Return the suitability for the current lane, left adjacent lane or right adjacent lane. | 383 |
| --No comment-- | 606 |
| this method should probably be moved into the CrossSectionLink class | 663 |
| org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingDirectedChangeTacticalPlanner | Line |
| should it be getObjectType().isGtu() or !getObjectType().isDistanceOnly() ? | 282 |
| Object & GTU | 283 |
| should it be getObjectType().isGtu() or !getObjectType().isDistanceOnly() ? | 329 |
| GTU & Object | 330 |
| remove this hack | 497 |
| should it be getObjectType().isGtu() or !getObjectType().isDistanceOnly() ? | 544 |
| Object & GTU | 545 |
| make type of plan (Egoistic, Altruistic) parameter of the class | 556 |
| make the elasticities 2.0 and 0.1 parameters of the class | 558 |
| org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingTacticalPlanner | Line |
| I really don't like this -- if there is a lane drop at 20 m, the GTU should stop... | 86 |
| org.opentrafficsim.road.gtu.lane.tactical.following.AbstractGTUFollowingModelMobil | Line |
| Under which circumstances can getDistance() be NULL? Should that indeed result in TOODANGEROUS? | 62 |
| org.opentrafficsim.road.gtu.lane.tactical.following.FixedAccelerationModel | Line |
| should be specified in constructor | 88 |
| org.opentrafficsim.road.gtu.lane.tactical.following.IDMOld | Line |
| maxDistance dV is the approach speed | 112 |
| org.opentrafficsim.road.gtu.lane.tactical.following.IDMPlusMulti | Line |
| add vehicle length corresponding to key 'headway' | 58 |
| org.opentrafficsim.road.gtu.lane.tactical.following.IDMPlusOld | Line |
| maxDistance | 118 |
| org.opentrafficsim.road.gtu.lane.tactical.following.SequentialFixedAccelerationModel | Line |
| incorporate stepSize | 155 |
| org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.AbstractLaneChangeModel | Line |
| make this driving side dependent; i.e. implement a general way to figure out on which side of the road cars are supposed to drive | 59 |
| org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.LaneChangeModel | Line |
| Lane change models should use the perceived nearby GTUs rather than a provided list of same lane traffic, etc. <p> Copyright (c) 2013-2017 Delft University of Technology, PO Box 5, 2600 AA, Delft, the Netherlands. All rights reserved. <br> BSD-style license. See <a href="http://opentrafficsim.org/docs/license.html">OpenTrafficSim License</a>. <p> | 15 |
| org.opentrafficsim.road.gtu.lane.tactical.lmrs.AccelerationBusStop | Line |
| this is much more complex: tail blocking other traffic? other bus in front? many people at bus stop? | 40 |
| org.opentrafficsim.road.gtu.lane.tactical.lmrs.IncentiveHierarchal | Line |
| keep left or right rules | 34 |
| org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS | Line |
| make this automatic within the perception itself, e.g. by a lane change event from the tactical planner | 174 |
| org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo | Line |
| vehicle not ahead and not backwards but completely adjacent | 116 |
| infinite -> some limited space, speed also one leader | 347 |
| definition of 'right most lane' does not account for ramps and weaving sections | 655 |
| org.opentrafficsim.road.gtu.lane.tactical.toledo.ToledoCarFollowing | Line |
| speed difference with reaction time | 138 |
| org.opentrafficsim.road.gtu.lane.tactical.toledo.ToledoPerception | Line |
| updateInfrastructureLaneChangeInfo with split number | 33 |
| org.opentrafficsim.road.gtu.lane.tactical.util.ConflictUtil | Line |
| do not ignore vehicles upstream of conflict if they have green | 61 |
| conflict over multiple lanes (longitudinal in own direction) | 62 |
| a) yielding while having priority happens only when leaders is standing still on conflict (then its useless...) b) two vehicles can remain upstream of merge if vehicle stands on merge but leaves some space to move probably 1 is yielding, and 1 is courtesy yielding as the other stands still c) they might start moving together and collide further down (no response to negative headway on merge) | 63 |
| depending on left/right-hand traffic | 172 |
| --No comment-- | 236 |
| what to do when we happen to be in the stopping distance? Stopping might be reasonable, while car-following might give strong deceleration due to s < s0. | 246 |
| what about long conflicts where we need to follow the second conflicting downstream vehicle? conflict GTU downstream of start of conflict, but upstream of us | 325 |
| only within visibility | 371 |
| safety factor? | 421 |
| conflicting vehicle on crossing conflict, but will leave sooner then we enter, so no problem? | 516 |
| more generally, also upstream conflicting vehicles at crossings may leave the conflict before we enter | 517 |
| all-stop behavior | 707 |
| org.opentrafficsim.road.gtu.lane.tactical.util.lmrs.LmrsUtil | Line |
| this is a hack to prevent right lane changes of all vehicles on the left lane when placed in network at t=0 | 85 |
| --No comment-- | 461 |
| org.opentrafficsim.road.gtu.lane.tactical.util.lmrs.Synchronization | Line |
| replace this hack with something that properly accounts for overshoot | 78 |
| org.opentrafficsim.road.gtu.perception.VerifyPerceptionCategoryMethods | Line |
| fail... | 215 |
| fail... | 221 |
| org.opentrafficsim.road.gtu.strategical.LaneBasedStrategicalRoutePlannerTest | Line |
| Gtu cannot be null anymore... LaneBasedStrategicalRoutePlanner lbsrp = new LaneBasedStrategicalRoutePlanner(bc, tacticalPlanner, null); | 68 |
| org.opentrafficsim.road.gtu.strategical.od.ODMatrix | Line |
| remove this method as soon as there is a JUNIT test | 487 |
| org.opentrafficsim.road.gtu.strategical.od.ODMatrixTrips | Line |
| pce (i.e. passenger car equivalent) instead of veh's | 27 |
| org.opentrafficsim.road.network.LinkLocationTest | Line |
| distance to location on another link (not yet possible; currently ALWAYS returns null) | 81 |
| org.opentrafficsim.road.network.animation.ConflictAnimation | Line |
| should ConflictAnimation implement the ClonableRenderable2DInterface? | 32 |
| org.opentrafficsim.road.network.animation.StripeAnimation | Line |
| startOffset does not work if a dash falls inside of it (so below the offset is 2.99m, rather than 3m) | 63 |
| org.opentrafficsim.road.network.lane.CrossSectionElement | Line |
| use throwIf | 135 |
| org.opentrafficsim.road.network.lane.CrossSectionLink | Line |
| per GTUDirectionality / LongitudinalDirectionality? | 50 |
| work in a different way with lane numbers to align to standard lane numbering. | 56 |
| allow for the removal of a Lane; currently this is not possible. | 63 |
| org.opentrafficsim.road.network.lane.CurveTest | Line |
| finish writing this test | 110 |
| org.opentrafficsim.road.network.lane.Lane | Line |
| allow for direction-dependent speed limit | 106 |
| allow for direction-dependent sensors | 113 |
| allow for direction-dependent lane objects | 120 |
| allow for direction-dependent overtaking conditions | 165 |
| constructor calls with this(...) | 411 |
| take the cross section slices into account... | 490 |
| take the cross section slices into account... | 504 |
| take the cross section slices into account... | 527 |
| take the cross section slices into account... | 541 |
| make sure triggering is done right when driving in DIR_MINUS direction | 758 |
| only center position? Or also width? What is a good cutoff? Base on average width of the GTU type that can drive on this Lane? E.g., for a Tram or Train, a 5 cm deviation is a problem; for a Car or a Bicycle, more deviation is acceptable. | 1198 |
| And is it aligned with its next lane? | 1244 |
| And is it aligned with its next lane? | 1258 |
| And is it aligned with its next lane? | 1316 |
| And is it aligned with its next lane? | 1330 |
| org.opentrafficsim.road.network.lane.LaneTest | Line |
| what overtaking conditions do we ant to test in this unit test? | 93 |
| what overtaking conditions do we ant to test in this unit test? | 144 |
| what overtaking conditions do we ant to test in this unit test? | 159 |
| what overtaking conditions do we want to test in this unit test? | 223 |
| org.opentrafficsim.road.network.lane.SensorTest | Line |
| this is not true anymore with OperationalPlans, Perception, etc => | 145 |
| the number of events that should be scheduled can vary per models chosen | 146 |
| assertEquals("There should be three scheduled events (trigger, leaveLane, | 147 |
| car.move, terminate)", 4, eventList.size()); The sensor should be triggered around t=38.3403 (exact value: 10 / 9 * (sqrt(3541) - 25)) System.out.println("trigger event is " + triggerEvent); / TODO not triggered in next half second. | 148 |
| assertEquals("Trigger event should be around 38.3403", 38.3403, | 152 |
| triggerEvent.getAbsoluteExecutionTime().get().getSI(), 0.0001); | 153 |
| check that the sensor is triggered at the right time. | 181 |
| org.opentrafficsim.road.network.lane.conflict.ConflictBuilder | Line |
| use z-coordinate for intersections of lines | 38 |
| quick bounding box check of both lanes, skip if not overlapping | 270 |
| org.opentrafficsim.road.network.lane.object.sensor.DirectionalOccupancySensor | Line |
| enforce clone method | 61 |
| org.opentrafficsim.road.network.lane.object.sensor.NonDirectionalOccupancySensor | Line |
| enforce clone method | 64 |
| org.opentrafficsim.road.network.lane.object.sensor.TrafficLightSensor | Line |
| Possibly provide the GTUTypes that trigger the sensor as an argument for the constructor | 89 |
| not handling backwards driving GTU | 325 |
| should the parent of the clone be our parent??? And should the (cloned) parent not construct its own flank sensors? | 606 |
| org.opentrafficsim.road.network.lane.object.sensor.TrafficLightSensorTest | Line |
| @Test | 198 |
| THIS TEST FAILS!! assertEquals("event list should contain one event (due to creation of the GTU on the detector)", 1, this.loggedEvents.size()); | 281 |
| org.opentrafficsim.road.network.sampling.RoadSampler | Line |
| GTUDirectionality from Lane.GTU_ADD_EVENT | 221 |
| Length from Lane.GTU_ADD_EVENT | 233 |
| GTUDirectionality from Lane.GTU_ADD_EVENT | 262 |
| org.opentrafficsim.road.network.speed.package-info | Line |
| --No comment-- | 21 |