Checkstyle Results

The following document contains the results of Checkstyle 6.1.1 with development/dsol-checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
147 26 128 0

Files

File  I  W  E
org/opentrafficsim/graphs/ContourPlot.java 1 0 0
org/opentrafficsim/graphs/FundamentalDiagram.java 1 0 0
org/opentrafficsim/graphs/FundamentalDiagramLane.java 1 1 0
org/opentrafficsim/road/gtu/animation/LaneChangeUrgeGTUColorer.java 0 8 0
org/opentrafficsim/road/gtu/following/IDM.java 1 0 0
org/opentrafficsim/road/gtu/generator/AbstractGTUGenerator.java 0 1 0
org/opentrafficsim/road/gtu/generator/ListGTUGenerator.java 1 0 0
org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU.java 9 12 0
org/opentrafficsim/road/gtu/lane/AbstractTrafficLight.java 0 49 0
org/opentrafficsim/road/gtu/lane/LaneBlock.java 0 46 0
org/opentrafficsim/road/gtu/lane/LaneBlockOnOff.java 0 4 0
org/opentrafficsim/road/network/animation/package-info.java 1 0 0
org/opentrafficsim/road/network/factory/osm/OSMNode.java 0 2 0
org/opentrafficsim/road/network/factory/osm/events/package-info.java 1 0 0
org/opentrafficsim/road/network/factory/osm/input/package-info.java 1 0 0
org/opentrafficsim/road/network/factory/osm/output/Convert.java 1 1 0
org/opentrafficsim/road/network/factory/osm/output/package-info.java 1 0 0
org/opentrafficsim/road/network/factory/osm/package-info.java 1 0 0
org/opentrafficsim/road/network/factory/package-info.java 1 0 0
org/opentrafficsim/road/network/factory/xml/Links.java 0 1 0
org/opentrafficsim/road/network/factory/xml/units/LaneAttributes.java 1 0 0
org/opentrafficsim/road/network/lane/CrossSectionElement.java 1 0 0
org/opentrafficsim/road/network/lane/Lane.java 1 0 0
org/opentrafficsim/road/network/lane/SinkSensor.java 0 2 0
org/opentrafficsim/road/network/route/AbstractLaneBasedRouteNavigator.java 0 1 0
org/opentrafficsim/road/network/route/CompleteLaneBasedRouteNavigator.java 1 0 0
org/opentrafficsim/road/network/route/package-info.java 1 0 0

Rules

Category Rule Violations Severity
blocks AvoidNestedBlocks
  • allowInSwitchCase: "true"
 3  Warning
EmptyBlock 2  Warning
coding HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
 18  Warning
design DesignForExtension 35  Warning
VisibilityModifier 7  Warning
javadoc JavadocMethod 4  Warning
JavadocPackage 1  Info
JavadocStyle 1  Warning
JavadocVariable 1  Warning
misc FinalParameters 45  Warning
TodoComment 3  Warning
naming StaticVariableName 1  Warning
sizes LineLength
  • max: "128"
 20  Info
MethodLength 3  Info
ParameterNumber 2  Info
whitespace NoWhitespaceAfter 7  Warning
WhitespaceAround
  • tokens: "ASSIGN, BAND, BAND_ASSIGN, BOR, BOR_ASSIGN, BSR, BSR_ASSIGN, BXOR, BXOR_ASSIGN, COLON, DIV, DIV_ASSIGN, EQUAL, GE, GT, LAND, LE, LITERAL_ASSERT, LITERAL_CATCH, LITERAL_DO, LITERAL_ELSE, LITERAL_FINALLY, LITERAL_FOR, LITERAL_IF, LITERAL_RETURN, LITERAL_SYNCHRONIZED, LITERAL_TRY, LITERAL_WHILE, LOR, LT, MINUS, MINUS_ASSIGN, MOD, MOD_ASSIGN, NOT_EQUAL, PLUS, PLUS_ASSIGN, QUESTION, SL, SLIST, SL_ASSIGN, SR, SR_ASSIGN, STAR, STAR_ASSIGN, TYPE_EXTENSION_AND"
 1  Warning

Details

org/opentrafficsim/graphs/ContourPlot.java

Severity Category Rule Message Line
 Info sizes ParameterNumber More than 7 parameters (found 9). 117

org/opentrafficsim/graphs/FundamentalDiagram.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 131). 574

org/opentrafficsim/graphs/FundamentalDiagramLane.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'flow' must be private and have accessor methods. 131
 Info sizes LineLength Line is longer than 128 characters (found 134). 487

org/opentrafficsim/road/gtu/animation/LaneChangeUrgeGTUColorer.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'getColor' is not designed for extension - needs to be abstract, final or empty. 65
 Warning misc FinalParameters Parameter gtu should be final. 66
 Warning design DesignForExtension Method 'getLegend' is not designed for extension - needs to be abstract, final or empty. 91
 Warning javadoc JavadocMethod Missing a Javadoc comment. 97
 Warning design VisibilityModifier Variable 'distance' must be private and have accessor methods. 106
 Warning javadoc JavadocStyle First sentence should end with a period. 108
 Warning design VisibilityModifier Variable 'left' must be private and have accessor methods. 112
 Warning javadoc JavadocMethod Missing a Javadoc comment. 145

org/opentrafficsim/road/gtu/following/IDM.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 129). 64

org/opentrafficsim/road/gtu/generator/AbstractGTUGenerator.java

Severity Category Rule Message Line
 Warning blocks AvoidNestedBlocks Avoid nested blocks. 323

org/opentrafficsim/road/gtu/generator/ListGTUGenerator.java

Severity Category Rule Message Line
 Info sizes ParameterNumber More than 7 parameters (found 11). 94

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU.java

Severity Category Rule Message Line
 Info sizes MethodLength Method length is 156 lines (max allowed is 150). 337
 Warning whitespace NoWhitespaceAfter '{' is followed by whitespace. 398
 Info sizes LineLength Line is longer than 128 characters (found 155). 521
 Info sizes LineLength Line is longer than 128 characters (found 165). 523
 Warning whitespace NoWhitespaceAfter '{' is followed by whitespace. 529
 Warning whitespace NoWhitespaceAfter '{' is followed by whitespace. 532
 Warning whitespace NoWhitespaceAfter '{' is followed by whitespace. 563
 Warning whitespace NoWhitespaceAfter '{' is followed by whitespace. 568
 Warning whitespace NoWhitespaceAfter '{' is followed by whitespace. 578
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 626
 Info sizes LineLength Line is longer than 128 characters (found 137). 763
 Info sizes LineLength Line is longer than 128 characters (found 139). 764
 Info sizes LineLength Line is longer than 128 characters (found 135). 765
 Info sizes LineLength Line is longer than 128 characters (found 138). 766
 Info sizes LineLength Line is longer than 128 characters (found 135). 767
 Info sizes LineLength Line is longer than 128 characters (found 144). 768
 Warning whitespace NoWhitespaceAfter '{' is followed by whitespace. 787
 Warning blocks AvoidNestedBlocks Avoid nested blocks. 1041
 Warning blocks AvoidNestedBlocks Avoid nested blocks. 1217
 Warning design DesignForExtension Method 'getLaneChangeDistanceAndDirection' is not designed for extension - needs to be abstract, final or empty. 1545
 Warning javadoc JavadocMethod Missing a Javadoc comment. 1545

org/opentrafficsim/road/gtu/lane/AbstractTrafficLight.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'lane' must be private and have accessor methods. 58
 Warning design VisibilityModifier Variable 'position' must be private and have accessor methods. 61
 Warning naming StaticVariableName Name 'TIME_ABS_0' must match pattern '^[a-z][a-zA-Z0-9]*$'. 76
 Warning javadoc JavadocVariable Missing a Javadoc comment. 116
 Warning coding HiddenField 'lane' hides a field. 342
 Warning coding HiddenField 'position' hides a field. 342
 Warning coding HiddenField 'lane' hides a field. 349
 Warning coding HiddenField 'lane' hides a field. 373
 Warning coding HiddenField 'lane' hides a field. 384
 Warning design DesignForExtension Method 'fractionalPositions' is not designed for extension - needs to be abstract, final or empty. 400
 Warning misc FinalParameters Parameter relativePosition should be final. 401
 Warning misc FinalParameters Parameter when should be final. 401
 Warning design DesignForExtension Method 'fractionalPosition' is not designed for extension - needs to be abstract, final or empty. 410
 Warning misc FinalParameters Parameter lane should be final. 411
 Warning coding HiddenField 'lane' hides a field. 411
 Warning misc FinalParameters Parameter relativePosition should be final. 411
 Warning misc FinalParameters Parameter when should be final. 411
 Warning design DesignForExtension Method 'fractionalPosition' is not designed for extension - needs to be abstract, final or empty. 418
 Warning misc FinalParameters Parameter lane should be final. 419
 Warning coding HiddenField 'lane' hides a field. 419
 Warning misc FinalParameters Parameter relativePosition should be final. 419
 Warning design DesignForExtension Method 'projectedPosition' is not designed for extension - needs to be abstract, final or empty. 425
 Warning misc FinalParameters Parameter projectionLane should be final. 426
 Warning misc FinalParameters Parameter relativePosition should be final. 426
 Warning misc FinalParameters Parameter when should be final. 426
 Warning design DesignForExtension Method 'headway' is not designed for extension - needs to be abstract, final or empty. 433
 Warning misc FinalParameters Parameter maxDistance should be final. 434
 Warning design DesignForExtension Method 'headway' is not designed for extension - needs to be abstract, final or empty. 440
 Warning misc FinalParameters Parameter lane should be final. 441
 Warning coding HiddenField 'lane' hides a field. 441
 Warning misc FinalParameters Parameter maxDistance should be final. 441
 Warning design DesignForExtension Method 'parallel' is not designed for extension - needs to be abstract, final or empty. 447
 Warning misc FinalParameters Parameter lane should be final. 448
 Warning coding HiddenField 'lane' hides a field. 448
 Warning misc FinalParameters Parameter when should be final. 448
 Warning design DesignForExtension Method 'parallel' is not designed for extension - needs to be abstract, final or empty. 454
 Warning misc FinalParameters Parameter lateralDirection should be final. 455
 Warning misc FinalParameters Parameter when should be final. 455
 Warning design DesignForExtension Method 'bestAccessibleAdjacentLane' is not designed for extension - needs to be abstract, final or empty. 461
 Warning misc FinalParameters Parameter currentLane should be final. 462
 Warning misc FinalParameters Parameter lateralDirection should be final. 462
 Warning misc FinalParameters Parameter longitudinalPosition should be final. 463
 Warning design DesignForExtension Method 'timeAtDistance' is not designed for extension - needs to be abstract, final or empty. 469
 Warning misc FinalParameters Parameter distance should be final. 470
 Warning design DesignForExtension Method 'deltaTimeForDistance' is not designed for extension - needs to be abstract, final or empty. 476
 Warning misc FinalParameters Parameter distance should be final. 477
 Warning design DesignForExtension Method 'getGTUFollowingModel' is not designed for extension - needs to be abstract, final or empty. 483
 Warning design DesignForExtension Method 'getLaneChangeDistanceAndDirection' is not designed for extension - needs to be abstract, final or empty. 490
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 497

org/opentrafficsim/road/gtu/lane/LaneBlock.java

Severity Category Rule Message Line
 Warning blocks EmptyBlock Must have at least one statement. 126
 Warning coding HiddenField 'lane' hides a field. 298
 Warning coding HiddenField 'position' hides a field. 298
 Warning coding HiddenField 'lane' hides a field. 305
 Warning coding HiddenField 'lane' hides a field. 329
 Warning coding HiddenField 'lane' hides a field. 340
 Warning design DesignForExtension Method 'fractionalPositions' is not designed for extension - needs to be abstract, final or empty. 356
 Warning misc FinalParameters Parameter relativePosition should be final. 357
 Warning misc FinalParameters Parameter when should be final. 357
 Warning design DesignForExtension Method 'fractionalPosition' is not designed for extension - needs to be abstract, final or empty. 366
 Warning misc FinalParameters Parameter lane should be final. 367
 Warning coding HiddenField 'lane' hides a field. 367
 Warning misc FinalParameters Parameter relativePosition should be final. 367
 Warning misc FinalParameters Parameter when should be final. 367
 Warning design DesignForExtension Method 'fractionalPosition' is not designed for extension - needs to be abstract, final or empty. 374
 Warning misc FinalParameters Parameter lane should be final. 375
 Warning coding HiddenField 'lane' hides a field. 375
 Warning misc FinalParameters Parameter relativePosition should be final. 375
 Warning design DesignForExtension Method 'projectedPosition' is not designed for extension - needs to be abstract, final or empty. 381
 Warning misc FinalParameters Parameter projectionLane should be final. 382
 Warning misc FinalParameters Parameter relativePosition should be final. 382
 Warning misc FinalParameters Parameter when should be final. 382
 Warning design DesignForExtension Method 'headway' is not designed for extension - needs to be abstract, final or empty. 389
 Warning misc FinalParameters Parameter maxDistance should be final. 390
 Warning design DesignForExtension Method 'headway' is not designed for extension - needs to be abstract, final or empty. 396
 Warning misc FinalParameters Parameter lane should be final. 397
 Warning coding HiddenField 'lane' hides a field. 397
 Warning misc FinalParameters Parameter maxDistance should be final. 397
 Warning design DesignForExtension Method 'parallel' is not designed for extension - needs to be abstract, final or empty. 403
 Warning misc FinalParameters Parameter lane should be final. 404
 Warning coding HiddenField 'lane' hides a field. 404
 Warning misc FinalParameters Parameter when should be final. 404
 Warning design DesignForExtension Method 'parallel' is not designed for extension - needs to be abstract, final or empty. 410
 Warning misc FinalParameters Parameter lateralDirection should be final. 411
 Warning misc FinalParameters Parameter when should be final. 411
 Warning design DesignForExtension Method 'bestAccessibleAdjacentLane' is not designed for extension - needs to be abstract, final or empty. 417
 Warning misc FinalParameters Parameter currentLane should be final. 418
 Warning misc FinalParameters Parameter lateralDirection should be final. 418
 Warning misc FinalParameters Parameter longitudinalPosition should be final. 419
 Warning design DesignForExtension Method 'timeAtDistance' is not designed for extension - needs to be abstract, final or empty. 425
 Warning misc FinalParameters Parameter distance should be final. 426
 Warning design DesignForExtension Method 'deltaTimeForDistance' is not designed for extension - needs to be abstract, final or empty. 432
 Warning misc FinalParameters Parameter distance should be final. 433
 Warning design DesignForExtension Method 'getGTUFollowingModel' is not designed for extension - needs to be abstract, final or empty. 439
 Warning design DesignForExtension Method 'getLaneChangeDistanceAndDirection' is not designed for extension - needs to be abstract, final or empty. 446
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 453

org/opentrafficsim/road/gtu/lane/LaneBlockOnOff.java

Severity Category Rule Message Line
 Warning blocks EmptyBlock Must have at least one statement. 51
 Warning design DesignForExtension Method 'changeColorTime' is not designed for extension - needs to be abstract, final or empty. 62
 Warning javadoc JavadocMethod Missing a Javadoc comment. 62
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 77

org/opentrafficsim/road/network/animation/package-info.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 156). 7

org/opentrafficsim/road/network/factory/osm/OSMNode.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'linksOriginating' must be private and have accessor methods. 45
 Warning design VisibilityModifier Variable 'linksTerminating' must be private and have accessor methods. 48

org/opentrafficsim/road/network/factory/osm/events/package-info.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 155). 7

org/opentrafficsim/road/network/factory/osm/input/package-info.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 155). 7

org/opentrafficsim/road/network/factory/osm/output/Convert.java

Severity Category Rule Message Line
 Info sizes MethodLength Method length is 236 lines (max allowed is 150). 206
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 710

org/opentrafficsim/road/network/factory/osm/output/package-info.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 155). 7

org/opentrafficsim/road/network/factory/osm/package-info.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 156). 7

org/opentrafficsim/road/network/factory/package-info.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 156). 7

org/opentrafficsim/road/network/factory/xml/Links.java

Severity Category Rule Message Line
 Warning whitespace WhitespaceAround '!=' is not preceded with whitespace. 508

org/opentrafficsim/road/network/factory/xml/units/LaneAttributes.java

Severity Category Rule Message Line
 Info javadoc JavadocPackage Missing package-info.java file.

org/opentrafficsim/road/network/lane/CrossSectionElement.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 130). 285

org/opentrafficsim/road/network/lane/Lane.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 131). 958

org/opentrafficsim/road/network/lane/SinkSensor.java

Severity Category Rule Message Line
 Warning design DesignForExtension Method 'trigger' is not designed for extension - needs to be abstract, final or empty. 47
 Warning design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 54

org/opentrafficsim/road/network/route/AbstractLaneBasedRouteNavigator.java

Severity Category Rule Message Line
 Warning misc TodoComment Comment matches to-do format 'TODO:'. 82

org/opentrafficsim/road/network/route/CompleteLaneBasedRouteNavigator.java

Severity Category Rule Message Line
 Info sizes MethodLength Method length is 187 lines (max allowed is 150). 87

org/opentrafficsim/road/network/route/package-info.java

Severity Category Rule Message Line
 Info sizes LineLength Line is longer than 128 characters (found 156). 7