PMD Results

The following document contains the results of PMD 5.1.2.

Files

org/opentrafficsim/graphs/FundamentalDiagram.java

Violation Line
Avoid unused private methods such as 'configureAxis(ValueAxis,Axis)'. 286

org/opentrafficsim/graphs/FundamentalDiagramLane.java

Violation Line
Avoid unused private methods such as 'configureAxis(ValueAxis,Axis)'. 283

org/opentrafficsim/road/gtu/generator/AbstractGTUGenerator.java

Violation Line
Useless parentheses. 241
Useless parentheses. 241
Useless parentheses. 242
Useless parentheses. 242
Avoid unused private methods such as 'headwayRecursiveForwardSI(Lane,double,double,double,Time.Abs,LaneBasedRouteNavigator)'. 294–296
These nested if statements could be combined 314–336

org/opentrafficsim/road/gtu/generator/ListGTUGenerator.java

Violation Line
Avoid unused private fields such as 'name'. 43
Avoid unused constructor parameters such as 'position'. 96

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU.java

Violation Line
Useless parentheses. 754
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 787
Avoid unused private methods such as 'headwayRecursiveForwardSI(Lane,double,double,double,Time.Abs)'. 1014–1015
These nested if statements could be combined 1032–1052
Avoid unused private methods such as 'headwayRecursiveBackwardSI(Lane,double,double,double,Time.Abs)'. 1074–1075
These nested if statements could be combined 1092–1109
Avoid unused private methods such as 'headwayRecursiveForwardSI(Lane,double,LaneBasedGTU,double,double,Time.Abs)'. 1195–1196
Avoid unused private methods such as 'headwayRecursiveBackwardSI(Lane,double,LaneBasedGTU,double,double,Time.Abs)'. 1247–1248

org/opentrafficsim/road/gtu/lane/AbstractTrafficLight.java

Violation Line
Avoid unused private fields such as 'animation'. 55

org/opentrafficsim/road/gtu/lane/LaneBlock.java

Violation Line
Avoid unused private fields such as 'animation'. 55
Avoid empty if statements 126–128

org/opentrafficsim/road/gtu/lane/LaneBlockOnOff.java

Violation Line
Avoid empty if statements 51–53

org/opentrafficsim/road/network/animation/StripeAnimation.java

Violation Line
Avoid unused private methods such as 'makeDashes(LengthIndexedLine,double,double,double)'. 58–59

org/opentrafficsim/road/network/factory/XMLParser.java

Violation Line
These nested if statements could be combined 40–43

org/opentrafficsim/road/network/factory/osm/output/Convert.java

Violation Line
Avoid unused private methods such as 'calculateOffsets(SortedMap,OSMLink,Integer,Integer,WarningListener)'. 453–454

org/opentrafficsim/road/network/factory/xml/ArcTag.java

Violation Line
Useless parentheses. 82

org/opentrafficsim/road/network/factory/xml/FillTag.java

Violation Line
Avoid unused local variables such as 'lane'. 209
Avoid unused local variables such as 'gtuClass'. 210
Avoid unused local variables such as 'rg'. 216

org/opentrafficsim/road/network/factory/xml/Links.java

Violation Line
Useless parentheses. 335
Avoid unused local variables such as 'trafficLight'. 562
These nested if statements could be combined 635–636
These nested if statements could be combined 659–660

org/opentrafficsim/road/network/lane/Lane.java

Violation Line
Useless parentheses. 243
Useless parentheses. 244
Useless parentheses. 245
Useless parentheses. 246
Useless parentheses. 254
Useless parentheses. 256
These nested if statements could be combined 259–263
Useless parentheses. 276
Useless parentheses. 277
Useless parentheses. 278
Useless parentheses. 279
Useless parentheses. 287
Useless parentheses. 289
These nested if statements could be combined 292–296
Useless parentheses. 403

org/opentrafficsim/road/network/lane/changing/OvertakingConditions.java

Violation Line
Avoid modifiers which are implied by the context 65–74
Avoid modifiers which are implied by the context 88–97
Avoid modifiers which are implied by the context 109–118
Avoid modifiers which are implied by the context 130–139
Avoid modifiers which are implied by the context 151–172
Avoid modifiers which are implied by the context 184–205
Avoid modifiers which are implied by the context 222–258
Useless parentheses. 250–252
Avoid modifiers which are implied by the context 275–311
Useless parentheses. 303–305
Avoid modifiers which are implied by the context 328–374
Useless parentheses. 364–366
Useless parentheses. 364–366
Avoid modifiers which are implied by the context 391–437
Useless parentheses. 427–429
Useless parentheses. 427–429