FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
310 239 0 0

Files

Class Bugs
org.opentrafficsim.graphs.ContourPlot 2
org.opentrafficsim.graphs.FundamentalDiagram 7
org.opentrafficsim.graphs.FundamentalDiagramLane 7
org.opentrafficsim.graphs.TrajectoryPlot 2
org.opentrafficsim.road.gtu.generator.AbstractGTUGenerator 1
org.opentrafficsim.road.gtu.generator.ListGTUGenerator 1
org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU 5
org.opentrafficsim.road.gtu.lane.CopyOfAbstractLaneBasedGTU 5
org.opentrafficsim.road.gtu.lane.LaneBasedIndividualGTU 1
org.opentrafficsim.road.gtu.lane.LaneBasedTemplateGTUType 1
org.opentrafficsim.road.gtu.lane.driver.LaneBasedBehavioralCharacteristics 2
org.opentrafficsim.road.gtu.lane.object.AbstractTrafficLight 1
org.opentrafficsim.road.gtu.lane.perception.AbstractLanePerception 1
org.opentrafficsim.road.gtu.lane.perception.LaneStructure 1
org.opentrafficsim.road.gtu.lane.plan.operational.LaneBasedOperationalPlan 1
org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner 6
org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingLaneChangeTacticalPlanner 1
org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingLaneChangeTacticalPlanner2 3
org.opentrafficsim.road.gtu.lane.tactical.LanePathInfo 1
org.opentrafficsim.road.gtu.lane.tactical.directedlanechange.AbstractDirectedLaneChangeModel 1
org.opentrafficsim.road.gtu.lane.tactical.following.AbstractGTUFollowingModelMobil 1
org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.AbstractLaneChangeModel 1
org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS 11
org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRSsync 4
org.opentrafficsim.road.network.factory.TestOpenDriveParserNASA$TestOpenDriveModel 7
org.opentrafficsim.road.network.factory.TestOpenDriveParserNoRTI$TestOpenDriveModel 9
org.opentrafficsim.road.network.factory.TestOpenDriveParserNoRTINew$TestOpenDriveModel 4
org.opentrafficsim.road.network.factory.TestOpenDriveParserSV$TestOpenDriveModel 7
org.opentrafficsim.road.network.factory.opendrive.ConnectionTag 5
org.opentrafficsim.road.network.factory.opendrive.Controller 1
org.opentrafficsim.road.network.factory.opendrive.ControllerTag 3
org.opentrafficsim.road.network.factory.opendrive.HeaderTag 11
org.opentrafficsim.road.network.factory.opendrive.HeightTag 4
org.opentrafficsim.road.network.factory.opendrive.JunctionTag 1
org.opentrafficsim.road.network.factory.opendrive.LaneSectionTag 2
org.opentrafficsim.road.network.factory.opendrive.LaneTag 3
org.opentrafficsim.road.network.factory.opendrive.LateralProfileTag 1
org.opentrafficsim.road.network.factory.opendrive.LinkTag 6
org.opentrafficsim.road.network.factory.opendrive.ObjectTag 14
org.opentrafficsim.road.network.factory.opendrive.ObjectsTag 1
org.opentrafficsim.road.network.factory.opendrive.OpenDriveNetworkLaneParser 2
org.opentrafficsim.road.network.factory.opendrive.OpenDriveNetworkWriter 2
org.opentrafficsim.road.network.factory.opendrive.PlanViewTag 5
org.opentrafficsim.road.network.factory.opendrive.RoadMarkTag 6
org.opentrafficsim.road.network.factory.opendrive.RoadTag 5
org.opentrafficsim.road.network.factory.opendrive.SignalReferenceTag 1
org.opentrafficsim.road.network.factory.opendrive.SignalTag 6
org.opentrafficsim.road.network.factory.opendrive.SpeedTag 1
org.opentrafficsim.road.network.factory.opendrive.SuperElevationTag 6
org.opentrafficsim.road.network.factory.opendrive.TypeTag 4
org.opentrafficsim.road.network.factory.opendrive.communicationRTI.communicationTest 2
org.opentrafficsim.road.network.factory.osm.events.ProgressEvent 1
org.opentrafficsim.road.network.factory.osm.output.Convert 2
org.opentrafficsim.road.network.factory.vissim.VissimANMNetworkLaneParser 2
org.opentrafficsim.road.network.factory.xml.FillTag 9
org.opentrafficsim.road.network.factory.xml.GTUTag 2
org.opentrafficsim.road.network.factory.xml.GeneratorTag 4
org.opentrafficsim.road.network.factory.xml.Links 3
org.opentrafficsim.road.network.factory.xml.ListGeneratorTag 4
org.opentrafficsim.road.network.factory.xml.ShortestRouteTag 5
org.opentrafficsim.road.network.factory.xml.XmlNetworkLaneParser 1
org.opentrafficsim.road.network.lane.CrossSectionLink 1
org.opentrafficsim.road.network.lane.Lane 3
org.opentrafficsim.road.network.lane.Lane$GTUTypeSensor 2
org.opentrafficsim.road.test.FourStop$TestXMLModel 2
org.opentrafficsim.road.test.LMRSTests$TestXMLModel 2
org.opentrafficsim.road.test.TestGMParser$CoordinateTransformRD 1
org.opentrafficsim.road.test.TestGMParser$TestGMModel 3
org.opentrafficsim.road.test.TestLaneDirections$TestXMLModel 2
org.opentrafficsim.road.test.TestNetwork2$TestXMLModel 2
org.opentrafficsim.road.test.TestXMLParser$TestXMLModel 2

org.opentrafficsim.graphs.ContourPlot

Bug Category Details Line Priority
org.opentrafficsim.graphs.ContourPlot.STANDARDDISTANCEGRANULARITIES should be package protected MALICIOUS_CODE MS_PKGPROTECT 93 Medium
org.opentrafficsim.graphs.ContourPlot.STANDARDTIMEGRANULARITIES should be package protected MALICIOUS_CODE MS_PKGPROTECT 87 Medium

org.opentrafficsim.graphs.FundamentalDiagram

Bug Category Details Line Priority
Comparison of String objects using == or != in org.opentrafficsim.graphs.FundamentalDiagram.actionPerformed(ActionEvent) BAD_PRACTICE ES_COMPARING_STRINGS_WITH_EQ 533 Medium
Class org.opentrafficsim.graphs.FundamentalDiagram defines non-transient non-serializable instance field densityAxis BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.graphs.FundamentalDiagram defines non-transient non-serializable instance field flowAxis BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.graphs.FundamentalDiagram defines non-transient non-serializable instance field samples BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.graphs.FundamentalDiagram defines non-transient non-serializable instance field speedAxis BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.graphs.FundamentalDiagram defines non-transient non-serializable instance field xAxis BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.graphs.FundamentalDiagram defines non-transient non-serializable instance field yAxis BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.graphs.FundamentalDiagramLane

Bug Category Details Line Priority
Comparison of String objects using == or != in org.opentrafficsim.graphs.FundamentalDiagramLane.actionPerformed(ActionEvent) BAD_PRACTICE ES_COMPARING_STRINGS_WITH_EQ 445 Medium
Class org.opentrafficsim.graphs.FundamentalDiagramLane defines non-transient non-serializable instance field densityAxis BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.graphs.FundamentalDiagramLane defines non-transient non-serializable instance field flowAxis BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.graphs.FundamentalDiagramLane defines non-transient non-serializable instance field samples BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.graphs.FundamentalDiagramLane defines non-transient non-serializable instance field speedAxis BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.graphs.FundamentalDiagramLane defines non-transient non-serializable instance field xAxis BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.graphs.FundamentalDiagramLane defines non-transient non-serializable instance field yAxis BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.graphs.TrajectoryPlot

Bug Category Details Line Priority
Class org.opentrafficsim.graphs.TrajectoryPlot defines non-transient non-serializable instance field trajectories BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.graphs.TrajectoryPlot defines non-transient non-serializable instance field trajectoryIndices BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.road.gtu.generator.AbstractGTUGenerator

Bug Category Details Line Priority
Dead store to direction rather than field with same name in org.opentrafficsim.road.gtu.generator.AbstractGTUGenerator.enoughSpace(LaneBasedIndividualGTU$LaneBasedIndividualCarBuilder) STYLE DLS_DEAD_LOCAL_STORE_SHADOWS_FIELD 246 High

org.opentrafficsim.road.gtu.generator.ListGTUGenerator

Bug Category Details Line Priority
Found reliance on default encoding in new org.opentrafficsim.road.gtu.generator.ListGTUGenerator(String, OTSDEVSSimulatorInterface, GTUType, Speed, Lane, Length$Rel, GTUDirectionality, GTUColorer, LaneBasedStrategicalPlanner, LanePerceptionFull, OTSNetwork, String): new java.io.FileReader(File) I18N DM_DEFAULT_ENCODING 123 High

org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.scheduleTriggers() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 636 Medium
Redundant nullcheck of longitudinalPosition, which is known to be non-null in org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.position(Lane, RelativePosition, Time$Abs) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 453 Medium
org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.move(DirectedPoint) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 281 Medium
org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.scheduleTriggers() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 626 Medium
org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.scheduleTriggers() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 518 Medium

org.opentrafficsim.road.gtu.lane.CopyOfAbstractLaneBasedGTU

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.CopyOfAbstractLaneBasedGTU.scheduleTriggers() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 625 Medium
Redundant nullcheck of longitudinalPosition, which is known to be non-null in org.opentrafficsim.road.gtu.lane.CopyOfAbstractLaneBasedGTU.position(Lane, RelativePosition, Time$Abs) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 442 Medium
org.opentrafficsim.road.gtu.lane.CopyOfAbstractLaneBasedGTU.move(DirectedPoint) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 281 Medium
org.opentrafficsim.road.gtu.lane.CopyOfAbstractLaneBasedGTU.scheduleTriggers() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 615 Medium
org.opentrafficsim.road.gtu.lane.CopyOfAbstractLaneBasedGTU.scheduleTriggers() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 507 Medium

org.opentrafficsim.road.gtu.lane.LaneBasedIndividualGTU

Bug Category Details Line Priority
Class org.opentrafficsim.road.gtu.lane.LaneBasedIndividualGTU defines non-transient non-serializable instance field animation BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.road.gtu.lane.LaneBasedTemplateGTUType

Bug Category Details Line Priority
Class org.opentrafficsim.road.gtu.lane.LaneBasedTemplateGTUType defines non-transient non-serializable instance field initialLongitudinalPositions BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.road.gtu.lane.driver.LaneBasedBehavioralCharacteristics

Bug Category Details Line Priority
Class org.opentrafficsim.road.gtu.lane.driver.LaneBasedBehavioralCharacteristics defines non-transient non-serializable instance field gtuFollowingModel BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.road.gtu.lane.driver.LaneBasedBehavioralCharacteristics defines non-transient non-serializable instance field laneChangeModel BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.road.gtu.lane.object.AbstractTrafficLight

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.object.AbstractTrafficLight.RELATIVE_POSITIONS is a mutable collection which should be package protected MALICIOUS_CODE MS_MUTABLE_COLLECTION_PKGPROTECT 79 Medium

org.opentrafficsim.road.gtu.lane.perception.AbstractLanePerception

Bug Category Details Line Priority
Call to org.opentrafficsim.road.gtu.lane.LaneBasedGTU.equals(org.opentrafficsim.road.gtu.lane.perception.AbstractLanePerception) in org.opentrafficsim.road.gtu.lane.perception.AbstractLanePerception.parallel(Lane, Time$Abs) CORRECTNESS EC_UNRELATED_CLASS_AND_INTERFACE 578 Medium

org.opentrafficsim.road.gtu.lane.perception.LaneStructure

Bug Category Details Line Priority
Unwritten field: org.opentrafficsim.road.gtu.lane.perception.LaneStructure.length CORRECTNESS UWF_UNWRITTEN_FIELD 110 Medium

org.opentrafficsim.road.gtu.lane.plan.operational.LaneBasedOperationalPlan

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.plan.operational.LaneBasedOperationalPlan doesn't override org.opentrafficsim.core.gtu.plan.operational.OperationalPlan.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium

org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner

Bug Category Details Line Priority
Dead store to currentLaneFine in org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner.generateOperationalPlan(GTU, Time$Abs, DirectedPoint) STYLE DLS_DEAD_LOCAL_STORE 140 Medium
Dead store to gtuFollowingModel in org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner.generateOperationalPlan(GTU, Time$Abs, DirectedPoint) STYLE DLS_DEAD_LOCAL_STORE 119 Medium
Dead store to maximumReverseHeadway in org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner.generateOperationalPlan(GTU, Time$Abs, DirectedPoint) STYLE DLS_DEAD_LOCAL_STORE 113 Medium
org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner.canChangeLane(Map, Map, LaneBasedGTU, LateralDirectionality) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 535 Medium
org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner.laneDrop(LaneBasedGTU, LateralDirectionality) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 419 Medium
org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner.suitability(LaneBasedGTU, LateralDirectionality) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 487 Medium

org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingLaneChangeTacticalPlanner

Bug Category Details Line Priority
Dead store to vt in org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingLaneChangeTacticalPlanner.makeLaneChangePlanMobil(LaneBasedGTU, LanePerception, LanePathInfo, LateralDirectionality) STYLE DLS_DEAD_LOCAL_STORE 458 High

org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingLaneChangeTacticalPlanner2

Bug Category Details Line Priority
Dead store to vt in org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingLaneChangeTacticalPlanner2.makeLaneChangePlanMobil(LaneBasedGTU, LanePerception, LanePathInfo, LateralDirectionality) STYLE DLS_DEAD_LOCAL_STORE 535 High
Read of unwritten field laneChangeDirection in org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingLaneChangeTacticalPlanner2.generateOperationalPlan(GTU, Time$Abs, DirectedPoint) CORRECTNESS NP_UNWRITTEN_FIELD 207 Medium
Unwritten field: org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingLaneChangeTacticalPlanner2.laneChangeDirection CORRECTNESS UWF_UNWRITTEN_FIELD 207 Medium

org.opentrafficsim.road.gtu.lane.tactical.LanePathInfo

Bug Category Details Line Priority
Class org.opentrafficsim.road.gtu.lane.tactical.LanePathInfo defines non-transient non-serializable instance field laneDirectionList BAD_PRACTICE SE_BAD_FIELD Not available High

org.opentrafficsim.road.gtu.lane.tactical.directedlanechange.AbstractDirectedLaneChangeModel

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.tactical.directedlanechange.AbstractDirectedLaneChangeModel.computeLaneChangeAndAcceleration(LaneBasedGTU, LateralDirectionality, Collection, Collection, Length$Rel, Speed, Acceleration, Acceleration, Time$Rel) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 48 Medium

org.opentrafficsim.road.gtu.lane.tactical.following.AbstractGTUFollowingModelMobil

Bug Category Details Line Priority
Dead store to maximumSIDeceleration in org.opentrafficsim.road.gtu.lane.tactical.following.AbstractGTUFollowingModelMobil.minimumHeadway(Speed, Speed, Length$Rel, Length$Rel, Speed, Speed) STYLE DLS_DEAD_LOCAL_STORE 234 Medium

org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.AbstractLaneChangeModel

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.AbstractLaneChangeModel.computeLaneChangeAndAcceleration(LaneBasedGTU, Collection, Collection, Collection, Speed, Acceleration, Acceleration, Acceleration) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 55 Medium

org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS

Bug Category Details Line Priority
Dead store to dfm in org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS.generateOperationalPlan(GTU, Time$Abs, DirectedPoint) STYLE DLS_DEAD_LOCAL_STORE 129 Medium
Read of unwritten public or protected field mandatoryIncentives in org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS.addMandatoryIncentive(MandatoryIncentive) STYLE NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD 81 Medium
Read of unwritten public or protected field voluntaryIncentives in org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS.addVoluntaryIncentive(VoluntaryIncentive) STYLE NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD 89 Medium
Read of unwritten public or protected field mandatoryIncentives in org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS.disableLaneChanges() STYLE NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD 108 Medium
Read of unwritten public or protected field voluntaryIncentives in org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS.disableLaneChanges() STYLE NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD 109 Medium
Read of unwritten public or protected field mandatoryIncentives in org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS.generateOperationalPlan(GTU, Time$Abs, DirectedPoint) STYLE NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD 122 Medium
Read of unwritten public or protected field voluntaryIncentives in org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS.generateOperationalPlan(GTU, Time$Abs, DirectedPoint) STYLE NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD 192 Medium
Read of unwritten public or protected field mandatoryIncentives in org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS.setDefaultIncentives() STYLE NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD 97 Medium
Read of unwritten public or protected field voluntaryIncentives in org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS.setDefaultIncentives() STYLE NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD 98 Medium
Class org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS defines non-transient non-serializable instance field mandatoryIncentives BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS defines non-transient non-serializable instance field voluntaryIncentives BAD_PRACTICE SE_BAD_FIELD Not available Medium
Unwritten public or protected field: org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS.mandatoryIncentives STYLE UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD 43 Medium
Unwritten public or protected field: org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS.voluntaryIncentives STYLE UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD 44 Medium

org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRSsync

Bug Category Details Line Priority
Read of unwritten public or protected field mandatoryIncentives in org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRSsync.setDefaultIncentives() STYLE NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD 43 Medium
Read of unwritten public or protected field voluntaryIncentives in org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRSsync.setDefaultIncentives() STYLE NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD 44 Medium

org.opentrafficsim.road.network.factory.TestOpenDriveParserNASA$TestOpenDriveModel

Bug Category Details Line Priority
Dead store to iatDist in org.opentrafficsim.road.network.factory.TestOpenDriveParserNASA$TestOpenDriveModel.constructModel(SimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 237 High
Dead store to initialSpeedDist in org.opentrafficsim.road.network.factory.TestOpenDriveParserNASA$TestOpenDriveModel.constructModel(SimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 235 High
Hard coded reference to an absolute pathname in org.opentrafficsim.road.network.factory.TestOpenDriveParserNASA$TestOpenDriveModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 198 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.road.network.factory.TestOpenDriveParserNASA$TestOpenDriveModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 213 Medium
Possible null pointer dereference of directedLanePosition in org.opentrafficsim.road.network.factory.TestOpenDriveParserNASA$TestOpenDriveModel.constructModel(SimulatorInterface) on exception path CORRECTNESS NP_NULL_ON_SOME_PATH_EXCEPTION 496 Medium
Possible null pointer dereference of network in org.opentrafficsim.road.network.factory.TestOpenDriveParserNASA$TestOpenDriveModel.constructModel(SimulatorInterface) on exception path CORRECTNESS NP_NULL_ON_SOME_PATH_EXCEPTION 253 Medium
Should org.opentrafficsim.road.network.factory.TestOpenDriveParserNASA$TestOpenDriveModel be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 176-582 Medium

org.opentrafficsim.road.network.factory.TestOpenDriveParserNoRTI$TestOpenDriveModel

Bug Category Details Line Priority
Dead store to iatDist in org.opentrafficsim.road.network.factory.TestOpenDriveParserNoRTI$TestOpenDriveModel.constructModel(SimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 233 High
Dead store to initialSpeedDist in org.opentrafficsim.road.network.factory.TestOpenDriveParserNoRTI$TestOpenDriveModel.constructModel(SimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 231 High
Hard coded reference to an absolute pathname in org.opentrafficsim.road.network.factory.TestOpenDriveParserNoRTI$TestOpenDriveModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 212 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.road.network.factory.TestOpenDriveParserNoRTI$TestOpenDriveModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 198 Medium
Possible null pointer dereference of directedLanePosition in org.opentrafficsim.road.network.factory.TestOpenDriveParserNoRTI$TestOpenDriveModel.constructModel(SimulatorInterface) on exception path CORRECTNESS NP_NULL_ON_SOME_PATH_EXCEPTION 501 Medium
Possible null pointer dereference of network in org.opentrafficsim.road.network.factory.TestOpenDriveParserNoRTI$TestOpenDriveModel.constructModel(SimulatorInterface) on exception path CORRECTNESS NP_NULL_ON_SOME_PATH_EXCEPTION 249 Medium
Should org.opentrafficsim.road.network.factory.TestOpenDriveParserNoRTI$TestOpenDriveModel be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 175-592 Medium
Useless object stored in variable strategicalPlanner of method org.opentrafficsim.road.network.factory.TestOpenDriveParserNoRTI$TestOpenDriveModel.constructModel(SimulatorInterface) STYLE UC_USELESS_OBJECT 270 Medium
Useless object stored in variable strategicalPlanner of method org.opentrafficsim.road.network.factory.TestOpenDriveParserNoRTI$TestOpenDriveModel.constructModel(SimulatorInterface) STYLE UC_USELESS_OBJECT 322 Medium

org.opentrafficsim.road.network.factory.TestOpenDriveParserNoRTINew$TestOpenDriveModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.road.network.factory.TestOpenDriveParserNoRTINew$TestOpenDriveModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 265 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.road.network.factory.TestOpenDriveParserNoRTINew$TestOpenDriveModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 251 Medium
Possible null pointer dereference of network in org.opentrafficsim.road.network.factory.TestOpenDriveParserNoRTINew$TestOpenDriveModel.constructModel(SimulatorInterface) on exception path CORRECTNESS NP_NULL_ON_SOME_PATH_EXCEPTION 391 Medium
Should org.opentrafficsim.road.network.factory.TestOpenDriveParserNoRTINew$TestOpenDriveModel be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 214-853 Medium

org.opentrafficsim.road.network.factory.TestOpenDriveParserSV$TestOpenDriveModel

Bug Category Details Line Priority
Dead store to iatDist in org.opentrafficsim.road.network.factory.TestOpenDriveParserSV$TestOpenDriveModel.constructModel(SimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 239 High
Dead store to initialSpeedDist in org.opentrafficsim.road.network.factory.TestOpenDriveParserSV$TestOpenDriveModel.constructModel(SimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 237 High
Hard coded reference to an absolute pathname in org.opentrafficsim.road.network.factory.TestOpenDriveParserSV$TestOpenDriveModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 215 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.road.network.factory.TestOpenDriveParserSV$TestOpenDriveModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 201 Medium
Possible null pointer dereference of directedLanePosition in org.opentrafficsim.road.network.factory.TestOpenDriveParserSV$TestOpenDriveModel.constructModel(SimulatorInterface) on exception path CORRECTNESS NP_NULL_ON_SOME_PATH_EXCEPTION 501 Medium
Possible null pointer dereference of network in org.opentrafficsim.road.network.factory.TestOpenDriveParserSV$TestOpenDriveModel.constructModel(SimulatorInterface) on exception path CORRECTNESS NP_NULL_ON_SOME_PATH_EXCEPTION 255 Medium
Should org.opentrafficsim.road.network.factory.TestOpenDriveParserSV$TestOpenDriveModel be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 178-602 Medium

org.opentrafficsim.road.network.factory.opendrive.ConnectionTag

Bug Category Details Line Priority
Unread field: org.opentrafficsim.road.network.factory.opendrive.ConnectionTag.contactPoint PERFORMANCE URF_UNREAD_FIELD 35 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.ConnectionTag.id PERFORMANCE URF_UNREAD_FIELD 23 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.ConnectionTag.incomingRoad PERFORMANCE URF_UNREAD_FIELD 27 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.ConnectionTag.laneLinkFrom PERFORMANCE URF_UNREAD_FIELD 39 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.ConnectionTag.laneLinkTo PERFORMANCE URF_UNREAD_FIELD 43 Medium

org.opentrafficsim.road.network.factory.opendrive.Controller

Bug Category Details Line Priority
Unread field: org.opentrafficsim.road.network.factory.opendrive.Controller.id PERFORMANCE URF_UNREAD_FIELD 54 Medium

org.opentrafficsim.road.network.factory.opendrive.ControllerTag

Bug Category Details Line Priority
Unread field: org.opentrafficsim.road.network.factory.opendrive.ControllerTag.controlType PERFORMANCE URF_UNREAD_FIELD 42 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.ControllerTag.name PERFORMANCE URF_UNREAD_FIELD 30 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.ControllerTag.type PERFORMANCE URF_UNREAD_FIELD 26 Medium

org.opentrafficsim.road.network.factory.opendrive.HeaderTag

Bug Category Details Line Priority
Unread field: org.opentrafficsim.road.network.factory.opendrive.HeaderTag.date PERFORMANCE URF_UNREAD_FIELD 40 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.HeaderTag.east PERFORMANCE URF_UNREAD_FIELD 52 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.HeaderTag.name PERFORMANCE URF_UNREAD_FIELD 24 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.HeaderTag.north PERFORMANCE URF_UNREAD_FIELD 44 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.HeaderTag.originHdg PERFORMANCE URF_UNREAD_FIELD 72 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.HeaderTag.revMajor PERFORMANCE URF_UNREAD_FIELD 28 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.HeaderTag.revMinor PERFORMANCE URF_UNREAD_FIELD 32 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.HeaderTag.south PERFORMANCE URF_UNREAD_FIELD 48 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.HeaderTag.vendor PERFORMANCE URF_UNREAD_FIELD 60 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.HeaderTag.version PERFORMANCE URF_UNREAD_FIELD 36 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.HeaderTag.west PERFORMANCE URF_UNREAD_FIELD 56 Medium

org.opentrafficsim.road.network.factory.opendrive.HeightTag

Bug Category Details Line Priority
Unread field: org.opentrafficsim.road.network.factory.opendrive.HeightTag.inner PERFORMANCE URF_UNREAD_FIELD 28 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.HeightTag.outer PERFORMANCE URF_UNREAD_FIELD 32 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.HeightTag.sOffst PERFORMANCE URF_UNREAD_FIELD 24 Medium

org.opentrafficsim.road.network.factory.opendrive.JunctionTag

Bug Category Details Line Priority
Unread field: org.opentrafficsim.road.network.factory.opendrive.JunctionTag.name PERFORMANCE URF_UNREAD_FIELD 29 Medium

org.opentrafficsim.road.network.factory.opendrive.LaneSectionTag

Bug Category Details Line Priority
Unread field: org.opentrafficsim.road.network.factory.opendrive.LaneSectionTag.id PERFORMANCE URF_UNREAD_FIELD 30 Medium
org.opentrafficsim.road.network.factory.opendrive.LaneSectionTag.findLanes(String) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 106 Medium

org.opentrafficsim.road.network.factory.opendrive.LaneTag

Bug Category Details Line Priority
Unread field: org.opentrafficsim.road.network.factory.opendrive.LaneTag.heightTag PERFORMANCE URF_UNREAD_FIELD 66 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.LaneTag.level PERFORMANCE URF_UNREAD_FIELD 33 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.LaneTag.predecessorId PERFORMANCE URF_UNREAD_FIELD 41 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.LaneTag.successorId PERFORMANCE URF_UNREAD_FIELD 37 Medium

org.opentrafficsim.road.network.factory.opendrive.LateralProfileTag

Bug Category Details Line Priority

org.opentrafficsim.road.network.factory.opendrive.LinkTag

Bug Category Details Line Priority
Unread field: org.opentrafficsim.road.network.factory.opendrive.LinkTag.leftNeighborDirection PERFORMANCE URF_UNREAD_FIELD 53 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.LinkTag.leftNeighborRoadId PERFORMANCE URF_UNREAD_FIELD 49 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.LinkTag.predecessorType PERFORMANCE URF_UNREAD_FIELD 29 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.LinkTag.rightNeighborDirection PERFORMANCE URF_UNREAD_FIELD 61 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.LinkTag.rightNeighborRoadId PERFORMANCE URF_UNREAD_FIELD 57 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.LinkTag.successorType PERFORMANCE URF_UNREAD_FIELD 41 Medium

org.opentrafficsim.road.network.factory.opendrive.ObjectTag

Bug Category Details Line Priority
Unread field: org.opentrafficsim.road.network.factory.opendrive.ObjectTag.hdg PERFORMANCE URF_UNREAD_FIELD 68 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.ObjectTag.height PERFORMANCE URF_UNREAD_FIELD 64 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.ObjectTag.id PERFORMANCE URF_UNREAD_FIELD 32 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.ObjectTag.length PERFORMANCE URF_UNREAD_FIELD 56 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.ObjectTag.name PERFORMANCE URF_UNREAD_FIELD 36 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.ObjectTag.orientation PERFORMANCE URF_UNREAD_FIELD 40 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.ObjectTag.pitch PERFORMANCE URF_UNREAD_FIELD 72 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.ObjectTag.roll PERFORMANCE URF_UNREAD_FIELD 76 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.ObjectTag.s PERFORMANCE URF_UNREAD_FIELD 24 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.ObjectTag.t PERFORMANCE URF_UNREAD_FIELD 28 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.ObjectTag.type PERFORMANCE URF_UNREAD_FIELD 48 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.ObjectTag.validLength PERFORMANCE URF_UNREAD_FIELD 52 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.ObjectTag.width PERFORMANCE URF_UNREAD_FIELD 60 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.ObjectTag.zOffset PERFORMANCE URF_UNREAD_FIELD 44 Medium

org.opentrafficsim.road.network.factory.opendrive.ObjectsTag

Bug Category Details Line Priority

org.opentrafficsim.road.network.factory.opendrive.OpenDriveNetworkLaneParser

Bug Category Details Line Priority
org.opentrafficsim.road.network.factory.opendrive.OpenDriveNetworkLaneParser.noTrafficLaneType isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 70 High
Unread public/protected field: org.opentrafficsim.road.network.factory.opendrive.OpenDriveNetworkLaneParser.gtuTypes STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 61 Medium

org.opentrafficsim.road.network.factory.opendrive.OpenDriveNetworkWriter

Bug Category Details Line Priority
Unread public/protected field: org.opentrafficsim.road.network.factory.opendrive.OpenDriveNetworkWriter.network STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 17 Medium
Field only ever set to null: org.opentrafficsim.road.network.factory.opendrive.OpenDriveNetworkWriter.output CORRECTNESS UWF_NULL_FIELD Not available Medium

org.opentrafficsim.road.network.factory.opendrive.PlanViewTag

Bug Category Details Line Priority
Dead store to mPoint in org.opentrafficsim.road.network.factory.opendrive.PlanViewTag.generateCurve(OTSPoint3D, OTSPoint3D, double, double, boolean, boolean) STYLE DLS_DEAD_LOCAL_STORE 231 High
Dead store to otsLine in org.opentrafficsim.road.network.factory.opendrive.PlanViewTag.interpolateSpiral(OpenDriveNetworkLaneParser, PlanViewTag, GeometryTag, int) STYLE DLS_DEAD_LOCAL_STORE 171 High
Dead store to endCurvature in org.opentrafficsim.road.network.factory.opendrive.PlanViewTag.interpolateSpiral(OpenDriveNetworkLaneParser, PlanViewTag, GeometryTag, int) STYLE DLS_DEAD_LOCAL_STORE 147 Medium
Dead store to start in org.opentrafficsim.road.network.factory.opendrive.PlanViewTag.interpolateSpiral(OpenDriveNetworkLaneParser, PlanViewTag, GeometryTag, int) STYLE DLS_DEAD_LOCAL_STORE 148 Medium
Dead store to startCurvature in org.opentrafficsim.road.network.factory.opendrive.PlanViewTag.interpolateSpiral(OpenDriveNetworkLaneParser, PlanViewTag, GeometryTag, int) STYLE DLS_DEAD_LOCAL_STORE 146 Medium

org.opentrafficsim.road.network.factory.opendrive.RoadMarkTag

Bug Category Details Line Priority
Unread field: org.opentrafficsim.road.network.factory.opendrive.RoadMarkTag.color PERFORMANCE URF_UNREAD_FIELD 36 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.RoadMarkTag.laneChange PERFORMANCE URF_UNREAD_FIELD 44 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.RoadMarkTag.sOffst PERFORMANCE URF_UNREAD_FIELD 24 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.RoadMarkTag.type PERFORMANCE URF_UNREAD_FIELD 28 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.RoadMarkTag.weight PERFORMANCE URF_UNREAD_FIELD 32 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.RoadMarkTag.width PERFORMANCE URF_UNREAD_FIELD 40 Medium

org.opentrafficsim.road.network.factory.opendrive.RoadTag

Bug Category Details Line Priority
Dead store to tempGeometryTags in org.opentrafficsim.road.network.factory.opendrive.RoadTag.buildSubLinks(RoadTag, OTSDEVSSimulatorInterface, OpenDriveNetworkLaneParser) STYLE DLS_DEAD_LOCAL_STORE 223 Medium
Dead store to ds in org.opentrafficsim.road.network.factory.opendrive.RoadTag.generateRegularRoads(RoadTag, OTSDEVSSimulatorInterface, OpenDriveNetworkLaneParser) STYLE DLS_DEAD_LOCAL_STORE 425 Medium
Incorrect lazy initialization and update of static field org.opentrafficsim.road.network.factory.opendrive.RoadTag.LANETYPE_ALL in org.opentrafficsim.road.network.factory.opendrive.RoadTag.parseRoad(Node, OpenDriveNetworkLaneParser) MT_CORRECTNESS LI_LAZY_INIT_UPDATE_STATIC 149-151 Medium
Possible null pointer dereference of RoadTag.junctionId in org.opentrafficsim.road.network.factory.opendrive.RoadTag.buildLink(RoadTag, OpenDriveNetworkLaneParser) CORRECTNESS NP_NULL_ON_SOME_PATH 880 High
Unread field: org.opentrafficsim.road.network.factory.opendrive.RoadTag.lateralProfileTag PERFORMANCE URF_UNREAD_FIELD 46 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.RoadTag.name PERFORMANCE URF_UNREAD_FIELD 71 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.RoadTag.objectsTag PERFORMANCE URF_UNREAD_FIELD 47 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.RoadTag.typeTag PERFORMANCE URF_UNREAD_FIELD 66 Medium

org.opentrafficsim.road.network.factory.opendrive.SignalReferenceTag

Bug Category Details Line Priority
Unread field: org.opentrafficsim.road.network.factory.opendrive.SignalReferenceTag.t PERFORMANCE URF_UNREAD_FIELD 26 Medium

org.opentrafficsim.road.network.factory.opendrive.SignalTag

Bug Category Details Line Priority
Unread field: org.opentrafficsim.road.network.factory.opendrive.SignalTag.country PERFORMANCE URF_UNREAD_FIELD 50 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.SignalTag.name PERFORMANCE URF_UNREAD_FIELD 34 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.SignalTag.subtype PERFORMANCE URF_UNREAD_FIELD 58 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.SignalTag.t PERFORMANCE URF_UNREAD_FIELD 26 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.SignalTag.value PERFORMANCE URF_UNREAD_FIELD 62 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.SignalTag.zOffset PERFORMANCE URF_UNREAD_FIELD 46 Medium

org.opentrafficsim.road.network.factory.opendrive.SpeedTag

Bug Category Details Line Priority
Unread field: org.opentrafficsim.road.network.factory.opendrive.SpeedTag.sOffst PERFORMANCE URF_UNREAD_FIELD 26 Medium

org.opentrafficsim.road.network.factory.opendrive.SuperElevationTag

Bug Category Details Line Priority
Unread field: org.opentrafficsim.road.network.factory.opendrive.SuperElevationTag.a PERFORMANCE URF_UNREAD_FIELD 31 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.SuperElevationTag.b PERFORMANCE URF_UNREAD_FIELD 35 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.SuperElevationTag.c PERFORMANCE URF_UNREAD_FIELD 39 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.SuperElevationTag.d PERFORMANCE URF_UNREAD_FIELD 43 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.SuperElevationTag.id PERFORMANCE URF_UNREAD_FIELD 23 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.SuperElevationTag.s PERFORMANCE URF_UNREAD_FIELD 27 Medium

org.opentrafficsim.road.network.factory.opendrive.TypeTag

Bug Category Details Line Priority
Unread field: org.opentrafficsim.road.network.factory.opendrive.TypeTag.maxSpeed PERFORMANCE URF_UNREAD_FIELD 34 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.TypeTag.s PERFORMANCE URF_UNREAD_FIELD 26 Medium
Unread field: org.opentrafficsim.road.network.factory.opendrive.TypeTag.type PERFORMANCE URF_UNREAD_FIELD 30 Medium

org.opentrafficsim.road.network.factory.opendrive.communicationRTI.communicationTest

Bug Category Details Line Priority
There is an apparent infinite loop in org.opentrafficsim.road.network.factory.opendrive.communicationRTI.communicationTest.main(String[]) CORRECTNESS IL_INFINITE_LOOP 29 High
The class name org.opentrafficsim.road.network.factory.opendrive.communicationRTI.communicationTest doesn't start with an upper case letter BAD_PRACTICE NM_CLASS_NAMING_CONVENTION 14-72 Medium

org.opentrafficsim.road.network.factory.osm.events.ProgressEvent

Bug Category Details Line Priority
Write to static field org.opentrafficsim.road.network.factory.osm.events.ProgressEvent.first from instance method new org.opentrafficsim.road.network.factory.osm.events.ProgressEvent(Object, String) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 40 Medium

org.opentrafficsim.road.network.factory.osm.output.Convert

Bug Category Details Line Priority
Write to static field org.opentrafficsim.road.network.factory.osm.output.Convert.baseX from instance method new org.opentrafficsim.road.network.factory.osm.output.Convert() STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 68 High
org.opentrafficsim.road.network.factory.osm.output.Convert.makeLanes(OSMLink, OTSDEVSSimulatorInterface, WarningListener) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 632 Medium

org.opentrafficsim.road.network.factory.vissim.VissimANMNetworkLaneParser

Bug Category Details Line Priority
org.opentrafficsim.road.network.factory.vissim.VissimANMNetworkLaneParser.noTrafficLaneType isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 91 High
Unread public/protected field: org.opentrafficsim.road.network.factory.vissim.VissimANMNetworkLaneParser.simulator STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 102 Medium

org.opentrafficsim.road.network.factory.xml.FillTag

Bug Category Details Line Priority
Dead store to rg in org.opentrafficsim.road.network.factory.xml.FillTag.makeFill(FillTag, XmlNetworkLaneParser, LinkTag, OTSDEVSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 218 High
Dead store to lane in org.opentrafficsim.road.network.factory.xml.FillTag.makeFill(FillTag, XmlNetworkLaneParser, LinkTag, OTSDEVSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 211 Medium
Dead store of org.opentrafficsim.road.gtu.lane.LaneBasedIndividualGTU.class in org.opentrafficsim.road.network.factory.xml.FillTag.makeFill(FillTag, XmlNetworkLaneParser, LinkTag, OTSDEVSSimulatorInterface) CORRECTNESS DLS_DEAD_STORE_OF_CLASS_LITERAL 212 Medium
Unread field: org.opentrafficsim.road.network.factory.xml.FillTag.distanceDist PERFORMANCE URF_UNREAD_FIELD 51 Medium
Unread field: org.opentrafficsim.road.network.factory.xml.FillTag.initialSpeedDist PERFORMANCE URF_UNREAD_FIELD 55 Medium
Unread field: org.opentrafficsim.road.network.factory.xml.FillTag.maxGTUs PERFORMANCE URF_UNREAD_FIELD 59 Medium
Unread field: org.opentrafficsim.road.network.factory.xml.FillTag.routeMixTag PERFORMANCE URF_UNREAD_FIELD 67 Medium
Unread field: org.opentrafficsim.road.network.factory.xml.FillTag.shortestRouteMixTag PERFORMANCE URF_UNREAD_FIELD 75 Medium
Unread field: org.opentrafficsim.road.network.factory.xml.FillTag.shortestRouteTag PERFORMANCE URF_UNREAD_FIELD 71 Medium

org.opentrafficsim.road.network.factory.xml.GTUTag

Bug Category Details Line Priority
Unread field: org.opentrafficsim.road.network.factory.xml.GTUTag.followingModel PERFORMANCE URF_UNREAD_FIELD 52 Medium
Unread field: org.opentrafficsim.road.network.factory.xml.GTUTag.laneChangeModel PERFORMANCE URF_UNREAD_FIELD 56 Medium

org.opentrafficsim.road.network.factory.xml.GeneratorTag

Bug Category Details Line Priority
Useless object stored in variable nodeList of method org.opentrafficsim.road.network.factory.xml.GeneratorTag.makeGenerator(GeneratorTag, XmlNetworkLaneParser, LinkTag, OTSDEVSSimulatorInterface) STYLE UC_USELESS_OBJECT 286 Medium
Unread field: org.opentrafficsim.road.network.factory.xml.GeneratorTag.routeMixTag PERFORMANCE URF_UNREAD_FIELD 91 Medium
Unread field: org.opentrafficsim.road.network.factory.xml.GeneratorTag.shortestRouteMixTag PERFORMANCE URF_UNREAD_FIELD 99 Medium
Unread field: org.opentrafficsim.road.network.factory.xml.GeneratorTag.shortestRouteTag PERFORMANCE URF_UNREAD_FIELD 95 Medium

org.opentrafficsim.road.network.factory.xml.Links

Bug Category Details Line Priority
org.opentrafficsim.road.network.factory.xml.Links.calculateNodeCoordinates(XmlNetworkLaneParser) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 148 Medium
Useless object stored in variable cseList of method org.opentrafficsim.road.network.factory.xml.Links.applyRoadTypeToLink(LinkTag, XmlNetworkLaneParser, OTSDEVSSimulatorInterface) STYLE UC_USELESS_OBJECT 489 Medium
Useless object stored in variable lanes of method org.opentrafficsim.road.network.factory.xml.Links.applyRoadTypeToLink(LinkTag, XmlNetworkLaneParser, OTSDEVSSimulatorInterface) STYLE UC_USELESS_OBJECT 490 Medium

org.opentrafficsim.road.network.factory.xml.ListGeneratorTag

Bug Category Details Line Priority
Unread field: org.opentrafficsim.road.network.factory.xml.ListGeneratorTag.initialSpeedDist PERFORMANCE URF_UNREAD_FIELD 44 Medium
Unread field: org.opentrafficsim.road.network.factory.xml.ListGeneratorTag.positionStr PERFORMANCE URF_UNREAD_FIELD 32 Medium
Unread field: org.opentrafficsim.road.network.factory.xml.ListGeneratorTag.uri PERFORMANCE URF_UNREAD_FIELD 28 Medium
Unused field: org.opentrafficsim.road.network.factory.xml.ListGeneratorTag.gtuColorer PERFORMANCE UUF_UNUSED_FIELD Not available Medium

org.opentrafficsim.road.network.factory.xml.ShortestRouteTag

Bug Category Details Line Priority
Unread field: org.opentrafficsim.road.network.factory.xml.ShortestRouteTag.costPerDistance PERFORMANCE URF_UNREAD_FIELD 50 Medium
Unread field: org.opentrafficsim.road.network.factory.xml.ShortestRouteTag.costPerTime PERFORMANCE URF_UNREAD_FIELD 46 Medium
Unread field: org.opentrafficsim.road.network.factory.xml.ShortestRouteTag.from PERFORMANCE URF_UNREAD_FIELD 34 Medium
Unread field: org.opentrafficsim.road.network.factory.xml.ShortestRouteTag.to PERFORMANCE URF_UNREAD_FIELD 42 Medium
Unread field: org.opentrafficsim.road.network.factory.xml.ShortestRouteTag.via PERFORMANCE URF_UNREAD_FIELD 38 Medium

org.opentrafficsim.road.network.factory.xml.XmlNetworkLaneParser

Bug Category Details Line Priority
org.opentrafficsim.road.network.factory.xml.XmlNetworkLaneParser.noTrafficLaneType isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 91 High

org.opentrafficsim.road.network.lane.CrossSectionLink

Bug Category Details Line Priority
org.opentrafficsim.road.network.lane.CrossSectionLink doesn't override org.opentrafficsim.core.network.OTSLink.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium

org.opentrafficsim.road.network.lane.Lane

Bug Category Details Line Priority
Class org.opentrafficsim.road.network.lane.Lane defines non-transient non-serializable instance field overtakingConditions BAD_PRACTICE SE_BAD_FIELD Not available Medium
org.opentrafficsim.road.network.lane.Lane.checkDirectionality() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 1163 Medium
org.opentrafficsim.road.network.lane.Lane.getSensorMap(GTUType) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 592 Medium

org.opentrafficsim.road.network.lane.Lane$GTUTypeSensor

Bug Category Details Line Priority
org.opentrafficsim.road.network.lane.Lane$GTUTypeSensor is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 1263-1281 Medium
Should org.opentrafficsim.road.network.lane.Lane$GTUTypeSensor be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 1263-1281 Medium

org.opentrafficsim.road.test.FourStop$TestXMLModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.road.test.FourStop$TestXMLModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 145 Medium
Should org.opentrafficsim.road.test.FourStop$TestXMLModel be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 128-164 Medium

org.opentrafficsim.road.test.LMRSTests$TestXMLModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.road.test.LMRSTests$TestXMLModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 147 Medium
Should org.opentrafficsim.road.test.LMRSTests$TestXMLModel be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 128-168 Medium

org.opentrafficsim.road.test.TestGMParser$CoordinateTransformRD

Bug Category Details Line Priority
Should org.opentrafficsim.road.test.TestGMParser$CoordinateTransformRD be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 271-296 Medium

org.opentrafficsim.road.test.TestGMParser$TestGMModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.road.test.TestGMParser$TestGMModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 189 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.road.test.TestGMParser$TestGMModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 176 Medium
Possible null pointer dereference of network in org.opentrafficsim.road.test.TestGMParser$TestGMModel.constructModel(SimulatorInterface) on exception path CORRECTNESS NP_NULL_ON_SOME_PATH_EXCEPTION 222 Medium

org.opentrafficsim.road.test.TestLaneDirections$TestXMLModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.road.test.TestLaneDirections$TestXMLModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 143 Medium
Should org.opentrafficsim.road.test.TestLaneDirections$TestXMLModel be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 126-162 Medium

org.opentrafficsim.road.test.TestNetwork2$TestXMLModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.road.test.TestNetwork2$TestXMLModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 143 Medium
Should org.opentrafficsim.road.test.TestNetwork2$TestXMLModel be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 126-162 Medium

org.opentrafficsim.road.test.TestXMLParser$TestXMLModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.road.test.TestXMLParser$TestXMLModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 146 Medium
Should org.opentrafficsim.road.test.TestXMLParser$TestXMLModel be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 126-165 Medium