PMD Results

The following document contains the results of PMD 5.3.5.

Files

org/opentrafficsim/road/gtu/generator/AbstractGTUGenerator.java

Violation Line
Avoid unused local variables such as 'direction'. 246
Useless parentheses. 257
Useless parentheses. 257
Useless parentheses. 258
Useless parentheses. 258
These nested if statements could be combined 328–349
These nested if statements could be combined 390–411

org/opentrafficsim/road/gtu/generator/LaneBasedGTUGenerator.java

Violation Line
Avoid unused constructor parameters such as 'network'. 102
Avoid modifiers which are implied by the context 315–316

org/opentrafficsim/road/gtu/generator/ListGTUGenerator.java

Violation Line
Avoid unused constructor parameters such as 'direction'. 103
Avoid unused constructor parameters such as 'position'. 103

org/opentrafficsim/road/gtu/generator/SpaceChecker.java

Violation Line
Avoid modifiers which are implied by the context 24

org/opentrafficsim/road/gtu/lane/AbstractLaneBasedGTU.java

Violation Line
Avoid empty if statements 215–217
Useless parentheses. 283
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 638
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 656
Avoid empty catch blocks 875–878

org/opentrafficsim/road/gtu/lane/CopyOfAbstractLaneBasedGTU.java

Violation Line
Avoid empty if statements 215–217
Useless parentheses. 283
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 627
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 645
Avoid empty catch blocks 864–867

org/opentrafficsim/road/gtu/lane/LaneBasedGTU.java

Violation Line
Avoid modifiers which are implied by the context 174

org/opentrafficsim/road/gtu/lane/LaneBasedGTUCharacteristicsGenerator.java

Violation Line
Avoid modifiers which are implied by the context 24
Avoid modifiers which are implied by the context 31

org/opentrafficsim/road/gtu/lane/driver/LaneBasedBehavioralCharacteristics.java

Violation Line
Avoid unused private fields such as 'STAYINCURRENTLANEINCENTIVE'. 40
Avoid unused private fields such as 'PREFERREDLANEINCENTIVE'. 44
Avoid unused private fields such as 'NONPREFERREDLANEINCENTIVE'. 48
Avoid unused private fields such as 'TIMEHORIZON'. 52

org/opentrafficsim/road/gtu/lane/object/LaneBlock.java

Violation Line
Avoid empty if statements 57–59

org/opentrafficsim/road/gtu/lane/object/LaneBlockOnOff.java

Violation Line
Avoid empty if statements 59–61

org/opentrafficsim/road/gtu/lane/object/OldTrafficLight.java

Violation Line
Avoid unused constructor parameters such as 'id'. 34

org/opentrafficsim/road/gtu/lane/object/animation/TrafficLightAnimation.java

Violation Line
Avoid unused private fields such as 'POINT_000'. 32

org/opentrafficsim/road/gtu/lane/perception/AbstractLanePerception.java

Violation Line
These nested if statements could be combined 521–539
Useless parentheses. 591
Useless parentheses. 591
Useless parentheses. 592
Useless parentheses. 592

org/opentrafficsim/road/gtu/lane/tactical/AbstractLaneBasedTacticalPlanner.java

Violation Line
Avoid unused local variables such as 'ld'. 441

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedCFLCTacticalPlanner.java

Violation Line
Avoid unused local variables such as 'maximumReverseHeadway'. 113
Avoid unused local variables such as 'gtuFollowingModel'. 118
Avoid unused local variables such as 'currentLaneFine'. 140
Useless parentheses. 197–198
Useless parentheses. 199–200
Useless parentheses. 498
These nested if statements could be combined 498–503
Useless parentheses. 499

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedGTUFollowingChange0TacticalPlanner.java

Violation Line
These nested if statements could be combined 130–145
Avoid unused method parameters such as 'lanePathInfo'. 367

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedGTUFollowingLaneChangeTacticalPlanner.java

Violation Line
These nested if statements could be combined 145–159
Useless parentheses. 430
Avoid unused private methods such as 'interpolateLinear(OTSLine3D,OTSLine3D,double)'. 521

org/opentrafficsim/road/gtu/lane/tactical/LaneBasedGTUFollowingLaneChangeTacticalPlanner2.java

Violation Line
These nested if statements could be combined 220–234
Useless parentheses. 507
Avoid unused private methods such as 'interpolateLinear(OTSLine3D,OTSLine3D,double)'. 610

org/opentrafficsim/road/gtu/lane/tactical/lmrs/Desire.java

Violation Line
An empty statement (semicolon) not part of a loop 28
An empty statement (semicolon) not part of a loop 29

org/opentrafficsim/road/gtu/lane/tactical/lmrs/LMRS.java

Violation Line
Avoid unused local variables such as 'dfm'. 129
Avoid unused local variables such as 'changeLeft'. 240
Avoid unused local variables such as 'changeRight'. 241
Avoid empty if statements 248–251
Avoid empty if statements 251–254

org/opentrafficsim/road/gtu/lane/tactical/lmrs/MandatoryIncentive.java

Violation Line
Avoid modifiers which are implied by the context 20

org/opentrafficsim/road/gtu/lane/tactical/lmrs/VoluntaryIncentive.java

Violation Line
Avoid modifiers which are implied by the context 21

org/opentrafficsim/road/gtu/strategical/route/LaneBasedStrategicalRoutePlanner.java

Violation Line
Useless parentheses. 153
Useless parentheses. 154
Useless parentheses. 168
Useless parentheses. 169

org/opentrafficsim/road/network/factory/TestOpenDriveParserNASA.java

Violation Line
Avoid unused local variables such as 'initialSpeedDist'. 235
Avoid unused local variables such as 'iatDist'. 237
Avoid unused local variables such as 'startTime'. 268
Avoid unused local variables such as 'endTime'. 269
Avoid unused local variables such as 'id'. 271
Avoid unused local variables such as 'strategicalPlanner'. 274
Avoid unused local variables such as 'perception'. 277
Avoid unused local variables such as 'startTime'. 319
Avoid unused local variables such as 'endTime'. 320
Avoid unused local variables such as 'id'. 323
Avoid unused local variables such as 'strategicalPlanner'. 326
Avoid unused local variables such as 'perception'. 329
Useless parentheses. 523
Useless parentheses. 523
Useless parentheses. 524
Useless parentheses. 524

org/opentrafficsim/road/network/factory/TestOpenDriveParserNoRTI.java

Violation Line
Avoid unused local variables such as 'initialSpeedDist'. 231
Avoid unused local variables such as 'iatDist'. 233
Avoid unused local variables such as 'startTime'. 264
Avoid unused local variables such as 'endTime'. 265
Avoid unused local variables such as 'id'. 267
Avoid unused local variables such as 'strategicalPlanner'. 270
Avoid unused local variables such as 'perception'. 273
Avoid unused local variables such as 'startTime'. 315
Avoid unused local variables such as 'endTime'. 316
Avoid unused local variables such as 'id'. 319
Avoid unused local variables such as 'strategicalPlanner'. 322
Avoid unused local variables such as 'perception'. 325
Useless parentheses. 528
Useless parentheses. 528
Useless parentheses. 529
Useless parentheses. 529

org/opentrafficsim/road/network/factory/TestOpenDriveParserSV.java

Violation Line
Avoid unused local variables such as 'initialSpeedDist'. 237
Avoid unused local variables such as 'iatDist'. 239
Avoid unused local variables such as 'startTime'. 270
Avoid unused local variables such as 'endTime'. 271
Avoid unused local variables such as 'id'. 273
Avoid unused local variables such as 'strategicalPlanner'. 276
Avoid unused local variables such as 'perception'. 279
Avoid unused local variables such as 'startTime'. 321
Avoid unused local variables such as 'endTime'. 322
Avoid unused local variables such as 'id'. 325
Avoid unused local variables such as 'strategicalPlanner'. 328
Avoid unused local variables such as 'perception'. 331
Useless parentheses. 528
Useless parentheses. 528
Useless parentheses. 529
Useless parentheses. 529

org/opentrafficsim/road/network/factory/XMLParser.java

Violation Line
These nested if statements could be combined 40–43

org/opentrafficsim/road/network/factory/opendrive/Controller.java

Violation Line
Avoid unused private fields such as 'id'. 39
Avoid empty if statements 62–64

org/opentrafficsim/road/network/factory/opendrive/LaneSectionTag.java

Violation Line
These nested if statements could be combined 114–115

org/opentrafficsim/road/network/factory/opendrive/LaneTag.java

Violation Line
Avoid unused local variables such as 'attributes1'. 92

org/opentrafficsim/road/network/factory/opendrive/OpenDriveNetworkLaneParser.java

Violation Line
Avoid unused private methods such as 'makeNetwork(String)'. 220

org/opentrafficsim/road/network/factory/opendrive/PlanViewTag.java

Violation Line
Avoid unused method parameters such as 'parser'. 143
Avoid unused method parameters such as 'planViewTag'. 143
Avoid unused method parameters such as 'geometryCount'. 144
Avoid unused local variables such as 'startCurvature'. 146
Avoid unused local variables such as 'endCurvature'. 147
Avoid unused local variables such as 'start'. 148
Avoid unused local variables such as 'length'. 149
Avoid unused local variables such as 'otsLine'. 171
Avoid unused method parameters such as 'roadTag'. 185
Avoid unused local variables such as 'length'. 191
Avoid unused local variables such as 'mPoint'. 231
Useless parentheses. 283
Useless parentheses. 283
Useless parentheses. 284
Useless parentheses. 284
Useless parentheses. 293
Useless parentheses. 293
Useless parentheses. 294
Useless parentheses. 294
Useless parentheses. 302
Useless parentheses. 302
Useless parentheses. 303
Useless parentheses. 303
Avoid unused local variables such as 'flipped'. 318
These nested if statements could be combined 321–328

org/opentrafficsim/road/network/factory/opendrive/RoadTag.java

Violation Line
Avoid empty if statements 990–992
Avoid empty if statements 1054–1056

org/opentrafficsim/road/network/factory/opendrive/WidthTag.java

Violation Line
Avoid unused local variables such as 'widthCount'. 55

org/opentrafficsim/road/network/factory/opendrive/communicationRTI/communicationTest.java

Violation Line
Avoid unused local variables such as 'simData'. 36

org/opentrafficsim/road/network/factory/xml/ArcTag.java

Violation Line
Useless parentheses. 83

org/opentrafficsim/road/network/factory/xml/FillTag.java

Violation Line
Avoid unused local variables such as 'lane'. 211
Avoid unused local variables such as 'gtuClass'. 212
Avoid unused local variables such as 'rg'. 218

org/opentrafficsim/road/network/factory/xml/Links.java

Violation Line
Useless parentheses. 410
These nested if statements could be combined 625–628
Avoid unused local variables such as 'trafficLight'. 685
These nested if statements could be combined 758–759
These nested if statements could be combined 782–783

org/opentrafficsim/road/network/lane/Lane.java

Violation Line
Useless parentheses. 388
Useless parentheses. 391
Useless parentheses. 402
Useless parentheses. 404
These nested if statements could be combined 407–411
These nested if statements could be combined 444–448
Useless parentheses. 554

org/opentrafficsim/road/network/lane/changing/OvertakingConditions.java

Violation Line
Avoid modifiers which are implied by the context 65–74
Avoid modifiers which are implied by the context 88–97
Avoid modifiers which are implied by the context 109–118
Avoid modifiers which are implied by the context 130–139
Avoid modifiers which are implied by the context 151–172
Avoid modifiers which are implied by the context 184–205
Avoid modifiers which are implied by the context 222–258
Useless parentheses. 250–252
Avoid modifiers which are implied by the context 275–311
Useless parentheses. 303–305
Avoid modifiers which are implied by the context 328–374
Useless parentheses. 364–366
Useless parentheses. 364–366
Avoid modifiers which are implied by the context 391–437
Useless parentheses. 427–429
Useless parentheses. 427–429

org/opentrafficsim/road/test/TestGMParser.java

Violation Line
Useless parentheses. 348