FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
294 96 0 0

Files

Class Bugs
org.opentrafficsim.graphs.ContourPlot 2
org.opentrafficsim.graphs.FundamentalDiagram$Sample 1
org.opentrafficsim.graphs.FundamentalDiagramLane$Sample 1
org.opentrafficsim.graphs.TrajectoryPlot$Trajectory 1
org.opentrafficsim.road.gtu.animation.DefaultCarAnimation 1
org.opentrafficsim.road.gtu.generator.LaneBasedGTUGenerator 1
org.opentrafficsim.road.gtu.generator.ListGTUGenerator 2
org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU 6
org.opentrafficsim.road.gtu.lane.object.AbstractTrafficLight 1
org.opentrafficsim.road.gtu.lane.object.animation.CSEBlockAnimation 1
org.opentrafficsim.road.gtu.lane.object.animation.DefaultBlockAnimation 1
org.opentrafficsim.road.gtu.lane.object.animation.DefaultBlockOnOffAnimation 1
org.opentrafficsim.road.gtu.lane.object.animation.TrafficLightAnimation 1
org.opentrafficsim.road.gtu.lane.perception.AbstractLanePerception 2
org.opentrafficsim.road.gtu.lane.perception.InfrastructureLaneChangeInfo 1
org.opentrafficsim.road.gtu.lane.perception.LaneStructure 2
org.opentrafficsim.road.gtu.lane.perception.categories.DefaultAlexander 1
org.opentrafficsim.road.gtu.lane.perception.categories.NeighborsPerception 2
org.opentrafficsim.road.gtu.lane.perceptionold.AbstractLanePerception 1
org.opentrafficsim.road.gtu.lane.plan.operational.LaneBasedOperationalPlan 1
org.opentrafficsim.road.gtu.lane.plan.operational.LaneOperationalPlanBuilder 3
org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner 5
org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlannerFactory 1
org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingLaneChangeTacticalPlanner 3
org.opentrafficsim.road.gtu.lane.tactical.directedlanechange.AbstractDirectedLaneChangeModel 1
org.opentrafficsim.road.gtu.lane.tactical.following.AbstractGTUFollowingModelMobil 1
org.opentrafficsim.road.gtu.lane.tactical.following.IDMPlusMulti 1
org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.AbstractLaneChangeModel 1
org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS 2
org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRSFactory 1
org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo 1
org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo$GapAcceptanceInfo 2
org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo$GapInfo 2
org.opentrafficsim.road.network.animation.DefaultSensorAnimation 1
org.opentrafficsim.road.network.animation.LaneAnimation 1
org.opentrafficsim.road.network.animation.ShoulderAnimation 1
org.opentrafficsim.road.network.animation.StripeAnimation 1
org.opentrafficsim.road.network.factory.xml.CrossSectionElementTag 1
org.opentrafficsim.road.network.factory.xml.FillTag 3
org.opentrafficsim.road.network.factory.xml.GeneratorTag 1
org.opentrafficsim.road.network.factory.xml.LinkTag 1
org.opentrafficsim.road.network.factory.xml.Links 3
org.opentrafficsim.road.network.factory.xml.ListGeneratorTag 1
org.opentrafficsim.road.network.lane.CrossSectionLink 1
org.opentrafficsim.road.network.lane.Lane 2
org.opentrafficsim.road.network.lane.Lane$GTUTypeSensor 2
org.opentrafficsim.road.network.lane.SensorAnimation 1
org.opentrafficsim.road.network.lane.SinkAnimation 1
org.opentrafficsim.road.network.speed.SpeedLimitInfo 1
org.opentrafficsim.road.test.FourStop$TestXMLModel 2
org.opentrafficsim.road.test.LMRSTests$TestXMLModel 2
org.opentrafficsim.road.test.TestGMParser$CoordinateTransformRD 2
org.opentrafficsim.road.test.TestGMParser$TestGMModel 4
org.opentrafficsim.road.test.TestLaneDirections$TestXMLModel 2
org.opentrafficsim.road.test.TestNetwork2$TestXMLModel 2
org.opentrafficsim.road.test.TestXMLParser$TestXMLModel 2
org.opentrafficsim.road.test.TestXMLParserXStream$TestXMLModel 4

org.opentrafficsim.graphs.ContourPlot

Bug Category Details Line Priority
org.opentrafficsim.graphs.ContourPlot.STANDARDDISTANCEGRANULARITIES should be package protected MALICIOUS_CODE MS_PKGPROTECT 101 Medium
org.opentrafficsim.graphs.ContourPlot.STANDARDTIMEGRANULARITIES should be package protected MALICIOUS_CODE MS_PKGPROTECT 95 Medium

org.opentrafficsim.graphs.FundamentalDiagram$Sample

Bug Category Details Line Priority
org.opentrafficsim.graphs.FundamentalDiagram$Sample is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 460-516 Medium

org.opentrafficsim.graphs.FundamentalDiagramLane$Sample

Bug Category Details Line Priority
org.opentrafficsim.graphs.FundamentalDiagramLane$Sample is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 530-566 Medium

org.opentrafficsim.graphs.TrajectoryPlot$Trajectory

Bug Category Details Line Priority
org.opentrafficsim.graphs.TrajectoryPlot$Trajectory is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 446-620 Medium

org.opentrafficsim.road.gtu.animation.DefaultCarAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.animation.DefaultCarAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 50-149 High

org.opentrafficsim.road.gtu.generator.LaneBasedGTUGenerator

Bug Category Details Line Priority
Class org.opentrafficsim.road.gtu.generator.LaneBasedGTUGenerator defines non-transient non-serializable instance field roomChecker BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.road.gtu.generator.ListGTUGenerator

Bug Category Details Line Priority
Found reliance on default encoding in new org.opentrafficsim.road.gtu.generator.ListGTUGenerator(String, OTSDEVSSimulatorInterface, GTUType, Speed, Lane, Length, GTUDirectionality, GTUColorer, LaneBasedStrategicalPlanner, OTSNetwork, String): new java.io.FileReader(File) I18N DM_DEFAULT_ENCODING 120 High
Class org.opentrafficsim.road.gtu.generator.ListGTUGenerator defines non-transient non-serializable instance field reader BAD_PRACTICE SE_BAD_FIELD Not available High

org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.scheduleTriggers() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 634 Medium
Possible null pointer dereference of initialLongitudinalPositions in org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.init(LaneBasedStrategicalPlanner, Set, Speed) CORRECTNESS NP_NULL_ON_SOME_PATH 136 High
Redundant nullcheck of longitudinalPosition, which is known to be non-null in org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.position(Lane, RelativePosition, Time) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 455 Medium
org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.move(DirectedPoint) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 277 Medium
org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.scheduleTriggers() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 625 Medium
org.opentrafficsim.road.gtu.lane.AbstractLaneBasedGTU.scheduleTriggers() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 518 Medium

org.opentrafficsim.road.gtu.lane.object.AbstractTrafficLight

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.object.AbstractTrafficLight.RELATIVE_POSITIONS is a mutable collection which should be package protected MALICIOUS_CODE MS_MUTABLE_COLLECTION_PKGPROTECT 70 Medium

org.opentrafficsim.road.gtu.lane.object.animation.CSEBlockAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.object.animation.CSEBlockAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 38-86 High

org.opentrafficsim.road.gtu.lane.object.animation.DefaultBlockAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.object.animation.DefaultBlockAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 46-63 High

org.opentrafficsim.road.gtu.lane.object.animation.DefaultBlockOnOffAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.object.animation.DefaultBlockOnOffAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 46-70 High

org.opentrafficsim.road.gtu.lane.object.animation.TrafficLightAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.object.animation.TrafficLightAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 36-88 High

org.opentrafficsim.road.gtu.lane.perception.AbstractLanePerception

Bug Category Details Line Priority
Dead store to down in org.opentrafficsim.road.gtu.lane.perception.AbstractLanePerception.getLaneStructure() STYLE DLS_DEAD_LOCAL_STORE 66 Medium
Dead store to upMerge in org.opentrafficsim.road.gtu.lane.perception.AbstractLanePerception.getLaneStructure() STYLE DLS_DEAD_LOCAL_STORE 72 Medium

org.opentrafficsim.road.gtu.lane.perception.InfrastructureLaneChangeInfo

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.perception.InfrastructureLaneChangeInfo defines compareTo(InfrastructureLaneChangeInfo) and uses Object.equals() BAD_PRACTICE EQ_COMPARETO_USE_OBJECT_EQUALS 77 Medium

org.opentrafficsim.road.gtu.lane.perception.LaneStructure

Bug Category Details Line Priority
Unwritten field: org.opentrafficsim.road.gtu.lane.perception.LaneStructure.crossSectionUpdateTime CORRECTNESS UWF_UNWRITTEN_FIELD 147 Medium
Unwritten field: org.opentrafficsim.road.gtu.lane.perception.LaneStructure.length CORRECTNESS UWF_UNWRITTEN_FIELD 128 Medium

org.opentrafficsim.road.gtu.lane.perception.categories.DefaultAlexander

Bug Category Details Line Priority
Call to org.opentrafficsim.road.gtu.lane.LaneBasedGTU.equals(org.opentrafficsim.road.gtu.lane.perception.categories.DefaultAlexander) in org.opentrafficsim.road.gtu.lane.perception.categories.DefaultAlexander.parallel(Lane, Time) CORRECTNESS EC_UNRELATED_CLASS_AND_INTERFACE 940 Medium

org.opentrafficsim.road.gtu.lane.perception.categories.NeighborsPerception

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.perception.categories.NeighborsPerception.getFirstDownstreamGTUs(LateralDirectionality, RelativePosition$TYPE) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 262 Medium
org.opentrafficsim.road.gtu.lane.perception.categories.NeighborsPerception.getFirstUpstreamGTUs(LateralDirectionality, RelativePosition$TYPE) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 324 Medium

org.opentrafficsim.road.gtu.lane.perceptionold.AbstractLanePerception

Bug Category Details Line Priority
Call to org.opentrafficsim.road.gtu.lane.LaneBasedGTU.equals(org.opentrafficsim.road.gtu.lane.perceptionold.AbstractLanePerception) in org.opentrafficsim.road.gtu.lane.perceptionold.AbstractLanePerception.parallel(Lane, Time) CORRECTNESS EC_UNRELATED_CLASS_AND_INTERFACE 599 Medium

org.opentrafficsim.road.gtu.lane.plan.operational.LaneBasedOperationalPlan

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.plan.operational.LaneBasedOperationalPlan doesn't override org.opentrafficsim.core.gtu.plan.operational.OperationalPlan.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium

org.opentrafficsim.road.gtu.lane.plan.operational.LaneOperationalPlanBuilder

Bug Category Details Line Priority
Dead store to fromFirst in org.opentrafficsim.road.gtu.lane.plan.operational.LaneOperationalPlanBuilder.buildAccelerationLaneChangePlan(LaneBasedGTU, List, LateralDirectionality, DirectedPoint, Time, Speed, Acceleration, Duration, LaneOperationalPlanBuilder$LaneChange) STYLE DLS_DEAD_LOCAL_STORE 388 Medium
Dead store to toFirst in org.opentrafficsim.road.gtu.lane.plan.operational.LaneOperationalPlanBuilder.buildAccelerationLaneChangePlan(LaneBasedGTU, List, LateralDirectionality, DirectedPoint, Time, Speed, Acceleration, Duration, LaneOperationalPlanBuilder$LaneChange) STYLE DLS_DEAD_LOCAL_STORE 389 Medium
Dead store to path in org.opentrafficsim.road.gtu.lane.plan.operational.LaneOperationalPlanBuilder.buildAccelerationPlan(LaneBasedGTU, List, Length, Time, Speed, Acceleration, Duration) STYLE DLS_DEAD_LOCAL_STORE 320 Medium

org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner

Bug Category Details Line Priority
Dead store to currentLaneFine in org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner.generateOperationalPlan(Time, DirectedPoint) STYLE DLS_DEAD_LOCAL_STORE 148 Medium
Dead store to maximumReverseHeadway in org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner.generateOperationalPlan(Time, DirectedPoint) STYLE DLS_DEAD_LOCAL_STORE 128 Medium
org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner.canChangeLane(Map, Map, LaneBasedGTU, LateralDirectionality) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 565 Medium
org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner.laneDrop(LaneBasedGTU, LateralDirectionality) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 441 Medium
org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlanner.suitability(LaneBasedGTU, LateralDirectionality) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 513 Medium

org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlannerFactory

Bug Category Details Line Priority
Class org.opentrafficsim.road.gtu.lane.tactical.LaneBasedCFLCTacticalPlannerFactory defines non-transient non-serializable instance field laneChangeModel BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingLaneChangeTacticalPlanner

Bug Category Details Line Priority
Dead store to vt in org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingLaneChangeTacticalPlanner.makeLaneChangePlanMobil(LaneBasedGTU, LanePerception, LanePathInfo, LateralDirectionality) STYLE DLS_DEAD_LOCAL_STORE 481 High
Read of unwritten field carFollowingModel in org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingLaneChangeTacticalPlanner.currentLanePlan(LaneBasedGTU, Time, DirectedPoint, LanePathInfo) CORRECTNESS NP_UNWRITTEN_FIELD 296 Medium
Unwritten field: org.opentrafficsim.road.gtu.lane.tactical.LaneBasedGTUFollowingLaneChangeTacticalPlanner.carFollowingModel CORRECTNESS UWF_UNWRITTEN_FIELD 295 Medium

org.opentrafficsim.road.gtu.lane.tactical.directedlanechange.AbstractDirectedLaneChangeModel

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.tactical.directedlanechange.AbstractDirectedLaneChangeModel.computeLaneChangeAndAcceleration(LaneBasedGTU, LateralDirectionality, Collection, Collection, Length, Speed, Acceleration, Acceleration, Duration) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 66 Medium

org.opentrafficsim.road.gtu.lane.tactical.following.AbstractGTUFollowingModelMobil

Bug Category Details Line Priority
Dead store to maximumSIDeceleration in org.opentrafficsim.road.gtu.lane.tactical.following.AbstractGTUFollowingModelMobil.minimumHeadway(Speed, Speed, Length, Length, Speed, Speed) STYLE DLS_DEAD_LOCAL_STORE 246 Medium

org.opentrafficsim.road.gtu.lane.tactical.following.IDMPlusMulti

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.tactical.following.IDMPlusMulti.combineInteractionTerm(Acceleration, BehavioralCharacteristics, Speed, Speed, Length, SortedMap) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 54 Medium

org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.AbstractLaneChangeModel

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.tactical.lanechangemobil.AbstractLaneChangeModel.computeLaneChangeAndAcceleration(LaneBasedGTU, Collection, Collection, Collection, Speed, Acceleration, Acceleration, Acceleration) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 58 Medium

org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS

Bug Category Details Line Priority
Class org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS defines non-transient non-serializable instance field mandatoryIncentives BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRS defines non-transient non-serializable instance field voluntaryIncentives BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRSFactory

Bug Category Details Line Priority
Class org.opentrafficsim.road.gtu.lane.tactical.lmrs.LMRSFactory defines non-transient non-serializable instance field carFollowingModelConstructor BAD_PRACTICE SE_BAD_FIELD Not available High

org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo

Bug Category Details Line Priority
Possible null pointer dereference of initiatedLaneChange in org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo.generateOperationalPlan(Time, DirectedPoint) CORRECTNESS NP_NULL_ON_SOME_PATH 258 Medium

org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo$GapAcceptanceInfo

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo$GapAcceptanceInfo is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 975-1000 Medium
Should org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo$GapAcceptanceInfo be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 975-1000 Medium

org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo$GapInfo

Bug Category Details Line Priority
org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo$GapInfo is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 898-941 Medium
Should org.opentrafficsim.road.gtu.lane.tactical.toledo.Toledo$GapInfo be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 898-941 Medium

org.opentrafficsim.road.network.animation.DefaultSensorAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.network.animation.DefaultSensorAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 50-68 High

org.opentrafficsim.road.network.animation.LaneAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.network.animation.LaneAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 51-87 High

org.opentrafficsim.road.network.animation.ShoulderAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.network.animation.ShoulderAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 44-60 High

org.opentrafficsim.road.network.animation.StripeAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.network.animation.StripeAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 65-244 High

org.opentrafficsim.road.network.factory.xml.CrossSectionElementTag

Bug Category Details Line Priority
org.opentrafficsim.road.network.lane.changing.OvertakingConditions$LeftAndRight stored into non-transient field CrossSectionElementTag.overtakingConditions BAD_PRACTICE SE_BAD_FIELD_STORE 92 High

org.opentrafficsim.road.network.factory.xml.FillTag

Bug Category Details Line Priority
Dead store to rg in org.opentrafficsim.road.network.factory.xml.FillTag.makeFill(FillTag, XmlNetworkLaneParser, LinkTag, OTSDEVSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 222 High
Dead store to lane in org.opentrafficsim.road.network.factory.xml.FillTag.makeFill(FillTag, XmlNetworkLaneParser, LinkTag, OTSDEVSSimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 215 Medium
Dead store of org.opentrafficsim.road.gtu.lane.LaneBasedIndividualGTU.class in org.opentrafficsim.road.network.factory.xml.FillTag.makeFill(FillTag, XmlNetworkLaneParser, LinkTag, OTSDEVSSimulatorInterface) CORRECTNESS DLS_DEAD_STORE_OF_CLASS_LITERAL 216 Medium

org.opentrafficsim.road.network.factory.xml.GeneratorTag

Bug Category Details Line Priority
Useless object stored in variable nodeList of method org.opentrafficsim.road.network.factory.xml.GeneratorTag.makeGenerator(GeneratorTag, XmlNetworkLaneParser, LinkTag, OTSDEVSSimulatorInterface) STYLE UC_USELESS_OBJECT 292 Medium

org.opentrafficsim.road.network.factory.xml.LinkTag

Bug Category Details Line Priority
Class org.opentrafficsim.road.network.factory.xml.LinkTag defines non-transient non-serializable instance field bezierTag BAD_PRACTICE SE_BAD_FIELD Not available High

org.opentrafficsim.road.network.factory.xml.Links

Bug Category Details Line Priority
org.opentrafficsim.road.network.factory.xml.Links.calculateNodeCoordinates(XmlNetworkLaneParser) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 159 Medium
Useless object stored in variable cseList of method org.opentrafficsim.road.network.factory.xml.Links.applyRoadTypeToLink(LinkTag, XmlNetworkLaneParser, OTSDEVSSimulatorInterface) STYLE UC_USELESS_OBJECT 507 Medium
Useless object stored in variable lanes of method org.opentrafficsim.road.network.factory.xml.Links.applyRoadTypeToLink(LinkTag, XmlNetworkLaneParser, OTSDEVSSimulatorInterface) STYLE UC_USELESS_OBJECT 508 Medium

org.opentrafficsim.road.network.factory.xml.ListGeneratorTag

Bug Category Details Line Priority
Unwritten field: org.opentrafficsim.road.network.factory.xml.ListGeneratorTag.gtuColorer CORRECTNESS UWF_UNWRITTEN_FIELD 143 Medium

org.opentrafficsim.road.network.lane.CrossSectionLink

Bug Category Details Line Priority
org.opentrafficsim.road.network.lane.CrossSectionLink doesn't override org.opentrafficsim.core.network.OTSLink.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium

org.opentrafficsim.road.network.lane.Lane

Bug Category Details Line Priority
org.opentrafficsim.road.network.lane.Lane.checkDirectionality() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 1146 Medium
org.opentrafficsim.road.network.lane.Lane.getSensorMap(GTUType) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 603 Medium

org.opentrafficsim.road.network.lane.Lane$GTUTypeSensor

Bug Category Details Line Priority
org.opentrafficsim.road.network.lane.Lane$GTUTypeSensor is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 1247-1272 Medium
Should org.opentrafficsim.road.network.lane.Lane$GTUTypeSensor be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 1247-1272 Medium

org.opentrafficsim.road.network.lane.SensorAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.network.lane.SensorAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 50-68 High

org.opentrafficsim.road.network.lane.SinkAnimation

Bug Category Details Line Priority
org.opentrafficsim.road.network.lane.SinkAnimation is Serializable but its superclass doesn't define an accessible void constructor BAD_PRACTICE SE_NO_SUITABLE_CONSTRUCTOR 46-63 High

org.opentrafficsim.road.network.speed.SpeedLimitInfo

Bug Category Details Line Priority
org.opentrafficsim.road.network.speed.SpeedLimitInfo.toString() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 127 Medium

org.opentrafficsim.road.test.FourStop$TestXMLModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.road.test.FourStop$TestXMLModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 154 Medium
Should org.opentrafficsim.road.test.FourStop$TestXMLModel be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 137-180 Medium

org.opentrafficsim.road.test.LMRSTests$TestXMLModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.road.test.LMRSTests$TestXMLModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 156 Medium
Should org.opentrafficsim.road.test.LMRSTests$TestXMLModel be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 137-184 Medium

org.opentrafficsim.road.test.TestGMParser$CoordinateTransformRD

Bug Category Details Line Priority
org.opentrafficsim.road.test.TestGMParser$CoordinateTransformRD is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 294-327 Medium
Should org.opentrafficsim.road.test.TestGMParser$CoordinateTransformRD be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 294-327 Medium

org.opentrafficsim.road.test.TestGMParser$TestGMModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.road.test.TestGMParser$TestGMModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 202 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.road.test.TestGMParser$TestGMModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 189 Medium
Possible null pointer dereference of network in org.opentrafficsim.road.test.TestGMParser$TestGMModel.constructModel(SimulatorInterface) on exception path CORRECTNESS NP_NULL_ON_SOME_PATH_EXCEPTION 233 Medium
org.opentrafficsim.road.test.TestGMParser$TestGMModel is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 174-270 Medium

org.opentrafficsim.road.test.TestLaneDirections$TestXMLModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.road.test.TestLaneDirections$TestXMLModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 152 Medium
Should org.opentrafficsim.road.test.TestLaneDirections$TestXMLModel be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 135-178 Medium

org.opentrafficsim.road.test.TestNetwork2$TestXMLModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.road.test.TestNetwork2$TestXMLModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 153 Medium
Should org.opentrafficsim.road.test.TestNetwork2$TestXMLModel be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 136-179 Medium

org.opentrafficsim.road.test.TestXMLParser$TestXMLModel

Bug Category Details Line Priority
Hard coded reference to an absolute pathname in org.opentrafficsim.road.test.TestXMLParser$TestXMLModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 153 Medium
Should org.opentrafficsim.road.test.TestXMLParser$TestXMLModel be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 135-178 Medium

org.opentrafficsim.road.test.TestXMLParserXStream$TestXMLModel

Bug Category Details Line Priority
Dead store to network in org.opentrafficsim.road.test.TestXMLParserXStream$TestXMLModel.constructModel(SimulatorInterface) STYLE DLS_DEAD_LOCAL_STORE 190 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.road.test.TestXMLParserXStream$TestXMLModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 171 Medium
Hard coded reference to an absolute pathname in org.opentrafficsim.road.test.TestXMLParserXStream$TestXMLModel.constructModel(SimulatorInterface) STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 185 Medium
Found reliance on default encoding in org.opentrafficsim.road.test.TestXMLParserXStream$TestXMLModel.constructModel(SimulatorInterface): String.getBytes() I18N DM_DEFAULT_ENCODING 185 High